OSDN Git Service

net-sysfs: Call dev_hold always in rx_queue_add_kobject
authorJouni Hogander <jouni.hogander@unikie.com>
Tue, 17 Dec 2019 11:46:34 +0000 (13:46 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 18 Dec 2019 06:57:11 +0000 (22:57 -0800)
commitddd9b5e3e765d8ed5a35786a6cb00111713fe161
treedfaa69217a2b2ce2bc86720999b5fa4ec1189da5
parent39f14c00b13c47186739a4cbc7a16e04d7fdbb60
net-sysfs: Call dev_hold always in rx_queue_add_kobject

Dev_hold has to be called always in rx_queue_add_kobject.
Otherwise usage count drops below 0 in case of failure in
kobject_init_and_add.

Fixes: b8eb718348b8 ("net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject")
Reported-by: syzbot <syzbot+30209ea299c09d8785c9@syzkaller.appspotmail.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: David Miller <davem@davemloft.net>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Signed-off-by: Jouni Hogander <jouni.hogander@unikie.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/net-sysfs.c