OSDN Git Service

sctp: fix memleak on err handling of stream initialization
authorMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Tue, 17 Dec 2019 01:01:16 +0000 (22:01 -0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 18 Dec 2019 05:58:37 +0000 (21:58 -0800)
commit951c6db954a1adefab492f6da805decacabbd1a7
tree4f10faba719c2bcb1c89d8a5cde985090036fb10
parent040cda8a15210f19da7e29232c897ca6ca6cc950
sctp: fix memleak on err handling of stream initialization

syzbot reported a memory leak when an allocation fails within
genradix_prealloc() for output streams. That's because
genradix_prealloc() leaves initialized members initialized when the
issue happens and SCTP stack will abort the current initialization but
without cleaning up such members.

The fix here is to always call genradix_free() when genradix_prealloc()
fails, for output and also input streams, as it suffers from the same
issue.

Reported-by: syzbot+772d9e36c490b18d51d1@syzkaller.appspotmail.com
Fixes: 2075e50caf5e ("sctp: convert to genradix")
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Tested-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/stream.c