OSDN Git Service

Uniquization of constants at the Tree level
[pf3gnuchains/gcc-fork.git] / gcc / bb-reorder.c
index 40d0cdf..5f7230f 100644 (file)
@@ -1,11 +1,12 @@
 /* Basic block reordering routines for the GNU compiler.
-   Copyright (C) 2000, 2002, 2003, 2004, 2005 Free Software Foundation, Inc.
+   Copyright (C) 2000, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2010
+   Free Software Foundation, Inc.
 
    This file is part of GCC.
 
    GCC is free software; you can redistribute it and/or modify it
    under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2, or (at your option)
+   the Free Software Foundation; either version 3, or (at your option)
    any later version.
 
    GCC is distributed in the hope that it will be useful, but WITHOUT
@@ -14,9 +15,8 @@
    License for more details.
 
    You should have received a copy of the GNU General Public License
-   along with GCC; see the file COPYING.  If not, write to the Free
-   Software Foundation, 51 Franklin Street, Fifth Floor, Boston, MA
-   02110-1301, USA.  */
+   along with GCC; see the file COPYING3.  If not see
+   <http://www.gnu.org/licenses/>.  */
 
 /* This (greedy) algorithm constructs traces in several rounds.
    The construction starts from "seeds".  The seed for the first round
 #include "params.h"
 #include "toplev.h"
 #include "tree-pass.h"
-
-#ifndef HAVE_conditional_execution
-#define HAVE_conditional_execution 0
-#endif
+#include "df.h"
 
 /* The number of rounds.  In most cases there will only be 4 rounds, but
    when partitioning hot and cold basic blocks into separate sections of
@@ -95,7 +92,7 @@
 #define N_ROUNDS 5
 
 /* Stubs in case we don't have a return insn.
-   We have to check at runtime too, not only compiletime.  */  
+   We have to check at runtime too, not only compiletime.  */
 
 #ifndef HAVE_return
 #define HAVE_return 0
@@ -173,12 +170,12 @@ static void find_traces_1_round (int, int, gcov_type, struct trace *, int *,
                                 int, fibheap_t *, int);
 static basic_block copy_bb (basic_block, edge, basic_block, int);
 static fibheapkey_t bb_to_key (basic_block);
-static bool better_edge_p (basic_block, edge, int, int, int, int, edge);
+static bool better_edge_p (const_basic_block, const_edge, int, int, int, int, const_edge);
 static void connect_traces (int, struct trace *);
-static bool copy_bb_p (basic_block, int);
+static bool copy_bb_p (const_basic_block, int);
 static int get_uncond_jump_length (void);
-static bool push_to_next_round_p (basic_block, int, int, int, gcov_type);
-static void find_rarely_executed_basic_blocks_and_crossing_edges (edge *
+static bool push_to_next_round_p (const_basic_block, int, int, int, gcov_type);
+static void find_rarely_executed_basic_blocks_and_crossing_edges (edge **,
                                                                  int *,
                                                                  int *);
 static void add_labels_and_missing_jumps (edge *, int);
@@ -197,7 +194,7 @@ static void fix_crossing_unconditional_branches (void);
    current round of trace collection.  */
 
 static bool
-push_to_next_round_p (basic_block bb, int round, int number_of_rounds,
+push_to_next_round_p (const_basic_block bb, int round, int number_of_rounds,
                      int exec_th, gcov_type count_th)
 {
   bool there_exists_another_round;
@@ -205,14 +202,14 @@ push_to_next_round_p (basic_block bb, int round, int number_of_rounds,
 
   there_exists_another_round = round < number_of_rounds - 1;
 
-  block_not_hot_enough = (bb->frequency < exec_th 
+  block_not_hot_enough = (bb->frequency < exec_th
                          || bb->count < count_th
                          || probably_never_executed_bb_p (bb));
 
   if (there_exists_another_round
       && block_not_hot_enough)
     return true;
-  else 
+  else
     return false;
 }
 
@@ -277,7 +274,7 @@ find_traces (int *n_traces, struct trace *traces)
          basic_block bb;
          fprintf (dump_file, "Trace %d (round %d):  ", i + 1,
                   traces[i].round + 1);
-         for (bb = traces[i].first; bb != traces[i].last; bb = bb->aux)
+         for (bb = traces[i].first; bb != traces[i].last; bb = (basic_block) bb->aux)
            fprintf (dump_file, "%d [%d] ", bb->index, bb->frequency);
          fprintf (dump_file, "%d [%d]\n", bb->index, bb->frequency);
        }
@@ -357,7 +354,7 @@ rotate_loop (edge back_edge, struct trace *trace, int trace_n)
                }
            }
        }
-      bb = bb->aux;
+      bb = (basic_block) bb->aux;
     }
   while (bb != back_edge->dest);
 
@@ -367,7 +364,7 @@ rotate_loop (edge back_edge, struct trace *trace, int trace_n)
         the trace.  */
       if (back_edge->dest == trace->first)
        {
-         trace->first = best_bb->aux;
+         trace->first = (basic_block) best_bb->aux;
        }
       else
        {
@@ -375,7 +372,7 @@ rotate_loop (edge back_edge, struct trace *trace, int trace_n)
 
          for (prev_bb = trace->first;
               prev_bb->aux != back_edge->dest;
-              prev_bb = prev_bb->aux)
+              prev_bb = (basic_block) prev_bb->aux)
            ;
          prev_bb->aux = best_bb->aux;
 
@@ -387,7 +384,7 @@ rotate_loop (edge back_edge, struct trace *trace, int trace_n)
              /* Duplicate HEADER if it is a small block containing cond jump
                 in the end.  */
              if (any_condjump_p (BB_END (header)) && copy_bb_p (header, 0)
-                 && !find_reg_note (BB_END (header), REG_CROSSING_JUMP, 
+                 && !find_reg_note (BB_END (header), REG_CROSSING_JUMP,
                                     NULL_RTX))
                copy_bb (header, single_succ_edge (prev_bb), prev_bb, trace_n);
            }
@@ -441,7 +438,7 @@ find_traces_1_round (int branch_th, int exec_th, gcov_type count_th,
       fibheapkey_t key;
       edge_iterator ei;
 
-      bb = fibheap_extract_min (*heap);
+      bb = (basic_block) fibheap_extract_min (*heap);
       bbd[bb->index].heap = NULL;
       bbd[bb->index].node = NULL;
 
@@ -449,11 +446,11 @@ find_traces_1_round (int branch_th, int exec_th, gcov_type count_th,
        fprintf (dump_file, "Getting bb %d\n", bb->index);
 
       /* If the BB's frequency is too low send BB to the next round.  When
-         partitioning hot/cold blocks into separate sections, make sure all
-         the cold blocks (and ONLY the cold blocks) go into the (extra) final
-         round.  */
+        partitioning hot/cold blocks into separate sections, make sure all
+        the cold blocks (and ONLY the cold blocks) go into the (extra) final
+        round.  */
 
-      if (push_to_next_round_p (bb, round, number_of_rounds, exec_th, 
+      if (push_to_next_round_p (bb, round, number_of_rounds, exec_th,
                                count_th))
        {
          int key = bb_to_key (bb);
@@ -491,7 +488,7 @@ find_traces_1_round (int branch_th, int exec_th, gcov_type count_th,
            fprintf (dump_file, "Basic block %d was visited in trace %d\n",
                     bb->index, *n_traces - 1);
 
-          ends_in_call = block_ends_with_call_p (bb);
+         ends_in_call = block_ends_with_call_p (bb);
 
          /* Select the successor that will be placed after BB.  */
          FOR_EACH_EDGE (e, ei, bb->succs)
@@ -593,7 +590,7 @@ find_traces_1_round (int branch_th, int exec_th, gcov_type count_th,
                         the cold blocks (and only the cold blocks) all get
                         pushed to the last round of trace collection.  */
 
-                     if (push_to_next_round_p (e->dest, round, 
+                     if (push_to_next_round_p (e->dest, round,
                                                number_of_rounds,
                                                exec_th, count_th))
                        which_heap = new_heap;
@@ -637,8 +634,8 @@ find_traces_1_round (int branch_th, int exec_th, gcov_type count_th,
                                           best_edge->dest->index, bb->index);
                                }
                              bb->aux = best_edge->dest;
-                             bbd[best_edge->dest->index].in_trace = 
-                                                            (*n_traces) - 1;
+                             bbd[best_edge->dest->index].in_trace =
+                                                            (*n_traces) - 1;
                              bb = rotate_loop (best_edge, trace, *n_traces);
                            }
                        }
@@ -647,7 +644,8 @@ find_traces_1_round (int branch_th, int exec_th, gcov_type count_th,
                          /* The loop has less than 4 iterations.  */
 
                          if (single_succ_p (bb)
-                             && copy_bb_p (best_edge->dest, !optimize_size))
+                             && copy_bb_p (best_edge->dest,
+                                           optimize_edge_for_speed_p (best_edge)))
                            {
                              bb = copy_bb (best_edge->dest, best_edge, bb,
                                            *n_traces);
@@ -779,7 +777,7 @@ copy_bb (basic_block old_bb, edge e, basic_block bb, int trace)
 
       new_size = MAX (last_basic_block, new_bb->index + 1);
       new_size = GET_ARRAY_SIZE (new_size);
-      bbd = xrealloc (bbd, new_size * sizeof (bbro_basic_block_data));
+      bbd = XRESIZEVEC (bbro_basic_block_data, bbd, new_size);
       for (i = array_size; i < new_size; i++)
        {
          bbd[i].start_of_trace = -1;
@@ -846,8 +844,8 @@ bb_to_key (basic_block bb)
    BEST_PROB; similarly for frequency.  */
 
 static bool
-better_edge_p (basic_block bb, edge e, int prob, int freq, int best_prob,
-              int best_freq, edge cur_best_edge)
+better_edge_p (const_basic_block bb, const_edge e, int prob, int freq, int best_prob,
+              int best_freq, const_edge cur_best_edge)
 {
   bool is_better_edge;
 
@@ -882,8 +880,8 @@ better_edge_p (basic_block bb, edge e, int prob, int freq, int best_prob,
      non-crossing edges over crossing edges.  */
 
   if (!is_better_edge
-      && flag_reorder_blocks_and_partition 
-      && cur_best_edge 
+      && flag_reorder_blocks_and_partition
+      && cur_best_edge
       && (cur_best_edge->flags & EDGE_CROSSING)
       && !(e->flags & EDGE_CROSSING))
     is_better_edge = true;
@@ -911,7 +909,7 @@ connect_traces (int n_traces, struct trace *traces)
   else
     count_threshold = max_entry_count / 1000 * DUPLICATION_THRESHOLD;
 
-  connected = xcalloc (n_traces, sizeof (bool));
+  connected = XCNEWVEC (bool, n_traces);
   last_trace = -1;
   current_pass = 1;
   current_partition = BB_PARTITION (traces[0].first);
@@ -919,7 +917,7 @@ connect_traces (int n_traces, struct trace *traces)
 
   if (flag_reorder_blocks_and_partition)
     for (i = 0; i < n_traces && !two_passes; i++)
-      if (BB_PARTITION (traces[0].first) 
+      if (BB_PARTITION (traces[0].first)
          != BB_PARTITION (traces[i].first))
        two_passes = true;
 
@@ -941,11 +939,11 @@ connect_traces (int n_traces, struct trace *traces)
          else
            current_partition = BB_HOT_PARTITION;
        }
-      
+
       if (connected[t])
        continue;
 
-      if (two_passes 
+      if (two_passes
          && BB_PARTITION (traces[t].first) != current_partition)
        continue;
 
@@ -1101,7 +1099,7 @@ connect_traces (int n_traces, struct trace *traces)
                 edge is traversed frequently enough.  */
              if (try_copy
                  && copy_bb_p (best->dest,
-                               !optimize_size
+                               optimize_edge_for_speed_p (best)
                                && EDGE_FREQUENCY (best) >= freq_threshold
                                && best->count >= count_threshold))
                {
@@ -1142,7 +1140,7 @@ connect_traces (int n_traces, struct trace *traces)
       basic_block bb;
 
       fprintf (dump_file, "Final order:\n");
-      for (bb = traces[0].first; bb; bb = bb->aux)
+      for (bb = traces[0].first; bb; bb = (basic_block) bb->aux)
        fprintf (dump_file, "%d ", bb->index);
       fprintf (dump_file, "\n");
       fflush (dump_file);
@@ -1155,7 +1153,7 @@ connect_traces (int n_traces, struct trace *traces)
    when code size is allowed to grow by duplication.  */
 
 static bool
-copy_bb_p (basic_block bb, int code_may_grow)
+copy_bb_p (const_basic_block bb, int code_may_grow)
 {
   int size = 0;
   int max_size = uncond_jump_length;
@@ -1172,7 +1170,7 @@ copy_bb_p (basic_block bb, int code_may_grow)
   if (EDGE_COUNT (bb->succs) > 8)
     return false;
 
-  if (code_may_grow && maybe_hot_bb_p (bb))
+  if (code_may_grow && optimize_bb_for_speed_p (bb))
     max_size *= PARAM_VALUE (PARAM_MAX_GROW_COPY_BB_INSNS);
 
   FOR_BB_INSNS (bb, insn)
@@ -1217,27 +1215,23 @@ get_uncond_jump_length (void)
    cache locality).  */
 
 static void
-find_rarely_executed_basic_blocks_and_crossing_edges (edge *crossing_edges, 
-                                                     int *n_crossing_edges, 
+find_rarely_executed_basic_blocks_and_crossing_edges (edge **crossing_edges,
+                                                     int *n_crossing_edges,
                                                      int *max_idx)
 {
   basic_block bb;
-  bool has_hot_blocks = false;
   edge e;
   int i;
   edge_iterator ei;
 
   /* Mark which partition (hot/cold) each basic block belongs in.  */
-  
+
   FOR_EACH_BB (bb)
     {
       if (probably_never_executed_bb_p (bb))
        BB_SET_PARTITION (bb, BB_COLD_PARTITION);
       else
-       {
-         BB_SET_PARTITION (bb, BB_HOT_PARTITION);
-         has_hot_blocks = true;
-       }
+       BB_SET_PARTITION (bb, BB_HOT_PARTITION);
     }
 
   /* Mark every edge that crosses between sections.  */
@@ -1254,10 +1248,9 @@ find_rarely_executed_basic_blocks_and_crossing_edges (edge *crossing_edges,
          if (i == *max_idx)
            {
              *max_idx *= 2;
-             crossing_edges = xrealloc (crossing_edges,
-                                        (*max_idx) * sizeof (edge));
+             *crossing_edges = XRESIZEVEC (edge, *crossing_edges, *max_idx);
            }
-         crossing_edges[i++] = e;
+         (*crossing_edges)[i++] = e;
        }
       else
        e->flags &= ~EDGE_CROSSING;
@@ -1269,7 +1262,7 @@ find_rarely_executed_basic_blocks_and_crossing_edges (edge *crossing_edges,
    Convert any fall-through crossing edges (for blocks that do not contain
    a jump) to unconditional jumps.  */
 
-static void 
+static void
 add_labels_and_missing_jumps (edge *crossing_edges, int n_crossing_edges)
 {
   int i;
@@ -1278,34 +1271,37 @@ add_labels_and_missing_jumps (edge *crossing_edges, int n_crossing_edges)
   rtx label;
   rtx barrier;
   rtx new_jump;
-  
-  for (i=0; i < n_crossing_edges; i++) 
+
+  for (i=0; i < n_crossing_edges; i++)
     {
-      if (crossing_edges[i]) 
-       {
-         src = crossing_edges[i]->src; 
-         dest = crossing_edges[i]->dest;
-         
-         /* Make sure dest has a label.  */
-         
-         if (dest && (dest != EXIT_BLOCK_PTR))
-           {
+      if (crossing_edges[i])
+       {
+         src = crossing_edges[i]->src;
+         dest = crossing_edges[i]->dest;
+
+         /* Make sure dest has a label.  */
+
+         if (dest && (dest != EXIT_BLOCK_PTR))
+           {
              label = block_label (dest);
-             
-             /* Make sure source block ends with a jump.  */
-             
-             if (src && (src != ENTRY_BLOCK_PTR)) 
-               {
-                 if (!JUMP_P (BB_END (src)))
-                   /* bb just falls through.  */
-                   {
-                     /* make sure there's only one successor */
+
+             /* Make sure source block ends with a jump.  If the
+                source block does not end with a jump it might end
+                with a call_insn;  this case will be handled in
+                fix_up_fall_thru_edges function.  */
+
+             if (src && (src != ENTRY_BLOCK_PTR))
+               {
+                 if (!JUMP_P (BB_END (src)) && !block_ends_with_call_p (src))
+                   /* bb just falls through.  */
+                   {
+                     /* make sure there's only one successor */
                      gcc_assert (single_succ_p (src));
-                     
+
                      /* Find label in dest block.  */
                      label = block_label (dest);
-                     
-                     new_jump = emit_jump_insn_after (gen_jump (label), 
+
+                     new_jump = emit_jump_insn_after (gen_jump (label),
                                                       BB_END (src));
                      barrier = emit_barrier_after (new_jump);
                      JUMP_LABEL (new_jump) = label;
@@ -1313,23 +1309,23 @@ add_labels_and_missing_jumps (edge *crossing_edges, int n_crossing_edges)
                      src->il.rtl->footer = unlink_insn_chain (barrier, barrier);
                      /* Mark edge as non-fallthru.  */
                      crossing_edges[i]->flags &= ~EDGE_FALLTHRU;
-                   } /* end: 'if (GET_CODE ... '  */
-               } /* end: 'if (src && src->index...'  */
-           } /* end: 'if (dest && dest->index...'  */
-       } /* end: 'if (crossing_edges[i]...'  */
+                   } /* end: 'if (GET_CODE ... '  */
+               } /* end: 'if (src && src->index...'  */
+           } /* end: 'if (dest && dest->index...'  */
+       } /* end: 'if (crossing_edges[i]...'  */
     } /* end for loop  */
 }
 
 /* Find any bb's where the fall-through edge is a crossing edge (note that
-   these bb's must also contain a conditional jump; we've already
-   dealt with fall-through edges for blocks that didn't have a
-   conditional jump in the call to add_labels_and_missing_jumps).
-   Convert the fall-through edge to non-crossing edge by inserting a
-   new bb to fall-through into.  The new bb will contain an
-   unconditional jump (crossing edge) to the original fall through
-   destination.  */
-
-static void 
+   these bb's must also contain a conditional jump or end with a call
+   instruction; we've already dealt with fall-through edges for blocks
+   that didn't have a conditional jump or didn't end with call instruction
+   in the call to add_labels_and_missing_jumps).  Convert the fall-through
+   edge to non-crossing edge by inserting a new bb to fall-through into.
+   The new bb will contain an unconditional jump (crossing edge) to the
+   original fall through destination.  */
+
+static void
 fix_up_fall_thru_edges (void)
 {
   basic_block cur_bb;
@@ -1344,7 +1340,7 @@ fix_up_fall_thru_edges (void)
   rtx old_jump;
   rtx fall_thru_label;
   rtx barrier;
-  
+
   FOR_EACH_BB (cur_bb)
     {
       fall_thru = NULL;
@@ -1354,127 +1350,152 @@ fix_up_fall_thru_edges (void)
        succ1 = NULL;
 
       if (EDGE_COUNT (cur_bb->succs) > 1)
-       succ2 = EDGE_SUCC (cur_bb, 1);
+       succ2 = EDGE_SUCC (cur_bb, 1);
       else
-       succ2 = NULL;
-      
+       succ2 = NULL;
+
       /* Find the fall-through edge.  */
-      
-      if (succ1 
-         && (succ1->flags & EDGE_FALLTHRU))
-       {
-         fall_thru = succ1;
-         cond_jump = succ2;
-       }
-      else if (succ2 
-              && (succ2->flags & EDGE_FALLTHRU))
-       {
-         fall_thru = succ2;
-         cond_jump = succ1;
-       }
-      
+
+      if (succ1
+         && (succ1->flags & EDGE_FALLTHRU))
+       {
+         fall_thru = succ1;
+         cond_jump = succ2;
+       }
+      else if (succ2
+              && (succ2->flags & EDGE_FALLTHRU))
+       {
+         fall_thru = succ2;
+         cond_jump = succ1;
+       }
+      else if (!fall_thru && succ1 && block_ends_with_call_p (cur_bb))
+      {
+        edge e;
+        edge_iterator ei;
+
+        /* Find EDGE_CAN_FALLTHRU edge.  */
+        FOR_EACH_EDGE (e, ei, cur_bb->succs)
+          if (e->flags & EDGE_CAN_FALLTHRU)
+          {
+            fall_thru = e;
+            break;
+          }
+      }
+
       if (fall_thru && (fall_thru->dest != EXIT_BLOCK_PTR))
-       {
-         /* Check to see if the fall-thru edge is a crossing edge.  */
-       
+       {
+         /* Check to see if the fall-thru edge is a crossing edge.  */
+
          if (fall_thru->flags & EDGE_CROSSING)
-           {
+           {
              /* The fall_thru edge crosses; now check the cond jump edge, if
-                it exists.  */
-             
-             cond_jump_crosses = true;
-             invert_worked  = 0;
+                it exists.  */
+
+             cond_jump_crosses = true;
+             invert_worked  = 0;
              old_jump = BB_END (cur_bb);
-             
-             /* Find the jump instruction, if there is one.  */
-             
-             if (cond_jump)
-               {
+
+             /* Find the jump instruction, if there is one.  */
+
+             if (cond_jump)
+               {
                  if (!(cond_jump->flags & EDGE_CROSSING))
-                   cond_jump_crosses = false;
-                 
-                 /* We know the fall-thru edge crosses; if the cond
-                    jump edge does NOT cross, and its destination is the
+                   cond_jump_crosses = false;
+
+                 /* We know the fall-thru edge crosses; if the cond
+                    jump edge does NOT cross, and its destination is the
                     next block in the bb order, invert the jump
-                    (i.e. fix it so the fall thru does not cross and
-                    the cond jump does).  */
-                 
+                    (i.e. fix it so the fall thru does not cross and
+                    the cond jump does).  */
+
                  if (!cond_jump_crosses
                      && cur_bb->aux == cond_jump->dest)
-                   {
-                     /* Find label in fall_thru block. We've already added
-                        any missing labels, so there must be one.  */
-                     
-                     fall_thru_label = block_label (fall_thru->dest);
-
-                     if (old_jump && fall_thru_label)
-                       invert_worked = invert_jump (old_jump, 
-                                                    fall_thru_label,0);
-                     if (invert_worked)
-                       {
-                         fall_thru->flags &= ~EDGE_FALLTHRU;
-                         cond_jump->flags |= EDGE_FALLTHRU;
-                         update_br_prob_note (cur_bb);
-                         e = fall_thru;
-                         fall_thru = cond_jump;
-                         cond_jump = e;
+                   {
+                     /* Find label in fall_thru block. We've already added
+                        any missing labels, so there must be one.  */
+
+                     fall_thru_label = block_label (fall_thru->dest);
+
+                     if (old_jump && JUMP_P (old_jump) && fall_thru_label)
+                       invert_worked = invert_jump (old_jump,
+                                                    fall_thru_label,0);
+                     if (invert_worked)
+                       {
+                         fall_thru->flags &= ~EDGE_FALLTHRU;
+                         cond_jump->flags |= EDGE_FALLTHRU;
+                         update_br_prob_note (cur_bb);
+                         e = fall_thru;
+                         fall_thru = cond_jump;
+                         cond_jump = e;
                          cond_jump->flags |= EDGE_CROSSING;
                          fall_thru->flags &= ~EDGE_CROSSING;
-                       }
-                   }
-               }
-             
-             if (cond_jump_crosses || !invert_worked)
-               {
-                 /* This is the case where both edges out of the basic
-                    block are crossing edges. Here we will fix up the
+                       }
+                   }
+               }
+
+             if (cond_jump_crosses || !invert_worked)
+               {
+                 /* This is the case where both edges out of the basic
+                    block are crossing edges. Here we will fix up the
                     fall through edge. The jump edge will be taken care
-                    of later.  */
-                 
-                 new_bb = force_nonfallthru (fall_thru);  
-                 
-                 if (new_bb)
-                   {
-                     new_bb->aux = cur_bb->aux;
-                     cur_bb->aux = new_bb;
-                     
-                     /* Make sure new fall-through bb is in same 
+                    of later.  The EDGE_CROSSING flag of fall_thru edge
+                     is unset before the call to force_nonfallthru
+                     function because if a new basic-block is created
+                     this edge remains in the current section boundary
+                     while the edge between new_bb and the fall_thru->dest
+                     becomes EDGE_CROSSING.  */
+
+                  fall_thru->flags &= ~EDGE_CROSSING;
+                 new_bb = force_nonfallthru (fall_thru);
+
+                 if (new_bb)
+                   {
+                     new_bb->aux = cur_bb->aux;
+                     cur_bb->aux = new_bb;
+
+                     /* Make sure new fall-through bb is in same
                         partition as bb it's falling through from.  */
 
                      BB_COPY_PARTITION (new_bb, cur_bb);
                      single_succ_edge (new_bb)->flags |= EDGE_CROSSING;
-                   }
-                 
-                 /* Add barrier after new jump */
-                 
-                 if (new_bb)
-                   {
-                     barrier = emit_barrier_after (BB_END (new_bb));
-                     new_bb->il.rtl->footer = unlink_insn_chain (barrier, 
-                                                              barrier);
-                   }
-                 else
-                   {
-                     barrier = emit_barrier_after (BB_END (cur_bb));
-                     cur_bb->il.rtl->footer = unlink_insn_chain (barrier,
-                                                              barrier);
-                   }
-               }
-           }
-       }
+                   }
+                  else
+                    {
+                      /* If a new basic-block was not created; restore
+                         the EDGE_CROSSING flag.  */
+                      fall_thru->flags |= EDGE_CROSSING;
+                    }
+
+                 /* Add barrier after new jump */
+
+                 if (new_bb)
+                   {
+                     barrier = emit_barrier_after (BB_END (new_bb));
+                     new_bb->il.rtl->footer = unlink_insn_chain (barrier,
+                                                              barrier);
+                   }
+                 else
+                   {
+                     barrier = emit_barrier_after (BB_END (cur_bb));
+                     cur_bb->il.rtl->footer = unlink_insn_chain (barrier,
+                                                              barrier);
+                   }
+               }
+           }
+       }
     }
 }
 
-/* This function checks the destination blockof a "crossing jump" to
+/* This function checks the destination block of a "crossing jump" to
    see if it has any crossing predecessors that begin with a code label
    and end with an unconditional jump.  If so, it returns that predecessor
    block.  (This is to avoid creating lots of new basic blocks that all
    contain unconditional jumps to the same destination).  */
 
 static basic_block
-find_jump_block (basic_block jump_dest) 
-{ 
-  basic_block source_bb = NULL; 
+find_jump_block (basic_block jump_dest)
+{
+  basic_block source_bb = NULL;
   edge e;
   rtx insn;
   edge_iterator ei;
@@ -1483,13 +1504,13 @@ find_jump_block (basic_block jump_dest)
     if (e->flags & EDGE_CROSSING)
       {
        basic_block src = e->src;
-       
+
        /* Check each predecessor to see if it has a label, and contains
           only one executable instruction, which is an unconditional jump.
           If so, we can use it.  */
-       
+
        if (LABEL_P (BB_HEAD (src)))
-         for (insn = BB_HEAD (src); 
+         for (insn = BB_HEAD (src);
               !INSN_P (insn) && insn != NEXT_INSN (BB_END (src));
               insn = NEXT_INSN (insn))
            {
@@ -1502,7 +1523,7 @@ find_jump_block (basic_block jump_dest)
                  break;
                }
            }
-       
+
        if (source_bb)
          break;
       }
@@ -1523,7 +1544,6 @@ fix_crossing_conditional_branches (void)
   basic_block new_bb;
   basic_block last_bb;
   basic_block dest;
-  basic_block prev_bb;
   edge succ1;
   edge succ2;
   edge crossing_edge;
@@ -1536,7 +1556,7 @@ fix_crossing_conditional_branches (void)
   rtx barrier;
 
  last_bb = EXIT_BLOCK_PTR->prev_bb;
-  
+
   FOR_EACH_BB (cur_bb)
     {
       crossing_edge = NULL;
@@ -1544,27 +1564,27 @@ fix_crossing_conditional_branches (void)
        succ1 = EDGE_SUCC (cur_bb, 0);
       else
        succ1 = NULL;
-    
+
       if (EDGE_COUNT (cur_bb->succs) > 1)
        succ2 = EDGE_SUCC (cur_bb, 1);
       else
        succ2 = NULL;
-      
+
       /* We already took care of fall-through edges, so only one successor
         can be a crossing edge.  */
-      
+
       if (succ1 && (succ1->flags & EDGE_CROSSING))
        crossing_edge = succ1;
       else if (succ2 && (succ2->flags & EDGE_CROSSING))
-       crossing_edge = succ2;
-      
-      if (crossing_edge) 
-       {
+       crossing_edge = succ2;
+
+      if (crossing_edge)
+       {
          old_jump = BB_END (cur_bb);
-         
+
          /* Check to make sure the jump instruction is a
             conditional jump.  */
-         
+
          set_src = NULL_RTX;
 
          if (any_condjump_p (old_jump))
@@ -1587,89 +1607,78 @@ fix_crossing_conditional_branches (void)
                old_label = XEXP (set_src, 2);
              else if (GET_CODE (XEXP (set_src, 2)) == PC)
                old_label = XEXP (set_src, 1);
-             
+
              /* Check to see if new bb for jumping to that dest has
                 already been created; if so, use it; if not, create
                 a new one.  */
 
              new_bb = find_jump_block (crossing_edge->dest);
-             
+
              if (new_bb)
                new_label = block_label (new_bb);
              else
                {
                  /* Create new basic block to be dest for
                     conditional jump.  */
-                 
+
                  new_bb = create_basic_block (NULL, NULL, last_bb);
                  new_bb->aux = last_bb->aux;
                  last_bb->aux = new_bb;
-                 prev_bb = last_bb;
                  last_bb = new_bb;
-                 
-                 /* Update register liveness information.  */
-                 
-                 new_bb->il.rtl->global_live_at_start = ALLOC_REG_SET (&reg_obstack);
-                 new_bb->il.rtl->global_live_at_end = ALLOC_REG_SET (&reg_obstack);
-                 COPY_REG_SET (new_bb->il.rtl->global_live_at_end,
-                               prev_bb->il.rtl->global_live_at_end);
-                 COPY_REG_SET (new_bb->il.rtl->global_live_at_start,
-                               prev_bb->il.rtl->global_live_at_end);
-                 
                  /* Put appropriate instructions in new bb.  */
-                 
+
                  new_label = gen_label_rtx ();
                  emit_label_before (new_label, BB_HEAD (new_bb));
                  BB_HEAD (new_bb) = new_label;
-                 
+
                  if (GET_CODE (old_label) == LABEL_REF)
                    {
                      old_label = JUMP_LABEL (old_jump);
-                     new_jump = emit_jump_insn_after (gen_jump 
-                                                      (old_label), 
+                     new_jump = emit_jump_insn_after (gen_jump
+                                                      (old_label),
                                                       BB_END (new_bb));
                    }
                  else
                    {
                      gcc_assert (HAVE_return
                                  && GET_CODE (old_label) == RETURN);
-                     new_jump = emit_jump_insn_after (gen_return (), 
+                     new_jump = emit_jump_insn_after (gen_return (),
                                                       BB_END (new_bb));
                    }
-                 
+
                  barrier = emit_barrier_after (new_jump);
                  JUMP_LABEL (new_jump) = old_label;
-                 new_bb->il.rtl->footer = unlink_insn_chain (barrier, 
+                 new_bb->il.rtl->footer = unlink_insn_chain (barrier,
                                                           barrier);
-                 
+
                  /* Make sure new bb is in same partition as source
                     of conditional branch.  */
                  BB_COPY_PARTITION (new_bb, cur_bb);
                }
-             
+
              /* Make old jump branch to new bb.  */
-             
+
              redirect_jump (old_jump, new_label, 0);
-             
+
              /* Remove crossing_edge as predecessor of 'dest'.  */
-             
+
              dest = crossing_edge->dest;
-             
+
              redirect_edge_succ (crossing_edge, new_bb);
-             
+
              /* Make a new edge from new_bb to old dest; new edge
                 will be a successor for new_bb and a predecessor
                 for 'dest'.  */
-             
+
              if (EDGE_COUNT (new_bb->succs) == 0)
                new_edge = make_edge (new_bb, dest, 0);
              else
                new_edge = EDGE_SUCC (new_bb, 0);
-             
+
              crossing_edge->flags &= ~EDGE_CROSSING;
              new_edge->flags |= EDGE_CROSSING;
            }
-       }
+       }
     }
 }
 
@@ -1699,7 +1708,7 @@ fix_crossing_unconditional_branches (void)
       succ = EDGE_SUCC (cur_bb, 0);
 
       /* Check to see if bb ends in a crossing (unconditional) jump.  At
-         this point, no crossing jumps should be conditional.  */
+        this point, no crossing jumps should be conditional.  */
 
       if (JUMP_P (last_insn)
          && (succ->flags & EDGE_CROSSING))
@@ -1716,26 +1725,26 @@ fix_crossing_unconditional_branches (void)
              /* We have found a "crossing" unconditional branch.  Now
                 we must convert it to an indirect jump.  First create
                 reference of label, as target for jump.  */
-             
+
              label = JUMP_LABEL (last_insn);
              label_addr = gen_rtx_LABEL_REF (Pmode, label);
              LABEL_NUSES (label) += 1;
-             
+
              /* Get a register to use for the indirect jump.  */
-             
+
              new_reg = gen_reg_rtx (Pmode);
-             
+
              /* Generate indirect the jump sequence.  */
-             
+
              start_sequence ();
              emit_move_insn (new_reg, label_addr);
              emit_indirect_jump (new_reg);
              indirect_jump_sequence = get_insns ();
              end_sequence ();
-             
+
              /* Make sure every instruction in the new jump sequence has
                 its basic block set to be cur_bb.  */
-             
+
              for (cur_insn = indirect_jump_sequence; cur_insn;
                   cur_insn = NEXT_INSN (cur_insn))
                {
@@ -1744,16 +1753,16 @@ fix_crossing_unconditional_branches (void)
                  if (JUMP_P (cur_insn))
                    jump_insn = cur_insn;
                }
-             
+
              /* Insert the new (indirect) jump sequence immediately before
                 the unconditional jump, then delete the unconditional jump.  */
-             
+
              emit_insn_before (indirect_jump_sequence, last_insn);
              delete_insn (last_insn);
-             
+
              /* Make BB_END for cur_bb be the jump instruction (NOT the
                 barrier instruction at the end of the sequence...).  */
-             
+
              BB_END (cur_bb) = jump_insn;
            }
        }
@@ -1773,10 +1782,7 @@ add_reg_crossing_jump_notes (void)
     FOR_EACH_EDGE (e, ei, bb->succs)
       if ((e->flags & EDGE_CROSSING)
          && JUMP_P (BB_END (e->src)))
-       REG_NOTES (BB_END (e->src)) = gen_rtx_EXPR_LIST (REG_CROSSING_JUMP, 
-                                                        NULL_RTX, 
-                                                        REG_NOTES (BB_END 
-                                                                 (e->src)));
+       add_reg_note (BB_END (e->src), REG_CROSSING_JUMP, NULL_RTX);
 }
 
 /* Hot and cold basic blocks are partitioned and put in separate
@@ -1793,16 +1799,16 @@ add_reg_crossing_jump_notes (void)
    sections are converted to indirect jumps.
 
    The code for fixing up fall_thru edges that cross between hot and
-   cold basic blocks does so by creating new basic blocks containing 
-   unconditional branches to the appropriate label in the "other" 
+   cold basic blocks does so by creating new basic blocks containing
+   unconditional branches to the appropriate label in the "other"
    section.  The new basic block is then put in the same (hot or cold)
    section as the original conditional branch, and the fall_thru edge
    is modified to fall into the new basic block instead.  By adding
    this level of indirection we end up with only unconditional branches
-   crossing between hot and cold sections.  
-   
+   crossing between hot and cold sections.
+
    Conditional branches are dealt with by adding a level of indirection.
-   A new basic block is added in the same (hot/cold) section as the 
+   A new basic block is added in the same (hot/cold) section as the
    conditional branch, and the conditional branch is retargeted to the
    new basic block.  The new basic block contains an unconditional branch
    to the original target of the conditional branch (in the other section).
@@ -1810,40 +1816,37 @@ add_reg_crossing_jump_notes (void)
    Unconditional branches are dealt with by converting them into
    indirect jumps.  */
 
-static void 
-fix_edges_for_rarely_executed_code (edge *crossing_edges, 
+static void
+fix_edges_for_rarely_executed_code (edge *crossing_edges,
                                    int n_crossing_edges)
 {
   /* Make sure the source of any crossing edge ends in a jump and the
      destination of any crossing edge has a label.  */
-  
+
   add_labels_and_missing_jumps (crossing_edges, n_crossing_edges);
-  
+
   /* Convert all crossing fall_thru edges to non-crossing fall
      thrus to unconditional jumps (that jump to the original fall
      thru dest).  */
-  
+
   fix_up_fall_thru_edges ();
-  
+
   /* If the architecture does not have conditional branches that can
      span all of memory, convert crossing conditional branches into
      crossing unconditional branches.  */
-  
+
   if (!HAS_LONG_COND_BRANCH)
     fix_crossing_conditional_branches ();
-  
+
   /* If the architecture does not have unconditional branches that
      can span all of memory, convert crossing unconditional branches
      into indirect jumps.  Since adding an indirect jump also adds
      a new register usage, update the register usage information as
      well.  */
-  
+
   if (!HAS_LONG_UNCOND_BRANCH)
-    {
-      fix_crossing_unconditional_branches ();
-      reg_scan (get_insns(), max_reg_num ());
-    }
-  
+    fix_crossing_unconditional_branches ();
+
   add_reg_crossing_jump_notes ();
 }
 
@@ -1860,7 +1863,7 @@ verify_hot_cold_block_grouping (void)
   int err = 0;
   bool switched_sections = false;
   int current_partition = 0;
-  
+
   FOR_EACH_BB (bb)
     {
       if (!current_partition)
@@ -1880,7 +1883,7 @@ verify_hot_cold_block_grouping (void)
            }
        }
     }
-  
+
   gcc_assert(!err);
 }
 
@@ -1888,20 +1891,17 @@ verify_hot_cold_block_grouping (void)
    the set of flags to pass to cfg_layout_initialize().  */
 
 void
-reorder_basic_blocks (unsigned int flags)
+reorder_basic_blocks (void)
 {
   int n_traces;
   int i;
   struct trace *traces;
 
-  if (n_basic_blocks <= 1)
-    return;
+  gcc_assert (current_ir_type () == IR_RTL_CFGLAYOUT);
 
-  if (targetm.cannot_modify_jumps_p ())
+  if (n_basic_blocks <= NUM_FIXED_BLOCKS + 1)
     return;
 
-  cfg_layout_initialize (flags);
-
   set_edge_can_fallthru_flag ();
   mark_dfs_back_edges ();
 
@@ -1912,7 +1912,7 @@ reorder_basic_blocks (unsigned int flags)
 
   /* We need to know some information for each basic block.  */
   array_size = GET_ARRAY_SIZE (last_basic_block);
-  bbd = xmalloc (array_size * sizeof (bbro_basic_block_data));
+  bbd = XNEWVEC (bbro_basic_block_data, array_size);
   for (i = 0; i < array_size; i++)
     {
       bbd[i].start_of_trace = -1;
@@ -1922,17 +1922,18 @@ reorder_basic_blocks (unsigned int flags)
       bbd[i].node = NULL;
     }
 
-  traces = xmalloc (n_basic_blocks * sizeof (struct trace));
+  traces = XNEWVEC (struct trace, n_basic_blocks);
   n_traces = 0;
   find_traces (&n_traces, traces);
   connect_traces (n_traces, traces);
   FREE (traces);
   FREE (bbd);
 
+  relink_block_chain (/*stay_in_cfglayout_mode=*/true);
+
   if (dump_file)
-    dump_flow_info (dump_file);
+    dump_flow_info (dump_file, dump_flags);
 
-  cfg_layout_finalize ();
   if (flag_reorder_blocks_and_partition)
     verify_hot_cold_block_grouping ();
 }
@@ -1951,7 +1952,7 @@ insert_section_boundary_note (void)
   basic_block bb;
   rtx new_note;
   int first_partition = 0;
-  
+
   if (flag_reorder_blocks_and_partition)
     FOR_EACH_BB (bb)
     {
@@ -1961,6 +1962,9 @@ insert_section_boundary_note (void)
        {
          new_note = emit_note_before (NOTE_INSN_SWITCH_TEXT_SECTIONS,
                                       BB_HEAD (bb));
+         /* ??? This kind of note always lives between basic blocks,
+            but add_insn_before will set BLOCK_FOR_INSN anyway.  */
+         BLOCK_FOR_INSN (new_note) = NULL;
          break;
        }
     }
@@ -1975,22 +1979,23 @@ insert_section_boundary_note (void)
 static bool
 gate_duplicate_computed_gotos (void)
 {
-  return (optimize > 0 && flag_expensive_optimizations && !optimize_size);
+  if (targetm.cannot_modify_jumps_p ())
+    return false;
+  return (optimize > 0
+         && flag_expensive_optimizations
+         && ! optimize_function_for_size_p (cfun));
 }
 
 
-static void
+static unsigned int
 duplicate_computed_gotos (void)
 {
   basic_block bb, new_bb;
   bitmap candidates;
   int max_size;
 
-  if (n_basic_blocks <= 1)
-    return;
-
-  if (targetm.cannot_modify_jumps_p ())
-    return;
+  if (n_basic_blocks <= NUM_FIXED_BLOCKS + 1)
+    return 0;
 
   cfg_layout_initialize (0);
 
@@ -2061,7 +2066,7 @@ duplicate_computed_gotos (void)
       bb->il.rtl->visited = 1;
 
       /* BB must have one outgoing edge.  That edge must not lead to
-         the exit block or the next block.
+        the exit block or the next block.
         The destination must have more than one predecessor.  */
       if (!single_succ_p (bb)
          || single_succ (bb) == EXIT_BLOCK_PTR
@@ -2083,10 +2088,13 @@ done:
   cfg_layout_finalize ();
 
   BITMAP_FREE (candidates);
+  return 0;
 }
 
-struct tree_opt_pass pass_duplicate_computed_gotos =
+struct rtl_opt_pass pass_duplicate_computed_gotos =
 {
+ {
+  RTL_PASS,
   "compgotos",                          /* name */
   gate_duplicate_computed_gotos,        /* gate */
   duplicate_computed_gotos,             /* execute */
@@ -2098,8 +2106,8 @@ struct tree_opt_pass pass_duplicate_computed_gotos =
   0,                                    /* properties_provided */
   0,                                    /* properties_destroyed */
   0,                                    /* todo_flags_start */
-  TODO_dump_func,                       /* todo_flags_finish */
-  0                                     /* letter */
+  TODO_dump_func | TODO_verify_rtl_sharing,/* todo_flags_finish */
+ }
 };
 
 
@@ -2161,83 +2169,75 @@ struct tree_opt_pass pass_duplicate_computed_gotos =
    (through registers) requires that this optimization be performed
    before register allocation.  */
 
-void
+static void
 partition_hot_cold_basic_blocks (void)
 {
-  basic_block cur_bb;
   edge *crossing_edges;
   int n_crossing_edges;
   int max_edges = 2 * last_basic_block;
-  
-  if (n_basic_blocks <= 1)
+
+  if (n_basic_blocks <= NUM_FIXED_BLOCKS + 1)
     return;
-  
-  crossing_edges = xcalloc (max_edges, sizeof (edge));
 
-  cfg_layout_initialize (0);
-  
-  FOR_EACH_BB (cur_bb)
-    if (cur_bb->index >= 0
-       && cur_bb->next_bb->index >= 0)
-      cur_bb->aux = cur_bb->next_bb;
-  
-  find_rarely_executed_basic_blocks_and_crossing_edges (crossing_edges, 
-                                                       &n_crossing_edges, 
+  crossing_edges = XCNEWVEC (edge, max_edges);
+
+  find_rarely_executed_basic_blocks_and_crossing_edges (&crossing_edges,
+                                                       &n_crossing_edges,
                                                        &max_edges);
 
   if (n_crossing_edges > 0)
     fix_edges_for_rarely_executed_code (crossing_edges, n_crossing_edges);
-  
-  free (crossing_edges);
 
-  cfg_layout_finalize();
+  free (crossing_edges);
 }
 \f
 static bool
 gate_handle_reorder_blocks (void)
 {
+  if (targetm.cannot_modify_jumps_p ())
+    return false;
   return (optimize > 0);
 }
 
 
 /* Reorder basic blocks.  */
-static void
+static unsigned int
 rest_of_handle_reorder_blocks (void)
 {
-  bool changed;
-  unsigned int liveness_flags;
+  basic_block bb;
 
   /* Last attempt to optimize CFG, as scheduling, peepholing and insn
      splitting possibly introduced more crossjumping opportunities.  */
-  liveness_flags = (!HAVE_conditional_execution ? CLEANUP_UPDATE_LIFE : 0);
-  changed = cleanup_cfg (CLEANUP_EXPENSIVE | liveness_flags);
+  cfg_layout_initialize (CLEANUP_EXPENSIVE);
+
+  if ((flag_reorder_blocks || flag_reorder_blocks_and_partition)
+      /* Don't reorder blocks when optimizing for size because extra jump insns may
+        be created; also barrier may create extra padding.
 
-  if (flag_sched2_use_traces && flag_schedule_insns_after_reload)
+        More correctly we should have a block reordering mode that tried to
+        minimize the combined size of all the jumps.  This would more or less
+        automatically remove extra jumps, but would also try to use more short
+        jumps instead of long jumps.  */
+      && optimize_function_for_speed_p (cfun))
     {
-      timevar_push (TV_TRACER);
-      tracer (liveness_flags);
-      timevar_pop (TV_TRACER);
+      reorder_basic_blocks ();
+      cleanup_cfg (CLEANUP_EXPENSIVE);
     }
 
-  if (flag_reorder_blocks || flag_reorder_blocks_and_partition)
-    reorder_basic_blocks (liveness_flags);
-  if (flag_reorder_blocks || flag_reorder_blocks_and_partition
-      || (flag_sched2_use_traces && flag_schedule_insns_after_reload))
-    changed |= cleanup_cfg (CLEANUP_EXPENSIVE | liveness_flags);
-
-  /* On conditional execution targets we can not update the life cheaply, so
-     we deffer the updating to after both cleanups.  This may lose some cases
-     but should not be terribly bad.  */
-  if (changed && HAVE_conditional_execution)
-    update_life_info (NULL, UPDATE_LIFE_GLOBAL_RM_NOTES,
-                      PROP_DEATH_NOTES);
+  FOR_EACH_BB (bb)
+    if (bb->next_bb != EXIT_BLOCK_PTR)
+      bb->aux = bb->next_bb;
+  cfg_layout_finalize ();
 
   /* Add NOTE_INSN_SWITCH_TEXT_SECTIONS notes.  */
   insert_section_boundary_note ();
+  return 0;
 }
 
-struct tree_opt_pass pass_reorder_blocks =
+struct rtl_opt_pass pass_reorder_blocks =
 {
+ {
+  RTL_PASS,
   "bbro",                               /* name */
   gate_handle_reorder_blocks,           /* gate */
   rest_of_handle_reorder_blocks,        /* execute */
@@ -2249,8 +2249,8 @@ struct tree_opt_pass pass_reorder_blocks =
   0,                                    /* properties_provided */
   0,                                    /* properties_destroyed */
   0,                                    /* todo_flags_start */
-  TODO_dump_func,                       /* todo_flags_finish */
-  'B'                                   /* letter */
+  TODO_dump_func | TODO_verify_rtl_sharing,/* todo_flags_finish */
+ }
 };
 
 static bool
@@ -2262,24 +2262,22 @@ gate_handle_partition_blocks (void)
      arises.  */
 
   return (flag_reorder_blocks_and_partition
-          && !DECL_ONE_ONLY (current_function_decl)
-          && !user_defined_section_attribute);
+         && !DECL_ONE_ONLY (current_function_decl)
+         && !user_defined_section_attribute);
 }
 
 /* Partition hot and cold basic blocks.  */
-static void
+static unsigned int
 rest_of_handle_partition_blocks (void)
 {
-  no_new_pseudos = 0;
   partition_hot_cold_basic_blocks ();
-  allocate_reg_life_data ();
-  update_life_info (NULL, UPDATE_LIFE_GLOBAL_RM_NOTES,
-                    PROP_LOG_LINKS | PROP_REG_INFO | PROP_DEATH_NOTES);
-  no_new_pseudos = 1;
+  return 0;
 }
 
-struct tree_opt_pass pass_partition_blocks =
+struct rtl_opt_pass pass_partition_blocks =
 {
+ {
+  RTL_PASS,
   "bbpart",                             /* name */
   gate_handle_partition_blocks,         /* gate */
   rest_of_handle_partition_blocks,      /* execute */
@@ -2287,12 +2285,10 @@ struct tree_opt_pass pass_partition_blocks =
   NULL,                                 /* next */
   0,                                    /* static_pass_number */
   TV_REORDER_BLOCKS,                    /* tv_id */
-  0,                                    /* properties_required */
+  PROP_cfglayout,                       /* properties_required */
   0,                                    /* properties_provided */
   0,                                    /* properties_destroyed */
   0,                                    /* todo_flags_start */
-  TODO_dump_func,                       /* todo_flags_finish */
-  0                                     /* letter */
+  TODO_dump_func | TODO_verify_rtl_sharing/* todo_flags_finish */
+ }
 };
-
-