OSDN Git Service

android-x86/external-toybox.git
6 years agoPromote dmesg back to lsb.
Rob Landley [Fri, 9 Jun 2017 20:01:07 +0000 (15:01 -0500)]
Promote dmesg back to lsb.

6 years agoCleanup dmesg (as posted to the list).
Rob Landley [Fri, 9 Jun 2017 19:59:51 +0000 (14:59 -0500)]
Cleanup dmesg (as posted to the list).

6 years agoAdd comment explaining strend()
Rob Landley [Tue, 6 Jun 2017 18:21:03 +0000 (13:21 -0500)]
Add comment explaining strend()

6 years agoHave help_exit() give a brief "See %s --help" message instead of the
Rob Landley [Tue, 6 Jun 2017 02:22:02 +0000 (21:22 -0500)]
Have help_exit() give a brief "See %s --help" message instead of the
full help text, and put it back in the args constraint failures.

6 years agoDon't add cpio TRAILER!!! entry by default, add new --trailer option if you
Rob Landley [Sun, 4 Jun 2017 18:15:51 +0000 (13:15 -0500)]
Don't add cpio TRAILER!!! entry by default, add new --trailer option if you
want that. (This lets you concatenate cpio archives with "cat". Kernel's
initramfs extractor doesn't need it.)

6 years agoAllow ':' in property names.
Elliott Hughes [Wed, 31 May 2017 18:01:11 +0000 (11:01 -0700)]
Allow ':' in property names.

Bug: http://b/62114389
Test: setprop
Change-Id: I165bcc01bb2422d991f746c5e6490cbdfb74472f

6 years agoteach head -v and -q
Ilya Kuzmich [Sun, 28 May 2017 14:03:26 +0000 (17:03 +0300)]
teach head -v and -q

Not POSIX, but implemented in coreutils and busybox.
Tests use sed to compensate for the stdin naming difference.

Signed-off-by: Ilya Kuzmich <ilya.kuzmich@gmail.com>
6 years agoReplace two space indents with tab indents in help text (for consistency).
Rob Landley [Sat, 27 May 2017 20:54:16 +0000 (15:54 -0500)]
Replace two space indents with tab indents in help text (for consistency).

6 years agoAdd separators in help -a with command name.
Rob Landley [Sat, 27 May 2017 19:57:45 +0000 (14:57 -0500)]
Add separators in help -a with command name.

6 years agoBe more consistent about periods in help text.
Elliott Hughes [Fri, 26 May 2017 00:56:11 +0000 (17:56 -0700)]
Be more consistent about periods in help text.

6 years agoAdd -0 to env.
Rob Landley [Thu, 25 May 2017 18:27:22 +0000 (13:27 -0500)]
Add -0 to env.

6 years agoTeach env that - as first argument means -i for some reason. (Posix!)
Rob Landley [Thu, 25 May 2017 18:00:00 +0000 (13:00 -0500)]
Teach env that - as first argument means -i for some reason. (Posix!)

6 years agoAdd and use xmmap.
Elliott Hughes [Wed, 24 May 2017 00:35:49 +0000 (17:35 -0700)]
Add and use xmmap.

Everyone forgets that mmap returns MAP_FAILED rather than NULL on failure.
Every use of mmap in toybox was either doing the wrong check, or no check
at all (including the two I personally added).

6 years agoAdd minof/maxof macros that autodetect type. Make xzcat use them.
Rob Landley [Tue, 23 May 2017 20:48:26 +0000 (15:48 -0500)]
Add minof/maxof macros that autodetect type. Make xzcat use them.

6 years agofixup code style
Joyounger [Tue, 23 May 2017 16:36:35 +0000 (00:36 +0800)]
fixup code style

Signed-off-by: Joyounger <aquanox@163.com>
7 years agoPromote chrt
Rob Landley [Sun, 21 May 2017 18:23:34 +0000 (13:23 -0500)]
Promote chrt

7 years agoCleaup chrt
Rob Landley [Sun, 21 May 2017 18:11:42 +0000 (13:11 -0500)]
Cleaup chrt

7 years agoAdd bzip2 support to tar.
Elliott Hughes [Sat, 13 May 2017 01:30:03 +0000 (18:30 -0700)]
Add bzip2 support to tar.

Also trivial cleanup of pipe -> xpipe.

Bug: http://b/38215123

7 years agoImplement date %N, loosely inspired by Elliott Hughes's patch.
Rob Landley [Fri, 19 May 2017 17:35:36 +0000 (12:35 -0500)]
Implement date %N, loosely inspired by Elliott Hughes's patch.

I didn't implement %37N's ability to insert zeroes, so removed those
two tests. If you really need it, I can add the divide loop back.

7 years agofactor shouldn't give incorrect answers for >64-bit integers.
Elliott Hughes [Sat, 13 May 2017 19:48:35 +0000 (12:48 -0700)]
factor shouldn't give incorrect answers for >64-bit integers.

7 years agoMinor tweaks to install.sh.
Rob Landley [Sun, 14 May 2017 20:10:29 +0000 (15:10 -0500)]
Minor tweaks to install.sh.

7 years agoSwitch to testcmd and add "-e all but \c" test.
Rob Landley [Thu, 11 May 2017 17:31:43 +0000 (12:31 -0500)]
Switch to testcmd and add "-e all but \c" test.

7 years agoMake fewer assumptions about the shell in echo.test.
Elliott Hughes [Wed, 10 May 2017 20:51:44 +0000 (13:51 -0700)]
Make fewer assumptions about the shell in echo.test.

This test fails with mksh, but we're not here to test mksh.

7 years agoMove strend() to lib/lib.c
Rob Landley [Tue, 9 May 2017 04:01:06 +0000 (23:01 -0500)]
Move strend() to lib/lib.c

7 years agoRemove old uClibc compatibility glue. It's been 5 years since the last release.
Rob Landley [Tue, 9 May 2017 03:09:08 +0000 (22:09 -0500)]
Remove old uClibc compatibility glue. It's been 5 years since the last release.
See http://lists.busybox.net/pipermail/buildroot/2016-December/180102.html
for a full post-mortem on the project.

7 years agoNow that xopen() no longer returns stdio, !fd doesn't need strcmp("-") to verify
Rob Landley [Mon, 8 May 2017 23:25:22 +0000 (18:25 -0500)]
Now that xopen() no longer returns stdio, !fd doesn't need strcmp("-") to verify

7 years agoFix error in writing output that was causing zcat to always fail.
Mike Moreton [Fri, 23 Sep 2016 07:46:11 +0000 (08:46 +0100)]
Fix error in writing output that was causing zcat to always fail.

7 years agoError if we can't autodetect filesystem type.
Rob Landley [Mon, 8 May 2017 03:48:44 +0000 (22:48 -0500)]
Error if we can't autodetect filesystem type.

7 years agoAndroid NDK doesn't have cutils/sched_policy.h so add a probed config symbol.
Rob Landley [Sun, 30 Apr 2017 07:46:36 +0000 (02:46 -0500)]
Android NDK doesn't have cutils/sched_policy.h so add a probed config symbol.

7 years agoAndroid needs -llog to link.
Elliott Hughes [Fri, 28 Apr 2017 22:25:56 +0000 (15:25 -0700)]
Android needs -llog to link.

7 years agoBuilding mkpasswd on Android makes no sense.
Elliott Hughes [Fri, 28 Apr 2017 22:21:36 +0000 (15:21 -0700)]
Building mkpasswd on Android makes no sense.

And won't work anyway because we don't have crypt(3).

7 years agoImplement zlib-based gzip/gunzip/zcat.
Elliott Hughes [Wed, 26 Apr 2017 22:01:41 +0000 (15:01 -0700)]
Implement zlib-based gzip/gunzip/zcat.

7 years agoElliott wants to run the toybox tests on android host and there's an sh but
Rob Landley [Wed, 26 Apr 2017 21:36:19 +0000 (16:36 -0500)]
Elliott wants to run the toybox tests on android host and there's an sh but
it isn't toysh, so test for a bash alias.

7 years agoForgot to check in one of the files for bzcat.test
Rob Landley [Tue, 25 Apr 2017 07:21:39 +0000 (02:21 -0500)]
Forgot to check in one of the files for bzcat.test

7 years agoAnother FAQ, and some related tweaks as long as I was there.
Rob Landley [Tue, 25 Apr 2017 00:01:33 +0000 (19:01 -0500)]
Another FAQ, and some related tweaks as long as I was there.

7 years agoAdd ls -ll (with --full-time as a compatibility synonym) to show nanoseconds.
Rob Landley [Wed, 19 Apr 2017 06:44:16 +0000 (01:44 -0500)]
Add ls -ll (with --full-time as a compatibility synonym) to show nanoseconds.
(And, for some reason, timezone. Individual files have timezones?)

7 years agoThe kernel needs bc to build because
Rob Landley [Tue, 18 Apr 2017 18:19:07 +0000 (13:19 -0500)]
The kernel needs bc to build because
https://landley.net/notes-2013.html#28-03-2013 so add it to the airlock install.

7 years agoUse $(( rather than $[ for arithmetic in expand.test.
Elliott Hughes [Sat, 15 Apr 2017 18:27:18 +0000 (11:27 -0700)]
Use $(( rather than $[ for arithmetic in expand.test.

I can't find any reference to $[ for arithmetic on the bash man page, but it
seems to be a synonym for $((. mksh doesn't support this, so the expand tests
that use it fail on Android. No other toybox tests are using $[.

7 years agoMake ls.test work without awk.
Elliott Hughes [Fri, 14 Apr 2017 20:43:16 +0000 (13:43 -0700)]
Make ls.test work without awk.

7 years agoSpeed up tail.test for shells without builtin printf.
Elliott Hughes [Sat, 8 Apr 2017 06:15:52 +0000 (23:15 -0700)]
Speed up tail.test for shells without builtin printf.

The test only needs echo, and Android currently doesn't use mksh's
builtin printf; the toybox printf is fuller featured and less buggy,
but a lot slower to call in a loop like this (and mksh doesn't fall
back to the printf on the path if given something it can't handle,
so we can't have the best of both worlds).

Without this hack, the tail test takes as long as all the other
tests put together.

7 years agoDefault to -b rather than -q when output is to a tty.
Rob Landley [Wed, 12 Apr 2017 18:41:10 +0000 (13:41 -0500)]
Default to -b rather than -q when output is to a tty.

7 years agoFix "make test_split".
Elliott Hughes [Sat, 8 Apr 2017 06:00:54 +0000 (23:00 -0700)]
Fix "make test_split".

The test shouldn't assume there's a toybox binary on the path.

7 years agoSilence a broken warning by hitting it with a rock.
Rob Landley [Tue, 11 Apr 2017 18:38:37 +0000 (13:38 -0500)]
Silence a broken warning by hitting it with a rock.

7 years agoMake fdisk buildable.
Elliott Hughes [Wed, 5 Apr 2017 17:13:47 +0000 (10:13 -0700)]
Make fdisk buildable.

The argument to help_exit is a char*, not a FILE*.

7 years agoFix touch -a/-m (and add the missing tests).
Elliott Hughes [Thu, 6 Apr 2017 21:44:45 +0000 (14:44 -0700)]
Fix touch -a/-m (and add the missing tests).

utimensat takes atime in [0] and mtime in [1], but since we're overwriting
with UTIME_OMIT, we actually want to flip the comparison so -a blats 1 and
-m blats 0.

7 years agoAdd "uudecode -o -" support.
Elliott Hughes [Mon, 3 Apr 2017 21:12:08 +0000 (14:12 -0700)]
Add "uudecode -o -" support.

busybox uudecode supports this, and POSIX explicitly mentions it (albeit
only in the "STDOUT" section). Plus Android doesn't have /dev/stdout and
/dev/stdin, so this lets us rewrite the uudecode tests so they pass on
Android too.

7 years agoFix the ls -m test (which is just a whitespace issue, but eh).
Rob Landley [Sat, 8 Apr 2017 18:52:18 +0000 (13:52 -0500)]
Fix the ls -m test (which is just a whitespace issue, but eh).

While we're at it, ls -m wordwrap was one column early.

7 years agoMake renice.test work without awk.
Elliott Hughes [Mon, 3 Apr 2017 15:57:42 +0000 (08:57 -0700)]
Make renice.test work without awk.

Also try to only kill processes we created.

7 years agoRemove mount.test awk dependency.
Elliott Hughes [Mon, 3 Apr 2017 15:33:23 +0000 (08:33 -0700)]
Remove mount.test awk dependency.

Parsing file(1) output isn't a good way to determine file system type anyway.

7 years agoMake pgrep tests runnable on toybox-only systems.
Elliott Hughes [Sun, 2 Apr 2017 19:29:39 +0000 (12:29 -0700)]
Make pgrep tests runnable on toybox-only systems.

Also make the cleanup kill more focused.

7 years agoMake pkill tests runnable on a toybox-only system.
Elliott Hughes [Sun, 2 Apr 2017 19:20:53 +0000 (12:20 -0700)]
Make pkill tests runnable on a toybox-only system.

Also use a much stricter regex in the regex test to avoid killing innocent
bystanders.

7 years agoMake bzcat tests runnable on a toybox-only system.
Elliott Hughes [Sun, 2 Apr 2017 19:27:38 +0000 (12:27 -0700)]
Make bzcat tests runnable on a toybox-only system.

7 years agoAdd "testcmd" function as an alternative to "testing" for tests/*.test, and
Rob Landley [Tue, 4 Apr 2017 23:13:51 +0000 (18:13 -0500)]
Add "testcmd" function as an alternative to "testing" for tests/*.test, and
check in two converted commands.

7 years agoFix ls -a and ls -A tests.
Elliott Hughes [Sun, 2 Apr 2017 18:58:49 +0000 (11:58 -0700)]
Fix ls -a and ls -A tests.

7 years agoTrivial cleanup. (Whitespace, brackets, and remove unnecessary typecasts.)
Rob Landley [Mon, 3 Apr 2017 21:57:40 +0000 (16:57 -0500)]
Trivial cleanup. (Whitespace, brackets, and remove unnecessary typecasts.)

7 years agoAdd gzip support. (Doesn't show source OS and timestamp, but reporting them
Rob Landley [Mon, 3 Apr 2017 20:48:21 +0000 (15:48 -0500)]
Add gzip support. (Doesn't show source OS and timestamp, but reporting them
isn't obviously useful.)

7 years agoImplement dmesg -T.
Elliott Hughes [Sat, 25 Mar 2017 20:08:20 +0000 (13:08 -0700)]
Implement dmesg -T.

Also refactor so that legacy mode gets all the new functionality too, and
add -S to make it easier to test legacy mode on 3.5 or newer kernels (at least
on the host; on Android the syslog(2) system call is no longer allowed).

Bug: http://b/36090178

7 years agoDon't try to implement %s, we have @seconds, strptime() in libc tends
Rob Landley [Wed, 29 Mar 2017 01:39:31 +0000 (20:39 -0500)]
Don't try to implement %s, we have @seconds, strptime() in libc tends
not to have it, and implementing our own means a pattern like
"Time %%%s%%" is expensive to handle the corner cases of.

7 years agoNew date range tests are simple, won't catch Feb 29 in non-leap-year
Rob Landley [Wed, 29 Mar 2017 01:19:28 +0000 (20:19 -0500)]
New date range tests are simple, won't catch Feb 29 in non-leap-year
(or April 31 in any year). Some normalization allowed, exclusions are just
what http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/time.h.html says.

7 years agoReplace chkmktime() (which produces false positive normalization failures)
Rob Landley [Wed, 29 Mar 2017 01:16:41 +0000 (20:16 -0500)]
Replace chkmktime() (which produces false positive normalization failures)
with range checks for seconds, minutes, hours, day of month, and month.

7 years agops: don't query for terminal size if not a tty.
Josh Gao [Mon, 27 Mar 2017 22:53:03 +0000 (15:53 -0700)]
ps: don't query for terminal size if not a tty.

`ps -A | cat` shouldn't have different output depending on the size of
your terminal window.

7 years agoFix the type of the callback in getprop.
Elliott Hughes [Wed, 22 Mar 2017 17:35:14 +0000 (10:35 -0700)]
Fix the type of the callback in getprop.

Fixes:

  toys/android/getprop.c:56:39: warning: incompatible pointer types
    passing 'void (void *, const char *, const char *)' to parameter of
    type 'void (*)(void *, const char *, const char *, uint32_t)'
    (aka 'void (*)(void *, const char *, const char *, unsigned int)')
    [-Wincompatible-pointer-types]

  __system_property_read_callback(pi, read_callback, NULL);
                                      ^~~~~~~~~~~~~

7 years agoWe grew a few more commands that weren't on the roadmap (mostly from android)
Rob Landley [Fri, 24 Mar 2017 16:59:26 +0000 (11:59 -0500)]
We grew a few more commands that weren't on the roadmap (mostly from android)
so throw them in the "requests" category so they show up in status.html.

7 years agoNow that just about everything has --help, don't output help for argument errors
Rob Landley [Thu, 23 Mar 2017 16:35:09 +0000 (11:35 -0500)]
Now that just about everything has --help, don't output help for argument errors

7 years agoFix a typo and explain a mystery in news.html.
Elliott Hughes [Wed, 22 Mar 2017 17:39:36 +0000 (10:39 -0700)]
Fix a typo and explain a mystery in news.html.

7 years agoImplement uptime -s.
Elliott Hughes [Tue, 21 Mar 2017 19:11:29 +0000 (12:11 -0700)]
Implement uptime -s.

Also add trivial tests.

7 years agodirtree_flagread() returns DIRTREE_ABORTVAL when the initial node doesn't
Rob Landley [Wed, 22 Mar 2017 00:25:33 +0000 (19:25 -0500)]
dirtree_flagread() returns DIRTREE_ABORTVAL when the initial node doesn't
exist, which can hit ps when /proc isn't there or /proc/$PID/task isn't
there (because process exited between the time we checked its contents
and the time we looked for its threads).

7 years agoPaste bugfix, more tests.
Rob Landley [Mon, 20 Mar 2017 18:14:14 +0000 (13:14 -0500)]
Paste bugfix, more tests.

7 years agoAdd TOYBOX_PEDANTIC_ARGS to check arguments when there are no arguments,
Rob Landley [Mon, 20 Mar 2017 17:41:22 +0000 (12:41 -0500)]
Add TOYBOX_PEDANTIC_ARGS to check arguments when there are no arguments,
and make uptime use it.

7 years agoRewrite paste so it actually works.
Rob Landley [Mon, 20 Mar 2017 16:11:34 +0000 (11:11 -0500)]
Rewrite paste so it actually works.

7 years agoAnother FAQ entry.
Rob Landley [Sun, 5 Mar 2017 02:42:06 +0000 (20:42 -0600)]
Another FAQ entry.

7 years agoFAQ tweak: one more link on toybox history.
Rob Landley [Sat, 4 Mar 2017 03:21:26 +0000 (21:21 -0600)]
FAQ tweak: one more link on toybox history.

7 years agoCheck in web page announcement for 0.7.3.
Rob Landley [Sat, 4 Mar 2017 03:13:57 +0000 (21:13 -0600)]
Check in web page announcement for 0.7.3.

7 years agoIt's past time for 0.7.3.
Rob Landley [Tue, 21 Feb 2017 17:27:25 +0000 (11:27 -0600)]
It's past time for 0.7.3.

7 years agoIf the last ps field is left justified, it extends to the width of the screen.
Rob Landley [Tue, 21 Feb 2017 04:40:10 +0000 (22:40 -0600)]
If the last ps field is left justified, it extends to the width of the screen.
(Recent "show + for last char when truncated" change broke that, putting it
back.)

7 years ago4a4b3d65644ce403b0f22887fc0d38b0202ec8c7 upset clang.
Elliott Hughes [Sun, 19 Feb 2017 17:22:45 +0000 (09:22 -0800)]
4a4b3d65644ce403b0f22887fc0d38b0202ec8c7 upset clang.

Recent-ish clang doesn't like self-assignment. Google/Android code always
uses the [template-based moral equivalent of] __attribute__((__unused__))
to keep both compilers happy.

7 years agoDeclaring todo bankruptcy, dmesg goes back into pending until I get a chance
Rob Landley [Tue, 21 Feb 2017 03:42:58 +0000 (21:42 -0600)]
Declaring todo bankruptcy, dmesg goes back into pending until I get a chance
to unify the two codepaths in Elliott's rewrite.

7 years agoFix dmesg -c and -C.
Elliott Hughes [Wed, 4 Jan 2017 18:45:55 +0000 (10:45 -0800)]
Fix dmesg -c and -C.

I never use these, so I didn't notice I'd broken them until someone who
does bringup complained.

The "one weird trick" with SEEK_DATA is documented at the URL we already
point to. SEEK_DATA was added in Linux 3.1 (2011) and isn't available in
glibc 2.19 (2014), so I've added that to "portability.h" for the benefit
of Ubuntu 14.04.

Also make -c and -C mutually exclusive.

Also fix some of the formatting I introduced earlier. (A clang-format file
would help prevent these mistakes...)

7 years agoAscii only showed 15 rows instead of 16 and spacing was wrong for 96-100.
Rob Landley [Sat, 18 Feb 2017 18:51:35 +0000 (12:51 -0600)]
Ascii only showed 15 rows instead of 16 and spacing was wrong for 96-100.

7 years agoFix the comment about the Android SIGPIPE behavior.
Elliott Hughes [Fri, 17 Feb 2017 22:43:56 +0000 (14:43 -0800)]
Fix the comment about the Android SIGPIPE behavior.

7 years agoTeach file(1) about bzip2 files.
Elliott Hughes [Thu, 16 Feb 2017 01:23:19 +0000 (17:23 -0800)]
Teach file(1) about bzip2 files.

If we can read and write bzip2 files, we should be able to identify them
too...

7 years agoAdd back bionic SIGPIPE handler workaround accidentally removed in 3b51a07e478d
Rob Landley [Fri, 10 Feb 2017 22:37:42 +0000 (16:37 -0600)]
Add back bionic SIGPIPE handler workaround accidentally removed in 3b51a07e478d

7 years agoDocument df -a
Rob Landley [Thu, 9 Feb 2017 19:58:03 +0000 (13:58 -0600)]
Document df -a

7 years agoAdd ascii: display ascii table.
Rob Landley [Tue, 7 Feb 2017 22:27:37 +0000 (16:27 -0600)]
Add ascii: display ascii table.

7 years agops -l has 4 chars left for "cmd", switch "ADDR" to "BIT" to save space.
Rob Landley [Tue, 7 Feb 2017 02:46:56 +0000 (20:46 -0600)]
ps -l has 4 chars left for "cmd", switch "ADDR" to "BIT" to save space.

7 years agoMake tty size failure to enable -w (Elliott prefers that), and fix last field
Rob Landley [Mon, 6 Feb 2017 22:07:57 +0000 (16:07 -0600)]
Make tty size failure to enable -w (Elliott prefers that), and fix last field
to be left justified again.

7 years agoDon't set SIGWINCH when reading ANSI size probe data, it causes a loop.
Rob Landley [Mon, 6 Feb 2017 02:02:47 +0000 (20:02 -0600)]
Don't set SIGWINCH when reading ANSI size probe data, it causes a loop.

7 years agoBugfix: last field was padding to width with trailing spaces (oops), and
Rob Landley [Mon, 6 Feb 2017 01:39:31 +0000 (19:39 -0600)]
Bugfix: last field was padding to width with trailing spaces (oops), and
when we can't query terminal size pad to 80 but add -w.

7 years agoPatch from Elliott to silence a "const" warning in android/getprop.c.
Rob Landley [Sun, 5 Feb 2017 06:53:13 +0000 (00:53 -0600)]
Patch from Elliott to silence a "const" warning in android/getprop.c.
(Broken out of a larger patch, fixed the other part a different way.)

7 years agoSilence a warning.
Rob Landley [Sun, 5 Feb 2017 06:51:18 +0000 (00:51 -0600)]
Silence a warning.

Once upon a time you could call fchown() and let it fail. Then gcc decided
not using its return code was inconcievable, but you could typecast it to (void)
to shut it up. Then gcc noticed people doing that and clutched its pearls and
took it away, so I added an if() statement that does nothing with the result
because we _expect_ this to fail when we're not root. Then clang started
complaining about an if (); statement with the semicolon on the same line,
but decided it's ok if the ; is on the next line (I.E. significant whitespace
in C), so I'm adding an "assignemnt to self" that gets optimized away so
it does a more _explicit_ nothing (the same way you suppress gcc's broken
"this isn't used uninitialized" warnings).

If the compilers weren't going to so much trouble to force the issue I might
add code to only call fchown when we're UID 0, but I refuse to be coerced
into it. (And if getpid() is still a system call instead of a vdso member
then it doesn't actually _save_ us anything, the dentry should be hot and
the permission check was just "if (!uid)" before selinux entered into it and
we're operating on an fd so the security's the same.)

7 years agoDefault to width 80 when tty size probe fails (ala serial console).
Rob Landley [Sun, 5 Feb 2017 06:44:29 +0000 (00:44 -0600)]
Default to width 80 when tty size probe fails (ala serial console).

(It was defaulting to 99999 but not FLAG_w, so it tried to _pad_ to 99999.)

7 years agoPosix says stdio.h should define 'stdout' as a macro, and bionic turns it into
Rob Landley [Sat, 4 Feb 2017 20:55:36 +0000 (14:55 -0600)]
Posix says stdio.h should define 'stdout' as a macro, and bionic turns it into
an array index, which doesn't work as a local variable name. So rename it.

7 years agoSwitch oneit to use xopen_stdio() for -c (oops) and switch XVFORK() to use
Rob Landley [Sat, 4 Feb 2017 06:34:31 +0000 (00:34 -0600)]
Switch oneit to use xopen_stdio() for -c (oops) and switch XVFORK() to use
__attribute__((returns_twice)) instead of noinline.

Yes LLVM supports it: https://llvm.org/bugs/show_bug.cgi?id=6287

7 years agoFix typo in pgrep help.
Elliott Hughes [Thu, 2 Feb 2017 22:51:32 +0000 (14:51 -0800)]
Fix typo in pgrep help.

7 years agoFix operator precedence error in df.
Elliott Hughes [Fri, 3 Feb 2017 00:50:46 +0000 (16:50 -0800)]
Fix operator precedence error in df.

7 years agoBuild dependency tweak.
Rob Landley [Wed, 1 Feb 2017 22:13:01 +0000 (16:13 -0600)]
Build dependency tweak.

7 years agoExtend default USER length to 12 and output "+" as last character of truncated
Rob Landley [Wed, 1 Feb 2017 21:57:52 +0000 (15:57 -0600)]
Extend default USER length to 12 and output "+" as last character of truncated
(left-justified) fields.

7 years agops bugfix: len of TTY field doesn't include null terminator, so memmove should
Rob Landley [Tue, 31 Jan 2017 07:46:34 +0000 (01:46 -0600)]
ps bugfix: len of TTY field doesn't include null terminator, so memmove should
subtract one _less_ than /dev prefix length or string isn't terminated.

7 years agoCleanup leftover debris.
Rob Landley [Tue, 31 Jan 2017 03:42:35 +0000 (21:42 -0600)]
Cleanup leftover debris.

7 years agoImprove file's ELF parsing.
Elliott Hughes [Sun, 29 Jan 2017 20:35:54 +0000 (12:35 -0800)]
Improve file's ELF parsing.

An ELF file with no program headers is valid, and binutils leaves e_phentsize
zero in that case. Fix the corruption check to cope.

Also, since notes are in both the program and section headers (and I'm not
aware of the possibility of having no sections but still having notes ---
where would they be?), look for them in the section headers instead.

Also extend the parsing of the .android.note.ident ELF note to include the
NDK version information if present. (This won't be present for platform
binaries, but will be present for NDK-built binaries such as app libraries.)