OSDN Git Service
Rostislav Pehlivanov [Sun, 6 Dec 2015 13:34:33 +0000 (13:34 +0000)]
aacenc_tns: tune and reduce artifacts
There are a couple of major changes here:
1. Start using TNS coefficient compression.
2. Start using 3 bits per coefficient maximum for short windows.
The bits we save from these 2 changes seem to make a nice impact on the
rest of the file/windows.
3. Remove special case gain checking for short windows.
4. Modify the coefficient loop to support up to 3 windows.
The additional restrictions on TNS were something that was no in the
specifications and furthermore restricting TNS to only low energy short
windows was done to compensate for bugs elsewhere in the code.
Overall, the improvements here reduce crackling artifacts heard in very
noisy tracks.
Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
Rostislav Pehlivanov [Sun, 6 Dec 2015 13:32:40 +0000 (13:32 +0000)]
aacenc: move the TNS search and filtering before PNS
The original plan was to have TNS use data from the PNS search to better
tune itself to noise but this was never used nor necessary. This should
slightly boost the PNS accuracy if TNS was used.
Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
Paul B Mahol [Sun, 6 Dec 2015 13:57:05 +0000 (14:57 +0100)]
avfilter/af_alimiter: add 3 more options
Signed-off-by: Paul B Mahol <onemda@gmail.com>
Timothy Gu [Fri, 27 Nov 2015 22:33:03 +0000 (14:33 -0800)]
fate/concatdec: Use -bitexact
Fixes FATE failures on --enable-small builds.
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Timothy Gu [Fri, 27 Nov 2015 22:33:02 +0000 (14:33 -0800)]
ffprobe: Do not print profile names in -bitexact
Instead, print "unknown" if it's unknown, or their numerical values if
they are known.
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Ganesh Ajjanagadde [Sun, 22 Nov 2015 16:27:22 +0000 (11:27 -0500)]
ffplay: use hypot()
Reviewed-by: Marton Balint <cus@passwd.hu>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
Ganesh Ajjanagadde [Fri, 4 Dec 2015 07:35:25 +0000 (02:35 -0500)]
avcodec/dvdsubdec: fix typo in dlog message
Likely accidental in
764900d6458a2f79166ff91df4f20ad39cd6acec.
Fixes: CID
1341578.
Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
Ganesh Ajjanagadde [Fri, 4 Dec 2015 06:03:26 +0000 (01:03 -0500)]
avformat/movenc-test: correct varargs usage
It is required to call va_end for each invocation of va_start within the
same function.
Fixes: CID
1341583.
Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
Ganesh Ajjanagadde [Fri, 4 Dec 2015 06:11:10 +0000 (01:11 -0500)]
avformat/rtsp: free opts dictionary on failure of getnameinfo
Fixes: CID
1341579.
Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
Paul B Mahol [Sun, 6 Dec 2015 09:09:09 +0000 (10:09 +0100)]
avfilter/af_stereotools: fix logic fail
Signed-off-by: Paul B Mahol <onemda@gmail.com>
Reynaldo H. Verdejo Pinochet [Fri, 4 Dec 2015 22:07:23 +0000 (14:07 -0800)]
libavutil: add version component accessor macros
Pretty standard macros, these should help libav*
users avoid repeating ver.si.on parsing code,
which aids in compatibility-checking tasks like
identifying FFmpeg from Libav (_MICRO >= 100 check).
Something many are doing since we are not
intercompatible anymore.
Signed-off-by: Reynaldo H. Verdejo Pinochet <reynaldo@osg.samsung.com>
Rostislav Pehlivanov [Sat, 5 Dec 2015 23:44:04 +0000 (23:44 +0000)]
doc/encoders.texi: fix typo and clarify mpeg2_aac_low
Thanks to Brad Smith for finding the typo.
Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
Michael Niedermayer [Sat, 5 Dec 2015 21:08:59 +0000 (22:08 +0100)]
avcodec/hevc: Fix integer overflow of entry_point_offset
Fixes out of array read
Fixes:
d41d8cd98f00b204e9800998ecf8427e/signal_sigsegv_321165b_7641_077dfcd8cbc80b1c0b470c8554cd6ffb.bit
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Rostislav Pehlivanov [Sat, 5 Dec 2015 19:06:39 +0000 (19:06 +0000)]
aacenc_ltp: use an AR filter for LTP encoding as well
Seems to work better. Information on why the decoder does this is
lacking.
Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
Rostislav Pehlivanov [Sat, 5 Dec 2015 18:43:17 +0000 (18:43 +0000)]
aacenc: fix aac_pred option triggering an error
Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
Rostislav Pehlivanov [Sat, 5 Dec 2015 18:35:59 +0000 (18:35 +0000)]
doc/encoders.texi: use words intead of numbers to describe option states
Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
Rostislav Pehlivanov [Sat, 5 Dec 2015 18:29:10 +0000 (18:29 +0000)]
Changelog: append experimental flag removal to the AAC encoder entry
Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
Michael Niedermayer [Sat, 5 Dec 2015 16:15:38 +0000 (17:15 +0100)]
avcodec/dirac_parser: Check that there is a previous PU before accessing it
Fixes out of array read
Fixes:
99d142c47e6ba3510a74b872a1a2ae72/asan_heap-oob_11b36f4_3811_0f5c69e7609a88a580135678de1df844.dxa
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Michael Niedermayer [Sat, 5 Dec 2015 16:14:36 +0000 (17:14 +0100)]
avcodec/dirac_parser: Add basic validity checks for next_pu_offset and prev_pu_offset
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Michael Niedermayer [Sat, 5 Dec 2015 16:11:54 +0000 (17:11 +0100)]
avcodec/dirac_parser: Fix potential overflows in pointer checks
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Rostislav Pehlivanov [Sat, 5 Dec 2015 16:38:18 +0000 (16:38 +0000)]
doc/encoders.texi: remove forgotten mention of "experimental" from libvo-aacenc
Previous documentation commit overlooked that particular mention.
Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
Rostislav Pehlivanov [Sat, 5 Dec 2015 14:45:18 +0000 (14:45 +0000)]
aacenc: remove the experimental flag
Thiss commit removes the experimental flag from the native AAC Encoder
and thus makes it the default.
After a lot of work, done by myself and Claudio Freire, the quality of
this encoder rivals and surpasses libfdk_aac in some situations. The
encoder had instability issues earlier which prevented it from having
its experimental flag removed, however the last commits done by Claudio
removed the last known source of instability and solved a lot of
problems which were previously observed. The issues were caused by the
various coding tools interfering with the scalefactor indices. Thus,
with these problems solved, it should now be possible to declare this
encoder as the default and recommend that the users should use it
instead of others provided by external libraries, as it is both faster
and has a subjectively higher quality with selected tracks.
The encoder has still yet to be fine tuned for every possible audio file
type like music or voice, so it is hoped that with the experimental flag
removed the users should be able to provide feedback and make the
encoder better than the alternatives for every type of audio and at
every bitrate.
Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
Rostislav Pehlivanov [Sat, 5 Dec 2015 14:43:17 +0000 (14:43 +0000)]
doc/encoders.texi: update documentation for the native AAC encoder
Since the next commit removes the experimental flag from the encoder
it's better to update the documentation which has been around in its
current form for as long as the encoder itself.
Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
Rostislav Pehlivanov [Sat, 5 Dec 2015 14:41:41 +0000 (14:41 +0000)]
aacenc: mark coders other than twoloop as experimental
ANMR has some interesting things coming up but is currently not in a
shape fit for non-experimental usage. Same with "FAST".
Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
Rostislav Pehlivanov [Sat, 5 Dec 2015 14:38:44 +0000 (14:38 +0000)]
aacenc: mark the "faac"-like coder for removal
This coder produces a much lower quality audio than the rest, is much
slower and is unstable. Hasn't been updated for a very long time as
well, hence it is more appropriate to remove it since it also depends on
a big burden of a code (the encode_window_bands_info function which is
just as old, just as unstable and bad and in no way modifiable or
fixable).
Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
Paul B Mahol [Sat, 5 Dec 2015 15:08:29 +0000 (16:08 +0100)]
avfilter/af_stereotools: check s->length size
Signed-off-by: Paul B Mahol <onemda@gmail.com>
Michael Niedermayer [Sat, 5 Dec 2015 12:48:06 +0000 (13:48 +0100)]
avcodec/wmaprodec: Check bits per sample to be within the range not causing integer overflows
Fixes:
549d5aab1480d10f2a775ed90b0342f1/signal_sigabrt_7ffff6ae7cc9_5643_96bbb0cfe3e28be1dadfce1075016345.wma
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Michael Niedermayer [Sat, 5 Dec 2015 12:15:01 +0000 (13:15 +0100)]
avcodec/utils: Fix overflow in get_bit_rates computations
Fixes:
129ca3e28d73af7b1e24a9d4118e7a2d/signal_sigabrt_7ffff6ae7cc9_836_762b310fc3ef6087bd7771e5d8e90b9b.asf
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Michael Niedermayer [Sat, 5 Dec 2015 12:13:10 +0000 (13:13 +0100)]
avcodec/pcm: Fix overflow in bitrate computation
Fixes:
129ca3e28d73af7b1e24a9d4118e7a2d/signal_sigabrt_7ffff6ae7cc9_836_762b310fc3ef6087bd7771e5d8e90b9b.asf
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Michael Niedermayer [Sat, 5 Dec 2015 12:11:23 +0000 (13:11 +0100)]
avcodec/wmaprodec: Fix overflow of cutoff
Fixes:
129ca3e28d73af7b1e24a9d4118e7a2d/signal_sigabrt_7ffff6ae7cc9_836_762b310fc3ef6087bd7771e5d8e90b9b.asf
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Michael Niedermayer [Sat, 5 Dec 2015 12:06:16 +0000 (13:06 +0100)]
avformat/smacker: fix integer overflow with pts_inc
Fixes:
ce19e41f0ef1e52a23edc488faecdb58/asan_heap-oob_2504e97_4202_ffa0df1baed14022b9bfd4f8ac23d0cb.smk
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Clément Bœsch [Sat, 5 Dec 2015 11:25:14 +0000 (12:25 +0100)]
avfilter/codecview: reindent after previous commit
Clément Bœsch [Mon, 31 Aug 2015 13:18:34 +0000 (15:18 +0200)]
avfilter/codecview: add QP support
Hendrik Leppkes [Sat, 5 Dec 2015 10:49:44 +0000 (11:49 +0100)]
Merge commit '
9f57f134c19773d54269b6cb9ee455ff87c2e9e1'
* commit '
9f57f134c19773d54269b6cb9ee455ff87c2e9e1':
configure: ObjC support
Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>
Neil Birkbeck [Fri, 4 Dec 2015 00:40:24 +0000 (16:40 -0800)]
libavformat/mov.c: allow QuickTime metadata to come after traks
QuickTime metadata can come after trak data. Add indicator for which trak is being parsed (-1 if none) so that global metadata after the trak can be parsed.
Signed-off-by: Neil Birkbeck <neil.birkbeck@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Simon Thelen [Sun, 22 Nov 2015 14:03:17 +0000 (15:03 +0100)]
ffmpeg: When streamcopying, only add the input seek position when copying timestamps.
Using -ss as an input option shifts timestamps down by the seek, so it
doesn't have to be added to the recording time when checking whether to
stop.
Fixes #977
Signed-off-by: Simon Thelen <ffmpeg-dev@c-14.de>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Claudio Freire [Sat, 5 Dec 2015 01:56:34 +0000 (22:56 -0300)]
AAC encoder: ANMR, avoid empty search ranges
Avoid generating broken paths when some bands have an
empty search space.
Andreas Cadhalpun [Fri, 4 Dec 2015 17:13:07 +0000 (18:13 +0100)]
aaccoder: prevent crash of anmr coder
If minq is negative, the range of sf_idx can be larger than
SCALE_MAX_DIFF allows, causing assertion failures later in
encode_scale_factors.
Reviewed-by: Claudio Freire <klaussfreire@gmail.com>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
Michael Niedermayer [Fri, 4 Dec 2015 20:44:05 +0000 (21:44 +0100)]
swscale/utils: Fix for runtime error: left shift of negative value -1
Fixes:
c106b36fa36db8ff8f3ed0c82be7bea2/asan_heap-oob_32699f0_6321_467b9a1d7e03d7cfd310b7e65dc53bcc.mov
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Michael Niedermayer [Fri, 4 Dec 2015 20:38:12 +0000 (21:38 +0100)]
avcodec/pgssubdec: Fix left shift of 255 by 24 places cannot be represented in type int
Fixes:
b293a6479bb4b5286cff24d356bfd955/asan_generic_225c3c9_7819_cc526b657450c6cdef1371b526499626.mkv
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Vicente Olivert Riera [Thu, 3 Dec 2015 13:22:18 +0000 (13:22 +0000)]
mips: add p5600 core optimizations
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Vicente Olivert Riera [Thu, 3 Dec 2015 13:22:17 +0000 (13:22 +0000)]
mips: remove --mips32r5 configure option
Having a configure option with the same name as a MIPS ISA is confusing,
so better to remove it. This option was being used to add some
optimizations to a specific core (p5600). We will add the optimizations
just when the p5600 core has been detected, in a later patch.
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Michael Niedermayer [Fri, 4 Dec 2015 17:53:03 +0000 (18:53 +0100)]
avformat/flvdec: Fix left shift of 137 by 24 places cannot be represented in type int
Fixes:
3c857d4d90365731524716e6d051e43a/signal_sigsegv_7f4f59bcc29e_1386_20abd2c8e655cb9c75b24368e65fe3b1.flv
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Michael Niedermayer [Fri, 4 Dec 2015 17:48:39 +0000 (18:48 +0100)]
avformat/msf: Check channels when reading the header
Fixes integer overflow
Fixes:
0c2625f236ced104d402b4a03c0d65c7/asan_generic_274e1ce_5990_9314e7a67c26aecf011b178ade9f217c.avi
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Michael Niedermayer [Fri, 4 Dec 2015 15:23:24 +0000 (16:23 +0100)]
avcodec/jpeg2000dec: Check bpno in decode_cblk()
Fixes: undefined shift
Fixes:
c409ef86f892335a0a164b5871174d5a/asan_heap-oob_1dff564_2159_162b7234616deab02b544410455eb07b.mov
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Paul B Mahol [Mon, 30 Nov 2015 12:36:58 +0000 (13:36 +0100)]
avfilter: add audio emphasis filter
Signed-off-by: Paul B Mahol <onemda@gmail.com>
Clément Bœsch [Thu, 19 Nov 2015 21:54:45 +0000 (22:54 +0100)]
ffmpeg: enable echoing with command and debug modes
Allow seeing text when pressing 'c' or 'd'.
Clément Bœsch [Sat, 21 Nov 2015 20:28:31 +0000 (21:28 +0100)]
avcodec/mpegvideo: use constants for rc_strategy
Clément Bœsch [Sat, 21 Nov 2015 21:06:07 +0000 (22:06 +0100)]
swscale: use AV_OPT_TYPE_BOOL for {src,dst}_range options
Clément Bœsch [Sat, 21 Nov 2015 21:05:40 +0000 (22:05 +0100)]
swresample: use AV_OPT_TYPE_BOOL for linear_interp and cheby options
Clément Bœsch [Sat, 21 Nov 2015 21:05:07 +0000 (22:05 +0100)]
avformat: use AV_OPT_TYPE_BOOL in a bunch of places
Clément Bœsch [Sat, 21 Nov 2015 21:04:54 +0000 (22:04 +0100)]
avfilter: use AV_OPT_TYPE_BOOL in a bunch of places
Clément Bœsch [Sat, 21 Nov 2015 21:04:39 +0000 (22:04 +0100)]
avcodec: use AV_OPT_TYPE_BOOL in a bunch of places
Andreas Cadhalpun [Wed, 2 Dec 2015 21:47:12 +0000 (22:47 +0100)]
ffmdec: reject zero-sized chunks
If size is zero, avio_get_str fails, leaving the buffer uninitialized.
This causes invalid reads in av_set_options_string.
Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
Andreas Cadhalpun [Wed, 2 Dec 2015 21:25:55 +0000 (22:25 +0100)]
ffmdec: only seek back at EOF if a server is attached
Otherwise the ffm demuxer can return the same packets endlessly, if
there is no server attached.
Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
Hendrik Leppkes [Wed, 2 Dec 2015 08:52:03 +0000 (09:52 +0100)]
libavcodec/aacsbr_tablegen: fix tablegen on windows
Including these headers is not needed and breaks building on Windows as it
tries to activate the full compat tools, which are not needed for host
tools.
Hendrik Leppkes [Wed, 2 Dec 2015 08:52:02 +0000 (09:52 +0100)]
avcodec: include tablegen compat header before the tablegen functionality
Hendrik Leppkes [Wed, 2 Dec 2015 08:52:01 +0000 (09:52 +0100)]
libavutil/tablegen: add missing math.h include
Michael Niedermayer [Fri, 4 Dec 2015 12:46:53 +0000 (13:46 +0100)]
avformat/oggparsetheora: Check duration to be not AV_NOPTS_VALUE (and positive) before use
Fixes:
1536b9b096a8f95b742bae9d3d761cc6/signal_sigsegv_294aaed_7322_4fad88a38dc8952dc20dcb60c1895758.ogg
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Michael Niedermayer [Fri, 4 Dec 2015 12:43:18 +0000 (13:43 +0100)]
avcodec/dnxhddec: Fix runtime error: left shift of negative value
Fixes:
2abd25478c62a675f335fac00b467023/asan_static-oob_10aff98_1227_8811480c6ef1e970a7977ceb7e5a9958.mxf
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Michael Niedermayer [Fri, 4 Dec 2015 12:17:30 +0000 (13:17 +0100)]
ffmpeg: Check pkt_dts for AV_NOPTS_VALUE
Fixes integer overflow
Fixes:
1536b9b096a8f95b742bae9d3d761cc6/signal_sigsegv_294aaed_2039_8d1797aeb823ea43858d0fa45c9eb899.ogv
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Michael Niedermayer [Fri, 4 Dec 2015 11:47:20 +0000 (12:47 +0100)]
avcodec/vp3: Fix "runtime error: left shift of negative value"
Fixes:
5c6129154b356b80bcab86f9e3ee5d29/signal_sigabrt_7ffff6ae7cc9_7322_d26ac6d7cb6567db1b8be0159b387d0b.ogg
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Yann Coupin [Tue, 1 Dec 2015 11:22:38 +0000 (12:22 +0100)]
avformat/movenc: HE-AAC correct FourCC in ISML
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Michael Niedermayer [Fri, 4 Dec 2015 02:09:00 +0000 (03:09 +0100)]
avformat/mpjpegdec: Fix "libavformat/mpjpegdec.c:269:9: warning: passing argument 3 of av_stristart from incompatible pointer type"
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Vicente Olivert Riera [Thu, 3 Dec 2015 13:22:16 +0000 (13:22 +0000)]
mips: rename mipsdspr1 to mipsdsp
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Sebastian Dröge [Thu, 3 Dec 2015 21:04:09 +0000 (23:04 +0200)]
mpegtsenc: Fix off-by-one in indexing into Opus channel mapping arrays
Fixes, CID1338323, CID1338324
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Michael Niedermayer [Thu, 3 Dec 2015 23:31:44 +0000 (00:31 +0100)]
avcodec/h264_direct: Check CO-POCs before use
Fixes harmless integer overflow
Fixes mozilla bug
1230286
Found-by: Tyson Smith
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Michael Niedermayer [Thu, 3 Dec 2015 20:54:43 +0000 (21:54 +0100)]
avformat/utils: Fix "libavformat/utils.c:927:35: runtime error: signed integer overflow: -
2450238577049583619 -
9223090561878065151 cannot be represented in type long long"
Fixes Mozilla bug
1229205
Found-by: Tyson Smith
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Rostislav Pehlivanov [Thu, 3 Dec 2015 23:12:37 +0000 (23:12 +0000)]
aacenc_ltp: fix out of bounds memory access
Discovered by Coverity.
Michael Niedermayer [Thu, 3 Dec 2015 19:18:35 +0000 (20:18 +0100)]
avformat/riffdec: remove special case for bitrate > 32bit
AVCodecContext.bitrate is 64bit
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Michael Niedermayer [Thu, 3 Dec 2015 19:16:00 +0000 (20:16 +0100)]
avformat/riffdec: Initialize bitrate
Fixes CID1338334
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Nicolas George [Fri, 27 Nov 2015 17:58:46 +0000 (18:58 +0100)]
lavf/mpegts: use AVERROR_INVALIDDATA instead of AVERROR(EINTR).
Nicolas George [Fri, 27 Nov 2015 17:58:25 +0000 (18:58 +0100)]
lavf/lxfdec: use FFERROR_REDO instead of AVERROR(EAGAIN).
Nicolas George [Fri, 27 Nov 2015 17:58:38 +0000 (18:58 +0100)]
lavf/mpeg: use FFERROR_REDO instead of AVERROR(EAGAIN).
Nicolas George [Fri, 27 Nov 2015 17:58:05 +0000 (18:58 +0100)]
lavf/flvdec: use FFERROR_REDO instead of AVERROR(EAGAIN).
Fix trac ticket #5041.
Nicolas George [Fri, 27 Nov 2015 17:57:27 +0000 (18:57 +0100)]
lavf: add FFERROR_REDO to let demuxers return no packet.
Timo Teräs [Sat, 28 Nov 2015 06:27:39 +0000 (08:27 +0200)]
mpegencts: Fix overflow in cbr mode period calculations
ts->mux_rate is int (signed 32-bit) type. The period calculations
will start to overflow when mux_rate > 5mbps. This fixes overflows
by converting first to 64-bit type.
Fixes #5044.
Signed-off-by: Timo Teräs <timo.teras@iki.fi>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Paul B Mahol [Thu, 3 Dec 2015 09:20:09 +0000 (10:20 +0100)]
avfilter/af_agate: change default for detection to rms
Signed-off-by: Paul B Mahol <onemda@gmail.com>
Paul B Mahol [Thu, 3 Dec 2015 09:05:21 +0000 (10:05 +0100)]
avfilter/af_sidechaincompress: kill init function
Should make addition of process_command easier.
Signed-off-by: Paul B Mahol <onemda@gmail.com>
Paul B Mahol [Thu, 3 Dec 2015 09:01:50 +0000 (10:01 +0100)]
avfilter/af_agate: compile agate only when requested.
Signed-off-by: Paul B Mahol <onemda@gmail.com>
Paul B Mahol [Thu, 3 Dec 2015 08:55:30 +0000 (09:55 +0100)]
avfilter/af_agate: add level_sc option for sidechaingate filter
Also correct usage of input gain for both filters.
Signed-off-by: Paul B Mahol <onemda@gmail.com>
Paul B Mahol [Sun, 29 Nov 2015 22:22:47 +0000 (23:22 +0100)]
avfilter: add sidechaingate filter
Signed-off-by: Paul B Mahol <onemda@gmail.com>
Paul B Mahol [Sun, 29 Nov 2015 22:08:22 +0000 (23:08 +0100)]
avfilter/af_agate: prepare for adding sidechain version
Signed-off-by: Paul B Mahol <onemda@gmail.com>
Hendrik Leppkes [Mon, 30 Nov 2015 21:50:12 +0000 (22:50 +0100)]
tests/api: Fix API test build on windows with --enable-shared
James Almer [Thu, 3 Dec 2015 04:39:47 +0000 (01:39 -0300)]
avformat/mpjpegdec: fix mixed declarations and code
Michael Niedermayer [Thu, 3 Dec 2015 02:14:11 +0000 (03:14 +0100)]
avutil/timecode: Fix fps check
The fps variable is explicitly set to -1 in case of some errors, the check must
thus be signed or the code setting it needs to use 0 as error code
the type of the field could be changed as well but its in an installed header
Fixes: integer overflow
Fixes:
9982cc157b1ea90429435640a989122f/asan_generic_3ad004a_3799_22cf198d9cd09928e2d9ad250474fa58.mov
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Michael Niedermayer [Thu, 3 Dec 2015 00:08:53 +0000 (01:08 +0100)]
avcodec/jpeg2000: fix type of arguments of tag_tree_size
Fixes: out of array read
Fixes:
36b8096fefab16c4c9326a508053e95c/signal_sigsegv_1d9ce18_3233_1a55196b018106dfabeace071a432d9e.r3d
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Ganesh Ajjanagadde [Wed, 25 Nov 2015 22:49:22 +0000 (17:49 -0500)]
avfilter/af_flanger: use rint instead of floor hack
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
Ganesh Ajjanagadde [Wed, 25 Nov 2015 22:32:15 +0000 (17:32 -0500)]
avfilter/vf_perspective: use lrint instead of floor hack
Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
Ganesh Ajjanagadde [Wed, 25 Nov 2015 22:27:27 +0000 (17:27 -0500)]
avfilter/vsrc_mptestsrc: use lrint instead of floor hack
lrint is faster, and is more consistent across the codebase.
Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
Ganesh Ajjanagadde [Mon, 30 Nov 2015 02:36:52 +0000 (21:36 -0500)]
avutil/crc: avoid needless space wastage of hardcoded crc table
There was no reason AFAIK for making AV_CRC_24_IEEE 12. This simply
resulted in wasted space under --enable-hardcoded-tables:
dynamic:
1318672 libavutil/libavutil.so.55
old :
1330680 libavutil/libavutil.so.55
new :
1326488 libavutil/libavutil.so.55
Minor version number is bumped, with ifdefry due to API breakage.
Reviewed-by: James Almer <jamrial@gmail.com>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
Michael Niedermayer [Wed, 2 Dec 2015 21:59:56 +0000 (22:59 +0100)]
avcodec/vp3: ensure header is parsed successfully before tables
Fixes assertion failure
Fixes:
266ee543812e934f7b4a72923a2701d4/signal_sigabrt_7ffff6ae7cc9_7322_85218d61759d461bdf7387180e8000c9.ogg
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Michael Niedermayer [Wed, 2 Dec 2015 21:59:56 +0000 (22:59 +0100)]
avformat/utils: Move end_time1 AV_NOPTS_VALUE Check after rescale
Fixes integer overflow
Fixes:
266ee543812e934f7b4a72923a2701d4/signal_sigabrt_7ffff6ae7cc9_7322_85218d61759d461bdf7387180e8000c9.ogg
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Michael Niedermayer [Wed, 2 Dec 2015 21:59:56 +0000 (22:59 +0100)]
avformat/utils: Check AVFormatContext->duration in compute_chapters_end() before use
Fixes integer overflow
Fixes:
266ee543812e934f7b4a72923a2701d4/signal_sigabrt_7ffff6ae7cc9_7322_85218d61759d461bdf7387180e8000c9.ogg
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Paul B Mahol [Tue, 1 Dec 2015 19:09:08 +0000 (20:09 +0100)]
avfilter/af_compand: do not clip; allow >0dB curve points
Do not clip output samples, so that clipping can be handled by other filters.
Alow setting curve points above 0dB. This is useful when operating with floats.
Signed-off-by: Paul B Mahol <onemda@gmail.com>
Alex Agranovsky [Sun, 29 Nov 2015 23:54:14 +0000 (18:54 -0500)]
avformat/mpjpeg: utilize MIME boundary value to detect start of new frame
This code is disabled by default so not to regress endpoints sending invalid MIME, but can be enabled via AVOption 'strict_mime_boundary'
Signed-off-by: Alex Agranovsky <alex@sighthound.com>
Alex Agranovsky [Sun, 29 Nov 2015 23:36:20 +0000 (18:36 -0500)]
avformat/mpjpeg: allow processing of MIME parts without Content-Length header
Fixes ticket 5023
Signed-off-by: Alex Agranovsky <alex@sighthound.com>
Michael Niedermayer [Tue, 1 Dec 2015 12:34:19 +0000 (13:34 +0100)]
avutil/rational: Test av_rescale_rnd() with combinations of "special" values
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Michael Niedermayer [Tue, 1 Dec 2015 12:32:31 +0000 (13:32 +0100)]
avutil/mathematics: return INT64_MIN (=AV_NOPTS_VALUE) from av_rescale_rnd() for overflows
Fixes integer overflow
Fixes: mozilla bug
1229167
Found-by: Tyson Smith
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Michael Niedermayer [Wed, 2 Dec 2015 20:16:27 +0000 (21:16 +0100)]
avcodec/apedec: Check length in long_filter_high_3800()
Fixes out of array read
Fixes:
0a7ff0c1d93da9cef28a315ec91b692a/asan_heap-oob_4a52e5_3604_9c56dbb20e308f4faeef7b35f688521a.ape
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>