OSDN Git Service

空配列の生成に Array.Empty<T> メソッドを使用する
authorKimura Youichi <kim.upsilon@bucyou.net>
Sat, 22 Oct 2016 22:42:28 +0000 (07:42 +0900)
committerKimura Youichi <kim.upsilon@bucyou.net>
Sun, 14 Oct 2018 07:09:17 +0000 (16:09 +0900)
12 files changed:
OpenTween.Tests/Api/TwitterApiTest.cs
OpenTween.Tests/HashtagManageTest.cs
OpenTween.Tests/TweenMainTest.cs
OpenTween/Models/PostClass.cs
OpenTween/Models/PostFilterRule.cs
OpenTween/Models/TabInformations.cs
OpenTween/MyLists.cs
OpenTween/Setting/SettingTabs.cs
OpenTween/ShortcutCommand.cs
OpenTween/Thumbnail/Services/Tumblr.cs
OpenTween/Tween.cs
OpenTween/Twitter.cs

index bdc493c..f2868d9 100644 (file)
@@ -104,7 +104,7 @@ namespace OpenTween.Api
                         },
                         "/statuses/home_timeline")
                 )
-                .ReturnsAsync(new TwitterStatus[0]);
+                .ReturnsAsync(Array.Empty<TwitterStatus>());
 
                 twitterApi.apiConnection = mock.Object;
 
@@ -134,7 +134,7 @@ namespace OpenTween.Api
                         },
                         "/statuses/mentions_timeline")
                 )
-                .ReturnsAsync(new TwitterStatus[0]);
+                .ReturnsAsync(Array.Empty<TwitterStatus>());
 
                 twitterApi.apiConnection = mock.Object;
 
@@ -166,7 +166,7 @@ namespace OpenTween.Api
                         },
                         "/statuses/user_timeline")
                 )
-                .ReturnsAsync(new TwitterStatus[0]);
+                .ReturnsAsync(Array.Empty<TwitterStatus>());
 
                 twitterApi.apiConnection = mock.Object;
 
@@ -261,7 +261,7 @@ namespace OpenTween.Api
 
                 twitterApi.apiConnection = mock.Object;
 
-                await twitterApi.StatusesUpdate("hogehoge", replyToId: null, mediaIds: null, excludeReplyUserIds: new long[0])
+                await twitterApi.StatusesUpdate("hogehoge", replyToId: null, mediaIds: null, excludeReplyUserIds: Array.Empty<long>())
                     .IgnoreResponse()
                     .ConfigureAwait(false);
 
@@ -536,7 +536,7 @@ namespace OpenTween.Api
                         },
                         "/lists/statuses")
                 )
-                .ReturnsAsync(new TwitterStatus[0]);
+                .ReturnsAsync(Array.Empty<TwitterStatus>());
 
                 twitterApi.apiConnection = mock.Object;
 
@@ -795,7 +795,7 @@ namespace OpenTween.Api
                         },
                         "/users/lookup")
                 )
-                .ReturnsAsync(new TwitterUser[0]);
+                .ReturnsAsync(Array.Empty<TwitterUser>());
 
                 twitterApi.apiConnection = mock.Object;
 
@@ -851,7 +851,7 @@ namespace OpenTween.Api
                         },
                         "/favorites/list")
                 )
-                .ReturnsAsync(new TwitterStatus[0]);
+                .ReturnsAsync(Array.Empty<TwitterStatus>());
 
                 twitterApi.apiConnection = mock.Object;
 
@@ -995,7 +995,7 @@ namespace OpenTween.Api
                         null,
                         "/friendships/no_retweets/ids")
                 )
-                .ReturnsAsync(new long[0]);
+                .ReturnsAsync(Array.Empty<long>());
 
                 twitterApi.apiConnection = mock.Object;
 
index 4a2fef8..93df7b4 100644 (file)
@@ -51,7 +51,7 @@ namespace OpenTween
         [Fact]
         public void InitHashtagHistory_EmptyTest()
         {
-            var hashtags = new string[0];
+            var hashtags = Array.Empty<string>();
 
             using (var atDialog = new AtIdSupplement())
             using (var hashDialog = new HashtagManage(atDialog, hashtags, "", false, false, false))
@@ -67,7 +67,7 @@ namespace OpenTween
         public void AddHashtag_Test()
         {
             using (var atDialog = new AtIdSupplement())
-            using (var hashDialog = new HashtagManage(atDialog, new string[0], "", false, false, false))
+            using (var hashDialog = new HashtagManage(atDialog, Array.Empty<string>(), "", false, false, false))
             {
                 hashDialog.RunSilent = true;
 
@@ -86,7 +86,7 @@ namespace OpenTween
         public void AddHashtag_FullWidthTest()
         {
             using (var atDialog = new AtIdSupplement())
-            using (var hashDialog = new HashtagManage(atDialog, new string[0], "", false, false, false))
+            using (var hashDialog = new HashtagManage(atDialog, Array.Empty<string>(), "", false, false, false))
             {
                 hashDialog.RunSilent = true;
 
@@ -107,7 +107,7 @@ namespace OpenTween
             // ハッシュタグを表す「#」の直後に結合文字 (濁点など) が続いた場合に対するテスト
 
             using (var atDialog = new AtIdSupplement())
-            using (var hashDialog = new HashtagManage(atDialog, new string[0], "", false, false, false))
+            using (var hashDialog = new HashtagManage(atDialog, Array.Empty<string>(), "", false, false, false))
             {
                 hashDialog.RunSilent = true;
 
@@ -127,7 +127,7 @@ namespace OpenTween
         public void AddHashtag_MultipleTest()
         {
             using (var atDialog = new AtIdSupplement())
-            using (var hashDialog = new HashtagManage(atDialog, new string[0], "", false, false, false))
+            using (var hashDialog = new HashtagManage(atDialog, Array.Empty<string>(), "", false, false, false))
             {
                 hashDialog.RunSilent = true;
 
@@ -146,7 +146,7 @@ namespace OpenTween
         public void AddHashtag_InvalidTest()
         {
             using (var atDialog = new AtIdSupplement())
-            using (var hashDialog = new HashtagManage(atDialog, new string[0], "", false, false, false))
+            using (var hashDialog = new HashtagManage(atDialog, Array.Empty<string>(), "", false, false, false))
             {
                 hashDialog.RunSilent = true;
 
@@ -265,7 +265,7 @@ namespace OpenTween
         public void EditModeSwitch_Test()
         {
             using (var atDialog = new AtIdSupplement())
-            using (var hashDialog = new HashtagManage(atDialog, new string[0], "", false, false, false))
+            using (var hashDialog = new HashtagManage(atDialog, Array.Empty<string>(), "", false, false, false))
             {
                 hashDialog.RunSilent = true;
 
index 576dd64..984dc31 100644 (file)
@@ -75,7 +75,7 @@ namespace OpenTween
         [Fact]
         public void GetUrlFromDataObject_UnknownFormatTest()
         {
-            using (var memstream = new MemoryStream(new byte[0]))
+            using (var memstream = new MemoryStream(Array.Empty<byte>()))
             {
                 var data = new DataObject("application/x-hogehoge", memstream);
 
index e94da63..45a6250 100644 (file)
@@ -192,8 +192,8 @@ namespace OpenTween.Models
             RetweetedBy = "";
             Media = new List<MediaInfo>();
             ReplyToList = new List<Tuple<long, string>>();
-            QuoteStatusIds = new long[0];
-            ExpandedUrls = new ExpandedUrlInfo[0];
+            QuoteStatusIds = Array.Empty<long>();
+            ExpandedUrls = Array.Empty<ExpandedUrlInfo>();
         }
 
         public string TextSingleLine
index 0e360c7..c583dab 100644 (file)
@@ -93,7 +93,7 @@ namespace OpenTween.Models
             get => this._FilterBody;
             set => this.SetProperty(ref this._FilterBody, value ?? throw new ArgumentNullException(nameof(value)));
         }
-        private string[] _FilterBody = new string[0];
+        private string[] _FilterBody = Array.Empty<string>();
 
         [XmlArray("ExBodyFilterArray")]
         public string[] ExFilterBody
@@ -101,7 +101,7 @@ namespace OpenTween.Models
             get => this._ExFilterBody;
             set => this.SetProperty(ref this._ExFilterBody, value ?? throw new ArgumentNullException(nameof(value)));
         }
-        private string[] _ExFilterBody = new string[0];
+        private string[] _ExFilterBody = Array.Empty<string>();
 
         [XmlElement("SearchBoth")]
         public bool UseNameField
index 721591d..a2ddc58 100644 (file)
@@ -311,7 +311,7 @@ namespace OpenTween.Models
             lock (this.LockObj)
             {
                 soundFile = "";
-                notifyPosts = new PostClass[0];
+                notifyPosts = Array.Empty<PostClass>();
                 newMentionOrDm = false;
                 isDeletePost = false;
 
index 222b828..59ad15e 100644 (file)
@@ -45,10 +45,10 @@ namespace OpenTween
         private readonly string contextScreenName;
 
         /// <summary>自分が所有しているリスト</summary>
-        private ListElement[] ownedLists = new ListElement[0];
+        private ListElement[] ownedLists = Array.Empty<ListElement>();
 
         /// <summary>操作対象のユーザーが追加されているリストのID</summary>
-        private long[] addedListIds = new long[0];
+        private long[] addedListIds = Array.Empty<long>();
 
         public MyLists()
             => this.InitializeComponent();
index 7f3a3cd..26918e2 100644 (file)
@@ -73,7 +73,7 @@ namespace OpenTween
             /// <summary>
             /// 振り分けルール (<see cref="MyCommon.TabUsageType.UserDefined"/> で使用)
             /// </summary>
-            public PostFilterRule[] FilterArray { get; set; } = new PostFilterRule[0];
+            public PostFilterRule[] FilterArray { get; set; } = Array.Empty<PostFilterRule>();
 
             /// <summary>
             /// 表示するユーザーのスクリーンネーム (<see cref="MyCommon.TabUsageType.UserTimeline"/> で使用)
index ece590a..235cc8c 100644 (file)
@@ -66,7 +66,7 @@ namespace OpenTween
 
         private ShortcutCommand()
         {
-            this.Shortcuts = new Keys[0];
+            this.Shortcuts = Array.Empty<Keys>();
             this.command = () => Task.FromResult(0);
             this.onlyWhen = () => true;
             this.FocusedOn = FocusedControl.None;
index 23b9e43..203a5dc 100644 (file)
@@ -97,7 +97,7 @@ namespace OpenTween.Thumbnail.Services
 
                 var item = xElm.XPathSelectElement("/response/posts/item[1]");
                 if (item == null)
-                    return new ThumbnailInfo[0];
+                    return Array.Empty<ThumbnailInfo>();
 
                 var postUrlElm = item.Element("post_url");
 
index 9dbcbcb..fd0f106 100644 (file)
@@ -1578,7 +1578,7 @@ namespace OpenTween
             {
                 return new ListViewSelection
                 {
-                    SelectedStatusIds = new long[0],
+                    SelectedStatusIds = Array.Empty<long>(),
                     SelectionMarkStatusId = null,
                     FocusedStatusId = null,
                 };
@@ -5716,7 +5716,7 @@ namespace OpenTween
             }
         }
 
-        private ShortcutCommand[] shortcutCommands = new ShortcutCommand[0];
+        private ShortcutCommand[] shortcutCommands = Array.Empty<ShortcutCommand>();
 
         private void InitializeShortcuts()
         {
index 3f58a58..9573bfd 100644 (file)
@@ -159,7 +159,7 @@ namespace OpenTween
         delegate void GetIconImageDelegate(PostClass post);
         private readonly object LockObj = new object();
         private ISet<long> followerId = new HashSet<long>();
-        private long[] noRTId = new long[0];
+        private long[] noRTId = Array.Empty<long>();
 
         //プロパティからアクセスされる共通情報
         private List<string> _hashList = new List<string>();