Fix missing breaks which lead to invalid fallthroughs.

diff --git a/src/libs/extensionsystem/pluginerrorview.cpp b/src/libs/extensionsystem/pluginerrorview.cpp
index 3512fe8..ab85767 100644 (file)
--- a/src/libs/extensionsystem/pluginerrorview.cpp
+++ b/src/libs/extensionsystem/pluginerrorview.cpp
@@ -102,10 +102,13 @@ void PluginErrorView::update(PluginSpec *spec)
     case PluginSpec::Stopped:
         text = tr("Stopped");
         tooltip = tr("Plugin was shut down");
+        break;
     case PluginSpec::Deleted:
         text = tr("Deleted");
         tooltip = tr("Plugin ended its life cycle and was deleted");
+        break;
     }
+
     m_ui->state->setText(text);
     m_ui->state->setToolTip(tooltip);
     m_ui->errorString->setText(spec->errorString());

diff --git a/src/plugins/debugger/breakhandler.cpp b/src/plugins/debugger/breakhandler.cpp
index 007544e..78be9bb 100644 (file)
--- a/src/plugins/debugger/breakhandler.cpp
+++ b/src/plugins/debugger/breakhandler.cpp
@@ -626,6 +626,7 @@ QVariant BreakHandler::data(const QModelIndex &mi, int role) const
                 return tr("Breakpoint will only be hit after being ignored so many times.");
             if (role == Qt::UserRole + 1)
                 return data->ignoreCount;
+            break;
         case 6:
             if (role == Qt::DisplayRole) {
                 if (data->pending)
@@ -637,6 +638,7 @@ QVariant BreakHandler::data(const QModelIndex &mi, int role) const
                 return tr("Breakpoint will only be hit in the specified thread(s).");
             if (role == Qt::UserRole + 1)
                 return data->threadSpec;
+            break;
         case 7:
             if (role == Qt::DisplayRole) {
                 if (data->type == BreakpointData::WatchpointType)

diff --git a/src/plugins/debugger/watchutils.cpp b/src/plugins/debugger/watchutils.cpp
index 3b625d5..2db73df 100644 (file)
--- a/src/plugins/debugger/watchutils.cpp
+++ b/src/plugins/debugger/watchutils.cpp
@@ -1219,6 +1219,7 @@ void QtDumperHelper::evaluationParameters(const WatchData &data,
         break;
     case StdDequeType:
         extraArgs[1] = zero;
+        break;
     case StdStackType:
         // remove 'std::allocator<...>':
         extraArgs[1] = zero;

diff --git a/src/plugins/qt4projectmanager/qt-s60/gccetoolchain.cpp b/src/plugins/qt4projectmanager/qt-s60/gccetoolchain.cpp
index 8b73e36..7f0966b 100644 (file)
--- a/src/plugins/qt4projectmanager/qt-s60/gccetoolchain.cpp
+++ b/src/plugins/qt4projectmanager/qt-s60/gccetoolchain.cpp
@@ -129,6 +129,7 @@ void GCCEToolChain::addToEnvironment(ProjectExplorer::Environment &env)
     switch (m_type) {
     case ProjectExplorer::ToolChain::GCCE:
         m_mixin.addEpocToEnvironment(&env);
+        break;
     case ProjectExplorer::ToolChain::GCCE_GNUPOC:
         m_mixin.addGnuPocToEnvironment(&env);
         break;

diff --git a/src/plugins/texteditor/colorschemeedit.cpp b/src/plugins/texteditor/colorschemeedit.cpp
index 232a241..03141bd 100644 (file)
--- a/src/plugins/texteditor/colorschemeedit.cpp
+++ b/src/plugins/texteditor/colorschemeedit.cpp
@@ -107,6 +107,8 @@ public:
             QColor background = m_scheme->formatFor(description.id()).background();
             if (background.isValid())
                 return background;
+            else
+                break;
         }
         case Qt::FontRole: {
             QFont font = m_baseFont;