OSDN Git Service

net: ag71xx: fix compile warnings
authorOleksij Rempel <o.rempel@pengutronix.de>
Tue, 17 Dec 2019 06:51:45 +0000 (07:51 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 18 Dec 2019 06:38:50 +0000 (22:38 -0800)
drivers/net/ethernet/atheros/ag71xx.c: In function 'ag71xx_probe':
drivers/net/ethernet/atheros/ag71xx.c:1776:30: warning: passing argument 2 of
 'of_get_phy_mode' makes pointer from integer without a cast [-Wint-conversion]
In file included from drivers/net/ethernet/atheros/ag71xx.c:33:
./include/linux/of_net.h:15:69: note: expected 'phy_interface_t *'
 {aka 'enum <anonymous> *'} but argument is of type 'int'

Fixes: 0c65b2b90d13c1 ("net: of_get_phy_mode: Change API to solve int/unit warnings")
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/atheros/ag71xx.c

index 8f50210..61a334d 100644 (file)
@@ -313,7 +313,7 @@ struct ag71xx {
        struct ag71xx_desc *stop_desc;
        dma_addr_t stop_desc_dma;
 
-       int phy_if_mode;
+       phy_interface_t phy_if_mode;
 
        struct delayed_work restart_work;
        struct timer_list oom_timer;
@@ -1744,7 +1744,7 @@ static int ag71xx_probe(struct platform_device *pdev)
                eth_random_addr(ndev->dev_addr);
        }
 
-       err = of_get_phy_mode(np, ag->phy_if_mode);
+       err = of_get_phy_mode(np, &ag->phy_if_mode);
        if (err) {
                netif_err(ag, probe, ndev, "missing phy-mode property in DT\n");
                goto err_free;