* java/util/Collections.java (sort): Copy from array in forwards

	order, rather than reverse order which may be much less efficient.

git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@88146 138bc75d-0d04-0410-961f-82ee72b054a4

diff --git a/libjava/ChangeLog b/libjava/ChangeLog
index 3bf4f1d..2a68a96 100644 (file)
--- a/libjava/ChangeLog
+++ b/libjava/ChangeLog
@@ -1,3 +1,8 @@
+2004-09-26  Per Bothner  <per@bothner.com>
+
+       * java/util/Collections.java (sort):  Copy from array in forwards
+       order, rather than reverse order which may be much less efficient.
+
 2004-09-26  Mark Wielaard  <mark@klomp.org>
 
        * java/lang/System.java (properties): Make package private.

diff --git a/libjava/java/util/Collections.java b/libjava/java/util/Collections.java
index d50563c..d7b5e54 100644 (file)
--- a/libjava/java/util/Collections.java
+++ b/libjava/java/util/Collections.java
@@ -1713,11 +1713,11 @@ public class Collections
   {
     Object[] a = l.toArray();
     Arrays.sort(a, c);
-    ListIterator i = l.listIterator(a.length);
-    for (int pos = a.length; --pos >= 0; )
+    ListIterator i = l.listIterator();
+    for (int pos = 0, alen = a.length;  pos < alen;  pos++)
       {
-       i.previous();
-       i.set(a[pos]);
+        i.next();
+        i.set(a[pos]);
       }
   }