2010-11-29 Nicola Pero <nicola.pero@meta-innovation.com>
* objc-act.c (start_class): When a class is reimplemented,
generate an error and avoid adding the class to the list of
implemented classes again, but do not return error_mark_node.
In gcc/testsuite/:
2010-11-29 Nicola Pero <nicola.pero@meta-innovation.com>
* objc.dg/duplicate-class-1.m: New.
* obj-c++.dg/duplicate-class-1.mm: New.
git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@167270
138bc75d-0d04-0410-961f-
82ee72b054a4
2010-11-29 Nicola Pero <nicola.pero@meta-innovation.com>
+ * objc-act.c (start_class): When a class is reimplemented,
+ generate an error and avoid adding the class to the list of
+ implemented classes again, but do not return error_mark_node.
+
+2010-11-29 Nicola Pero <nicola.pero@meta-innovation.com>
+
* objc-act.c (objc_maybe_build_component_ref): Removed TODO.
2010-11-29 Nicola Pero <nicola.pero@meta-innovation.com>
{
error ("reimplementation of class %qE",
class_name);
- return error_mark_node;
+ /* TODO: error message saying where it was previously
+ implemented. */
+ break;
}
- implemented_classes = tree_cons (NULL_TREE, class_name,
- implemented_classes);
+ if (chain == NULL_TREE)
+ implemented_classes = tree_cons (NULL_TREE, class_name,
+ implemented_classes);
}
/* Reset for multiple classes per file. */
2010-11-29 Nicola Pero <nicola.pero@meta-innovation.com>
+ * objc.dg/duplicate-class-1.m: New.
+ * obj-c++.dg/duplicate-class-1.mm: New.
+
+2010-11-29 Nicola Pero <nicola.pero@meta-innovation.com>
+
* objc.dg/property/dotsyntax-21.m
* obj-c++.dg/property/dotsyntax-21.mm
--- /dev/null
+/* Contributed by Nicola Pero <nicola.pero@meta-innovation.com>, November 2010. */
+/* { dg-do compile } */
+
+/* Test that a duplicated @implementation for the same class does not
+ crash the compiler. */
+
+@interface Test
+{
+ Class isa;
+}
+- (int) test;
+@end
+
+@implementation Test
+- (int) test
+{
+ return 4;
+}
+@end
+
+/* The most likely cause is that the programmer meant this to be a
+ category, so check what happens if we have some different methods
+ in there. */
+@implementation Test /* { dg-error "reimplementation of class .Test." } */
+- (int) test2
+{
+ return [self test];
+}
+@end
+/* { dg-warning "incomplete implementation" "" { target *-*-* } 29 } */
+/* { dg-warning "not found" "" { target *-*-* } 29 } */
--- /dev/null
+/* Contributed by Nicola Pero <nicola.pero@meta-innovation.com>, November 2010. */
+/* { dg-do compile } */
+
+/* Test that a duplicated @implementation for the same class does not
+ crash the compiler. */
+
+@interface Test
+{
+ Class isa;
+}
+- (int) test;
+@end
+
+@implementation Test
+- (int) test
+{
+ return 4;
+}
+@end
+
+/* The most likely cause is that the programmer meant this to be a
+ category, so check what happens if we have some different methods
+ in there. */
+@implementation Test
+- (int) test2 /* { dg-error "reimplementation of class .Test." } */
+{
+ return [self test];
+}
+@end
+/* { dg-warning "incomplete implementation" "" { target *-*-* } 29 } */
+/* { dg-warning "not found" "" { target *-*-* } 29 } */