QmlJS checks: Add warning about 'eval'.

Migrated from QtChecker.

Change-Id: I4b3e8993c7b9f697497d2199b24bf49379dbc1b4
Reviewed-on: http://codereview.qt-project.org/5860
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@nokia.com>

diff --git a/src/libs/qmljs/qmljscheck.cpp b/src/libs/qmljs/qmljscheck.cpp
index 3c56387..da9c5cf 100644 (file)
--- a/src/libs/qmljs/qmljscheck.cpp
+++ b/src/libs/qmljs/qmljscheck.cpp
@@ -1160,6 +1160,8 @@ bool Check::visit(CallExpression *ast)
     if (!name.isEmpty() && name.at(0).isUpper()) {
         addMessage(WarnExpectedNewWithUppercaseFunction, location);
     }
+    if (cast<IdentifierExpression *>(ast->base) && name == QLatin1String("eval"))
+        addMessage(WarnEval, location);
     return true;
 }
 

diff --git a/tests/auto/qml/codemodel/check/avoid-eval.qml b/tests/auto/qml/codemodel/check/avoid-eval.qml
new file mode 100644 (file)
index 0000000..6155d50
--- /dev/null
+++ b/tests/auto/qml/codemodel/check/avoid-eval.qml
@@ -0,0 +1,9 @@
+import QtQuick 1.0
+
+Item {
+    function foo() {
+        eval("a + b") // 23 9 12
+        var a = { eval: function (string) { return string; } }
+        a.eval("a + b")
+    }
+}