OSDN Git Service

intel: Don't spam "intelReadPixels: fallback to swrast" in non-PBO case.
authorKenneth Graunke <kenneth@whitecape.org>
Thu, 16 May 2013 03:40:33 +0000 (20:40 -0700)
committerKenneth Graunke <kenneth@whitecape.org>
Fri, 17 May 2013 05:35:01 +0000 (22:35 -0700)
commitccb041fe8e0f4ed7e393bb82e89a7c57d222bec7
tree5ab1a1f6fa985ca955d869de4ef371885e98796c
parent46ea8041074df79561f9771e2ecf198f2cbd088f
intel: Don't spam "intelReadPixels: fallback to swrast" in non-PBO case.

When an application is using PBOs, we attempt to use the BLT engine to
perform ReadPixels.  If that fails due to some restrictions, it's useful
to raise a performance warning.

In the non-PBO case, we always use a CPU mapping since getting the data
into client memory requires a CPU-side copy.  This is a very common case,
so raising a performance warning is annoying.  In particular, apitrace's
image dumping code hits this path, causing it to print hundreds of
thousands of performance warnings via ARB_debug_output.  This tends to
obscure actual errors or other important messages.

Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
src/mesa/drivers/dri/intel/intel_pixel_read.c