OSDN Git Service

Work around gcc 4.6.0 bug that breaks WAL replay.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 10 Jun 2011 21:03:03 +0000 (17:03 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 10 Jun 2011 21:04:29 +0000 (17:04 -0400)
commitc2ba0121c73b7461331104a46d140156e847572a
tree424e4230bada5194dabf274282713b585c168271
parentcb2d158c5808c72cbd12cbffe0b7f5dbe830760b
Work around gcc 4.6.0 bug that breaks WAL replay.

ReadRecord's habit of using both direct references to tmpRecPtr and
references to *RecPtr (which is pointing at tmpRecPtr) triggers an
optimization bug in gcc 4.6.0, which apparently has forgotten about
aliasing rules.  Avoid the compiler bug, and make the code more readable
to boot, by getting rid of the direct references.  Improve the comments
while at it.

Back-patch to all supported versions, in case they get built with 4.6.0.

Tom Lane, with some cosmetic suggestions from Alex Hunsaker
src/backend/access/transam/xlog.c
src/include/access/xlog_internal.h