libstdc++-v3/ChangeLog

   1 2011-03-16  Benjamin Kosnik  <bkoz@redhat.com>
   2
   3         * src/Makefile.am: Add functional.cc, shared_ptr.cc.
   4         * src/Makefile.in: Regenerate.
   5         * libsupc++/Makefile.am: Add nested_exception.cc.
   6         * libsupc++/Makefile.in: Regenerate.
   7         * src/system_error.cc: Add ctor and dtor definitions for error_category.
   8         * src/functional.cc: New. Add dtor definition for bad_function_call.
   9         * src/stdexcept.cc: Add dtor definitions for domain_error,
  10         invalid_argument, length_error, out_of_range, range_error,
  11         overflow_error, underflow_error.
  12         * src/future.cc: Add dtor definition for __future_base::_Result_base.
  13         * src/shared_ptr.cc: New. Add dtor definition for bad_weak_ptr.
  14         * include/std/system_error: Adjust.
  15         * include/std/stdexcept: Same.
  16         * include/std/future: Same.
  17         * include/std/functional: Same.
  18         * include/bits/shared_ptr_base.h: Same.
  19         * libsupc++/nested_exception.cc: New. Add dtor for nested_exception.
  20         * libsupc++/nested_exception.h: Adjust.
  21         * testsuite/20_util/shared_ptr/cons/43820_neg.cc: Adjust line numbers.
  22         * testsuite/20_util/weak_ptr/comparison/cmp_neg.cc: Same.
  23         * config/abi/pre/gnu.ver: Add new exports.
  24
  25         * src/future.cc: Guard definitions.
  26         * libsupc++/nested_exception.cc: Same.
  27
  28         * config/abi/pre/gnu.ver: Make nested_exception exports super clear.
  29         Move bad_function_call exports from CXXABI_1.3.5 to GLIBCXX_3.4.15.
  30         Add base destructors for stdexcept classes.
  31
  32         * testsuite/19_diagnostics/stdexcept.cc: New.
  33
  34 2011-03-15  Doug Kwan  <dougkwan@google.com>
  35
  36         PR libstdc++/48123
  37         * include/Makefile.am (install-freestanding-headers): Install
  38         cpu_defines.h
  39         * include/Makefile.in: Regenerate.
  40
  41 2011-03-14  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
  42
  43         * doc/xml/manual/abi.xml: Replace docs.sun.com URLs by their OTN
  44         equivalents.
  45         * doc/html/manual/abi.html: Regenerate.
  46
  47 2011-03-14  Andrey Zholos  <aaz@althenia.net>
  48
  49         PR libstdc++/48114
  50         * include/bits/random.h (geometric_distribution): Correct formula
  51         in comment, per C++0x.
  52         (geometric_distribution<>::param_type::param_type(double)): Fix check.
  53         (geometric_distribution<>::param_type::_M_initialize):
  54         Store log(1 - p).
  55         * include/bits/random.tcc (geometric_distribution<>::operator()):
  56         Fix computation.
  57         (binomial_distribution<>::operator()): Likewise.
  58
  59 2011-03-09  Paolo Carlini  <paolo.carlini@oracle.com>
  60
  61         * testsuite/util/testsuite_rvalref.h: Minor tweaks.
  62
  63 2011-03-09  Jonathan Wakely  <redi@gcc.gnu.org>
  64             Chris Jefferson  <chris@bubblescope.net>
  65             Paolo Carlini  <paolo.carlini@oracle.com>
  66
  67         * testsuite/util/testsuite_rvalref.h (rvalstruct_compare_by_value):
  68         New.
  69         * testsuite/25_algorithms/sort_heap/check_compare_by_value.cc:
  70         Likewise.
  71         * testsuite/25_algorithms/partial_sort/check_compare_by_value:
  72         Likewise.
  73         * testsuite/25_algorithms/stable_sort/check_compare_by_value.cc:
  74         Likewise.
  75         * testsuite/25_algorithms/sort/check_compare_by_value: Likewise.
  76
  77 2011-03-09  Chris Jefferson  <chris@bubblescope.net>
  78
  79         PR libstdc++/48038
  80         * include/bits/stl_algo.h (__merge_backward): Rename to
  81         __move_merge_backward and change to always move rather than copy.
  82         (__move_merge): New function similar to std::merge except values
  83         are moved instead of copied.
  84         (__merge_adaptive, __merge_sort_loop): Change from using std::merge
  85         and __merge_backward to __move_merge and __move_merge_backward.
  86
  87 2011-03-07  Jason Merrill  <jason@redhat.com>
  88
  89         * testsuite/20_util/ratio/cons/cons_overflow_neg.cc: Adjust
  90         expected errors.
  91
  92 2011-03-07  Benjamin Kosnik  <bkoz@redhat.com>
  93             Matthias Klose  <doko@ubuntu.com>
  94             Jonathan Wakely  <redi@gcc.gnu.org>
  95
  96         PR libstdc++/47145
  97         * acinclude.m4 (GLIBCXX_CONFIGURE_DOCBOOK): Define.
  98         * configure.ac: Use it.
  99         * doc/Makefile.am (XSL_STYLE_DIR): Set at configure time.
 100         * configure: Regenerate.
 101         * doc/Makefile.in: Regenerate.
 102
 103 2011-03-04  Benjamin Kosnik  <bkoz@chula>
 104
 105         * src/Makefile.am (inst_sources): Make source instantion files
 106         conditional.
 107         (XTEMPLATE_FLAGS): Make -fno-implicit-templates conditional.
 108         * src/Makefile.in: Regenerate.
 109         * src/valarray-inst.cc: Move to..
 110         * src/valarray.cc: ...this.
 111         * acinclude.m4 (GLIBCXX_ENABLE_EXTERN_TEMPLATE]): Define.
 112         * configure.ac (GLIBCXX_ENABLE_EXTERN_TEMPLATE): Use it.
 113         * configure: Regenerate.
 114         * include/Makefile.am (stamp-extern-template): Add.
 115         * include/Makefile.in: Regenerate.
 116
 117         * doc/xml/manual/configure.xml: Document --enable-extern-template.
 118
 119         * include/bits/locale_classes.tcc: Adjust comment.
 120         * include/bits/locale_facets.tcc: Same.
 121         * include/bits/basic_ios.tcc: Same.
 122         * include/bits/istream.tcc: Same.
 123         * include/bits/codecvt.h: Same.
 124         * include/bits/ostream.tcc: Same.
 125         * include/bits/sstream.tcc: Same.
 126         * include/bits/c++config: Same.
 127         * include/bits/basic_string.tcc: Same.
 128         * include/bits/ostream_insert.h: Same.
 129         * include/bits/locale_facets_nonio.tcc: Same.
 130         * include/bits/streambuf.tcc: Same.
 131         * include/bits/allocator.h: Same.
 132         * include/bits/fstream.tcc: Same.
 133
 134         * testsuite/ext/profile/mutex_extensions_neg.cc: Adjust line numbers.
 135
 136 2011-03-02  Benjamin Kosnik  <bkoz@redhat.com>
 137
 138         * testsuite/Makefile.am: Make clean fixups.
 139         * testsuite/Makefile.in: Regenerate.
 140
 141 2011-03-02  Marc Glisse  <marc.glisse@normalesup.org>
 142
 143         * include/std/ratio (ratio_less): Add comments.
 144
 145 2011-03-02  Marc Glisse  <marc.glisse@normalesup.org>
 146
 147         PR libstdc++/47913
 148         * include/std/ratio (ratio_add): Avoid denominator overflow.
 149         * testsuite/20_util/ratio/operations/47913.cc: New.
 150
 151 2011-02-28  Benjamin Kosnik  <bkoz@redhat.com>
 152
 153         * testsuite/20_util/hash/chi2_quality.cc: Use C++0x mode on simulators.
 154         * testsuite/20_util/hash/quality.cc: Same.
 155
 156 2011-02-28  Paolo Carlini  <paolo.carlini@oracle.com>
 157
 158         PR libstdc++/47921
 159         * include/std/streambuf (basic_streambuf<>::__safe_gbump,
 160         __safe_pbump): Add.
 161         * include/bits/streambuf.tcc (basic_streambuf<>::xgetn,
 162         xputn): Use the latter.
 163         * include/bits/streambuf_iterator.h: Likewise.
 164         * src/strstream.cc: Likewise.
 165         * src/streambuf.cc: Likewise.
 166         * src/compatibility.cc: Likewise.
 167         * src/istream.cc: Likewise.
 168         * include/bits/fstream.tcc (basic_filebuf<>::xsgetn): Use setg
 169         instead of gbump.
 170         * include/std/sstream (basic_stringbuf<>::_M_pbump): Add.
 171         * include/bits/sstream.tcc (basic_stringbuf<>::seekoff,
 172         seekpos, _M_sync): Use setg, setp, and _M_pbump.
 173         * config/abi/pre/gnu.ver: Tweak.
 174
 175 2011-02-28  Paolo Carlini  <paolo.carlini@oracle.com>
 176
 177         * testsuite/20_util/ratio/comparisons/comp3.cc: New.
 178
 179 2011-02-28  Marc Glisse  <marc.glisse@normalesup.org>
 180
 181         PR libstdc++/42622
 182         * include/std/ratio (ratio_less): Reimplement to never overflow.
 183         * testsuite/20_util/ratio/comparisons/comp2.cc: Extend.
 184
 185 2011-02-24  Benjamin Kosnik  <bkoz@redhat.com>
 186
 187         * testsuite/18_support/type_info/fundamental.cc: New.
 188
 189         * testsuite/Makefile.am: Make clean fixups.
 190         * testsuite/Makefile.in: Regenerate.
 191
 192 2011-02-19  François Dumont  <francois.cppdevs@free.fr>
 193
 194         * include/debug/string (basic_string::insert): Add iterator check and
 195         pass normal iterator to normal insert.
 196         * include/debug/macros.h (__glibcxx_check_heap,
 197         __glibcxx_check_heap_pred): Remove __glibcxx_check_valid_range,
 198         already done.
 199
 200 2011-02-17  Paolo Carlini  <paolo.carlini@oracle.com>
 201
 202         PR libstdc++/47776
 203         * testsuite/ext/vstring/hash/char/1.cc: Fix.
 204         * testsuite/ext/vstring/hash/wchar_t/1.cc: Likewise.
 205
 206 2011-02-17  Jonathan Wakely  <jwakely.gcc@gmail.com>
 207
 208         * include/bits/regex.h (basic_regex::traits_type): Add typedef.
 209         (basic_regex::basic_regex(basic_regex&&)): Add noexcept.
 210         (basic_regex::operator=(basic_regex&&)): Likewise.
 211         (basic_regex::assign(basic_regex&&)): Likewise.
 212         (operator==(sub_match,...)): Implement DR 1181.
 213         (match_results::match_results(match_results&&)): Define.
 214         (match_results::operator=(const match_results&)): Fix parameter type.
 215         (match_results::operator=(match_results&&)): Define.
 216
 217 2011-02-17  Jonathan Wakely  <jwakely.gcc@gmail.com>
 218
 219         PR libstdc++/47724
 220         * include/bits/regex_compiler.h (_Scanner::_M_advance): Do not treat
 221         line anchors as metacharacters.
 222         * testsuite/28_regex/basic_regex/ctors/47724.cc: New.
 223
 224 2011-02-16  Paolo Carlini  <paolo.carlini@oracle.com>
 225
 226         PR libstdc++/47773
 227         * include/ext/vstring.h (hash<__gnu_cxx::__vstring>,
 228         hash<__gnu_cxx::__wvstring>, hash<__gnu_cxx::__u16vstring>,
 229         hash<__gnu_cxx::__u32vstring>): Add.
 230         * testsuite/ext/vstring/hash/char/1.cc: New.
 231         * testsuite/ext/vstring/hash/wchar_t/1.cc: Likewise.
 232
 233 2011-02-16  Jonathan Wakely  <jwakely.gcc@gmail.com>
 234
 235         * include/bits/regex.h (match_results::format): Use char_traits.
 236
 237 2011-02-16  Benjamin Kosnik  <bkoz@redhat.com>
 238
 239         * include/std/atomic: Remove atomic_address, uplift to N3225.
 240         * include/bits/atomic_0.h: Same.
 241         * include/bits/atomic_2.h: Same.
 242         * include/bits/atomic_base.h: Same.
 243         * testsuite/29_atomics/atomic_address/*: Delete.
 244
 245 2011-02-14  Jonathan Wakely  <jwakely.gcc@gmail.com>
 246
 247         * include/bits/regex.h (sub_match::sub_match): Add.
 248         (match_results::ready): Add.
 249         (match_results::empty): Adjust.
 250         (match_results::length): Add missing dereference.
 251         (match_results::operator[],prefix,suffix): Add debug mode checks.
 252         (match_results::cend): Re-use end().
 253         (match_results::format): Adjust signatures.
 254         (operator==(match_results,match_results)): Implement.
 255         * include/bits/regex_compiler.h (_Scanner_base): Use constexpr.
 256         * include/bits/regex_constants.h (syntax_option_type): Likewise.
 257         * include/bits/regex_grep_matcher.h: Fix comment typo.
 258         (_SpecializedResults::_SpecializedResults): Simplify.
 259         * include/bits/regex_cursor.h: Fix comment typo.
 260         * include/bits/regex_nfa.h: Likewise.
 261         * testsuite/28_regex/basic_regex/ctors/basic/string_range_01_02_03.cc:
 262         Fix error code, remove xfail.
 263         * testsuite/28_regex/basic_regex/ctors/extended/
 264         string_range_01_02_03.cc: Likewise.
 265
 266 2011-02-14  Jonathan Wakely  <jwakely.gcc@gmail.com>
 267
 268         * include/bits/regex_compiler.h: Remove unnecessary bind() calls.
 269         * include/bits/regex_nfa.h: Remove unnecessary base classes.
 270
 271 2011-02-13  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>
 272
 273         * configure: Regenerate.
 274
 275 2011-02-12  Paolo Carlini  <paolo.carlini@oracle.com>
 276
 277         PR libstdc++/47709
 278         * include/ext/algorithm (is_heap): In C++0x mode import from
 279         namespace std.
 280         * testsuite/ext/is_heap/47709.cc: New.
 281
 282 2011-02-12  Jakub Jelinek  <jakub@redhat.com>
 283             Jonathan Wakely  <jwakely.gcc@gmail.com>
 284
 285         PR libstdc++/47662
 286         * testsuite/17_intro/headers/c++200x/operator_names.cc: New.
 287         * testsuite/17_intro/headers/c++1998/operator_names.cc: Add comment.
 288
 289 2011-02-12  Paolo Carlini  <paolo.carlini@oracle.com>
 290
 291         * include/tr1/cmath (fabs): Define.
 292         * include/tr1/complex (acos, asin, atan): Avoid duplicate definitions
 293         in C++0x mode.
 294
 295 2011-02-12  Jonathan Wakely  <jwakely.gcc@gmail.com>
 296
 297         * testsuite/tr1/headers/c++200x/complex.cc: New.
 298
 299 2011-02-11  Johannes Singler  <singler@kit.edu>
 300
 301         PR libstdc++/47433
 302         * include/parallel/losertree.h
 303         (_LoserTreeUnguarded<>::__delete_min_insert):
 304         Add missing "using std::swap;", as for other variants.
 305
 306 2011-02-10  Benjamin Kosnik  <bkoz@redhat.com>
 307
 308         * src/Makefile.am (sources): Add regex.cc.
 309         * src/Makefile.in: Regenerate.
 310         * src/regex.cc: New.
 311         * include/bits/regex_error.h (error_type): Use constexpr.
 312         (regex_error): Move ctor and dtor out of line.
 313
 314         * testsuite/28_regex/03_requirements: To...
 315         * testsuite/28_regex/requirements: ... this.
 316         * testsuite/28_regex/04_header: To...
 317         * testsuite/28_regex/headers: ... this.
 318         * testsuite/28_regex/05_constants: To...
 319         * testsuite/28_regex/constants: ... this.
 320         * testsuite/28_regex/06_exception_type: To...
 321         * testsuite/28_regex/regex_error: ... this.
 322         * testsuite/28_regex/07_traits: To...
 323         * testsuite/28_regex/traits: ... this.
 324         * testsuite/28_regex/08_basic_regex: To...
 325         * testsuite/28_regex/basic_regex: ... this.
 326         * testsuite/28_regex/09_sub_match: To...
 327         * testsuite/28_regex/sub_match: ... this.
 328         * testsuite/28_regex/10_match_results: To...
 329         * testsuite/28_regex/match_results: ... this.
 330         * testsuite/28_regex/11_algorithms: To...
 331         * testsuite/28_regex/algorithms: ... this.
 332         * testsuite/28_regex/12_iterators: To...
 333         * testsuite/28_regex/iterators: ... this.
 334
 335 2011-02-10  Jonathan Wakely  <jwakely.gcc@gmail.com>
 336
 337         PR libstdc++/47662
 338         * include/bits/c++config: Do not use alternative token.
 339         * testsuite/17_intro/headers/c++1998/operator_names.cc: New.
 340
 341 2011-02-10  Jonathan Wakely  <jwakely.gcc@gmail.com>
 342
 343         * src/future.cc (future_error_category::message): Handle no_state.
 344
 345 2011-02-10  Paolo Carlini  <paolo.carlini@oracle.com>
 346
 347         * testsuite/23_containers/multimap/modifiers/erase/47628.cc: Do
 348         not test in C++0x mode.
 349         * testsuite/23_containers/map/modifiers/erase/47628.cc: Likewise.
 350         * testsuite/20_util/headers/utility/synopsis.cc: Tweak to work
 351         in C++0x mode too.
 352
 353 2011-02-10  Jonathan Wakely  <jwakely.gcc@gmail.com>
 354
 355         * doc/xml/manual/status_cxx200x.xml: Update.
 356         * doc/html/*: Regenerate.
 357
 358 2011-02-10  Jonathan Wakely  <jwakely.gcc@gmail.com>
 359
 360         * doc/xml/manual/debug.xml: Improve data race docs.
 361
 362 2011-02-09  Paolo Carlini  <paolo.carlini@oracle.com>
 363
 364         PR libstdc++/47668
 365         * include/debug/map.h (map): Remove unnecessary using-declaration.
 366         * include/debug/multimap.h (multimap): Likewise.
 367         * include/profile/map.h (map): Likewise.
 368         * include/profile/multimap.h (multimap): Likewise.
 369
 370 2011-02-09  Jonathan Wakely  <jwakely.gcc@gmail.com>
 371
 372         PR libstdc++/43863
 373         * libsupc++/guard.cc (recursive_init_error::~recursive_init_error):
 374         Move to ...
 375         * libsupc++/guard_error.cc: ... new file.
 376         * libsupc++/Makefile.am: Update.
 377         * libsupc++/Makefile.in: Regenerate.
 378
 379 2011-02-09  Jonathan Wakely  <jwakely.gcc@gmail.com>
 380
 381         * include/std/future (packaged_task::operator bool): Rename to...
 382         (packaged_task::valid): ...this.
 383         * testsuite/30_threads/packaged_task/cons/1.cc: Adjust.
 384         * testsuite/30_threads/packaged_task/cons/2.cc: Adjust.
 385         * testsuite/30_threads/packaged_task/cons/move.cc: Adjust.
 386         * testsuite/30_threads/packaged_task/cons/move_assign.cc: Adjust.
 387         * testsuite/30_threads/packaged_task/cons/alloc.cc: Adjust.
 388         * testsuite/30_threads/packaged_task/members/invoke.cc: Adjust.
 389         * testsuite/30_threads/packaged_task/members/reset.cc: Adjust.
 390         * testsuite/30_threads/packaged_task/members/reset2.cc: Adjust.
 391         * testsuite/30_threads/packaged_task/members/swap.cc: Adjust.
 392         * testsuite/30_threads/packaged_task/members/boolconv.cc: Remove.
 393         * testsuite/30_threads/packaged_task/members/valid.cc: Add.
 394
 395 2011-02-09  Paolo Carlini  <paolo.carlini@oracle.com>
 396
 397         * doc/xml/manual/io.xml: Fix typo.
 398         * doc/html/manual/streambufs.html: Likewise.
 399
 400 2011-02-09  Paolo Carlini  <paolo.carlini@oracle.com>
 401
 402         * config/abi/pre/gnu.ver: Fix.
 403
 404 2011-02-08  Benjamin Kosnik  <bkoz@redhat.com>
 405
 406         * doc/xml/manual/appendix_porting.xml: Add doc section.
 407         * doc/xml/manual/appendix_contributing.xml: Split out doc bits to...
 408         * doc/xml/manual/documentation_hacking.xml: ...here.
 409
 410         * doc/xml/manual/debug_mode.xml: Adjust.
 411         * doc/xml/manual/prerequisites.xml: Adjust.
 412         * doc/Makefile.am (xml_sources): Add dot files,
 413         documentation_hacking.xml.
 414         * doc/Makefile.in: Regenerate.
 415
 416         * doc/xml/manual/build_hacking.xml: Use absolute paths for images.
 417         * doc/xml/images/confdeps.pdf: Add.
 418
 419         * doc/html/*: Regenerate.
 420
 421 2011-02-08  Jonathan Wakely  <jwakely.gcc@gmail.com>
 422
 423         * doc/xml/gnu/fdl-1.2.xml: Remove.
 424         * doc/xml/gnu/gpl-2.0.xml: Remove.
 425         * doc/Makefile.am: Update.
 426         * doc/Makefile.in: Regenerate.
 427
 428 2011-02-07  Paolo Carlini  <paolo.carlini@oracle.com>
 429
 430         PR libstdc++/47628
 431         * include/bits/stl_tree.h (_Rb_tree::erase(iterator), erase(iterator,
 432         iterator)): Add back in C++03 mode.
 433         * testsuite/23_containers/map/modifiers/erase/47628.cc: New.
 434         * testsuite/23_containers/multimap/modifiers/erase/47628.cc: Likewise.
 435
 436 2011-02-07  Benjamin Kosnik  <bkoz@redhat.com>
 437
 438         PR libstdc++/47560 try two
 439         * config/os/hpux/os_defines.h: Guard for C++.
 440
 441 2011-02-07  Gerald Pfeifer  <gerald@pfeifer.com>
 442
 443         * doc/xml/faq.xml: Adjust link to bug database.
 444         Remove old item on broken header files.
 445
 446 2011-02-04  Benjamin Kosnik  <bkoz@redhat.com>
 447
 448         * include/bits/regex_error.h (__throw_regex_error): Not inline.
 449         * src/functexcept.cc: Add definition.
 450         * config/abi/pre/gnu.ver: Export.
 451
 452 2011-02-04  Ralf Corsépius <ralf.corsepius@rtems.org>
 453
 454         * crossconfig.m4 (GLIBCXX_CROSSCONFIG): Add *-rtems*.
 455         * configure: Regenerate.
 456
 457 2011-02-01  Paolo Carlini  <paolo.carlini@oracle.com>
 458
 459         PR libstdc++/46914
 460         * include/bits/atomic_0.h (_ATOMIC_STORE_, _ATOMIC_MODIFY_,
 461         _ATOMIC_CMPEXCHNG_): Rename __v -> __w, and __m -> __n, to
 462         avoid name conflicts.
 463
 464 2011-02-01  Benjamin Kosnik  <bkoz@redhat.com>
 465
 466         PR libstdc++/47560
 467         * config/os/hpux/os_defines.h: Remove use of macros on namespace.
 468
 469 2011-02-01  Benjamin Kosnik  <bkoz@redhat.com>
 470
 471         * scripts/run_doxygen: Allow doxygen 1.7.0 again.
 472         * doc/doxygen/user.cfg.in (PDF_HYPERLINKS): Re-enable.
 473         (COMPACT_LATEX): Enable.
 474
 475         * include/profile/impl/profiler_container_size.h: Adjust doxygen markup.
 476         * include/profile/impl/profiler_hash_func.h: Same.
 477         * include/bits/hashtable.h: Same.
 478         * include/backward/auto_ptr.h: Same.
 479         * include/backward/strstream: Same.
 480         * include/backward/backward_warning.h: Same.
 481         * include/backward/binders.h: Same.
 482
 483 2011-02-01  Gerald Pfeifer  <gerald@pfeifer.com>
 484
 485         * doc/xml/manual/debug.xml: Use GDB instead of gdb.
 486         Adjust link to GDB manual.
 487
 488 2011-01-31  Benjamin Kosnik  <bkoz@redhat.com>
 489
 490         * include/bits/c++config (_GLIBCXX_DEPRECATED): To
 491         _GLIBCXX_USE_DEPRECATED.
 492         (_GLIBCXX_DEPRECATED_ATTR): To _GLIBCXX_DEPRECATED.
 493         * doc/xml/manual/using.xml: Same.
 494         * include/std/memory: Same.
 495         * include/std/streambuf: Same.
 496         * include/bits/shared_ptr.h: Same.
 497         * include/bits/unique_ptr.h: Same.
 498         * include/bits/shared_ptr_base.h: Same.
 499         * include/bits/stl_function.h: Same.
 500         * include/tr1/shared_ptr.h: Same.
 501         * include/backward/auto_ptr.h: Same.
 502         * include/backward/binders.h: Same.
 503
 504 2011-01-31  Paolo Carlini  <paolo.carlini@oracle.com>
 505
 506         * doc/html/ext/lwg-active.html: Update to Revision D73.
 507         * doc/html/ext/lwg-closed.html: Likewise.
 508         * doc/html/ext/lwg-defects.html: Likewise.
 509         * doc/xml/manual/intro.xml: Update status of issues 408, 539, 865.
 510
 511 2011-01-30  Benjamin Kosnik  <bkoz@redhat.com>
 512
 513         PR libstdc++/36104 part four
 514         * include/bits/c++config (_GLIBCXX_STD): Remove.
 515         (_GLIBCXX_STD_D, _GLIBCXX_PR): Now _GLIBCXX_STD_C.
 516         (_GLIBCXX_P): Now _GLIBCXX_STD_A.
 517         (_GLIBCXX_NAMESPACE_DEBUG, _GLIBCXX_NAMESPACE_PARALLEL,
 518          _GLIBCXX_NAMESPACE_PROFILE, _GLIBCXX_NAMESPACE_VERSION): Remove.
 519         (_GLIBCXX_INLINE_DEBUG, _GLIBCXX_INLINE_PARALLEL,
 520          _GLIBCXX_INLINE_PROFILE): Remove.
 521         (_GLIBCXX_BEGIN_NAMESPACE(X)): Remove.
 522         (_GLIBCXX_END_NAMESPACE): Remove.
 523         (_GLIBCXX_BEGIN_NESTED_NAMESPACE(X, Y)): Remove.
 524         (_GLIBCXX_END_NESTED_NAMESPACE): Remove.
 525         (_GLIBCXX_BEGIN_NAMESPACE_ALGO): Add.
 526         (_GLIBCXX_END_NAMESPACE_ALGO): Add.
 527         (_GLIBCXX_BEGIN_NAMESPACE_CONTAINER): Add.
 528         (_GLIBCXX_END_NAMESPACE_CONTAINER): Add.
 529         (_GLIBCXX_BEGIN_NAMESPACE_VERSION): Add.
 530         (_GLIBCXX_END_NAMESPACE_VERSION): Add.
 531         (_GLIBCXX_BEGIN_LDBL_NAMESPACE): To _GLIBCXX_BEGIN_NAMESPACE_LDBL.
 532         (_GLIBCXX_END_LDBL_NAMESPACE): To _GLIBCXX_END_NAMESPACE_LDBL.
 533         (_GLIBCXX_VISIBILITY_ATTR): Revert to _GLIBCXX_VISIBILITY.
 534         * include/*: Use new macros for namespace scope.
 535         * config/*: Same.
 536         * src/*: Same.
 537
 538         * src/Makefile.am (sources): Remove debug_list.cc, add
 539         compatibility-debug_list-2.cc.
 540         (parallel_sources): Remove parallel_list.cc, add
 541         compatibility-parallel_list-2.cc.
 542         (compatibility-parallel_list-2.[o,lo]): New rule.
 543         * src/Makefile.in: Regenerate.
 544         * src/debug_list.cc: Remove.
 545         * src/parallel_list.cc: Remove.
 546         * src/compatibility-list-2.cc: New.
 547         * src/compatibility-debug_list-2.cc: New.
 548         * src/compatibility-parallel_list-2.cc: New.
 549
 550         * doc/doxygen/user.cfg.in: Adjust macros.
 551
 552         * testsuite/20_util/auto_ptr/assign_neg.cc: Adjust line numbers, macros.
 553         * testsuite/20_util/declval/requirements/1_neg.cc: Same.
 554         * testsuite/20_util/duration/requirements/typedefs_neg1.cc: Same.
 555         * testsuite/20_util/duration/requirements/typedefs_neg2.cc: Same.
 556         * testsuite/20_util/duration/requirements/typedefs_neg3.cc: Same.
 557         * testsuite/20_util/forward/c_neg.cc: Same.
 558         * testsuite/20_util/forward/f_neg.cc: Same.
 559         * testsuite/20_util/make_signed/requirements/typedefs_neg.cc: Same.
 560         * testsuite/20_util/make_unsigned/requirements/typedefs_neg.cc: Same.
 561         * testsuite/20_util/ratio/cons/cons_overflow_neg.cc: Same.
 562         * testsuite/20_util/ratio/operations/ops_overflow_neg.cc: Same.
 563         * testsuite/20_util/shared_ptr/cons/43820_neg.cc: Same.
 564         * testsuite/20_util/weak_ptr/comparison/cmp_neg.cc: Same.
 565         * testsuite/23_containers/deque/requirements/dr438/assign_neg.cc: Same.
 566         * testsuite/23_containers/deque/requirements/dr438/
 567         constructor_1_neg.cc: Same.
 568         * testsuite/23_containers/deque/requirements/dr438/
 569         constructor_2_neg.cc: Same.
 570         * testsuite/23_containers/deque/requirements/dr438/insert_neg.cc: Same.
 571         * testsuite/23_containers/forward_list/capacity/1.cc: Same.
 572         * testsuite/23_containers/forward_list/requirements/dr438/
 573         assign_neg.cc: Same.
 574         * testsuite/23_containers/forward_list/requirements/dr438/
 575         constructor_1_neg.cc: Same.
 576         * testsuite/23_containers/forward_list/requirements/dr438/
 577         constructor_2_neg.cc: Same.
 578         * testsuite/23_containers/forward_list/requirements/dr438/
 579         insert_neg.cc: Same.
 580         * testsuite/23_containers/list/capacity/29134.cc: Same.
 581         * testsuite/23_containers/list/requirements/dr438/assign_neg.cc: Same.
 582         * testsuite/23_containers/list/requirements/dr438/
 583         constructor_1_neg.cc: Same.
 584         * testsuite/23_containers/list/requirements/dr438/
 585         constructor_2_neg.cc: Same.
 586         * testsuite/23_containers/list/requirements/dr438/insert_neg.cc: Same.
 587         * testsuite/23_containers/vector/bool/capacity/29134.cc: Same.
 588         * testsuite/23_containers/vector/bool/modifiers/insert/31370.cc: Same.
 589         * testsuite/23_containers/vector/requirements/dr438/assign_neg.cc: Same.
 590         * testsuite/23_containers/vector/requirements/dr438/
 591         constructor_1_neg.cc: Same.
 592         * testsuite/23_containers/vector/requirements/dr438/
 593         constructor_2_neg.cc: Same.
 594         * testsuite/23_containers/vector/requirements/dr438/insert_neg.cc: Same.
 595         * testsuite/25_algorithms/sort/35588.cc: Same.
 596         * testsuite/27_io/ios_base/cons/assign_neg.cc: Same.
 597         * testsuite/27_io/ios_base/cons/copy_neg.cc: Same.
 598         * testsuite/ext/profile/mutex_extensions_neg.cc: Same.
 599         * testsuite/ext/profile/profiler_algos.cc: Same.
 600         * testsuite/ext/type_traits/add_unsigned_floating_neg.cc: Same.
 601         * testsuite/ext/type_traits/add_unsigned_integer_neg.cc: Same.
 602         * testsuite/ext/type_traits/remove_unsigned_floating_neg.cc: Same.
 603         * testsuite/ext/type_traits/remove_unsigned_integer_neg.cc: Same.
 604         * testsuite/tr1/2_general_utilities/shared_ptr/cons/43820_neg.cc: Same.
 605
 606 2011-01-30  Gerald Pfeifer  <gerald@pfeifer.com>
 607
 608         * doc/xml/manual/abi.xml: Adjust link to C++ ABI specification.
 609         Improve description of one such reference.
 610
 611 2011-01-30  Gerald Pfeifer  <gerald@pfeifer.com>
 612
 613         * doc/xml/manual/codecvt.xml: Fix link to The Austin Common
 614         Standards Revision Group.
 615         * doc/xml/manual/locale.xml: Ditto.
 616         * doc/xml/manual/messages.xml: Ditto.
 617         * doc/xml/manual/using_exceptions.xml: Ditto.
 618
 619 2011-01-28  Paolo Carlini  <paolo.carlini@oracle.com>
 620
 621         * include/bits/atomic_base.h: Do not include <stddef.h>.
 622         (kill_dependency): Uglify ret.
 623
 624 2011-01-26  Johannes Singler  <singler@kit.edu>
 625
 626         * include/parallel/numeric (inner_product, partial_sum):
 627         Qualify subsequent call with __gnu_parallel instead of
 628         _GLIBCXX_STD_P to reenable parallel execution without ambiguity.
 629         * include/parallel/algobase.h (equal): Likewise.
 630         * include/parallel/algo.h (find_first_of, search_n, merge,
 631         nth_element, partial_sort, max_element, min_element): Likewise.
 632         * testsuite/25_algorithms/headers/algorithm/
 633         parallel_algorithm_mixed1.cc (main): Add respective test cases.
 634         * testsuite/25_algorithms/headers/algorithm/
 635         parallel_algorithm_mixed2.cc (main): Likewise.
 636         * testsuite/26_numerics/headers/numeric/
 637         parallel_numeric_mixed1.cc (main): Likewise.
 638         * testsuite/26_numerics/headers/numeric/
 639         parallel_numeric_mixed2.cc (main): Likewise.
 640
 641 2011-01-24  Graham Reed  <greed@pobox.com>
 642
 643         PR libstdc++/47387
 644         * config/os/aix/ctype_inline.h (ctype<char>::is): Use _M_table if
 645         provided.
 646
 647 2011-01-24  Johannes Singler  <singler@kit.edu>
 648
 649         PR libstdc++/47433
 650         * include/parallel/losertree.h
 651         (_LoserTree<>::__delete_min_insert):
 652         Do not qualify swap with std:: for value type,
 653         but include a using directive instead.
 654         (_LoserTreeUnguarded<>::__delete_min_insert): Likewise.
 655         * include/parallel/balanced_quicksort.h (__qsb_divide):
 656         Use std::iter_swap instead of std::swap.
 657         (__qsb_local_sort_with_helping): Likewise.
 658         * include/parallel/partition.h (__parallel_partition):
 659         Likewise. (__parallel_nth_element): Likewise.
 660
 661 2011-01-24  Johannes Singler  <singler@kit.edu>
 662
 663         PR libstdc++/47437
 664         * include/parallel/multiway_merge.h (_UnguardedIterator):
 665         Remove useless "mutable" from reference declaration.
 666
 667 2011-01-21  Benjamin Kosnik  <bkoz@redhat.com>
 668
 669         * include/bits/c++config (_GLIBCXX_EXPORT_TEMPLATE): Remove.
 670         * include/debug/safe_sequence.h: Same.
 671         * include/debug/safe_iterator.h: Same.
 672         * include/std/forward_list: Same.
 673         * include/std/deque: Same.
 674         * include/std/list: Same.
 675         * include/std/random: Same.
 676         * include/std/streambuf: Same.
 677         * include/std/fstream: Same.
 678         * include/std/istream: Same.
 679         * include/std/string: Same.
 680         * include/std/ostream: Same.
 681         * include/std/sstream: Same.
 682         * include/ext/vstring.h: Same.
 683         * include/bits/basic_ios.h: Same.
 684         * include/bits/locale_classes.h: Same.
 685         * include/bits/locale_facets.h: Same.
 686         * include/bits/valarray_array.h: Same.
 687         * include/bits/locale_facets_nonio.h: Same.
 688         * include/tr1/random: Same.
 689
 690 2011-01-20  Jonathan Wakely  <jwakely.gcc@gmail.com>
 691
 692         * doc/xml/manual/diagnostics.xml: Replace note about C++0x concepts.
 693
 694 2011-01-20  Benjamin Kosnik  <bkoz@redhat.com>
 695
 696         PR libstdc++/36104 part three
 697         * src/hashtable_c++0x.cc: Adjust namespace macros.
 698         * testsuite/util/testsuite_rvalref.h: Don't forward declare hash.
 699         * config/abi/pre/gnu-versioned-namespace.ver: Update.
 700
 701 2011-01-20  Benjamin Kosnik  <bkoz@redhat.com>
 702
 703         * include/ext/pb_ds/detail/resize_policy/
 704         hash_load_check_resize_trigger_imp.hpp: Adjust assert condition.
 705         * include/ext/pb_ds/detail/pat_trie_/
 706         constructors_destructor_fn_imps.hpp: Same.
 707         * include/ext/pb_ds/detail/binary_heap_/erase_fn_imps.hpp: Format.
 708         * include/ext/pb_ds/detail/ov_tree_map_/debug_fn_imps.hpp: Same.
 709         * include/ext/pb_ds/detail/debug_map_base.hpp: Use never_adjustor.
 710
 711         * testsuite/ext/pb_ds/regression/hash_data_map_rand.cc: Adjust
 712         iterations downward when testing in debug mode.
 713         * testsuite/ext/pb_ds/regression/trie_data_map_rand.cc: Same.
 714         * testsuite/ext/pb_ds/regression/tree_no_data_map_rand.cc: Same.
 715         * testsuite/ext/pb_ds/regression/hash_no_data_map_rand.cc: Same.
 716         * testsuite/ext/pb_ds/regression/tree_data_map_rand.cc: Same.
 717         * testsuite/ext/pb_ds/regression/trie_no_data_map_rand.cc: Same.
 718         * testsuite/ext/pb_ds/example/hash_illegal_resize.cc: Use SIZE,
 719         reduce in debug mode.
 720
 721 2011-01-19  Benjamin Kosnik  <bkoz@redhat.com>
 722
 723         PR libstdc++/36104 part two
 724         * include/bits/hashtable.h: Revert to non-nested macro usage.
 725         * include/bits/hashtable_policy.h: Same.
 726
 727 2011-01-19  Graham Reed  <greed@pobox.com>
 728
 729         PR libstdc++/47354
 730         * src/bitmap_allocator.cc (free_list::_M_get): Lock mutex.
 731
 732 2011-01-18  Benjamin Kosnik  <bkoz@redhat.com>
 733
 734         * doc/xml/images/confdeps.png: Regenerate.
 735
 736         * include/std/chrono (duration): Mark copy constructor constexpr.
 737         * testsuite/20_util/duration/cons/constexpr.cc: Add test.
 738
 739 2011-01-18  Paolo Carlini  <paolo.carlini@oracle.com>
 740
 741         * include/bits/unique_ptr.h (default_delete<>::default_delete()):
 742         Declare defaulted per DR 1517.
 743         * testsuite/util/testsuite_common_types.h
 744         (constexpr_defaulted_default_constructible): Add.
 745         * testsuite/20_util/default_delete/cons/constexpr.cc: Use it.
 746
 747 2011-01-17  Paolo Carlini  <paolo.carlini@oracle.com>
 748
 749         * include/bits/stl_queue.h (queue<>::swap, priority_queue<>::swap):
 750         Implement DR 1198.
 751         * include/bits/stl_stack.h (stack<>::swap): Likewise.
 752
 753 2011-01-16  Paolo Carlini  <paolo.carlini@oracle.com>
 754
 755         PR libstdc++/47323
 756         * testsuite/28_regex/08_basic_regex/requirements/constexpr_data.cc:
 757         Only test wregex when _GLIBCXX_USE_WCHAR_T is defined.
 758
 759 2011-01-16  Paolo Carlini  <paolo.carlini@oracle.com>
 760
 761         PR libstdc++/47320
 762         * testsuite/18_support/numeric_limits/lowest.cc:
 763         Only test wchar_t when _GLIBCXX_USE_WCHAR_T is defined.
 764
 765 2011-01-16  Paolo Carlini  <paolo.carlini@oracle.com>
 766
 767         PR libstdc++/47321
 768         * testsuite/21_strings/basic_string/requirements/typedefs.cc:
 769         Only test std::wstring when _GLIBCXX_USE_WCHAR_T is defined.
 770
 771 2011-01-16  François Dumont  <francois.cppdevs@free.fr>
 772
 773         * testsuite/23_containers/forward_list/debug/erase_after1_neg.cc: Move
 774         to this. Use _neg suffix.
 775         * testsuite/23_containers/forward_list/debug/erase_after1.cc: ...from
 776         this.
 777         * testsuite/23_containers/forward_list/debug/erase_after2_neg.cc:
 778         Same.
 779         * testsuite/23_containers/forward_list/debug/erase_after2.cc: Same.
 780         * testsuite/23_containers/forward_list/debug/erase_after3_neg.cc:
 781         Same.
 782         * testsuite/23_containers/forward_list/debug/erase_after3.cc: Same.
 783         * testsuite/23_containers/forward_list/debug/erase_after4_neg.cc:
 784         Same.
 785         * testsuite/23_containers/forward_list/debug/erase_after4.cc: Same.
 786         * testsuite/23_containers/forward_list/debug/erase_after5_neg.cc:
 787         Same.
 788         * testsuite/23_containers/forward_list/debug/erase_after5.cc: Same.
 789         * testsuite/23_containers/forward_list/debug/erase_after6_neg.cc:
 790         Same.
 791         * testsuite/23_containers/forward_list/debug/erase_after6.cc: Same.
 792         * testsuite/23_containers/forward_list/debug/erase_after7_neg.cc:
 793         Same.
 794         * testsuite/23_containers/forward_list/debug/erase_after7.cc: Same.
 795         * testsuite/23_containers/forward_list/debug/erase_after8_neg.cc:
 796         Same.
 797         * testsuite/23_containers/forward_list/debug/erase_after8.cc: Same.
 798         * testsuite/23_containers/forward_list/debug/erase_after9_neg.cc:
 799         Same.
 800         * testsuite/23_containers/forward_list/debug/erase_after9.cc: Same.
 801         * testsuite/23_containers/forward_list/debug/insert_after1_neg.cc:
 802         Same.
 803         * testsuite/23_containers/forward_list/debug/insert_after1.cc: Same.
 804         * testsuite/23_containers/forward_list/debug/insert_after2_neg.cc:
 805         Same.
 806         * testsuite/23_containers/forward_list/debug/insert_after2.cc: Same.
 807         * testsuite/23_containers/forward_list/debug/insert_after3_neg.cc:
 808         Same.
 809         * testsuite/23_containers/forward_list/debug/insert_after3.cc: Same.
 810         * testsuite/23_containers/forward_list/debug/splice_after1_neg.cc:
 811         Same.
 812         * testsuite/23_containers/forward_list/debug/splice_after1.cc: Same.
 813         * testsuite/23_containers/forward_list/debug/splice_after2_neg.cc:
 814         Same.
 815         * testsuite/23_containers/forward_list/debug/splice_after2.cc: Same.
 816         * testsuite/23_containers/forward_list/debug/splice_after3_neg.cc:
 817         Same.
 818         * testsuite/23_containers/forward_list/debug/splice_after3.cc: Same.
 819         * testsuite/23_containers/forward_list/debug/splice_after4_neg.cc:
 820         Same.
 821         * testsuite/23_containers/forward_list/debug/splice_after4.cc: Same.
 822
 823 2011-01-14  Benjamin Kosnik  <bkoz@redhat.com>
 824
 825         PR libstdc++/36104
 826         * include/Makefile.am (bits_sup_headers, stamp-bits-sup): New.
 827         * include/Makefile.in: Regenerate.
 828         * libsupc++/Makefile.am (std_HEADERS, bits_HEADERS): New.
 829         (install-stdHEADERS, install-bitsHEADERS): New.
 830         * libsupc++/Makefile.in: Regenerate.
 831
 832         * include/bits/c++config: Update for inline namespaces.
 833         * libsupc++/cxxabi-forced.h: To...
 834         * libsupc++/cxxabi_forced.h: ...this.
 835         * libsupc++/hash_bytes.h: Separate file.
 836         * libsupc++/typeinfo: Use it.
 837         * libsupc++/exception: Adjust for bits subdirectory.
 838         * libsupc++/eh_aux_runtime.cc: Same.
 839         * libsupc++/eh_ptr.cc: Same.
 840         * libsupc++/new_op.cc: Same.
 841         * libsupc++/exception_defines.h: Same.
 842         * libsupc++/nested_exception.h: Same.
 843         * libsupc++/eh_terminate.cc: Same.
 844         * libsupc++/vec.cc: Same.
 845         * libsupc++/vterminate.cc: Same.
 846         * libsupc++/exception_ptr.h: Same.
 847         * libsupc++/eh_personality.cc: Same.
 848         * libsupc++/eh_call.cc: Same.
 849         * libsupc++/new_opnt.cc: Same.
 850         * libsupc++/hash_bytes.cc: Same.
 851         * config/cpu/arm/cxxabi_tweaks.h: Same.
 852         * config/cpu/generic/cxxabi_tweaks.h: Same.
 853         * libsupc++/cxxabi.h: Same. Consolidate _GLIBCXX_NOTHROW defines.
 854         * include/std/bitset: Same.
 855         * include/ext/vstring.tcc: Same.
 856         * include/bits/hashtable.h: Same.
 857         * include/bits/functional_hash.h: Same.
 858         * include/bits/hashtable_policy.h: Same.
 859         * include/bits/basic_string.h: Same.
 860         * include/bits/istream.tcc: Same.
 861         * include/bits/ostream.tcc: Same.
 862         * include/bits/algorithmfwd.h: Same.
 863         * include/bits/basic_string.tcc: Same.
 864         * include/bits/ostream_insert.h: Same.
 865         * include/bits/fstream.tcc: Same.
 866         * include/bits/functexcept.h: Same.
 867
 868         * doc/doxygen/user.cfg.in: Adjust names.
 869
 870         * testsuite/ext/profile/mutex_extensions_neg.cc: Adjust line numbers.
 871
 872 2011-01-14  Paolo Carlini  <paolo.carlini@oracle.com>
 873
 874         * testsuite/25_algorithms/is_permutation/check_type.cc: Minor
 875         tweaks.
 876         * testsuite/25_algorithms/is_permutation/1.cc: Cosmetic changes.
 877
 878 2011-01-13  Paolo Carlini  <paolo.carlini@oracle.com>
 879
 880         * testsuite/25_algorithms/is_permutation/check_type.cc: New.
 881         * testsuite/25_algorithms/is_permutation/requirements/
 882         explicit_instantiation/2.cc: Likewise.
 883         * testsuite/25_algorithms/is_permutation/requirements/
 884         explicit_instantiation/pod.cc: Likewise.
 885         * testsuite/25_algorithms/is_permutation/1.cc: Likewise.
 886
 887 2011-01-13  John Lakos  <jlakos@bloomberg.net>
 888             Pablo Halpern  <phalpern@halpernwightsoftware.com>
 889             Paolo Carlini  <paolo.carlini@oracle.com>
 890
 891         * include/bits/stl_algo.h (is_permutation): Add, per N3068.
 892         * include/bits/algorithmfwd.h: Add.
 893
 894 2011-01-13  Jonathan Wakely  <jwakely.gcc@gmail.com>
 895
 896         PR libstdc++/47045
 897         * config/os/bsd/netbsd/ctype_base.h: Use new macros based on version.
 898
 899 2011-01-11  Paolo Carlini  <paolo.carlini@oracle.com>
 900
 901         * aclocal.m4: Regenerate.
 902
 903 2011-01-06  Paolo Carlini  <paolo.carlini@oracle.com>
 904
 905         PR libstdc++/47185
 906         * src/placeholders.cc: New.
 907         * src/Makefile.am: Adjust.
 908         * src/Makefile.in: Regenerate.
 909         * include/std/functional (placeholders::_1, _2, ..., _29): Declare
 910         extern.
 911         * config/abi/pre/gnu.ver: Export.
 912
 913 2011-01-05  François Dumont  <francois.cppdevs@free.fr>
 914
 915         * include/debug/safe_base.h (_Safe_iterator_base::_M_unlink): New.
 916         * include/src/debug.cc: Use latter
 917         * include/debug/forward_list (forward_list<>::_M_swap):  Fix to
 918         correctly handle before_begin iterators.
 919         * testsuite/23_containers/forward_list/debug/swap.cc: Remove now
 920         useless _GLIBCXX_DEBUG checks.
 921
 922 2011-01-04  Kai Tietz  <kai.tietz@onevision.com>
 923
 924         PR libstdc++/47145
 925         * configure.ac (AC_CHECK_FILE): Replaced by test -f.
 926         * configure: Regenerated.
 927
 928 2011-01-03  Paolo Carlini  <paolo.carlini@oracle.com>
 929
 930         PR libstdc++/46922
 931         * config/abi/pre/gnu.ver: Export std::bad_function_call symbols.
 932
 933 \f
 934 Copyright (C) 2011 Free Software Foundation, Inc.
 935
 936 Copying and distribution of this file, with or without modification,
 937 are permitted in any medium without royalty provided the copyright
 938 notice and this notice are preserved.