From 2999f661ee3916db6c4a123c73bbe76a66cf3464 Mon Sep 17 00:00:00 2001 From: iains Date: Sat, 8 Jan 2011 20:32:32 +0000 Subject: [PATCH] gcc/objc: * objc-act.c (objc_finish_foreach_loop): Mark collection expression as read. gcc/testsuite: * objc.dg/foreach-1.m: Add "-Wall" to flags. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@168602 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/objc/ChangeLog | 5 +++++ gcc/objc/objc-act.c | 2 ++ gcc/testsuite/ChangeLog | 4 ++++ gcc/testsuite/objc.dg/foreach-1.m | 1 + 4 files changed, 12 insertions(+) diff --git a/gcc/objc/ChangeLog b/gcc/objc/ChangeLog index 6da04931bdf..b42bb42c68c 100644 --- a/gcc/objc/ChangeLog +++ b/gcc/objc/ChangeLog @@ -1,3 +1,8 @@ +2011-01-08 Iain Sandoe + + * objc-act.c (objc_finish_foreach_loop): Mark collection expression + as read. + 2011-01-02 H.J. Lu * objc-act.c (check_that_protocol_is_defined): Fix a typo. diff --git a/gcc/objc/objc-act.c b/gcc/objc/objc-act.c index 605705b04ff..6e69070b282 100644 --- a/gcc/objc/objc-act.c +++ b/gcc/objc/objc-act.c @@ -13635,6 +13635,8 @@ objc_finish_foreach_loop (location_t location, tree object_expression, tree coll t = build2 (MODIFY_EXPR, void_type_node, objc_foreach_collection_decl, collection_expression); SET_EXPR_LOCATION (t, location); append_to_statement_list (t, &BIND_EXPR_BODY (bind)); + /* We have used 'collection_expression'. */ + mark_exp_read (collection_expression); /* __objc_foreach_enum_state.state = 0; */ t = build2 (MODIFY_EXPR, void_type_node, objc_build_component_ref (objc_foreach_enum_state_decl, diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 459750ff4d0..39777861bc5 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2011-01-08 Iain Sandoe + + * objc.dg/foreach-1.m: Add "-Wall" to flags. + 2011-01-08 Nicola Pero PR objc/47078 diff --git a/gcc/testsuite/objc.dg/foreach-1.m b/gcc/testsuite/objc.dg/foreach-1.m index dd1d8cf985d..60993d57775 100644 --- a/gcc/testsuite/objc.dg/foreach-1.m +++ b/gcc/testsuite/objc.dg/foreach-1.m @@ -4,6 +4,7 @@ /* { dg-do run } */ /* { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { ! objc2 } } } { "-fnext-runtime" } { "" } } */ /* { dg-additional-sources "../objc-obj-c++-shared/Object1.m" } */ +/* { dg-options "-Wall" } */ #import "../objc-obj-c++-shared/Object1.h" -- 2.11.0