From: hjl Date: Mon, 30 May 2005 18:48:59 +0000 (+0000) Subject: 2005-05-30 H.J. Lu X-Git-Url: http://git.sourceforge.jp/view?p=pf3gnuchains%2Fgcc-fork.git;a=commitdiff_plain;h=c93eec39cbd181e3c8eeb272ae00176a19de976d;hp=9d97464a872a5a8d611f63181ba8d404535dff39 2005-05-30 H.J. Lu PR middle-end/20303 * c-pragma.c: Include "vec.h". (handle_pragma_visibility): Use VEC. * doc/invoke.texi: Remove the nested visibility push limit. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@100371 138bc75d-0d04-0410-961f-82ee72b054a4 --- diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 370ea010def..7a91d13abf3 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,11 @@ +2005-05-30 H.J. Lu + + PR middle-end/20303 + * c-pragma.c: Include "vec.h". + (handle_pragma_visibility): Use VEC. + + * doc/invoke.texi: Remove the nested visibility push limit. + 2005-05-30 Roger Sayle PR rtl-optimization/15422 diff --git a/gcc/c-pragma.c b/gcc/c-pragma.c index f4801e87c06..bf1c4581a1d 100644 --- a/gcc/c-pragma.c +++ b/gcc/c-pragma.c @@ -34,6 +34,7 @@ Software Foundation, 59 Temple Place - Suite 330, Boston, MA #include "c-common.h" #include "output.h" #include "tm_p.h" +#include "vec.h" #include "target.h" #define GCC_BAD(msgid) do { warning (0, msgid); return; } while (0) @@ -585,15 +586,20 @@ maybe_apply_renaming_pragma (tree decl, tree asmname) #ifdef HANDLE_PRAGMA_VISIBILITY static void handle_pragma_visibility (cpp_reader *); +typedef enum symbol_visibility visibility; +DEF_VEC_I (visibility); +DEF_VEC_ALLOC_I (visibility, heap); + /* Sets the default visibility for symbols to something other than that specified on the command line. */ static void handle_pragma_visibility (cpp_reader *dummy ATTRIBUTE_UNUSED) -{ /* Form is #pragma GCC visibility push(hidden)|pop */ - static int visstack [16], visidx; +{ + /* Form is #pragma GCC visibility push(hidden)|pop */ tree x; enum cpp_ttype token; enum { bad, push, pop } action = bad; + static VEC (visibility, heap) *visstack; token = c_lex (&x); if (token == CPP_NAME) @@ -610,14 +616,15 @@ handle_pragma_visibility (cpp_reader *dummy ATTRIBUTE_UNUSED) { if (pop == action) { - if (!visidx) + if (!VEC_length (visibility, visstack)) { GCC_BAD ("No matching push for %<#pragma GCC visibility pop%>"); } else { - default_visibility = visstack[--visidx]; - visibility_options.inpragma = (visidx>0); + default_visibility = VEC_pop (visibility, visstack); + visibility_options.inpragma + = VEC_length (visibility, visstack) != 0; } } else @@ -629,14 +636,11 @@ handle_pragma_visibility (cpp_reader *dummy ATTRIBUTE_UNUSED) { GCC_BAD ("malformed #pragma GCC visibility push"); } - else if (visidx >= 16) - { - GCC_BAD ("No more than sixteen #pragma GCC visibility pushes allowed at once"); - } else { const char *str = IDENTIFIER_POINTER (x); - visstack[visidx++] = default_visibility; + VEC_safe_push (visibility, heap, visstack, + default_visibility); if (!strcmp (str, "default")) default_visibility = VISIBILITY_DEFAULT; else if (!strcmp (str, "internal")) diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index 4f8be566fdf..47e137c03bd 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@ -12774,8 +12774,8 @@ For those adding visibility support to existing code, you may find @samp{#pragma GCC visibility} of use. This works by you enclosing the declarations you wish to set visibility for with (for example) @samp{#pragma GCC visibility push(hidden)} and -@samp{#pragma GCC visibility pop}. These can be nested up to sixteen -times. Bear in mind that symbol visibility should be viewed @strong{as +@samp{#pragma GCC visibility pop}. +Bear in mind that symbol visibility should be viewed @strong{as part of the API interface contract} and thus all new code should always specify visibility when it is not the default ie; declarations only for use within the local DSO should @strong{always} be marked explicitly