* c-typeck.c (convert_for_assignment): Tightened up pointer converstions

        that differ in signedness.
Apple Radar 2535328.

git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@85114 138bc75d-0d04-0410-961f-82ee72b054a4

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index be41b26..0c8219d 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,8 @@
+2004-07-23  Mike Stump  <mrs@apple.com>
+
+       * c-typeck.c (convert_for_assignment): Tightened up pointer converstions
+       that differ in signedness.
+

 2004-07-23  Zack Weinberg  <zack@codesourcery.com>
 
        * genmodes.c (make_vector_modes): Mark with ATTRIBUTE_UNUSED.
 2004-07-23  Zack Weinberg  <zack@codesourcery.com>
 
        * genmodes.c (make_vector_modes): Mark with ATTRIBUTE_UNUSED.

diff --git a/gcc/c-typeck.c b/gcc/c-typeck.c
index 8d201cd..ba92b2e 100644 (file)
--- a/gcc/c-typeck.c
+++ b/gcc/c-typeck.c
@@ -3472,7 +3472,7 @@ convert_for_assignment (tree type, tree rhs, const char *errtype,
                       || target_cmp)
                ;
              /* If there is a mismatch, do warn.  */
                       || target_cmp)
                ;
              /* If there is a mismatch, do warn.  */

-             else if (pedantic)
+             else

                warn_for_assignment ("pointer targets in %s differ in signedness",
                                     errtype, funname, parmnum);
            }
                warn_for_assignment ("pointer targets in %s differ in signedness",
                                     errtype, funname, parmnum);
            }

diff --git a/gcc/testsuite/gcc.dg/conv-2.c b/gcc/testsuite/gcc.dg/conv-2.c
new file mode 100644 (file)
index 0000000..349c8ac
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/conv-2.c
@@ -0,0 +1,26 @@
+/* { dg-do compile } */
+/* { dg-options "" } */
+
+void f1(long *);
+void f2(unsigned long *);
+
+int main()
+{
+  long *lp;
+  unsigned long *ulp;
+  char *cp;
+  unsigned char *ucp;
+  signed char *scp;
+
+  ulp = lp;    /* { dg-warning " pointer targets in assignment differ in signedness" } */
+  lp = ulp;    /* { dg-warning " pointer targets in assignment differ in signedness" } */
+  f1(ulp);     /* { dg-warning " differ in signedness" } */
+  f2(lp);      /* { dg-warning " differ in signedness" } */
+
+  cp = ucp;    /* { dg-warning " pointer targets in assignment differ in signedness" } */
+  cp = scp;    /* { dg-warning " pointer targets in assignment differ in signedness" } */
+  ucp = scp;   /* { dg-warning " pointer targets in assignment differ in signedness" } */
+  ucp = cp;    /* { dg-warning " pointer targets in assignment differ in signedness" } */
+  scp = ucp;   /* { dg-warning " pointer targets in assignment differ in signedness" } */
+  scp = cp;    /* { dg-warning " pointer targets in assignment differ in signedness" } */
+}