2010-05-01 Richard Guenther <rguenther@suse.de>

	PR tree-optimization/43949
	* tree-vrp.c (ssa_name_nonnegative_p): Return true for unsigned
	types.
	(extract_range_from_binary_expr): Handle *_MOD_EXPR.

	* g++.dg/warn/Warray-bounds-5.C: New testcase.

git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@158965 138bc75d-0d04-0410-961f-82ee72b054a4

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index f978694..7f636b3 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,10 @@
+2010-05-01  Richard Guenther  <rguenther@suse.de>
+
+       PR tree-optimization/43949
+       * tree-vrp.c (ssa_name_nonnegative_p): Return true for unsigned
+       types.
+       (extract_range_from_binary_expr): Handle *_MOD_EXPR.
+
 2010-05-01  Anatoly Sokolov  <aesok@post.ru>
 
        * rtl.h (CONST_DOUBLE_P): Define.

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 8e1b484..39a8d97 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2010-05-01  Richard Guenther  <rguenther@suse.de>
+
+       PR tree-optimization/43949
+       * g++.dg/warn/Warray-bounds-5.C: New testcase.
+
 2010-05-01  H.J. Lu  <hongjiu.lu@intel.com>
 
        PR c++/43951

diff --git a/gcc/tree-vrp.c b/gcc/tree-vrp.c
index 8ffde5b..83ff665 100644 (file)
--- a/gcc/tree-vrp.c
+++ b/gcc/tree-vrp.c
@@ -32,8 +32,6 @@ along with GCC; see the file COPYING3.  If not see
 #include "tree-dump.h"
 #include "timevar.h"
 #include "diagnostic.h"
-#include "tree-pretty-print.h"
-#include "gimple-pretty-print.h"
 #include "toplev.h"
 #include "intl.h"
 #include "cfgloop.h"
@@ -2086,6 +2084,9 @@ extract_range_from_binary_expr (value_range_t *vr,
       && code != EXACT_DIV_EXPR
       && code != ROUND_DIV_EXPR
       && code != TRUNC_MOD_EXPR
+      && code != FLOOR_MOD_EXPR
+      && code != CEIL_MOD_EXPR
+      && code != ROUND_MOD_EXPR
       && code != RSHIFT_EXPR
       && code != MIN_EXPR
       && code != MAX_EXPR
@@ -2155,6 +2156,9 @@ extract_range_from_binary_expr (value_range_t *vr,
       && code != EXACT_DIV_EXPR
       && code != ROUND_DIV_EXPR
       && code != TRUNC_MOD_EXPR
+      && code != FLOOR_MOD_EXPR
+      && code != CEIL_MOD_EXPR
+      && code != ROUND_MOD_EXPR
       && (vr0.type == VR_VARYING
          || vr1.type == VR_VARYING
          || vr0.type != vr1.type
@@ -2505,30 +2509,27 @@ extract_range_from_binary_expr (value_range_t *vr,
            }
        }
     }
-  else if (code == TRUNC_MOD_EXPR)
+  else if (code == TRUNC_MOD_EXPR
+          || code == FLOOR_MOD_EXPR
+          || code == CEIL_MOD_EXPR
+          || code == ROUND_MOD_EXPR)
     {
       bool sop = false;
-      if (vr1.type != VR_RANGE
+      if (vr0.type == VR_ANTI_RANGE
+         || vr1.type != VR_RANGE
          || symbolic_range_p (&vr1)
-         || range_includes_zero_p (&vr1)
-         || vrp_val_is_min (vr1.min))
+         || range_includes_zero_p (&vr1))
        {
          set_value_range_to_varying (vr);
          return;
        }
       type = VR_RANGE;
-      /* Compute MAX <|vr1.min|, |vr1.max|> - 1.  */
-      max = fold_unary_to_constant (ABS_EXPR, TREE_TYPE (vr1.min), vr1.min);
-      if (tree_int_cst_lt (max, vr1.max))
-       max = vr1.max;
-      max = int_const_binop (MINUS_EXPR, max, integer_one_node, 0);
-      /* If the dividend is non-negative the modulus will be
-        non-negative as well.  */
-      if (TYPE_UNSIGNED (TREE_TYPE (max))
-         || (vrp_expr_computes_nonnegative (op0, &sop) && !sop))
-       min = build_int_cst (TREE_TYPE (max), 0);
+      max = int_const_binop (MINUS_EXPR, vr1.max, integer_one_node, 0);
+      if (vrp_expr_computes_nonnegative (op0, &sop)
+         && vrp_expr_computes_nonnegative (op1, &sop) && !sop)
+       min = build_int_cst (TREE_TYPE (vr1.max), 0);
       else
-       min = fold_unary_to_constant (NEGATE_EXPR, TREE_TYPE (max), max);
+       min = fold_unary (NEGATE_EXPR, TREE_TYPE (max), max);
     }
   else if (code == MINUS_EXPR)
     {