OSDN Git Service

TODO解消
authoryukihane <yukihane.feather@gmail.com>
Tue, 30 Aug 2011 10:15:54 +0000 (19:15 +0900)
committeryukihane <yukihane.feather@gmail.com>
Tue, 30 Aug 2011 10:15:54 +0000 (19:15 +0900)
frontend/src/saccubus/worker/impl/convert/Convert.java

index 4f60132..a1d69f1 100644 (file)
@@ -166,8 +166,7 @@ public class Convert extends Worker<ConvertResult, ConvertProgress> {
         }
         final List<String> avfilterArgs = createAvfilterOptions(ffop.getAvfilterOption());
         if (!prof.isVhookDisabled()) {
-            // TODO 引数冗長
-            final String vhookArg = getVhookArg(prof, prof.isCommentOverlay(), transformedComment.getPath(), isHD);
+            final String vhookArg = getVhookArg(prof, transformedComment.getPath(), isHD);
             if (isNotBlank(vhookArg)) {
                 avfilterArgs.add(vhookArg);
             }
@@ -232,12 +231,12 @@ public class Convert extends Worker<ConvertResult, ConvertProgress> {
         return avfilterArgs;
     }
 
-    private static String getVhookArg(ConvertProfile prof, boolean addComment, String commPath, boolean isHD) throws
+    private static String getVhookArg(ConvertProfile prof, String commPath, boolean isHD) throws
             UnsupportedEncodingException {
         StringBuilder sb = new StringBuilder();
         sb.append("vhext=");
         sb.append(prof.getVhook().getPath().replace("\\", "/"));
-        if (addComment) {
+        if (prof.isCommentOverlay()) {
             sb.append("|");
             sb.append("--data-user:");
             sb.append(URLEncoder.encode(commPath.replace("\\", "/"), "Shift_JIS"));