From 5bfb60b4afb3901e09b9303def258f7ee72ad5ac Mon Sep 17 00:00:00 2001 From: rguenth Date: Mon, 17 Jul 2006 08:04:25 +0000 Subject: [PATCH] 2006-07-17 Richard Guenther PR tree-optimization/28238 * tree-inline.c (copy_bb): Check if we produced valid gimple copying and substituting a stmt. If not, gimplify it. * g++.dg/tree-ssa/pr28238.C: New testcase. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@115517 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/ChangeLog | 7 +++++++ gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/g++.dg/tree-ssa/pr28238.C | 22 ++++++++++++++++++++++ gcc/tree-inline.c | 8 ++++++++ 4 files changed, 42 insertions(+) create mode 100644 gcc/testsuite/g++.dg/tree-ssa/pr28238.C diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 90c89795d4a..8c6048b7e09 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +2006-07-17 Richard Guenther + + PR tree-optimization/28238 + * tree-inline.c (copy_bb): Check if we produced valid + gimple copying and substituting a stmt. If not, gimplify + it. + 2006-07-16 Eric Botcazou * optabs.c (maybe_encapsulate_block): New function extracted from... diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 8b6cf37bd73..9b08ae65f01 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2006-07-17 Richard Guenther + + PR tree-optimization/28238 + * g++.dg/tree-ssa/pr28238.C: New testcase. + 2006-07-17 Volker Reichelt PR c++/28250 diff --git a/gcc/testsuite/g++.dg/tree-ssa/pr28238.C b/gcc/testsuite/g++.dg/tree-ssa/pr28238.C new file mode 100644 index 00000000000..97e388fbd32 --- /dev/null +++ b/gcc/testsuite/g++.dg/tree-ssa/pr28238.C @@ -0,0 +1,22 @@ +/* { dg-do compile } */ +/* { dg-options "-O" } */ + +struct iterator{}; +struct ByteIterator : iterator +{ + ByteIterator (){} + int a[1024]; +}; +inline ByteIterator f () +{ + return ByteIterator (); +} +class ConfLexerCore +{ + ConfLexerCore (); + ByteIterator m_matchStart; +}; +ConfLexerCore::ConfLexerCore () +: m_matchStart (f ()) +{ } + diff --git a/gcc/tree-inline.c b/gcc/tree-inline.c index 4749be519e3..92d85a89b2b 100644 --- a/gcc/tree-inline.c +++ b/gcc/tree-inline.c @@ -704,6 +704,14 @@ copy_bb (copy_body_data *id, basic_block bb, int frequency_scale, int count_scal if (stmt) { tree call, decl; + + /* With return slot optimization we can end up with + non-gimple (foo *)&this->m, fix that here. */ + if (TREE_CODE (stmt) == MODIFY_EXPR + && TREE_CODE (TREE_OPERAND (stmt, 1)) == NOP_EXPR + && !is_gimple_val (TREE_OPERAND (TREE_OPERAND (stmt, 1), 0))) + gimplify_stmt (&stmt); + bsi_insert_after (©_bsi, stmt, BSI_NEW_STMT); call = get_call_expr_in (stmt); /* We're duplicating a CALL_EXPR. Find any corresponding -- 2.11.0