From a837ff93f96778825f244575af91b64a7fff760e Mon Sep 17 00:00:00 2001 From: jason Date: Mon, 23 Jan 2012 20:48:31 +0000 Subject: [PATCH] PR c++/51930 * decl2.c (determine_visibility): Check for visibility attribute on template specialization. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@183455 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/cp/ChangeLog | 6 ++++++ gcc/cp/decl2.c | 8 +++++++- gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/g++.dg/ext/visibility/template10.C | 16 ++++++++++++++++ 4 files changed, 34 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/g++.dg/ext/visibility/template10.C diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 13f34845818..11d458a3644 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,9 @@ +2012-01-23 Jason Merrill + + PR c++/51930 + * decl2.c (determine_visibility): Check for visibility attribute + on template specialization. + 2012-01-23 Paolo Carlini PR c++/51398 diff --git a/gcc/cp/decl2.c b/gcc/cp/decl2.c index f51790c551d..bdc962abcf9 100644 --- a/gcc/cp/decl2.c +++ b/gcc/cp/decl2.c @@ -2177,8 +2177,14 @@ determine_visibility (tree decl) ? TYPE_TEMPLATE_INFO (TREE_TYPE (decl)) : DECL_TEMPLATE_INFO (decl)); tree args = TI_ARGS (tinfo); + tree attribs = (TREE_CODE (decl) == TYPE_DECL + ? TYPE_ATTRIBUTES (TREE_TYPE (decl)) + : DECL_ATTRIBUTES (decl)); - if (args != error_mark_node) + if (args != error_mark_node + /* Template argument visibility outweighs #pragma or namespace + visibility, but not an explicit attribute. */ + && !lookup_attribute ("visibility", attribs)) { int depth = TMPL_ARGS_DEPTH (args); tree pattern = DECL_TEMPLATE_RESULT (TI_TEMPLATE (tinfo)); diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 0f1e4bf2bb8..43794d3e5eb 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2012-01-23 Jason Merrill + + PR c++/51930 + * g++.dg/ext/visibility/template10.C: New. + 2012-01-23 Tobias Burnus PR fortran/51948 diff --git a/gcc/testsuite/g++.dg/ext/visibility/template10.C b/gcc/testsuite/g++.dg/ext/visibility/template10.C new file mode 100644 index 00000000000..01108aa7f42 --- /dev/null +++ b/gcc/testsuite/g++.dg/ext/visibility/template10.C @@ -0,0 +1,16 @@ +// PR c++/51930 +// { dg-require-visibility } +// { dg-options -fvisibility=hidden } +// { dg-final { scan-not-hidden "_Z8testfuncI3fooEvv" } } + +struct foo { }; + +template +__attribute__ ((visibility("default"))) +void testfunc(); + +template void testfunc() { } + +template +__attribute__ ((visibility("default"))) +void testfunc(); -- 2.11.0