X-Git-Url: http://git.sourceforge.jp/view?a=blobdiff_plain;f=libobjc%2Fencoding.c;h=e65634103aa41c55ff2b903e29ac74513d2a17a4;hb=a379b1cbb386dacd9252facf3f719bc6f0b936ea;hp=ec7173774e8a6955024493bd60adc8ff4515fb1d;hpb=5047c11ee877965063c13024474b0bb14d111871;p=pf3gnuchains%2Fgcc-fork.git diff --git a/libobjc/encoding.c b/libobjc/encoding.c index ec7173774e8..e65634103aa 100644 --- a/libobjc/encoding.c +++ b/libobjc/encoding.c @@ -1,24 +1,25 @@ /* Encoding of types for Objective C. - Copyright (C) 1993, 1995, 1996, 1997, 1998, 2000 Free Software Foundation, Inc. + Copyright (C) 1993, 1995, 1996, 1997, 1998, 2000, 2002, 2004 + Free Software Foundation, Inc. Contributed by Kresten Krab Thorup Bitfield support by Ovidiu Predescu -This file is part of GNU CC. +This file is part of GCC. -GNU CC is free software; you can redistribute it and/or modify +GCC is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2, or (at your option) any later version. -GNU CC is distributed in the hope that it will be useful, +GCC is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License -along with GNU CC; see the file COPYING. If not, write to -the Free Software Foundation, 59 Temple Place - Suite 330, -Boston, MA 02111-1307, USA. */ +along with GCC; see the file COPYING. If not, write to +the Free Software Foundation, 51 Franklin Street, Fifth Floor, +Boston, MA 02110-1301, USA. */ /* As a special exception, if you link this library with files compiled with GCC to produce an executable, this does not cause @@ -26,21 +27,29 @@ Boston, MA 02111-1307, USA. */ This exception does not however invalidate any other reasons why the executable file might be covered by the GNU General Public License. */ +/* FIXME: This file has no business including tm.h. */ + #include "tconfig.h" -#include "objc-api.h" -#include "encoding.h" +#include "coretypes.h" +#include "tm.h" +#include "objc/objc-api.h" +#include "objc/encoding.h" +#include +#undef MAX #define MAX(X, Y) \ - ({ typeof(X) __x = (X), __y = (Y); \ + ({ typeof (X) __x = (X), __y = (Y); \ (__x > __y ? __x : __y); }) +#undef MIN #define MIN(X, Y) \ - ({ typeof(X) __x = (X), __y = (Y); \ + ({ typeof (X) __x = (X), __y = (Y); \ (__x < __y ? __x : __y); }) +#undef ROUND #define ROUND(V, A) \ - ({ typeof(V) __v=(V); typeof(A) __a=(A); \ - __a*((__v+__a-1)/__a); }) + ({ typeof (V) __v = (V); typeof (A) __a = (A); \ + __a * ((__v+__a - 1)/__a); }) /* Various hacks for objc_layout_record. These are used by the target @@ -58,43 +67,70 @@ Boston, MA 02111-1307, USA. */ #define VECTOR_TYPE _C_VECTOR -#define TYPE_FIELDS(TYPE) objc_skip_typespec (TYPE) +#define TYPE_FIELDS(TYPE) ({const char *_field = (TYPE)+1; \ + while (*_field != _C_STRUCT_E && *_field != _C_STRUCT_B \ + && *_field != _C_UNION_B && *_field++ != '=') \ + /* do nothing */; \ + _field;}) #define DECL_MODE(TYPE) *(TYPE) #define TYPE_MODE(TYPE) *(TYPE) #define DFmode _C_DBL -#define get_inner_array_type(TYPE) ((TYPE) + 1) +#define get_inner_array_type(TYPE) ({const char *_field = (TYPE); \ + while (*_field == _C_ARY_B)\ + {\ + while (isdigit ((unsigned char)*++_field))\ + ;\ + }\ + _field;}) /* Some ports (eg ARM) allow the structure size boundary to be selected at compile-time. We override the normal definition with one that has a constant value for this compilation. */ -#undef STRUCTURE_SIZE_BOUNDARY +#ifndef BITS_PER_UNIT +#define BITS_PER_UNIT 8 +#endif +#undef STRUCTURE_SIZE_BOUNDARY #define STRUCTURE_SIZE_BOUNDARY (BITS_PER_UNIT * sizeof (struct{char a;})) /* Some ROUND_TYPE_ALIGN macros use TARGET_foo, and consequently - target_flags. Define a dummy entry here to so we don't die. */ - -static int target_flags = 0; - -static inline int -atoi (const char* str) -{ - int res = 0; - - while (isdigit (*str)) - res *= 10, res += (*str++ - '0'); - - return res; -} + target_flags. Define a dummy entry here to so we don't die. + We have to rename it because target_flags may already have been + declared extern. */ +#define target_flags not_target_flags +static int __attribute__ ((__unused__)) not_target_flags = 0; + +/* Some ROUND_TYPE_ALIGN use ALTIVEC_VECTOR_MODE (rs6000 darwin). + Define a dummy ALTIVEC_VECTOR_MODE so it will not die. */ +#undef ALTIVEC_VECTOR_MODE +#define ALTIVEC_VECTOR_MODE(MODE) (0) + + +/* FIXME: while this file has no business including tm.h, this + definitely has no business defining this macro but it + is only way around without really rewritting this file, + should look after the branch of 3.4 to fix this. */ +#define rs6000_special_round_type_align(STRUCT, COMPUTED, SPECIFIED) \ + ({ const char *_fields = TYPE_FIELDS (STRUCT); \ + ((_fields != 0 \ + && TYPE_MODE (TREE_CODE (TREE_TYPE (_fields)) == ARRAY_TYPE \ + ? get_inner_array_type (_fields) \ + : TREE_TYPE (_fields)) == DFmode) \ + ? MAX (MAX (COMPUTED, SPECIFIED), 64) \ + : MAX (COMPUTED, SPECIFIED));}) +/* FIXME: The word 'fixme' is insufficient to explain the wrong-ness + of this next macro definition. */ +#define darwin_rs6000_special_round_type_align(S,C,S2) \ + rs6000_special_round_type_align(S,C,S2) /* - return the size of an object specified by type + return the size of an object specified by type */ int -objc_sizeof_type (const char* type) +objc_sizeof_type (const char *type) { /* Skip the variable name if any */ if (*type == '"') @@ -103,83 +139,89 @@ objc_sizeof_type (const char* type) /* do nothing */; } - switch(*type) { + switch (*type) { + case _C_BOOL: + return sizeof (_Bool); + break; + case _C_ID: - return sizeof(id); + return sizeof (id); break; case _C_CLASS: - return sizeof(Class); + return sizeof (Class); break; case _C_SEL: - return sizeof(SEL); + return sizeof (SEL); break; case _C_CHR: - return sizeof(char); + return sizeof (char); break; - + case _C_UCHR: - return sizeof(unsigned char); + return sizeof (unsigned char); break; case _C_SHT: - return sizeof(short); + return sizeof (short); break; case _C_USHT: - return sizeof(unsigned short); + return sizeof (unsigned short); break; case _C_INT: - return sizeof(int); + return sizeof (int); break; case _C_UINT: - return sizeof(unsigned int); + return sizeof (unsigned int); break; case _C_LNG: - return sizeof(long); + return sizeof (long); break; case _C_ULNG: - return sizeof(unsigned long); + return sizeof (unsigned long); break; case _C_LNG_LNG: - return sizeof(long long); + return sizeof (long long); break; case _C_ULNG_LNG: - return sizeof(unsigned long long); + return sizeof (unsigned long long); break; case _C_FLT: - return sizeof(float); + return sizeof (float); break; case _C_DBL: - return sizeof(double); + return sizeof (double); break; case _C_VOID: - return sizeof(void); + return sizeof (void); break; + case _C_PTR: case _C_ATOM: case _C_CHARPTR: - return sizeof(char*); + return sizeof (char *); break; case _C_ARY_B: { - int len = atoi(type+1); - while (isdigit(*++type)); - return len*objc_aligned_size (type); + int len = atoi (type + 1); + while (isdigit ((unsigned char)*++type)) + ; + return len * objc_aligned_size (type); } - break; + break; case _C_BFLD: { @@ -188,7 +230,8 @@ objc_sizeof_type (const char* type) int startByte, endByte; position = atoi (type + 1); - while (isdigit (*++type)); + while (isdigit ((unsigned char)*++type)) + ; size = atoi (type + 1); startByte = position / BITS_PER_UNIT; @@ -196,6 +239,7 @@ objc_sizeof_type (const char* type) return endByte - startByte; } + case _C_UNION_B: case _C_STRUCT_B: { struct objc_struct_layout layout; @@ -208,28 +252,72 @@ objc_sizeof_type (const char* type) return size; } - - case _C_UNION_B: + + case _C_COMPLEX: { - int max_size = 0; - while (*type != _C_UNION_E && *type++ != '=') /* do nothing */; - while (*type != _C_UNION_E) - { - /* Skip the variable name if any */ - if (*type == '"') - { - for (type++; *type++ != '"';) - /* do nothing */; - } - max_size = MAX (max_size, objc_sizeof_type (type)); - type = objc_skip_typespec (type); + type++; /* Skip after the 'j'. */ + switch (*type) + { + case _C_CHR: + return sizeof (_Complex char); + break; + + case _C_UCHR: + return sizeof (_Complex unsigned char); + break; + + case _C_SHT: + return sizeof (_Complex short); + break; + + case _C_USHT: + return sizeof (_Complex unsigned short); + break; + + case _C_INT: + return sizeof (_Complex int); + break; + + case _C_UINT: + return sizeof (_Complex unsigned int); + break; + + case _C_LNG: + return sizeof (_Complex long); + break; + + case _C_ULNG: + return sizeof (_Complex unsigned long); + break; + + case _C_LNG_LNG: + return sizeof (_Complex long long); + break; + + case _C_ULNG_LNG: + return sizeof (_Complex unsigned long long); + break; + + case _C_FLT: + return sizeof (_Complex float); + break; + + case _C_DBL: + return sizeof (_Complex double); + break; + + default: + { + objc_error (nil, OBJC_ERR_BAD_TYPE, "unknown complex type %s\n", + type); + return 0; + } } - return max_size; } - + default: { - objc_error(nil, OBJC_ERR_BAD_TYPE, "unknown type %s\n", type); + objc_error (nil, OBJC_ERR_BAD_TYPE, "unknown type %s\n", type); return 0; } } @@ -237,11 +325,11 @@ objc_sizeof_type (const char* type) /* - Return the alignment of an object specified by type + Return the alignment of an object specified by type */ int -objc_alignof_type(const char* type) +objc_alignof_type (const char *type) { /* Skip the variable name if any */ if (*type == '"') @@ -249,78 +337,84 @@ objc_alignof_type(const char* type) for (type++; *type++ != '"';) /* do nothing */; } - switch(*type) { + switch (*type) { + case _C_BOOL: + return __alignof__ (_Bool); + break; + case _C_ID: - return __alignof__(id); + return __alignof__ (id); break; case _C_CLASS: - return __alignof__(Class); + return __alignof__ (Class); break; - + case _C_SEL: - return __alignof__(SEL); + return __alignof__ (SEL); break; case _C_CHR: - return __alignof__(char); + return __alignof__ (char); break; - + case _C_UCHR: - return __alignof__(unsigned char); + return __alignof__ (unsigned char); break; case _C_SHT: - return __alignof__(short); + return __alignof__ (short); break; case _C_USHT: - return __alignof__(unsigned short); + return __alignof__ (unsigned short); break; case _C_INT: - return __alignof__(int); + return __alignof__ (int); break; case _C_UINT: - return __alignof__(unsigned int); + return __alignof__ (unsigned int); break; case _C_LNG: - return __alignof__(long); + return __alignof__ (long); break; case _C_ULNG: - return __alignof__(unsigned long); + return __alignof__ (unsigned long); break; case _C_LNG_LNG: - return __alignof__(long long); + return __alignof__ (long long); break; case _C_ULNG_LNG: - return __alignof__(unsigned long long); + return __alignof__ (unsigned long long); break; case _C_FLT: - return __alignof__(float); + return __alignof__ (float); break; case _C_DBL: - return __alignof__(double); + return __alignof__ (double); break; case _C_PTR: case _C_ATOM: case _C_CHARPTR: - return __alignof__(char*); + return __alignof__ (char *); break; case _C_ARY_B: - while (isdigit(*++type)) /* do nothing */; + while (isdigit ((unsigned char)*++type)) + /* do nothing */; return objc_alignof_type (type); case _C_STRUCT_B: + case _C_UNION_B: { struct objc_struct_layout layout; unsigned int align; @@ -332,28 +426,73 @@ objc_alignof_type(const char* type) return align; } - - case _C_UNION_B: + + + case _C_COMPLEX: { - int maxalign = 0; - while (*type != _C_UNION_E && *type++ != '=') /* do nothing */; - while (*type != _C_UNION_E) - { - /* Skip the variable name if any */ - if (*type == '"') - { - for (type++; *type++ != '"';) - /* do nothing */; - } - maxalign = MAX (maxalign, objc_alignof_type (type)); - type = objc_skip_typespec (type); + type++; /* Skip after the 'j'. */ + switch (*type) + { + case _C_CHR: + return __alignof__ (_Complex char); + break; + + case _C_UCHR: + return __alignof__ (_Complex unsigned char); + break; + + case _C_SHT: + return __alignof__ (_Complex short); + break; + + case _C_USHT: + return __alignof__ (_Complex unsigned short); + break; + + case _C_INT: + return __alignof__ (_Complex int); + break; + + case _C_UINT: + return __alignof__ (_Complex unsigned int); + break; + + case _C_LNG: + return __alignof__ (_Complex long); + break; + + case _C_ULNG: + return __alignof__ (_Complex unsigned long); + break; + + case _C_LNG_LNG: + return __alignof__ (_Complex long long); + break; + + case _C_ULNG_LNG: + return __alignof__ (_Complex unsigned long long); + break; + + case _C_FLT: + return __alignof__ (_Complex float); + break; + + case _C_DBL: + return __alignof__ (_Complex double); + break; + + default: + { + objc_error (nil, OBJC_ERR_BAD_TYPE, "unknown complex type %s\n", + type); + return 0; + } } - return maxalign; } default: { - objc_error(nil, OBJC_ERR_BAD_TYPE, "unknown type %s\n", type); + objc_error (nil, OBJC_ERR_BAD_TYPE, "unknown type %s\n", type); return 0; } } @@ -364,7 +503,7 @@ objc_alignof_type(const char* type) */ int -objc_aligned_size (const char* type) +objc_aligned_size (const char *type) { int size, align; @@ -383,11 +522,11 @@ objc_aligned_size (const char* type) /* The size rounded up to the nearest integral of the wordsize, taken - to be the size of a void*. + to be the size of a void *. */ -int -objc_promoted_size (const char* type) +int +objc_promoted_size (const char *type) { int size, wordsize; @@ -399,7 +538,7 @@ objc_promoted_size (const char* type) } size = objc_sizeof_type (type); - wordsize = sizeof (void*); + wordsize = sizeof (void *); return ROUND (size, wordsize); } @@ -409,13 +548,13 @@ objc_promoted_size (const char* type) occurring in method prototype encodings. */ -inline const char* -objc_skip_type_qualifiers (const char* type) +inline const char * +objc_skip_type_qualifiers (const char *type) { while (*type == _C_CONST - || *type == _C_IN + || *type == _C_IN || *type == _C_INOUT - || *type == _C_OUT + || *type == _C_OUT || *type == _C_BYCOPY || *type == _C_BYREF || *type == _C_ONEWAY @@ -426,14 +565,14 @@ objc_skip_type_qualifiers (const char* type) return type; } - + /* Skip one typespec element. If the typespec is prepended by type qualifiers, these are skipped as well. */ -const char* -objc_skip_typespec (const char* type) +const char * +objc_skip_typespec (const char *type) { /* Skip the variable name if any */ if (*type == '"') @@ -443,7 +582,7 @@ objc_skip_typespec (const char* type) } type = objc_skip_type_qualifiers (type); - + switch (*type) { case _C_ID: @@ -454,7 +593,8 @@ objc_skip_typespec (const char* type) return type; else { - while (*++type != '"') /* do nothing */; + while (*++type != '"') + /* do nothing */; return type + 1; } @@ -470,6 +610,7 @@ objc_skip_typespec (const char* type) case _C_INT: case _C_UINT: case _C_LNG: + case _C_BOOL: case _C_ULNG: case _C_LNG_LNG: case _C_ULNG_LNG: @@ -479,48 +620,63 @@ objc_skip_typespec (const char* type) case _C_UNDEF: return ++type; break; + + case _C_COMPLEX: + return type + 2; + break; case _C_ARY_B: /* skip digits, typespec and closing ']' */ - - while(isdigit(*++type)); - type = objc_skip_typespec(type); + + while (isdigit ((unsigned char)*++type)) + ; + type = objc_skip_typespec (type); if (*type == _C_ARY_E) return ++type; else { - objc_error(nil, OBJC_ERR_BAD_TYPE, "bad array type %s\n", type); + objc_error (nil, OBJC_ERR_BAD_TYPE, "bad array type %s\n", type); return 0; } case _C_BFLD: /* The new encoding of bitfields is: b 'position' 'type' 'size' */ - while (isdigit (*++type)); /* skip position */ - while (isdigit (*++type)); /* skip type and size */ + while (isdigit ((unsigned char)*++type)) + ; /* skip position */ + while (isdigit ((unsigned char)*++type)) + ; /* skip type and size */ return type; case _C_STRUCT_B: /* skip name, and elements until closing '}' */ - - while (*type != _C_STRUCT_E && *type++ != '='); - while (*type != _C_STRUCT_E) { type = objc_skip_typespec (type); } + + while (*type != _C_STRUCT_E && *type++ != '=') + ; + while (*type != _C_STRUCT_E) + { + type = objc_skip_typespec (type); + } return ++type; case _C_UNION_B: /* skip name, and elements until closing ')' */ - - while (*type != _C_UNION_E && *type++ != '='); - while (*type != _C_UNION_E) { type = objc_skip_typespec (type); } + + while (*type != _C_UNION_E && *type++ != '=') + ; + while (*type != _C_UNION_E) + { + type = objc_skip_typespec (type); + } return ++type; case _C_PTR: /* Just skip the following typespec */ - + return objc_skip_typespec (++type); - + default: { - objc_error(nil, OBJC_ERR_BAD_TYPE, "unknown type %s\n", type); + objc_error (nil, OBJC_ERR_BAD_TYPE, "unknown type %s\n", type); return 0; } } @@ -530,19 +686,21 @@ objc_skip_typespec (const char* type) Skip an offset as part of a method encoding. This is prepended by a '+' if the argument is passed in registers. */ -inline const char* -objc_skip_offset (const char* type) +inline const char * +objc_skip_offset (const char *type) { - if (*type == '+') type++; - while(isdigit(*++type)); + if (*type == '+') + type++; + while (isdigit ((unsigned char) *++type)) + ; return type; } /* Skip an argument specification of a method encoding. */ -const char* -objc_skip_argspec (const char* type) +const char * +objc_skip_argspec (const char *type) { type = objc_skip_typespec (type); type = objc_skip_offset (type); @@ -552,13 +710,13 @@ objc_skip_argspec (const char* type) /* Return the number of arguments that the method MTH expects. Note that all methods need two implicit arguments `self' and - `_cmd'. + `_cmd'. */ int -method_get_number_of_arguments (struct objc_method* mth) +method_get_number_of_arguments (struct objc_method *mth) { int i = 0; - const char* type = mth->method_types; + const char *type = mth->method_types; while (*type) { type = objc_skip_argspec (type); @@ -574,9 +732,9 @@ method_get_number_of_arguments (struct objc_method* mth) */ int -method_get_sizeof_arguments (struct objc_method* mth) +method_get_sizeof_arguments (struct objc_method *mth) { - const char* type = objc_skip_typespec (mth->method_types); + const char *type = objc_skip_typespec (mth->method_types); return atoi (type); } @@ -585,7 +743,7 @@ method_get_sizeof_arguments (struct objc_method* mth) the last argument. Typical use of this look like: { - char *datum, *type; + char *datum, *type; for (datum = method_get_first_argument (method, argframe, &type); datum; datum = method_get_next_argument (argframe, &type)) { @@ -596,15 +754,14 @@ method_get_sizeof_arguments (struct objc_method* mth) else { if ((flags & _F_IN) == _F_IN) - [portal encodeData: *(char**)datum ofType: ++type]; + [portal encodeData: *(char **) datum ofType: ++type]; } } } -*/ +*/ -char* -method_get_next_argument (arglist_t argframe, - const char **type) +char * +method_get_next_argument (arglist_t argframe, const char **type) { const char *t = objc_skip_argspec (*type); @@ -621,15 +778,15 @@ method_get_next_argument (arglist_t argframe, } /* - Return a pointer to the value of the first argument of the method + Return a pointer to the value of the first argument of the method described in M with the given argumentframe ARGFRAME. The type - is returned in TYPE. type must be passed to successive calls of + is returned in TYPE. type must be passed to successive calls of method_get_next_argument. */ -char* -method_get_first_argument (struct objc_method* m, - arglist_t argframe, - const char** type) +char * +method_get_first_argument (struct objc_method *m, + arglist_t argframe, + const char **type) { *type = m->method_types; return method_get_next_argument (argframe, type); @@ -638,22 +795,22 @@ method_get_first_argument (struct objc_method* m, /* Return a pointer to the ARGth argument of the method M from the frame ARGFRAME. The type of the argument - is returned in the value-result argument TYPE + is returned in the value-result argument TYPE */ -char* -method_get_nth_argument (struct objc_method* m, - arglist_t argframe, int arg, +char * +method_get_nth_argument (struct objc_method *m, + arglist_t argframe, int arg, const char **type) { - const char* t = objc_skip_argspec (m->method_types); + const char *t = objc_skip_argspec (m->method_types); if (arg > method_get_number_of_arguments (m)) return 0; while (arg--) t = objc_skip_argspec (t); - + *type = t; t = objc_skip_typespec (t); @@ -664,7 +821,7 @@ method_get_nth_argument (struct objc_method* m, } unsigned -objc_get_type_qualifiers (const char* type) +objc_get_type_qualifiers (const char *type) { unsigned res = 0; BOOL flag = YES; @@ -715,13 +872,14 @@ objc_layout_structure (const char *type, { const char *ntype; - if (*type++ != _C_STRUCT_B) + if (*type != _C_UNION_B && *type != _C_STRUCT_B) { - objc_error(nil, OBJC_ERR_BAD_TYPE, - "record type expected in objc_layout_structure, got %s\n", + objc_error (nil, OBJC_ERR_BAD_TYPE, + "record (or union) type expected in objc_layout_structure, got %s\n", type); } + type ++; layout->original_type = type; /* Skip "=" if any. Avoid embedded structures and unions. */ @@ -746,27 +904,30 @@ objc_layout_structure (const char *type, BOOL objc_layout_structure_next_member (struct objc_struct_layout *layout) { - register int known_align = layout->record_size; register int desired_align = 0; /* The following are used only if the field is a bitfield */ - register const char *bfld_type; - register int bfld_type_size, bfld_type_align, bfld_field_size; + register const char *bfld_type = 0; + register int bfld_type_size, bfld_type_align = 0, bfld_field_size = 0; /* The current type without the type qualifiers */ const char *type; + BOOL unionp = layout->original_type[-1] == _C_UNION_B; /* Add the size of the previous field to the size of the record. */ if (layout->prev_type) { type = objc_skip_type_qualifiers (layout->prev_type); + if (unionp) + layout->record_size = MAX (layout->record_size, + objc_sizeof_type (type) * BITS_PER_UNIT); - if (*type != _C_BFLD) + else if (*type != _C_BFLD) layout->record_size += objc_sizeof_type (type) * BITS_PER_UNIT; else { /* Get the bitfield's type */ for (bfld_type = type + 1; - isdigit(*bfld_type); + isdigit ((unsigned char)*bfld_type); bfld_type++) /* do nothing */; @@ -777,7 +938,8 @@ objc_layout_structure_next_member (struct objc_struct_layout *layout) } } - if (*layout->type == _C_STRUCT_E) + if ((unionp && *layout->type == _C_UNION_E) + || (!unionp && *layout->type == _C_STRUCT_E)) return NO; /* Skip the variable name if any */ @@ -790,12 +952,14 @@ objc_layout_structure_next_member (struct objc_struct_layout *layout) type = objc_skip_type_qualifiers (layout->type); if (*type != _C_BFLD) - desired_align = objc_alignof_type(type) * BITS_PER_UNIT; + desired_align = objc_alignof_type (type) * BITS_PER_UNIT; else { desired_align = 1; /* Skip the bitfield's offset */ - for (bfld_type = type + 1; isdigit(*bfld_type); bfld_type++) + for (bfld_type = type + 1; + isdigit ((unsigned char) *bfld_type); + bfld_type++) /* do nothing */; bfld_type_size = objc_sizeof_type (bfld_type) * BITS_PER_UNIT; @@ -815,7 +979,7 @@ objc_layout_structure_next_member (struct objc_struct_layout *layout) is meaningless. */ #ifndef PCC_BITFIELD_TYPE_MATTERS layout->record_align = MAX (layout->record_align, desired_align); -#else +#else /* PCC_BITFIELD_TYPE_MATTERS */ if (*type == _C_BFLD) { /* For these machines, a zero-length field does not @@ -847,7 +1011,7 @@ objc_layout_structure_next_member (struct objc_struct_layout *layout) } else layout->record_align = MAX (layout->record_align, desired_align); -#endif +#endif /* PCC_BITFIELD_TYPE_MATTERS */ /* Does this field automatically have alignment it needs by virtue of the fields that precede it and the record's @@ -861,7 +1025,7 @@ objc_layout_structure_next_member (struct objc_struct_layout *layout) Bump the cumulative size to multiple of field alignment. */ layout->record_size = ROUND (layout->record_size, desired_align); } - + /* Jump to the next field in record. */ layout->prev_type = layout->type; @@ -875,14 +1039,16 @@ void objc_layout_finish_structure (struct objc_struct_layout *layout, unsigned int *size, unsigned int *align) { - if (layout->type && *layout->type == _C_STRUCT_E) + BOOL unionp = layout->original_type[-1] == _C_UNION_B; + if (layout->type + && ((!unionp && *layout->type == _C_STRUCT_E) + || (unionp && *layout->type == _C_UNION_E))) { /* Work out the alignment of the record as one expression and store in the record type. Round it up to a multiple of the record's alignment. */ - -#if defined(ROUND_TYPE_ALIGN) && !defined(__sparc__) - layout->record_align = ROUND_TYPE_ALIGN (layout->original_type, +#if defined (ROUND_TYPE_ALIGN) && ! defined (__sparc__) + layout->record_align = ROUND_TYPE_ALIGN (layout->original_type-1, 1, layout->record_align); #else