X-Git-Url: http://git.sourceforge.jp/view?a=blobdiff_plain;f=gcc%2Fada%2Fsem_ch6.adb;h=9aaa37f9fb4f3968bb9d40dbbf85f084c80af848;hb=f63eb5d36d7d12fc7f0703dfc6fa5cbbf7315f18;hp=efdb1548897313e2fcf52c58f1fc39111a658966;hpb=e78e8c8eeb9163e35f31da808a111c5552dcd171;p=pf3gnuchains%2Fgcc-fork.git diff --git a/gcc/ada/sem_ch6.adb b/gcc/ada/sem_ch6.adb index efdb1548897..9aaa37f9fb4 100644 --- a/gcc/ada/sem_ch6.adb +++ b/gcc/ada/sem_ch6.adb @@ -6,19 +6,17 @@ -- -- -- B o d y -- -- -- --- -- --- Copyright (C) 1992-2002, Free Software Foundation, Inc. -- +-- Copyright (C) 1992-2007, Free Software Foundation, Inc. -- -- -- -- GNAT is free software; you can redistribute it and/or modify it under -- -- terms of the GNU General Public License as published by the Free Soft- -- --- ware Foundation; either version 2, or (at your option) any later ver- -- +-- ware Foundation; either version 3, or (at your option) any later ver- -- -- sion. GNAT is distributed in the hope that it will be useful, but WITH- -- -- OUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY -- -- or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License -- -- for more details. You should have received a copy of the GNU General -- --- Public License distributed with GNAT; see file COPYING. If not, write -- --- to the Free Software Foundation, 59 Temple Place - Suite 330, Boston, -- --- MA 02111-1307, USA. -- +-- Public License distributed with GNAT; see file COPYING3. If not, go to -- +-- http://www.gnu.org/licenses for a complete copy of the license. -- -- -- -- GNAT was originally developed by the GNAT team at New York University. -- -- Extensive contributions were provided by Ada Core Technologies Inc. -- @@ -32,9 +30,15 @@ with Einfo; use Einfo; with Elists; use Elists; with Errout; use Errout; with Expander; use Expander; +with Exp_Ch6; use Exp_Ch6; with Exp_Ch7; use Exp_Ch7; +with Exp_Tss; use Exp_Tss; +with Exp_Util; use Exp_Util; +with Fname; use Fname; with Freeze; use Freeze; +with Itypes; use Itypes; with Lib.Xref; use Lib.Xref; +with Layout; use Layout; with Namet; use Namet; with Lib; use Lib; with Nlists; use Nlists; @@ -48,6 +52,7 @@ with Sem_Ch3; use Sem_Ch3; with Sem_Ch4; use Sem_Ch4; with Sem_Ch5; use Sem_Ch5; with Sem_Ch8; use Sem_Ch8; +with Sem_Ch10; use Sem_Ch10; with Sem_Ch12; use Sem_Ch12; with Sem_Disp; use Sem_Disp; with Sem_Dist; use Sem_Dist; @@ -74,37 +79,53 @@ with Validsw; use Validsw; package body Sem_Ch6 is + May_Hide_Profile : Boolean := False; + -- This flag is used to indicate that two formals in two subprograms being + -- checked for conformance differ only in that one is an access parameter + -- while the other is of a general access type with the same designated + -- type. In this case, if the rest of the signatures match, a call to + -- either subprogram may be ambiguous, which is worth a warning. The flag + -- is set in Compatible_Types, and the warning emitted in + -- New_Overloaded_Entity. + ----------------------- -- Local Subprograms -- ----------------------- + procedure Analyze_Return_Statement (N : Node_Id); + -- Common processing for simple_ and extended_return_statements + + procedure Analyze_Function_Return (N : Node_Id); + -- Subsidiary to Analyze_Return_Statement. Called when the return statement + -- applies to a [generic] function. + + procedure Analyze_Return_Type (N : Node_Id); + -- Subsidiary to Process_Formals: analyze subtype mark in function + -- specification, in a context where the formals are visible and hide + -- outer homographs. + procedure Analyze_Generic_Subprogram_Body (N : Node_Id; Gen_Id : Entity_Id); - -- Analyze a generic subprogram body + -- Analyze a generic subprogram body. N is the body to be analyzed, and + -- Gen_Id is the defining entity Id for the corresponding spec. - function Build_Body_To_Inline - (N : Node_Id; - Subp : Entity_Id; - Orig_Body : Node_Id) - return Boolean; + procedure Build_Body_To_Inline (N : Node_Id; Subp : Entity_Id); -- If a subprogram has pragma Inline and inlining is active, use generic -- machinery to build an unexpanded body for the subprogram. This body is -- subsequenty used for inline expansions at call sites. If subprogram can -- be inlined (depending on size and nature of local declarations) this -- function returns true. Otherwise subprogram body is treated normally. - - type Conformance_Type is - (Type_Conformant, Mode_Conformant, Subtype_Conformant, Fully_Conformant); - -- Conformance type used for following call, meaning matches the - -- RM definitions of the corresponding terms. + -- If proper warnings are enabled and the subprogram contains a construct + -- that cannot be inlined, the offending construct is flagged accordingly. procedure Check_Conformance - (New_Id : Entity_Id; - Old_Id : Entity_Id; - Ctype : Conformance_Type; - Errmsg : Boolean; - Conforms : out Boolean; - Err_Loc : Node_Id := Empty; - Get_Inst : Boolean := False); + (New_Id : Entity_Id; + Old_Id : Entity_Id; + Ctype : Conformance_Type; + Errmsg : Boolean; + Conforms : out Boolean; + Err_Loc : Node_Id := Empty; + Get_Inst : Boolean := False; + Skip_Controlling_Formals : Boolean := False); -- Given two entities, this procedure checks that the profiles associated -- with these entities meet the conformance criterion given by the third -- parameter. If they conform, Conforms is set True and control returns @@ -117,54 +138,55 @@ package body Sem_Ch6 is -- against a formal access-to-subprogram type so Get_Instance_Of must -- be called. + procedure Check_Overriding_Indicator + (Subp : Entity_Id; + Overridden_Subp : Entity_Id; + Is_Primitive : Boolean); + -- Verify the consistency of an overriding_indicator given for subprogram + -- declaration, body, renaming, or instantiation. Overridden_Subp is set + -- if the scope where we are introducing the subprogram contains a + -- type-conformant subprogram that becomes hidden by the new subprogram. + -- Is_Primitive indicates whether the subprogram is primitive. + procedure Check_Subprogram_Order (N : Node_Id); -- N is the N_Subprogram_Body node for a subprogram. This routine applies -- the alpha ordering rule for N if this ordering requirement applicable. - function Is_Non_Overriding_Operation - (Prev_E : Entity_Id; - New_E : Entity_Id) - return Boolean; - -- Enforce the rule given in 12.3(18): a private operation in an instance - -- overrides an inherited operation only if the corresponding operation - -- was overriding in the generic. This can happen for primitive operations - -- of types derived (in the generic unit) from formal private or formal - -- derived types. - procedure Check_Returns (HSS : Node_Id; Mode : Character; - Err : out Boolean); - -- Called to check for missing return statements in a function body, - -- or for returns present in a procedure body which has No_Return set. - -- L is the handled statement sequence for the subprogram body. This - -- procedure checks all flow paths to make sure they either have a - -- return (Mode = 'F') or do not have a return (Mode = 'P'). The flag - -- Err is set if there are any control paths not explicitly terminated - -- by a return in the function case, and is True otherwise. - - function Conforming_Types - (T1 : Entity_Id; - T2 : Entity_Id; - Ctype : Conformance_Type; - Get_Inst : Boolean := False) - return Boolean; - -- Check that two formal parameter types conform, checking both - -- for equality of base types, and where required statically - -- matching subtypes, depending on the setting of Ctype. + Err : out Boolean; + Proc : Entity_Id := Empty); + -- Called to check for missing return statements in a function body, or for + -- returns present in a procedure body which has No_Return set. HSS is the + -- handled statement sequence for the subprogram body. This procedure + -- checks all flow paths to make sure they either have return (Mode = 'F', + -- used for functions) or do not have a return (Mode = 'P', used for + -- No_Return procedures). The flag Err is set if there are any control + -- paths not explicitly terminated by a return in the function case, and is + -- True otherwise. Proc is the entity for the procedure case and is used + -- in posting the warning message. procedure Enter_Overloaded_Entity (S : Entity_Id); - -- This procedure makes S, a new overloaded entity, into the first - -- visible entity with that name. + -- This procedure makes S, a new overloaded entity, into the first visible + -- entity with that name. procedure Install_Entity (E : Entity_Id); - -- Make single entity visible. Used for generic formals as well. + -- Make single entity visible. Used for generic formals as well procedure Install_Formals (Id : Entity_Id); - -- On entry to a subprogram body, make the formals visible. Note - -- that simply placing the subprogram on the scope stack is not - -- sufficient: the formals must become the current entities for - -- their names. + -- On entry to a subprogram body, make the formals visible. Note that + -- simply placing the subprogram on the scope stack is not sufficient: + -- the formals must become the current entities for their names. + + function Is_Non_Overriding_Operation + (Prev_E : Entity_Id; + New_E : Entity_Id) return Boolean; + -- Enforce the rule given in 12.3(18): a private operation in an instance + -- overrides an inherited operation only if the corresponding operation + -- was overriding in the generic. This can happen for primitive operations + -- of types derived (in the generic unit) from formal private or formal + -- derived types. procedure Make_Inequality_Operator (S : Entity_Id); -- Create the declaration for an inequality operator that is implicitly @@ -179,32 +201,184 @@ package body Sem_Ch6 is -- setting the proper validity status for this entity, which depends -- on the kind of parameter and the validity checking mode. + ------------------------------ + -- Analyze_Return_Statement -- + ------------------------------ + + procedure Analyze_Return_Statement (N : Node_Id) is + + pragma Assert (Nkind_In (N, N_Simple_Return_Statement, + N_Extended_Return_Statement)); + + Returns_Object : constant Boolean := + Nkind (N) = N_Extended_Return_Statement + or else + (Nkind (N) = N_Simple_Return_Statement + and then Present (Expression (N))); + -- True if we're returning something; that is, "return ;" + -- or "return Result : T [:= ...]". False for "return;". Used for error + -- checking: If Returns_Object is True, N should apply to a function + -- body; otherwise N should apply to a procedure body, entry body, + -- accept statement, or extended return statement. + + function Find_What_It_Applies_To return Entity_Id; + -- Find the entity representing the innermost enclosing body, accept + -- statement, or extended return statement. If the result is a callable + -- construct or extended return statement, then this will be the value + -- of the Return_Applies_To attribute. Otherwise, the program is + -- illegal. See RM-6.5(4/2). + + ----------------------------- + -- Find_What_It_Applies_To -- + ----------------------------- + + function Find_What_It_Applies_To return Entity_Id is + Result : Entity_Id := Empty; + + begin + -- Loop outward through the Scope_Stack, skipping blocks and loops + + for J in reverse 0 .. Scope_Stack.Last loop + Result := Scope_Stack.Table (J).Entity; + exit when Ekind (Result) /= E_Block and then + Ekind (Result) /= E_Loop; + end loop; + + pragma Assert (Present (Result)); + return Result; + end Find_What_It_Applies_To; + + -- Local declarations + + Scope_Id : constant Entity_Id := Find_What_It_Applies_To; + Kind : constant Entity_Kind := Ekind (Scope_Id); + Loc : constant Source_Ptr := Sloc (N); + Stm_Entity : constant Entity_Id := + New_Internal_Entity + (E_Return_Statement, Current_Scope, Loc, 'R'); + + -- Start of processing for Analyze_Return_Statement + + begin + Set_Return_Statement_Entity (N, Stm_Entity); + + Set_Etype (Stm_Entity, Standard_Void_Type); + Set_Return_Applies_To (Stm_Entity, Scope_Id); + + -- Place Return entity on scope stack, to simplify enforcement of 6.5 + -- (4/2): an inner return statement will apply to this extended return. + + if Nkind (N) = N_Extended_Return_Statement then + Push_Scope (Stm_Entity); + end if; + + -- Check that pragma No_Return is obeyed + + if No_Return (Scope_Id) then + Error_Msg_N ("RETURN statement not allowed (No_Return)", N); + end if; + + -- Warn on any unassigned OUT parameters if in procedure + + if Ekind (Scope_Id) = E_Procedure then + Warn_On_Unassigned_Out_Parameter (N, Scope_Id); + end if; + + -- Check that functions return objects, and other things do not + + if Kind = E_Function or else Kind = E_Generic_Function then + if not Returns_Object then + Error_Msg_N ("missing expression in return from function", N); + end if; + + elsif Kind = E_Procedure or else Kind = E_Generic_Procedure then + if Returns_Object then + Error_Msg_N ("procedure cannot return value (use function)", N); + end if; + + elsif Kind = E_Entry or else Kind = E_Entry_Family then + if Returns_Object then + if Is_Protected_Type (Scope (Scope_Id)) then + Error_Msg_N ("entry body cannot return value", N); + else + Error_Msg_N ("accept statement cannot return value", N); + end if; + end if; + + elsif Kind = E_Return_Statement then + + -- We are nested within another return statement, which must be an + -- extended_return_statement. + + if Returns_Object then + Error_Msg_N + ("extended_return_statement cannot return value; " & + "use `""RETURN;""`", N); + end if; + + else + Error_Msg_N ("illegal context for return statement", N); + end if; + + if Kind = E_Function or else Kind = E_Generic_Function then + Analyze_Function_Return (N); + end if; + + if Nkind (N) = N_Extended_Return_Statement then + End_Scope; + end if; + + Kill_Current_Values (Last_Assignment_Only => True); + Check_Unreachable_Code (N); + end Analyze_Return_Statement; + --------------------------------------------- -- Analyze_Abstract_Subprogram_Declaration -- --------------------------------------------- procedure Analyze_Abstract_Subprogram_Declaration (N : Node_Id) is - Designator : constant Entity_Id := Analyze_Spec (Specification (N)); + Designator : constant Entity_Id := + Analyze_Subprogram_Specification (Specification (N)); Scop : constant Entity_Id := Current_Scope; begin Generate_Definition (Designator); - Set_Is_Abstract (Designator); + Set_Is_Abstract_Subprogram (Designator); New_Overloaded_Entity (Designator); Check_Delayed_Subprogram (Designator); - Set_Is_Pure (Designator, - Is_Pure (Scop) and then Is_Library_Level_Entity (Designator)); - Set_Is_Remote_Call_Interface ( - Designator, Is_Remote_Call_Interface (Scop)); - Set_Is_Remote_Types (Designator, Is_Remote_Types (Scop)); + Set_Categorization_From_Scope (Designator, Scop); if Ekind (Scope (Designator)) = E_Protected_Type then Error_Msg_N ("abstract subprogram not allowed in protected type", N); + + -- Issue a warning if the abstract subprogram is neither a dispatching + -- operation nor an operation that overrides an inherited subprogram or + -- predefined operator, since this most likely indicates a mistake. + + elsif Warn_On_Redundant_Constructs + and then not Is_Dispatching_Operation (Designator) + and then not Is_Overriding_Operation (Designator) + and then (not Is_Operator_Symbol_Name (Chars (Designator)) + or else Scop /= Scope (Etype (First_Formal (Designator)))) + then + Error_Msg_N + ("?abstract subprogram is not dispatching or overriding", N); end if; + + Generate_Reference_To_Formals (Designator); end Analyze_Abstract_Subprogram_Declaration; + ---------------------------------------- + -- Analyze_Extended_Return_Statement -- + ---------------------------------------- + + procedure Analyze_Extended_Return_Statement (N : Node_Id) is + begin + Analyze_Return_Statement (N); + end Analyze_Extended_Return_Statement; + ---------------------------- -- Analyze_Function_Call -- ---------------------------- @@ -217,6 +391,18 @@ package body Sem_Ch6 is begin Analyze (P); + -- A call of the form A.B (X) may be an Ada05 call, which is rewritten + -- as B (A, X). If the rewriting is successful, the call has been + -- analyzed and we just return. + + if Nkind (P) = N_Selected_Component + and then Name (N) /= P + and then Is_Rewrite_Substitution (N) + and then Present (Etype (N)) + then + return; + end if; + -- If error analyzing name, then set Any_Type as result type and return if Etype (P) = Any_Type then @@ -228,7 +414,6 @@ package body Sem_Ch6 is if Present (L) then Actual := First (L); - while Present (Actual) loop Analyze (Actual); Check_Parameterless_Call (Actual); @@ -237,9 +422,302 @@ package body Sem_Ch6 is end if; Analyze_Call (N); - end Analyze_Function_Call; + ----------------------------- + -- Analyze_Function_Return -- + ----------------------------- + + procedure Analyze_Function_Return (N : Node_Id) is + Loc : constant Source_Ptr := Sloc (N); + Stm_Entity : constant Entity_Id := Return_Statement_Entity (N); + Scope_Id : constant Entity_Id := Return_Applies_To (Stm_Entity); + + R_Type : constant Entity_Id := Etype (Scope_Id); + -- Function result subtype + + procedure Check_Limited_Return (Expr : Node_Id); + -- Check the appropriate (Ada 95 or Ada 2005) rules for returning + -- limited types. Used only for simple return statements. + -- Expr is the expression returned. + + procedure Check_Return_Subtype_Indication (Obj_Decl : Node_Id); + -- Check that the return_subtype_indication properly matches the result + -- subtype of the function, as required by RM-6.5(5.1/2-5.3/2). + + -------------------------- + -- Check_Limited_Return -- + -------------------------- + + procedure Check_Limited_Return (Expr : Node_Id) is + begin + -- Ada 2005 (AI-318-02): Return-by-reference types have been + -- removed and replaced by anonymous access results. This is an + -- incompatibility with Ada 95. Not clear whether this should be + -- enforced yet or perhaps controllable with special switch. ??? + + if Is_Limited_Type (R_Type) + and then Comes_From_Source (N) + and then not In_Instance_Body + and then not OK_For_Limited_Init_In_05 (Expr) + then + -- Error in Ada 2005 + + if Ada_Version >= Ada_05 + and then not Debug_Flag_Dot_L + and then not GNAT_Mode + then + Error_Msg_N + ("(Ada 2005) cannot copy object of a limited type " & + "(RM-2005 6.5(5.5/2))", Expr); + if Is_Inherently_Limited_Type (R_Type) then + Error_Msg_N + ("\return by reference not permitted in Ada 2005", Expr); + end if; + + -- Warn in Ada 95 mode, to give folks a heads up about this + -- incompatibility. + + -- In GNAT mode, this is just a warning, to allow it to be + -- evilly turned off. Otherwise it is a real error. + + elsif Warn_On_Ada_2005_Compatibility or GNAT_Mode then + if Is_Inherently_Limited_Type (R_Type) then + Error_Msg_N + ("return by reference not permitted in Ada 2005 " & + "(RM-2005 6.5(5.5/2))?", Expr); + else + Error_Msg_N + ("cannot copy object of a limited type in Ada 2005 " & + "(RM-2005 6.5(5.5/2))?", Expr); + end if; + + -- Ada 95 mode, compatibility warnings disabled + + else + return; -- skip continuation messages below + end if; + + Error_Msg_N + ("\consider switching to return of access type", Expr); + Explain_Limited_Type (R_Type, Expr); + end if; + end Check_Limited_Return; + + ------------------------------------- + -- Check_Return_Subtype_Indication -- + ------------------------------------- + + procedure Check_Return_Subtype_Indication (Obj_Decl : Node_Id) is + Return_Obj : constant Node_Id := Defining_Identifier (Obj_Decl); + R_Stm_Type : constant Entity_Id := Etype (Return_Obj); + -- Subtype given in the extended return statement; + -- this must match R_Type. + + Subtype_Ind : constant Node_Id := + Object_Definition (Original_Node (Obj_Decl)); + + R_Type_Is_Anon_Access : + constant Boolean := + Ekind (R_Type) = E_Anonymous_Access_Subprogram_Type + or else + Ekind (R_Type) = E_Anonymous_Access_Protected_Subprogram_Type + or else + Ekind (R_Type) = E_Anonymous_Access_Type; + -- True if return type of the function is an anonymous access type + -- Can't we make Is_Anonymous_Access_Type in einfo ??? + + R_Stm_Type_Is_Anon_Access : + constant Boolean := + Ekind (R_Stm_Type) = E_Anonymous_Access_Subprogram_Type + or else + Ekind (R_Stm_Type) = E_Anonymous_Access_Protected_Subprogram_Type + or else + Ekind (R_Stm_Type) = E_Anonymous_Access_Type; + -- True if type of the return object is an anonymous access type + + begin + -- First, avoid cascade errors: + + if Error_Posted (Obj_Decl) or else Error_Posted (Subtype_Ind) then + return; + end if; + + -- "return access T" case; check that the return statement also has + -- "access T", and that the subtypes statically match: + + if R_Type_Is_Anon_Access then + if R_Stm_Type_Is_Anon_Access then + if Base_Type (Designated_Type (R_Stm_Type)) /= + Base_Type (Designated_Type (R_Type)) + or else not Subtypes_Statically_Match (R_Stm_Type, R_Type) + then + Error_Msg_N + ("subtype must statically match function result subtype", + Subtype_Mark (Subtype_Ind)); + end if; + + else + Error_Msg_N ("must use anonymous access type", Subtype_Ind); + end if; + + -- Subtype_indication case; check that the types are the same, and + -- statically match if appropriate: + + elsif Base_Type (R_Stm_Type) = Base_Type (R_Type) then + if Is_Constrained (R_Type) then + if not Subtypes_Statically_Match (R_Stm_Type, R_Type) then + Error_Msg_N + ("subtype must statically match function result subtype", + Subtype_Ind); + end if; + end if; + + -- If the function's result type doesn't match the return object + -- entity's type, then we check for the case where the result type + -- is class-wide, and allow the declaration if the type of the object + -- definition matches the class-wide type. This prevents rejection + -- in the case where the object declaration is initialized by a call + -- to a build-in-place function with a specific result type and the + -- object entity had its type changed to that specific type. (Note + -- that the ARG believes that return objects should be allowed to + -- have a type covered by a class-wide result type in any case, so + -- once that relaxation is made (see AI05-32), the above check for + -- type compatibility should be changed to test Covers rather than + -- equality, and then the following special test will no longer be + -- needed. ???) + + elsif Is_Class_Wide_Type (R_Type) + and then + R_Type = Etype (Object_Definition (Original_Node (Obj_Decl))) + then + null; + + else + Error_Msg_N + ("wrong type for return_subtype_indication", Subtype_Ind); + end if; + end Check_Return_Subtype_Indication; + + --------------------- + -- Local Variables -- + --------------------- + + Expr : Node_Id; + + -- Start of processing for Analyze_Function_Return + + begin + Set_Return_Present (Scope_Id); + + if Nkind (N) = N_Simple_Return_Statement then + Expr := Expression (N); + Analyze_And_Resolve (Expr, R_Type); + Check_Limited_Return (Expr); + + else + -- Analyze parts specific to extended_return_statement: + + declare + Obj_Decl : constant Node_Id := + Last (Return_Object_Declarations (N)); + + HSS : constant Node_Id := Handled_Statement_Sequence (N); + + begin + Expr := Expression (Obj_Decl); + + -- Note: The check for OK_For_Limited_Init will happen in + -- Analyze_Object_Declaration; we treat it as a normal + -- object declaration. + + Analyze (Obj_Decl); + + Set_Is_Return_Object (Defining_Identifier (Obj_Decl)); + Check_Return_Subtype_Indication (Obj_Decl); + + if Present (HSS) then + Analyze (HSS); + + if Present (Exception_Handlers (HSS)) then + + -- ???Has_Nested_Block_With_Handler needs to be set. + -- Probably by creating an actual N_Block_Statement. + -- Probably in Expand. + + null; + end if; + end if; + + Check_References (Stm_Entity); + end; + end if; + + -- Case of Expr present (Etype check defends against previous errors) + + if Present (Expr) + and then Present (Etype (Expr)) + then + -- Apply constraint check. Note that this is done before the implicit + -- conversion of the expression done for anonymous access types to + -- ensure correct generation of the null-excluding check asssociated + -- with null-excluding expressions found in return statements. + + Apply_Constraint_Check (Expr, R_Type); + + -- Ada 2005 (AI-318-02): When the result type is an anonymous access + -- type, apply an implicit conversion of the expression to that type + -- to force appropriate static and run-time accessibility checks. + + if Ada_Version >= Ada_05 + and then Ekind (R_Type) = E_Anonymous_Access_Type + then + Rewrite (Expr, Convert_To (R_Type, Relocate_Node (Expr))); + Analyze_And_Resolve (Expr, R_Type); + end if; + + if (Is_Class_Wide_Type (Etype (Expr)) + or else Is_Dynamically_Tagged (Expr)) + and then not Is_Class_Wide_Type (R_Type) + then + Error_Msg_N + ("dynamically tagged expression not allowed!", Expr); + end if; + + -- ??? A real run-time accessibility check is needed in cases + -- involving dereferences of access parameters. For now we just + -- check the static cases. + + if (Ada_Version < Ada_05 or else Debug_Flag_Dot_L) + and then Is_Inherently_Limited_Type (Etype (Scope_Id)) + and then Object_Access_Level (Expr) > + Subprogram_Access_Level (Scope_Id) + then + Rewrite (N, + Make_Raise_Program_Error (Loc, + Reason => PE_Accessibility_Check_Failed)); + Analyze (N); + + Error_Msg_N + ("cannot return a local value by reference?", N); + Error_Msg_NE + ("\& will be raised at run time?", + N, Standard_Program_Error); + end if; + + if Known_Null (Expr) + and then Nkind (Parent (Scope_Id)) = N_Function_Specification + and then Null_Exclusion_Present (Parent (Scope_Id)) + then + Apply_Compile_Time_Constraint_Error + (N => Expr, + Msg => "(Ada 2005) null not allowed for " + & "null-excluding return?", + Reason => CE_Null_Not_Allowed); + end if; + end if; + end Analyze_Function_Return; + ------------------------------------- -- Analyze_Generic_Subprogram_Body -- ------------------------------------- @@ -248,16 +726,16 @@ package body Sem_Ch6 is (N : Node_Id; Gen_Id : Entity_Id) is - Gen_Decl : constant Node_Id := Unit_Declaration_Node (Gen_Id); - Spec : Node_Id; + Gen_Decl : constant Node_Id := Unit_Declaration_Node (Gen_Id); Kind : constant Entity_Kind := Ekind (Gen_Id); - Nam : Entity_Id; + Body_Id : Entity_Id; New_N : Node_Id; + Spec : Node_Id; begin - -- Copy body and disable expansion while analyzing the generic - -- For a stub, do not copy the stub (which would load the proper body), - -- this will be done when the proper body is analyzed. + -- Copy body and disable expansion while analyzing the generic For a + -- stub, do not copy the stub (which would load the proper body), this + -- will be done when the proper body is analyzed. if Nkind (N) /= N_Subprogram_Body_Stub then New_N := Copy_Generic_Node (N, Empty, Instantiating => False); @@ -270,22 +748,22 @@ package body Sem_Ch6 is -- Within the body of the generic, the subprogram is callable, and -- behaves like the corresponding non-generic unit. - Nam := Defining_Entity (Spec); + Body_Id := Defining_Entity (Spec); if Kind = E_Generic_Procedure and then Nkind (Spec) /= N_Procedure_Specification then - Error_Msg_N ("invalid body for generic procedure ", Nam); + Error_Msg_N ("invalid body for generic procedure ", Body_Id); return; elsif Kind = E_Generic_Function and then Nkind (Spec) /= N_Function_Specification then - Error_Msg_N ("invalid body for generic function ", Nam); + Error_Msg_N ("invalid body for generic function ", Body_Id); return; end if; - Set_Corresponding_Body (Gen_Decl, Nam); + Set_Corresponding_Body (Gen_Decl, Body_Id); if Has_Completion (Gen_Id) and then Nkind (Parent (N)) /= N_Subunit @@ -310,7 +788,7 @@ package body Sem_Ch6 is -- needed to process the formals declarations. Then make the formals -- visible in a separate step. - New_Scope (Gen_Id); + Push_Scope (Gen_Id); declare E : Entity_Id; @@ -330,45 +808,57 @@ package body Sem_Ch6 is -- Now generic formals are visible, and the specification can be -- analyzed, for subsequent conformance check. - Nam := Analyze_Spec (Spec); - - if Nkind (N) = N_Subprogram_Body_Stub then - - -- Nothing to do if no body to process + Body_Id := Analyze_Subprogram_Specification (Spec); - Set_Ekind (Nam, Kind); - End_Scope; - return; - end if; + -- Make formal parameters visible if Present (E) then - -- E is the first formal parameter, which must be the first - -- entity in the subprogram body. + -- E is the first formal parameter, we loop through the formals + -- installing them so that they will be visible. Set_First_Entity (Gen_Id, E); - - -- Now make formal parameters visible - while Present (E) loop Install_Entity (E); Next_Formal (E); end loop; end if; - -- Visible generic entity is callable within its own body. + -- Visible generic entity is callable within its own body + + Set_Ekind (Gen_Id, Ekind (Body_Id)); + Set_Ekind (Body_Id, E_Subprogram_Body); + Set_Convention (Body_Id, Convention (Gen_Id)); + Set_Is_Obsolescent (Body_Id, Is_Obsolescent (Gen_Id)); + Set_Scope (Body_Id, Scope (Gen_Id)); + Check_Fully_Conformant (Body_Id, Gen_Id, Body_Id); + + if Nkind (N) = N_Subprogram_Body_Stub then + + -- No body to analyze, so restore state of generic unit + + Set_Ekind (Gen_Id, Kind); + Set_Ekind (Body_Id, Kind); + + if Present (First_Ent) then + Set_First_Entity (Gen_Id, First_Ent); + end if; - Set_Ekind (Gen_Id, Ekind (Nam)); - Set_Convention (Nam, Convention (Gen_Id)); - Set_Scope (Nam, Scope (Gen_Id)); - Check_Fully_Conformant (Nam, Gen_Id, Nam); + End_Scope; + return; + end if; - -- If this is a compilation unit, it must be made visible - -- explicitly, because the compilation of the declaration, - -- unlike other library unit declarations, does not. If it - -- is not a unit, the following is redundant but harmless. + -- If this is a compilation unit, it must be made visible explicitly, + -- because the compilation of the declaration, unlike other library + -- unit declarations, does not. If it is not a unit, the following + -- is redundant but harmless. Set_Is_Immediately_Visible (Gen_Id); + Reference_Body_Formals (Gen_Id, Body_Id); + + if Is_Child_Unit (Gen_Id) then + Generate_Reference (Gen_Id, Scope (Gen_Id), 'k', False); + end if; Set_Actual_Subtypes (N, Current_Scope); Analyze_Declarations (Declarations (N)); @@ -377,51 +867,56 @@ package body Sem_Ch6 is Save_Global_References (Original_Node (N)); - -- Prior to exiting the scope, include generic formals again - -- (if any are present) in the set of local entities. + -- Prior to exiting the scope, include generic formals again (if any + -- are present) in the set of local entities. if Present (First_Ent) then Set_First_Entity (Gen_Id, First_Ent); end if; + Check_References (Gen_Id); end; + Process_End_Label (Handled_Statement_Sequence (N), 't', Current_Scope); End_Scope; Check_Subprogram_Order (N); - -- Outside of its body, unit is generic again. + -- Outside of its body, unit is generic again Set_Ekind (Gen_Id, Kind); - Set_Ekind (Nam, E_Subprogram_Body); - Generate_Reference (Gen_Id, Nam, 'b'); - Style.Check_Identifier (Nam, Gen_Id); - End_Generic; + Generate_Reference (Gen_Id, Body_Id, 'b', Set_Ref => False); + if Style_Check then + Style.Check_Identifier (Body_Id, Gen_Id); + end if; + End_Generic; end Analyze_Generic_Subprogram_Body; ----------------------------- -- Analyze_Operator_Symbol -- ----------------------------- - -- An operator symbol such as "+" or "and" may appear in context where - -- the literal denotes an entity name, such as "+"(x, y) or in a - -- context when it is just a string, as in (conjunction = "or"). In - -- these cases the parser generates this node, and the semantics does - -- the disambiguation. Other such case are actuals in an instantiation, - -- the generic unit in an instantiation, and pragma arguments. + -- An operator symbol such as "+" or "and" may appear in context where the + -- literal denotes an entity name, such as "+"(x, y) or in context when it + -- is just a string, as in (conjunction = "or"). In these cases the parser + -- generates this node, and the semantics does the disambiguation. Other + -- such case are actuals in an instantiation, the generic unit in an + -- instantiation, and pragma arguments. procedure Analyze_Operator_Symbol (N : Node_Id) is Par : constant Node_Id := Parent (N); begin - if (Nkind (Par) = N_Function_Call and then N = Name (Par)) + if (Nkind (Par) = N_Function_Call + and then N = Name (Par)) or else Nkind (Par) = N_Function_Instantiation - or else (Nkind (Par) = N_Indexed_Component and then N = Prefix (Par)) + or else (Nkind (Par) = N_Indexed_Component + and then N = Prefix (Par)) or else (Nkind (Par) = N_Pragma_Argument_Association and then not Is_Pragma_String_Literal (Par)) or else Nkind (Par) = N_Subprogram_Renaming_Declaration - or else (Nkind (Par) = N_Attribute_Reference - and then Attribute_Name (Par) /= Name_Value) + or else (Nkind (Par) = N_Attribute_Reference + and then Attribute_Name (Par) /= Name_Value) then Find_Direct_Name (N); @@ -454,6 +949,10 @@ package body Sem_Ch6 is procedure Analyze_Call_And_Resolve; -- Do Analyze and Resolve calls for procedure call + ------------------------------ + -- Analyze_Call_And_Resolve -- + ------------------------------ + procedure Analyze_Call_And_Resolve is begin if Nkind (N) = N_Procedure_Call_Statement then @@ -478,6 +977,14 @@ package body Sem_Ch6 is Analyze (P); + -- If this is a call of the form Obj.Op, the call may have been + -- analyzed and possibly rewritten into a block, in which case + -- we are done. + + if Analyzed (N) then + return; + end if; + -- If error analyzing prefix, then set Any_Type as result and return if Etype (P) = Any_Type then @@ -540,9 +1047,9 @@ package body Sem_Ch6 is and then Present (Actuals) and then No (Next (First (Actuals))) then - -- Can be call to parameterless entry family. What appears to be - -- the sole argument is in fact the entry index. Rewrite prefix - -- of node accordingly. Source representation is unchanged by this + -- Can be call to parameterless entry family. What appears to be the + -- sole argument is in fact the entry index. Rewrite prefix of node + -- accordingly. Source representation is unchanged by this -- transformation. New_N := @@ -564,9 +1071,9 @@ package body Sem_Ch6 is Error_Msg_N ("expect access to procedure in call", P); end if; - -- The name can be a selected component or an indexed component - -- that yields an access to subprogram. Such a prefix is legal if - -- the call has parameter associations. + -- The name can be a selected component or an indexed component that + -- yields an access to subprogram. Such a prefix is legal if the call + -- has parameter associations. elsif Is_Access_Type (Etype (P)) and then Ekind (Designated_Type (Etype (P))) = E_Subprogram_Type @@ -577,15 +1084,14 @@ package body Sem_Ch6 is Error_Msg_N ("missing explicit dereference in call ", N); end if; - -- If not an access to subprogram, then the prefix must resolve to - -- the name of an entry, entry family, or protected operation. + -- If not an access to subprogram, then the prefix must resolve to the + -- name of an entry, entry family, or protected operation. - -- For the case of a simple entry call, P is a selected component - -- where the prefix is the task and the selector name is the entry. - -- A call to a protected procedure will have the same syntax. If - -- the protected object contains overloaded operations, the entity - -- may appear as a function, the context will select the operation - -- whose type is Void. + -- For the case of a simple entry call, P is a selected component where + -- the prefix is the task and the selector name is the entry. A call to + -- a protected procedure will have the same syntax. If the protected + -- object contains overloaded operations, the entity may appear as a + -- function, the context will select the operation whose type is Void. elsif Nkind (P) = N_Selected_Component and then (Ekind (Entity (Selector_Name (P))) = E_Entry @@ -601,9 +1107,9 @@ package body Sem_Ch6 is and then Present (Actuals) and then No (Next (First (Actuals))) then - -- Can be call to parameterless entry family. What appears to be - -- the sole argument is in fact the entry index. Rewrite prefix - -- of node accordingly. Source representation is unchanged by this + -- Can be call to parameterless entry family. What appears to be the + -- sole argument is in fact the entry index. Rewrite prefix of node + -- accordingly. Source representation is unchanged by this -- transformation. New_N := @@ -640,198 +1146,308 @@ package body Sem_Ch6 is Analyze (P); Analyze_Call_And_Resolve; - -- Anything else is an error. + -- Anything else is an error else - Error_Msg_N ("Invalid procedure or entry call", N); + Error_Msg_N ("invalid procedure or entry call", N); end if; end Analyze_Procedure_Call; - ------------------------------ - -- Analyze_Return_Statement -- - ------------------------------ - - procedure Analyze_Return_Statement (N : Node_Id) is - Loc : constant Source_Ptr := Sloc (N); - Expr : Node_Id; - Scope_Id : Entity_Id; - Kind : Entity_Kind; - R_Type : Entity_Id; + ------------------------------------- + -- Analyze_Simple_Return_Statement -- + ------------------------------------- + procedure Analyze_Simple_Return_Statement (N : Node_Id) is begin - -- Find subprogram or accept statement enclosing the return statement + if Present (Expression (N)) then + Mark_Coextensions (N, Expression (N)); + end if; - Scope_Id := Empty; - for J in reverse 0 .. Scope_Stack.Last loop - Scope_Id := Scope_Stack.Table (J).Entity; - exit when Ekind (Scope_Id) /= E_Block and then - Ekind (Scope_Id) /= E_Loop; - end loop; + Analyze_Return_Statement (N); + end Analyze_Simple_Return_Statement; - pragma Assert (Present (Scope_Id)); + ------------------------- + -- Analyze_Return_Type -- + ------------------------- - Kind := Ekind (Scope_Id); - Expr := Expression (N); + procedure Analyze_Return_Type (N : Node_Id) is + Designator : constant Entity_Id := Defining_Entity (N); + Typ : Entity_Id := Empty; - if Kind /= E_Function - and then Kind /= E_Generic_Function - and then Kind /= E_Procedure - and then Kind /= E_Generic_Procedure - and then Kind /= E_Entry - and then Kind /= E_Entry_Family - then - Error_Msg_N ("illegal context for return statement", N); + begin + -- Normal case where result definition does not indicate an error - elsif Present (Expr) then - if Kind = E_Function or else Kind = E_Generic_Function then - Set_Return_Present (Scope_Id); - R_Type := Etype (Scope_Id); - Set_Return_Type (N, R_Type); - Analyze_And_Resolve (Expr, R_Type); + if Result_Definition (N) /= Error then + if Nkind (Result_Definition (N)) = N_Access_Definition then + Typ := Access_Definition (N, Result_Definition (N)); + Set_Parent (Typ, Result_Definition (N)); + Set_Is_Local_Anonymous_Access (Typ); + Set_Etype (Designator, Typ); + + -- Subtype_Mark case + + else + Find_Type (Result_Definition (N)); + Typ := Entity (Result_Definition (N)); + Set_Etype (Designator, Typ); - if (Is_Class_Wide_Type (Etype (Expr)) - or else Is_Dynamically_Tagged (Expr)) - and then not Is_Class_Wide_Type (R_Type) + if Ekind (Typ) = E_Incomplete_Type + and then Is_Value_Type (Typ) + then + null; + + elsif Ekind (Typ) = E_Incomplete_Type + or else (Is_Class_Wide_Type (Typ) + and then + Ekind (Root_Type (Typ)) = E_Incomplete_Type) then Error_Msg_N - ("dynamically tagged expression not allowed!", Expr); + ("invalid use of incomplete type", Result_Definition (N)); end if; + end if; - Apply_Constraint_Check (Expr, R_Type); + -- Ada 2005 (AI-231): Ensure proper usage of null exclusion - -- ??? A real run-time accessibility check is needed - -- in cases involving dereferences of access parameters. - -- For now we just check the static cases. + Null_Exclusion_Static_Checks (N); - if Is_Return_By_Reference_Type (Etype (Scope_Id)) - and then Object_Access_Level (Expr) - > Subprogram_Access_Level (Scope_Id) - then - Rewrite (N, - Make_Raise_Program_Error (Loc, - Reason => PE_Accessibility_Check_Failed)); - Analyze (N); + -- Case where result definition does indicate an error - Error_Msg_N - ("cannot return a local value by reference?", N); - Error_Msg_NE - ("& will be raised at run time?!", - N, Standard_Program_Error); - end if; + else + Set_Etype (Designator, Any_Type); + end if; + end Analyze_Return_Type; - elsif Kind = E_Procedure or else Kind = E_Generic_Procedure then - Error_Msg_N ("procedure cannot return value (use function)", N); + ----------------------------- + -- Analyze_Subprogram_Body -- + ----------------------------- + + -- This procedure is called for regular subprogram bodies, generic bodies, + -- and for subprogram stubs of both kinds. In the case of stubs, only the + -- specification matters, and is used to create a proper declaration for + -- the subprogram, or to perform conformance checks. + + procedure Analyze_Subprogram_Body (N : Node_Id) is + Loc : constant Source_Ptr := Sloc (N); + Body_Spec : constant Node_Id := Specification (N); + Body_Id : Entity_Id := Defining_Entity (Body_Spec); + Prev_Id : constant Entity_Id := Current_Entity_In_Scope (Body_Id); + Body_Deleted : constant Boolean := False; + HSS : Node_Id; + Spec_Id : Entity_Id; + Spec_Decl : Node_Id := Empty; + Last_Formal : Entity_Id := Empty; + Conformant : Boolean; + Missing_Ret : Boolean; + P_Ent : Entity_Id; + + procedure Check_Anonymous_Return; + -- (Ada 2005): if a function returns an access type that denotes a task, + -- or a type that contains tasks, we must create a master entity for + -- the anonymous type, which typically will be used in an allocator + -- in the body of the function. + + procedure Check_Inline_Pragma (Spec : in out Node_Id); + -- Look ahead to recognize a pragma that may appear after the body. + -- If there is a previous spec, check that it appears in the same + -- declarative part. If the pragma is Inline_Always, perform inlining + -- unconditionally, otherwise only if Front_End_Inlining is requested. + -- If the body acts as a spec, and inlining is required, we create a + -- subprogram declaration for it, in order to attach the body to inline. + + procedure Copy_Parameter_List (Plist : List_Id); + -- Utility to create a parameter profile for a new subprogram spec, + -- when the subprogram has a body that acts as spec. This is done for + -- some cases of inlining, and for private protected ops. + + procedure Verify_Overriding_Indicator; + -- If there was a previous spec, the entity has been entered in the + -- current scope previously. If the body itself carries an overriding + -- indicator, check that it is consistent with the known status of the + -- entity. + + ---------------------------- + -- Check_Anonymous_Return -- + ---------------------------- + + procedure Check_Anonymous_Return is + Decl : Node_Id; + Scop : Entity_Id; + + begin + if Present (Spec_Id) then + Scop := Spec_Id; else - Error_Msg_N ("accept statement cannot return value", N); + Scop := Body_Id; end if; - -- No expression present + if Ekind (Scop) = E_Function + and then Ekind (Etype (Scop)) = E_Anonymous_Access_Type + and then Has_Task (Designated_Type (Etype (Scop))) + and then Expander_Active + then + Decl := + Make_Object_Declaration (Loc, + Defining_Identifier => + Make_Defining_Identifier (Loc, Name_uMaster), + Constant_Present => True, + Object_Definition => + New_Reference_To (RTE (RE_Master_Id), Loc), + Expression => + Make_Explicit_Dereference (Loc, + New_Reference_To (RTE (RE_Current_Master), Loc))); + + if Present (Declarations (N)) then + Prepend (Decl, Declarations (N)); + else + Set_Declarations (N, New_List (Decl)); + end if; - else - if Kind = E_Function or Kind = E_Generic_Function then - Error_Msg_N ("missing expression in return from function", N); + Set_Master_Id (Etype (Scop), Defining_Identifier (Decl)); + Set_Has_Master_Entity (Scop); + end if; + end Check_Anonymous_Return; + + ------------------------- + -- Check_Inline_Pragma -- + ------------------------- + + procedure Check_Inline_Pragma (Spec : in out Node_Id) is + Prag : Node_Id; + Plist : List_Id; + + begin + if not Expander_Active then + return; end if; - if (Ekind (Scope_Id) = E_Procedure - or else Ekind (Scope_Id) = E_Generic_Procedure) - and then No_Return (Scope_Id) + if Is_List_Member (N) + and then Present (Next (N)) + and then Nkind (Next (N)) = N_Pragma then - Error_Msg_N - ("RETURN statement not allowed (No_Return)", N); + Prag := Next (N); + + if Nkind (Prag) = N_Pragma + and then + (Get_Pragma_Id (Chars (Prag)) = Pragma_Inline_Always + or else + (Front_End_Inlining + and then Get_Pragma_Id (Chars (Prag)) = Pragma_Inline)) + and then + Chars + (Expression (First (Pragma_Argument_Associations (Prag)))) + = Chars (Body_Id) + then + Prag := Next (N); + else + Prag := Empty; + end if; + else + Prag := Empty; end if; - end if; - Check_Unreachable_Code (N); - end Analyze_Return_Statement; + if Present (Prag) then + if Present (Spec_Id) then + if List_Containing (N) = + List_Containing (Unit_Declaration_Node (Spec_Id)) + then + Analyze (Prag); + end if; - ------------------ - -- Analyze_Spec -- - ------------------ + else + -- Create a subprogram declaration, to make treatment uniform - function Analyze_Spec (N : Node_Id) return Entity_Id is - Designator : constant Entity_Id := Defining_Entity (N); - Formals : constant List_Id := Parameter_Specifications (N); - Typ : Entity_Id; + declare + Subp : constant Entity_Id := + Make_Defining_Identifier (Loc, Chars (Body_Id)); + Decl : constant Node_Id := + Make_Subprogram_Declaration (Loc, + Specification => New_Copy_Tree (Specification (N))); + begin + Set_Defining_Unit_Name (Specification (Decl), Subp); - begin - Generate_Definition (Designator); + if Present (First_Formal (Body_Id)) then + Plist := New_List; + Copy_Parameter_List (Plist); + Set_Parameter_Specifications + (Specification (Decl), Plist); + end if; - if Nkind (N) = N_Function_Specification then - Set_Ekind (Designator, E_Function); - Set_Mechanism (Designator, Default_Mechanism); + Insert_Before (N, Decl); + Analyze (Decl); + Analyze (Prag); + Set_Has_Pragma_Inline (Subp); - if Subtype_Mark (N) /= Error then - Find_Type (Subtype_Mark (N)); - Typ := Entity (Subtype_Mark (N)); - Set_Etype (Designator, Typ); + if Get_Pragma_Id (Chars (Prag)) = Pragma_Inline_Always then + Set_Is_Inlined (Subp); + Set_Next_Rep_Item (Prag, First_Rep_Item (Subp)); + Set_First_Rep_Item (Subp, Prag); + end if; - if (Ekind (Typ) = E_Incomplete_Type - or else (Is_Class_Wide_Type (Typ) - and then - Ekind (Root_Type (Typ)) = E_Incomplete_Type)) - then - Error_Msg_N - ("invalid use of incomplete type", Subtype_Mark (N)); + Spec := Subp; + end; end if; - - else - Set_Etype (Designator, Any_Type); end if; + end Check_Inline_Pragma; - else - Set_Ekind (Designator, E_Procedure); - Set_Etype (Designator, Standard_Void_Type); - end if; + ------------------------- + -- Copy_Parameter_List -- + ------------------------- - if Present (Formals) then - Set_Scope (Designator, Current_Scope); - New_Scope (Designator); - Process_Formals (Formals, N); - End_Scope; - end if; + procedure Copy_Parameter_List (Plist : List_Id) is + Formal : Entity_Id; - if Nkind (N) = N_Function_Specification then - if Nkind (Designator) = N_Defining_Operator_Symbol then - Valid_Operator_Definition (Designator); - end if; + begin + Formal := First_Formal (Body_Id); - May_Need_Actuals (Designator); + while Present (Formal) loop + Append + (Make_Parameter_Specification (Loc, + Defining_Identifier => + Make_Defining_Identifier (Sloc (Formal), + Chars => Chars (Formal)), + In_Present => In_Present (Parent (Formal)), + Out_Present => Out_Present (Parent (Formal)), + Parameter_Type => + New_Reference_To (Etype (Formal), Loc), + Expression => + New_Copy_Tree (Expression (Parent (Formal)))), + Plist); - if Is_Abstract (Etype (Designator)) - and then Nkind (Parent (N)) /= N_Abstract_Subprogram_Declaration - then - Error_Msg_N - ("function that returns abstract type must be abstract", N); - end if; - end if; + Next_Formal (Formal); + end loop; + end Copy_Parameter_List; - return Designator; - end Analyze_Spec; + --------------------------------- + -- Verify_Overriding_Indicator -- + --------------------------------- - ----------------------------- - -- Analyze_Subprogram_Body -- - ----------------------------- + procedure Verify_Overriding_Indicator is + begin + if Must_Override (Body_Spec) + and then not Is_Overriding_Operation (Spec_Id) + then + Error_Msg_NE + ("subprogram& is not overriding", Body_Spec, Spec_Id); - -- This procedure is called for regular subprogram bodies, generic bodies, - -- and for subprogram stubs of both kinds. In the case of stubs, only the - -- specification matters, and is used to create a proper declaration for - -- the subprogram, or to perform conformance checks. + elsif Must_Not_Override (Body_Spec) then + if Is_Overriding_Operation (Spec_Id) then + Error_Msg_NE + ("subprogram& overrides inherited operation", + Body_Spec, Spec_Id); - procedure Analyze_Subprogram_Body (N : Node_Id) is - Loc : constant Source_Ptr := Sloc (N); - Body_Spec : constant Node_Id := Specification (N); - Body_Id : Entity_Id := Defining_Entity (Body_Spec); - Prev_Id : constant Entity_Id := Current_Entity_In_Scope (Body_Id); + -- If this is not a primitive operation the overriding indicator + -- is altogether illegal. - HSS : Node_Id; - Spec_Id : Entity_Id; - Spec_Decl : Node_Id := Empty; - Last_Formal : Entity_Id := Empty; - Conformant : Boolean; - Missing_Ret : Boolean; - Body_Deleted : Boolean := False; - P_Ent : Entity_Id; + elsif not Is_Primitive (Spec_Id) then + Error_Msg_N ("overriding indicator only allowed " & + "if subprogram is primitive", + Body_Spec); + end if; + end if; + end Verify_Overriding_Indicator; + + -- Start of processing for Analyze_Subprogram_Body begin if Debug_Flag_C then @@ -842,24 +1458,22 @@ package body Sem_Ch6 is Write_Eol; end if; - Trace_Scope (N, Body_Id, " Analyze subprogram"); + Trace_Scope (N, Body_Id, " Analyze subprogram: "); - -- Generic subprograms are handled separately. They always have - -- a generic specification. Determine whether current scope has - -- a previous declaration. + -- Generic subprograms are handled separately. They always have a + -- generic specification. Determine whether current scope has a + -- previous declaration. - -- If the subprogram body is defined within an instance of the - -- same name, the instance appears as a package renaming, and - -- will be hidden within the subprogram. + -- If the subprogram body is defined within an instance of the same + -- name, the instance appears as a package renaming, and will be hidden + -- within the subprogram. if Present (Prev_Id) and then not Is_Overloadable (Prev_Id) and then (Nkind (Parent (Prev_Id)) /= N_Package_Renaming_Declaration or else Comes_From_Source (Prev_Id)) then - if Ekind (Prev_Id) = E_Generic_Procedure - or else Ekind (Prev_Id) = E_Generic_Function - then + if Is_Generic_Subprogram (Prev_Id) then Spec_Id := Prev_Id; Set_Is_Compilation_Unit (Body_Id, Is_Compilation_Unit (Spec_Id)); Set_Is_Child_Unit (Body_Id, Is_Child_Unit (Spec_Id)); @@ -868,18 +1482,18 @@ package body Sem_Ch6 is return; else - -- Previous entity conflicts with subprogram name. - -- Attempting to enter name will post error. + -- Previous entity conflicts with subprogram name. Attempting to + -- enter name will post error. Enter_Name (Body_Id); return; end if; - -- Non-generic case, find the subprogram declaration, if one was - -- seen, or enter new overloaded entity in the current scope. - -- If the current_entity is the body_id itself, the unit is being - -- analyzed as part of the context of one of its subunits. No need - -- to redo the analysis. + -- Non-generic case, find the subprogram declaration, if one was seen, + -- or enter new overloaded entity in the current scope. If the + -- Current_Entity is the Body_Id itself, the unit is being analyzed as + -- part of the context of one of its subunits. No need to redo the + -- analysis. elsif Prev_Id = Body_Id and then Has_Completion (Body_Id) @@ -887,7 +1501,7 @@ package body Sem_Ch6 is return; else - Body_Id := Analyze_Spec (Body_Spec); + Body_Id := Analyze_Subprogram_Specification (Body_Spec); if Nkind (N) = N_Subprogram_Body_Stub or else No (Corresponding_Spec (N)) @@ -900,13 +1514,13 @@ package body Sem_Ch6 is return; end if; - -- A subprogram body should cause freezing of its own - -- declaration, but if there was no previous explicit - -- declaration, then the subprogram will get frozen too - -- late (there may be code within the body that depends - -- on the subprogram having been frozen, such as uses of - -- extra formals), so we force it to be frozen here. - -- Same holds if the body and the spec are compilation units. + -- A subprogram body should cause freezing of its own declaration, + -- but if there was no previous explicit declaration, then the + -- subprogram will get frozen too late (there may be code within + -- the body that depends on the subprogram having been frozen, + -- such as uses of extra formals), so we force it to be frozen + -- here. Same holds if the body and the spec are compilation + -- units. if No (Spec_Id) then Freeze_Before (N, Body_Id); @@ -919,38 +1533,44 @@ package body Sem_Ch6 is end if; end if; - -- Do not inline any subprogram that contains nested subprograms, - -- since the backend inlining circuit seems to generate uninitialized + -- Do not inline any subprogram that contains nested subprograms, since + -- the backend inlining circuit seems to generate uninitialized -- references in this case. We know this happens in the case of front - -- end ZCX support, but it also appears it can happen in other cases - -- as well. The backend often rejects attempts to inline in the case - -- of nested procedures anyway, so little if anything is lost by this. + -- end ZCX support, but it also appears it can happen in other cases as + -- well. The backend often rejects attempts to inline in the case of + -- nested procedures anyway, so little if anything is lost by this. + -- Note that this is test is for the benefit of the back-end. There is + -- a separate test for front-end inlining that also rejects nested + -- subprograms. -- Do not do this test if errors have been detected, because in some -- error cases, this code blows up, and we don't need it anyway if -- there have been errors, since we won't get to the linker anyway. - if Serious_Errors_Detected = 0 then + if Comes_From_Source (Body_Id) + and then Serious_Errors_Detected = 0 + then P_Ent := Body_Id; loop P_Ent := Scope (P_Ent); exit when No (P_Ent) or else P_Ent = Standard_Standard; - if Is_Subprogram (P_Ent) and then Is_Inlined (P_Ent) then + if Is_Subprogram (P_Ent) then Set_Is_Inlined (P_Ent, False); if Comes_From_Source (P_Ent) - and then Ineffective_Inline_Warnings and then Has_Pragma_Inline (P_Ent) then - Error_Msg_NE - ("?pragma Inline for & ignored (has nested subprogram)", - Get_Rep_Pragma (P_Ent, Name_Inline), P_Ent); + Cannot_Inline + ("cannot inline& (nested subprogram)?", + N, P_Ent); end if; end if; end loop; end if; + Check_Inline_Pragma (Spec_Id); + -- Case of fully private operation in the body of the protected type. -- We must create a declaration for the subprogram, in order to attach -- the protected subprogram that will be used in internal calls. @@ -968,9 +1588,9 @@ package body Sem_Ch6 is begin Formal := First_Formal (Body_Id); - -- The protected operation always has at least one formal, - -- namely the object itself, but it is only placed in the - -- parameter list if expansion is enabled. + -- The protected operation always has at least one formal, namely + -- the object itself, but it is only placed in the parameter list + -- if expansion is enabled. if Present (Formal) or else Expander_Active @@ -981,22 +1601,7 @@ package body Sem_Ch6 is Plist := No_List; end if; - while Present (Formal) loop - Append - (Make_Parameter_Specification (Loc, - Defining_Identifier => - Make_Defining_Identifier (Sloc (Formal), - Chars => Chars (Formal)), - In_Present => In_Present (Parent (Formal)), - Out_Present => Out_Present (Parent (Formal)), - Parameter_Type => - New_Reference_To (Etype (Formal), Loc), - Expression => - New_Copy_Tree (Expression (Parent (Formal)))), - Plist); - - Next_Formal (Formal); - end loop; + Copy_Parameter_List (Plist); if Nkind (Body_Spec) = N_Procedure_Specification then New_Spec := @@ -1012,21 +1617,52 @@ package body Sem_Ch6 is Make_Defining_Identifier (Sloc (Body_Id), Chars => Chars (Body_Id)), Parameter_Specifications => Plist, - Subtype_Mark => New_Occurrence_Of (Etype (Body_Id), Loc)); + Result_Definition => + New_Occurrence_Of (Etype (Body_Id), Loc)); end if; Decl := Make_Subprogram_Declaration (Loc, Specification => New_Spec); Insert_Before (N, Decl); - Analyze (Decl); Spec_Id := Defining_Unit_Name (New_Spec); + + -- Indicate that the entity comes from source, to ensure that + -- cross-reference information is properly generated. The body + -- itself is rewritten during expansion, and the body entity will + -- not appear in calls to the operation. + + Set_Comes_From_Source (Spec_Id, True); + Analyze (Decl); Set_Has_Completion (Spec_Id); Set_Convention (Spec_Id, Convention_Protected); end; elsif Present (Spec_Id) then Spec_Decl := Unit_Declaration_Node (Spec_Id); + Verify_Overriding_Indicator; + + -- In general, the spec will be frozen when we start analyzing the + -- body. However, for internally generated operations, such as + -- wrapper functions for inherited operations with controlling + -- results, the spec may not have been frozen by the time we + -- expand the freeze actions that include the bodies. In particular, + -- extra formals for accessibility or for return-in-place may need + -- to be generated. Freeze nodes, if any, are inserted before the + -- current body. + + if not Is_Frozen (Spec_Id) + and then Expander_Active + then + -- Force the generation of its freezing node to ensure proper + -- management of access types in the backend. + + -- This is definitely needed for some cases, but it is not clear + -- why, to be investigated further??? + + Set_Has_Delayed_Freeze (Spec_Id); + Insert_Actions (N, Freeze_Entity (Spec_Id, Loc)); + end if; end if; -- Place subprogram on scope stack, and make formals visible. If there @@ -1034,12 +1670,19 @@ package body Sem_Ch6 is if Present (Spec_Id) then Generate_Reference (Spec_Id, Body_Id, 'b', Set_Ref => False); - Style.Check_Identifier (Body_Id, Spec_Id); + + if Is_Child_Unit (Spec_Id) then + Generate_Reference (Spec_Id, Scope (Spec_Id), 'k', False); + end if; + + if Style_Check then + Style.Check_Identifier (Body_Id, Spec_Id); + end if; Set_Is_Compilation_Unit (Body_Id, Is_Compilation_Unit (Spec_Id)); Set_Is_Child_Unit (Body_Id, Is_Child_Unit (Spec_Id)); - if Is_Abstract (Spec_Id) then + if Is_Abstract_Subprogram (Spec_Id) then Error_Msg_N ("an abstract subprogram cannot have a body", N); return; else @@ -1056,9 +1699,15 @@ package body Sem_Ch6 is -- and the test can lead to spurious errors on nested defaults. if Present (Spec_Decl) - and then Nkind (Original_Node (Spec_Decl)) = - N_Subprogram_Renaming_Declaration and then not Comes_From_Source (N) + and then + (Nkind (Original_Node (Spec_Decl)) = + N_Subprogram_Renaming_Declaration + or else (Present (Corresponding_Body (Spec_Decl)) + and then + Nkind (Unit_Declaration_Node + (Corresponding_Body (Spec_Decl))) = + N_Subprogram_Renaming_Declaration)) then Conformant := True; else @@ -1084,35 +1733,56 @@ package body Sem_Ch6 is end if; end if; - -- Generate references from body formals to spec formals - -- and also set the Spec_Entity fields for all formals. We - -- do not set this reference count as a reference for the - -- purposes of identifying unreferenced formals however. - if Spec_Id /= Body_Id then - declare - Fs : Entity_Id; - Fb : Entity_Id; - - begin - Fs := First_Formal (Spec_Id); - Fb := First_Formal (Body_Id); - while Present (Fs) loop - Generate_Reference (Fs, Fb, 'b'); - Style.Check_Identifier (Fb, Fs); - Set_Spec_Entity (Fb, Fs); - Set_Referenced (Fs, False); - Next_Formal (Fs); - Next_Formal (Fb); - end loop; - end; + Reference_Body_Formals (Spec_Id, Body_Id); end if; if Nkind (N) /= N_Subprogram_Body_Stub then Set_Corresponding_Spec (N, Spec_Id); + + -- Ada 2005 (AI-345): If the operation is a primitive operation + -- of a concurrent type, the type of the first parameter has been + -- replaced with the corresponding record, which is the proper + -- run-time structure to use. However, within the body there may + -- be uses of the formals that depend on primitive operations + -- of the type (in particular calls in prefixed form) for which + -- we need the original concurrent type. The operation may have + -- several controlling formals, so the replacement must be done + -- for all of them. + + if Comes_From_Source (Spec_Id) + and then Present (First_Entity (Spec_Id)) + and then Ekind (Etype (First_Entity (Spec_Id))) = E_Record_Type + and then Is_Tagged_Type (Etype (First_Entity (Spec_Id))) + and then + Present (Abstract_Interfaces (Etype (First_Entity (Spec_Id)))) + and then + Present + (Corresponding_Concurrent_Type + (Etype (First_Entity (Spec_Id)))) + then + declare + Typ : constant Entity_Id := Etype (First_Entity (Spec_Id)); + Form : Entity_Id; + + begin + Form := First_Formal (Spec_Id); + while Present (Form) loop + if Etype (Form) = Typ then + Set_Etype (Form, Corresponding_Concurrent_Type (Typ)); + end if; + + Next_Formal (Form); + end loop; + end; + end if; + + -- Now make the formals visible, and place subprogram + -- on scope stack. + Install_Formals (Spec_Id); Last_Formal := Last_Entity (Spec_Id); - New_Scope (Spec_Id); + Push_Scope (Spec_Id); -- Make sure that the subprogram is immediately visible. For -- child units that have no separate spec this is indispensable. @@ -1124,6 +1794,7 @@ package body Sem_Ch6 is Set_Corresponding_Body (Unit_Declaration_Node (Spec_Id), Body_Id); Set_Ekind (Body_Id, E_Subprogram_Body); Set_Scope (Body_Id, Scope (Spec_Id)); + Set_Is_Obsolescent (Body_Id, Is_Obsolescent (Spec_Id)); -- Case of subprogram body with no previous spec @@ -1141,11 +1812,88 @@ package body Sem_Ch6 is if Nkind (N) /= N_Subprogram_Body_Stub then Set_Acts_As_Spec (N); Generate_Definition (Body_Id); + Generate_Reference + (Body_Id, Body_Id, 'b', Set_Ref => False, Force => True); + Generate_Reference_To_Formals (Body_Id); Install_Formals (Body_Id); - New_Scope (Body_Id); + Push_Scope (Body_Id); end if; end if; + -- Ada 2005 (AI-251): Check wrong placement of abstract interface + -- primitives, and update anonymous access returns with limited views. + + if Ada_Version >= Ada_05 + and then Comes_From_Source (N) + then + declare + E : Entity_Id; + Etyp : Entity_Id; + Rtyp : Entity_Id; + + begin + -- Check the type of the formals + + E := First_Entity (Body_Id); + while Present (E) loop + Etyp := Etype (E); + + if Is_Access_Type (Etyp) then + Etyp := Directly_Designated_Type (Etyp); + end if; + + if not Is_Class_Wide_Type (Etyp) + and then Is_Interface (Etyp) + then + Error_Msg_Name_1 := Chars (Defining_Entity (N)); + Error_Msg_N + ("(Ada 2005) abstract interface primitives must be" & + " defined in package specs", N); + exit; + end if; + + Next_Entity (E); + end loop; + + -- In case of functions, check the type of the result + + if Ekind (Body_Id) = E_Function then + Etyp := Etype (Body_Id); + + if Is_Access_Type (Etyp) then + Etyp := Directly_Designated_Type (Etyp); + end if; + + if not Is_Class_Wide_Type (Etyp) + and then Is_Interface (Etyp) + then + Error_Msg_Name_1 := Chars (Defining_Entity (N)); + Error_Msg_N + ("(Ada 2005) abstract interface primitives must be" & + " defined in package specs", N); + end if; + end if; + + -- If the return type is an anonymous access type whose + -- designated type is the limited view of a class-wide type + -- and the non-limited view is available. update the return + -- type accordingly. + + Rtyp := Etype (Current_Scope); + + if Ekind (Rtyp) = E_Anonymous_Access_Type then + Etyp := Directly_Designated_Type (Rtyp); + + if Is_Class_Wide_Type (Etyp) + and then From_With_Type (Etyp) + then + Set_Directly_Designated_Type + (Etype (Current_Scope), Available_View (Etyp)); + end if; + end if; + end; + end if; + -- If this is the proper body of a stub, we must verify that the stub -- conforms to the body, and to the previous spec if one was present. -- we know already that the body conforms to that spec. This test is @@ -1154,12 +1902,15 @@ package body Sem_Ch6 is if Nkind (Parent (N)) = N_Subunit and then Comes_From_Source (N) and then not Error_Posted (Body_Id) + and then Nkind (Corresponding_Stub (Parent (N))) = + N_Subprogram_Body_Stub then declare + Old_Id : constant Entity_Id := + Defining_Entity + (Specification (Corresponding_Stub (Parent (N)))); + Conformant : Boolean := False; - Old_Id : Entity_Id := - Defining_Entity - (Specification (Corresponding_Stub (Parent (N)))); begin if No (Spec_Id) then @@ -1186,16 +1937,54 @@ package body Sem_Ch6 is if Nkind (N) = N_Subprogram_Body_Stub then return; - elsif Present (Spec_Id) + elsif Present (Spec_Id) and then Expander_Active - and then (Is_Always_Inlined (Spec_Id) - or else (Has_Pragma_Inline (Spec_Id) - and then - (Front_End_Inlining or else No_Run_Time))) + and then + (Has_Pragma_Inline_Always (Spec_Id) + or else (Has_Pragma_Inline (Spec_Id) and Front_End_Inlining)) then - if Build_Body_To_Inline (N, Spec_Id, Copy_Separate_Tree (N)) then - null; - end if; + Build_Body_To_Inline (N, Spec_Id); + end if; + + -- Ada 2005 (AI-262): In library subprogram bodies, after the analysis + -- if its specification we have to install the private withed units. + + if Is_Compilation_Unit (Body_Id) + and then Scope (Body_Id) = Standard_Standard + then + Install_Private_With_Clauses (Body_Id); + end if; + + Check_Anonymous_Return; + + -- Set the Protected_Formal field of each extra formal of the protected + -- subprogram to reference the corresponding extra formal of the + -- subprogram that implements it. For regular formals this occurs when + -- the protected subprogram's declaration is expanded, but the extra + -- formals don't get created until the subprogram is frozen. We need to + -- do this before analyzing the protected subprogram's body so that any + -- references to the original subprogram's extra formals will be changed + -- refer to the implementing subprogram's formals (see Expand_Formal). + + if Present (Spec_Id) + and then Is_Protected_Type (Scope (Spec_Id)) + and then Present (Protected_Body_Subprogram (Spec_Id)) + then + declare + Impl_Subp : constant Entity_Id := + Protected_Body_Subprogram (Spec_Id); + Prot_Ext_Formal : Entity_Id := Extra_Formals (Spec_Id); + Impl_Ext_Formal : Entity_Id := Extra_Formals (Impl_Subp); + begin + while Present (Prot_Ext_Formal) loop + pragma Assert (Present (Impl_Ext_Formal)); + + Set_Protected_Formal (Prot_Ext_Formal, Impl_Ext_Formal); + + Next_Formal_With_Extras (Prot_Ext_Formal); + Next_Formal_With_Extras (Impl_Ext_Formal); + end loop; + end; end if; -- Now we can go on to analyze the body @@ -1208,6 +1997,7 @@ package body Sem_Ch6 is Process_End_Label (HSS, 't', Current_Scope); End_Scope; Check_Subprogram_Order (N); + Set_Analyzed (Body_Id); -- If we have a separate spec, then the analysis of the declarations -- caused the entities in the body to be chained to the spec id, but @@ -1216,14 +2006,13 @@ package body Sem_Ch6 is if Present (Spec_Id) then - -- If a parent unit is categorized, the context of a subunit - -- must conform to the categorization. Conversely, if a child - -- unit is categorized, the parents themselves must conform. + -- We must conform to the categorization of our spec + + Validate_Categorization_Dependency (N, Spec_Id); - if Nkind (Parent (N)) = N_Subunit then - Validate_Categorization_Dependency (N, Spec_Id); + -- And if this is a child unit, the parent units must conform - elsif Is_Child_Unit (Spec_Id) then + if Is_Child_Unit (Spec_Id) then Validate_Categorization_Dependency (Unit_Declaration_Node (Spec_Id), Spec_Id); end if; @@ -1276,25 +2065,84 @@ package body Sem_Ch6 is and then Present (Spec_Id) and then No_Return (Spec_Id) then - Check_Returns (HSS, 'P', Missing_Ret); + Check_Returns (HSS, 'P', Missing_Ret, Spec_Id); end if; - -- Don't worry about checking for variables that are never modified - -- if the first statement of the body is a raise statement, since - -- we assume this is some kind of stub. We ignore a label generated - -- by the exception stuff for the purpose of this test. + -- Now we are going to check for variables that are never modified in + -- the body of the procedure. We omit these checks if the first + -- statement of the procedure raises an exception. In particular this + -- deals with the common idiom of a stubbed function, which might + -- appear as something like + + -- function F (A : Integer) return Some_Type; + -- X : Some_Type; + -- begin + -- raise Program_Error; + -- return X; + -- end F; + + -- Here the purpose of X is simply to satisfy the (annoying) + -- requirement in Ada that there be at least one return, and we + -- certainly do not want to go posting warnings on X that it is not + -- initialized! declare - Stm : Node_Id := First (Statements (HSS)); + Stm : Node_Id; begin - if Nkind (Stm) = N_Label then + -- Skip initial labels (for one thing this occurs when we are in + -- front end ZCX mode, but in any case it is irrelevant), and also + -- initial Push_xxx_Error_Label nodes, which are also irrelevant. + + Stm := First (Statements (HSS)); + while Nkind (Stm) = N_Label + or else Nkind (Stm) in N_Push_xxx_Label + loop Next (Stm); - end if; + end loop; - if Nkind (Original_Node (Stm)) = N_Raise_Statement then - return; - end if; + -- Do the test on the original statement before expansion + + declare + Ostm : constant Node_Id := Original_Node (Stm); + + begin + -- If explicit raise statement, return with no checks + + if Nkind (Ostm) = N_Raise_Statement then + return; + + -- Check for explicit call cases which likely raise an exception + + elsif Nkind (Ostm) = N_Procedure_Call_Statement then + if Is_Entity_Name (Name (Ostm)) then + declare + Ent : constant Entity_Id := Entity (Name (Ostm)); + + begin + -- If the procedure is marked No_Return, then likely it + -- raises an exception, but in any case it is not coming + -- back here, so no need to check beyond the call. + + if Ekind (Ent) = E_Procedure + and then No_Return (Ent) + then + return; + + -- If the procedure name is Raise_Exception, then also + -- assume that it raises an exception. The main target + -- here is Ada.Exceptions.Raise_Exception, but this name + -- is pretty evocative in any context! Note that the + -- procedure in Ada.Exceptions is not marked No_Return + -- because of the annoying case of the null exception Id. + + elsif Chars (Ent) = Name_Raise_Exception then + return; + end if; + end; + end if; + end if; + end; end; -- Check for variables that are never modified @@ -1303,32 +2151,24 @@ package body Sem_Ch6 is E1, E2 : Entity_Id; begin - -- If there is a separate spec, then transfer Not_Source_Assigned + -- If there is a separate spec, then transfer Never_Set_In_Source -- flags from out parameters to the corresponding entities in the -- body. The reason we do that is we want to post error flags on -- the body entities, not the spec entities. if Present (Spec_Id) then E1 := First_Entity (Spec_Id); - while Present (E1) loop if Ekind (E1) = E_Out_Parameter then E2 := First_Entity (Body_Id); - - loop - -- If no matching body entity, then we already had - -- a detected error of some kind, so just forget - -- about worrying about these warnings. - - if No (E2) then - return; - end if; - + while Present (E2) loop exit when Chars (E1) = Chars (E2); Next_Entity (E2); end loop; - Set_Not_Source_Assigned (E2, Not_Source_Assigned (E1)); + if Present (E2) then + Set_Never_Set_In_Source (E2, Never_Set_In_Source (E1)); + end if; end if; Next_Entity (E1); @@ -1350,24 +2190,25 @@ package body Sem_Ch6 is ------------------------------------ procedure Analyze_Subprogram_Declaration (N : Node_Id) is - Designator : constant Entity_Id := Analyze_Spec (Specification (N)); - Scop : constant Entity_Id := Current_Scope; + Designator : constant Entity_Id := + Analyze_Subprogram_Specification (Specification (N)); + Scop : constant Entity_Id := Current_Scope; -- Start of processing for Analyze_Subprogram_Declaration begin Generate_Definition (Designator); - -- Check for RCI unit subprogram declarations against in-lined + -- Check for RCI unit subprogram declarations for illegal inlined -- subprograms and subprograms having access parameter or limited - -- parameter without Read and Write (RM E.2.3(12-13)). + -- parameter without Read and Write attributes (RM E.2.3(12-13)). Validate_RCI_Subprogram_Declaration (N); Trace_Scope (N, Defining_Entity (N), - " Analyze subprogram spec. "); + " Analyze subprogram spec: "); if Debug_Flag_C then Write_Str ("==== Compiling subprogram spec "); @@ -1379,22 +2220,70 @@ package body Sem_Ch6 is New_Overloaded_Entity (Designator); Check_Delayed_Subprogram (Designator); - Set_Suppress_Elaboration_Checks - (Designator, Elaboration_Checks_Suppressed (Designator)); + + -- Ada 2005 (AI-251): Abstract interface primitives must be abstract + -- or null. + + if Ada_Version >= Ada_05 + and then Comes_From_Source (N) + and then Is_Dispatching_Operation (Designator) + then + declare + E : Entity_Id; + Etyp : Entity_Id; + + begin + if Has_Controlling_Result (Designator) then + Etyp := Etype (Designator); + + else + E := First_Entity (Designator); + while Present (E) + and then Is_Formal (E) + and then not Is_Controlling_Formal (E) + loop + Next_Entity (E); + end loop; + + Etyp := Etype (E); + end if; + + if Is_Access_Type (Etyp) then + Etyp := Directly_Designated_Type (Etyp); + end if; + + if Is_Interface (Etyp) + and then not Is_Abstract_Subprogram (Designator) + and then not (Ekind (Designator) = E_Procedure + and then Null_Present (Specification (N))) + then + Error_Msg_Name_1 := Chars (Defining_Entity (N)); + Error_Msg_N + ("(Ada 2005) interface subprogram % must be abstract or null", + N); + end if; + end; + end if; + + -- What is the following code for, it used to be + + -- ??? Set_Suppress_Elaboration_Checks + -- ??? (Designator, Elaboration_Checks_Suppressed (Designator)); + + -- The following seems equivalent, but a bit dubious + + if Elaboration_Checks_Suppressed (Designator) then + Set_Kill_Elaboration_Checks (Designator); + end if; if Scop /= Standard_Standard and then not Is_Child_Unit (Designator) then - Set_Is_Pure (Designator, - Is_Pure (Scop) and then Is_Library_Level_Entity (Designator)); - Set_Is_Remote_Call_Interface ( - Designator, Is_Remote_Call_Interface (Scop)); - Set_Is_Remote_Types (Designator, Is_Remote_Types (Scop)); - + Set_Categorization_From_Scope (Designator, Scop); else - -- For a compilation unit, check for library-unit pragmas. + -- For a compilation unit, check for library-unit pragmas - New_Scope (Designator); + Push_Scope (Designator); Set_Categorization_From_Pragmas (N); Validate_Categorization_Dependency (N, Designator); Pop_Scope; @@ -1405,58 +2294,174 @@ package body Sem_Ch6 is if Nkind (Parent (N)) = N_Compilation_Unit then Set_Body_Required (Parent (N), True); + + if Ada_Version >= Ada_05 + and then Nkind (Specification (N)) = N_Procedure_Specification + and then Null_Present (Specification (N)) + then + Error_Msg_N + ("null procedure cannot be declared at library level", N); + end if; end if; + Generate_Reference_To_Formals (Designator); Check_Eliminated (Designator); + + -- Ada 2005: if procedure is declared with "is null" qualifier, + -- it requires no body. + + if Nkind (Specification (N)) = N_Procedure_Specification + and then Null_Present (Specification (N)) + then + Set_Has_Completion (Designator); + Set_Is_Inlined (Designator); + + if Is_Protected_Type (Current_Scope) then + Error_Msg_N + ("protected operation cannot be a null procedure", N); + end if; + end if; end Analyze_Subprogram_Declaration; + -------------------------------------- + -- Analyze_Subprogram_Specification -- + -------------------------------------- + + -- Reminder: N here really is a subprogram specification (not a subprogram + -- declaration). This procedure is called to analyze the specification in + -- both subprogram bodies and subprogram declarations (specs). + + function Analyze_Subprogram_Specification (N : Node_Id) return Entity_Id is + Designator : constant Entity_Id := Defining_Entity (N); + Formal : Entity_Id; + Formal_Typ : Entity_Id; + Formals : constant List_Id := Parameter_Specifications (N); + + -- Start of processing for Analyze_Subprogram_Specification + + begin + Generate_Definition (Designator); + + if Nkind (N) = N_Function_Specification then + Set_Ekind (Designator, E_Function); + Set_Mechanism (Designator, Default_Mechanism); + + else + Set_Ekind (Designator, E_Procedure); + Set_Etype (Designator, Standard_Void_Type); + end if; + + -- Introduce new scope for analysis of the formals and the return type + + Set_Scope (Designator, Current_Scope); + + if Present (Formals) then + Push_Scope (Designator); + Process_Formals (Formals, N); + + -- Ada 2005 (AI-345): Allow the overriding of interface primitives + -- by subprograms which belong to a concurrent type implementing an + -- interface. Set the parameter type of each controlling formal to + -- the corresponding record type. + + if Ada_Version >= Ada_05 then + Formal := First_Formal (Designator); + while Present (Formal) loop + Formal_Typ := Etype (Formal); + + if (Ekind (Formal_Typ) = E_Protected_Type + or else Ekind (Formal_Typ) = E_Task_Type) + and then Present (Corresponding_Record_Type (Formal_Typ)) + and then Present (Abstract_Interfaces + (Corresponding_Record_Type (Formal_Typ))) + then + Set_Etype (Formal, + Corresponding_Record_Type (Formal_Typ)); + end if; + + Formal := Next_Formal (Formal); + end loop; + end if; + + End_Scope; + + elsif Nkind (N) = N_Function_Specification then + Analyze_Return_Type (N); + end if; + + if Nkind (N) = N_Function_Specification then + if Nkind (Designator) = N_Defining_Operator_Symbol then + Valid_Operator_Definition (Designator); + end if; + + May_Need_Actuals (Designator); + + -- Ada 2005 (AI-251): In case of primitives associated with abstract + -- interface types the following error message will be reported later + -- (see Analyze_Subprogram_Declaration). + + if Is_Abstract_Type (Etype (Designator)) + and then not Is_Interface (Etype (Designator)) + and then Nkind (Parent (N)) + /= N_Abstract_Subprogram_Declaration + and then (Nkind (Parent (N))) + /= N_Formal_Abstract_Subprogram_Declaration + and then (Nkind (Parent (N)) /= N_Subprogram_Renaming_Declaration + or else not Is_Entity_Name (Name (Parent (N))) + or else not Is_Abstract_Subprogram + (Entity (Name (Parent (N))))) + then + Error_Msg_N + ("function that returns abstract type must be abstract", N); + end if; + end if; + + return Designator; + end Analyze_Subprogram_Specification; + -------------------------- -- Build_Body_To_Inline -- -------------------------- - function Build_Body_To_Inline - (N : Node_Id; - Subp : Entity_Id; - Orig_Body : Node_Id) return Boolean - is - Decl : constant Node_Id := Unit_Declaration_Node (Subp); + procedure Build_Body_To_Inline (N : Node_Id; Subp : Entity_Id) is + Decl : constant Node_Id := Unit_Declaration_Node (Subp); Original_Body : Node_Id; Body_To_Analyze : Node_Id; Max_Size : constant := 10; Stat_Count : Integer := 0; function Has_Excluded_Declaration (Decls : List_Id) return Boolean; - -- Check for declarations that make inlining not worthwhile. + -- Check for declarations that make inlining not worthwhile function Has_Excluded_Statement (Stats : List_Id) return Boolean; - -- Check for statements that make inlining not worthwhile: any - -- tasking statement, nested at any level. Keep track of total - -- number of elementary statements, as a measure of acceptable size. + -- Check for statements that make inlining not worthwhile: any tasking + -- statement, nested at any level. Keep track of total number of + -- elementary statements, as a measure of acceptable size. function Has_Pending_Instantiation return Boolean; - -- If some enclosing body contains instantiations that appear before - -- the corresponding generic body, the enclosing body has a freeze node - -- so that it can be elaborated after the generic itself. This might + -- If some enclosing body contains instantiations that appear before the + -- corresponding generic body, the enclosing body has a freeze node so + -- that it can be elaborated after the generic itself. This might -- conflict with subsequent inlinings, so that it is unsafe to try to -- inline in such a case. - ------------------- - -- Cannot_Inline -- - ------------------- + function Has_Single_Return return Boolean; + -- In general we cannot inline functions that return unconstrained type. + -- However, we can handle such functions if all return statements return + -- a local variable that is the only declaration in the body of the + -- function. In that case the call can be replaced by that local + -- variable as is done for other inlined calls. - procedure Cannot_Inline (Msg : String; N : Node_Id); - -- If subprogram has pragma Inline_Always, it is an error if - -- it cannot be inlined. Otherwise, emit a warning. + procedure Remove_Pragmas; + -- A pragma Unreferenced that mentions a formal parameter has no meaning + -- when the body is inlined and the formals are rewritten. Remove it + -- from body to inline. The analysis of the non-inlined body will handle + -- the pragma properly. - procedure Cannot_Inline (Msg : String; N : Node_Id) is - begin - if Is_Always_Inlined (Subp) then - Error_Msg_NE (Msg (1 .. Msg'Length - 1), N, Subp); - - elsif Ineffective_Inline_Warnings then - Error_Msg_NE (Msg, N, Subp); - end if; - end Cannot_Inline; + function Uses_Secondary_Stack (Bod : Node_Id) return Boolean; + -- If the body of the subprogram includes a call that returns an + -- unconstrained type, the secondary stack is involved, and it + -- is not worth inlining. ------------------------------ -- Has_Excluded_Declaration -- @@ -1465,20 +2470,56 @@ package body Sem_Ch6 is function Has_Excluded_Declaration (Decls : List_Id) return Boolean is D : Node_Id; + function Is_Unchecked_Conversion (D : Node_Id) return Boolean; + -- Nested subprograms make a given body ineligible for inlining, but + -- we make an exception for instantiations of unchecked conversion. + -- The body has not been analyzed yet, so check the name, and verify + -- that the visible entity with that name is the predefined unit. + + ----------------------------- + -- Is_Unchecked_Conversion -- + ----------------------------- + + function Is_Unchecked_Conversion (D : Node_Id) return Boolean is + Id : constant Node_Id := Name (D); + Conv : Entity_Id; + + begin + if Nkind (Id) = N_Identifier + and then Chars (Id) = Name_Unchecked_Conversion + then + Conv := Current_Entity (Id); + + elsif Nkind_In (Id, N_Selected_Component, N_Expanded_Name) + and then Chars (Selector_Name (Id)) = Name_Unchecked_Conversion + then + Conv := Current_Entity (Selector_Name (Id)); + else + return False; + end if; + + return Present (Conv) + and then Is_Predefined_File_Name + (Unit_File_Name (Get_Source_Unit (Conv))) + and then Is_Intrinsic_Subprogram (Conv); + end Is_Unchecked_Conversion; + + -- Start of processing for Has_Excluded_Declaration + begin D := First (Decls); - while Present (D) loop - if Nkind (D) = N_Function_Instantiation - or else Nkind (D) = N_Protected_Type_Declaration - or else Nkind (D) = N_Package_Declaration - or else Nkind (D) = N_Package_Instantiation - or else Nkind (D) = N_Subprogram_Body - or else Nkind (D) = N_Procedure_Instantiation - or else Nkind (D) = N_Task_Type_Declaration + if (Nkind (D) = N_Function_Instantiation + and then not Is_Unchecked_Conversion (D)) + or else Nkind_In (D, N_Protected_Type_Declaration, + N_Package_Declaration, + N_Package_Instantiation, + N_Subprogram_Body, + N_Procedure_Instantiation, + N_Task_Type_Declaration) then Cannot_Inline - ("\declaration prevents front-end inlining of&?", D); + ("cannot inline & (non-allowed declaration)?", D, Subp); return True; end if; @@ -1486,7 +2527,6 @@ package body Sem_Ch6 is end loop; return False; - end Has_Excluded_Declaration; ---------------------------- @@ -1499,20 +2539,19 @@ package body Sem_Ch6 is begin S := First (Stats); - while Present (S) loop Stat_Count := Stat_Count + 1; - if Nkind (S) = N_Abort_Statement - or else Nkind (S) = N_Asynchronous_Select - or else Nkind (S) = N_Conditional_Entry_Call - or else Nkind (S) = N_Delay_Relative_Statement - or else Nkind (S) = N_Delay_Until_Statement - or else Nkind (S) = N_Selective_Accept - or else Nkind (S) = N_Timed_Entry_Call + if Nkind_In (S, N_Abort_Statement, + N_Asynchronous_Select, + N_Conditional_Entry_Call, + N_Delay_Relative_Statement, + N_Delay_Until_Statement, + N_Selective_Accept, + N_Timed_Entry_Call) then Cannot_Inline - ("\statement prevents front-end inlining of&?", S); + ("cannot inline & (non-allowed statement)?", S, Subp); return True; elsif Nkind (S) = N_Block_Statement then @@ -1534,7 +2573,6 @@ package body Sem_Ch6 is elsif Nkind (S) = N_Case_Statement then E := First (Alternatives (S)); - while Present (E) loop if Has_Excluded_Statement (Statements (E)) then return True; @@ -1550,7 +2588,6 @@ package body Sem_Ch6 is if Present (Elsif_Parts (S)) then E := First (Elsif_Parts (S)); - while Present (E) loop if Has_Excluded_Statement (Then_Statements (E)) then return True; @@ -1582,9 +2619,10 @@ package body Sem_Ch6 is ------------------------------- function Has_Pending_Instantiation return Boolean is - S : Entity_Id := Current_Scope; + S : Entity_Id; begin + S := Current_Scope; while Present (S) loop if Is_Compilation_Unit (S) or else Is_Child_Unit (S) @@ -1602,93 +2640,171 @@ package body Sem_Ch6 is return False; end Has_Pending_Instantiation; - -- Start of processing for Build_Body_To_Inline + ------------------------ + -- Has_Single_Return -- + ------------------------ - begin - if Nkind (Decl) = N_Subprogram_Declaration - and then Present (Body_To_Inline (Decl)) - then - return True; -- Done already. + function Has_Single_Return return Boolean is + Return_Statement : Node_Id := Empty; - -- Functions that return unconstrained composite types will require - -- secondary stack handling, and cannot currently be inlined. + function Check_Return (N : Node_Id) return Traverse_Result; - elsif Ekind (Subp) = E_Function - and then not Is_Scalar_Type (Etype (Subp)) - and then not Is_Access_Type (Etype (Subp)) - and then not Is_Constrained (Etype (Subp)) - then - Cannot_Inline - ("unconstrained return type prevents front-end inlining of&?", N); - return False; - end if; + ------------------ + -- Check_Return -- + ------------------ - -- We need to capture references to the formals in order to substitute - -- the actuals at the point of inlining, i.e. instantiation. To treat - -- the formals as globals to the body to inline, we nest it within - -- a dummy parameterless subprogram, declared within the real one. + function Check_Return (N : Node_Id) return Traverse_Result is + begin + if Nkind (N) = N_Simple_Return_Statement then + if Present (Expression (N)) + and then Is_Entity_Name (Expression (N)) + then + if No (Return_Statement) then + Return_Statement := N; + return OK; - Original_Body := Orig_Body; + elsif Chars (Expression (N)) = + Chars (Expression (Return_Statement)) + then + return OK; - -- Within an instance, the current tree is already the result of - -- a generic copy, and not what we need for subsequent inlining. - -- We create the required body by doing an instantiating copy, to - -- obtain the proper partially analyzed tree. + else + return Abandon; + end if; + + else + -- Expression has wrong form + + return Abandon; + end if; + + else + return OK; + end if; + end Check_Return; + + function Check_All_Returns is new Traverse_Func (Check_Return); + + -- Start of processing for Has_Single_Return + + begin + return Check_All_Returns (N) = OK + and then Present (Declarations (N)) + and then Present (First (Declarations (N))) + and then Chars (Expression (Return_Statement)) = + Chars (Defining_Identifier (First (Declarations (N)))); + end Has_Single_Return; + + -------------------- + -- Remove_Pragmas -- + -------------------- + + procedure Remove_Pragmas is + Decl : Node_Id; + Nxt : Node_Id; + + begin + Decl := First (Declarations (Body_To_Analyze)); + while Present (Decl) loop + Nxt := Next (Decl); + + if Nkind (Decl) = N_Pragma + and then Chars (Decl) = Name_Unreferenced + then + Remove (Decl); + end if; + + Decl := Nxt; + end loop; + end Remove_Pragmas; + + -------------------------- + -- Uses_Secondary_Stack -- + -------------------------- + + function Uses_Secondary_Stack (Bod : Node_Id) return Boolean is + function Check_Call (N : Node_Id) return Traverse_Result; + -- Look for function calls that return an unconstrained type + + ---------------- + -- Check_Call -- + ---------------- + + function Check_Call (N : Node_Id) return Traverse_Result is + begin + if Nkind (N) = N_Function_Call + and then Is_Entity_Name (Name (N)) + and then Is_Composite_Type (Etype (Entity (Name (N)))) + and then not Is_Constrained (Etype (Entity (Name (N)))) + then + Cannot_Inline + ("cannot inline & (call returns unconstrained type)?", + N, Subp); + return Abandon; + else + return OK; + end if; + end Check_Call; - if In_Instance then - if No (Generic_Parent (Specification (N))) then - return False; + function Check_Calls is new Traverse_Func (Check_Call); - elsif Is_Child_Unit (Scope (Current_Scope)) then - return False; + begin + return Check_Calls (Bod) = Abandon; + end Uses_Secondary_Stack; - elsif Scope (Current_Scope) = Cunit_Entity (Main_Unit) then + -- Start of processing for Build_Body_To_Inline - -- compiling an instantiation. There is no point in generating - -- bodies to inline, because they will not be used. + begin + if Nkind (Decl) = N_Subprogram_Declaration + and then Present (Body_To_Inline (Decl)) + then + return; -- Done already. - return False; + -- Functions that return unconstrained composite types require + -- secondary stack handling, and cannot currently be inlined, unless + -- all return statements return a local variable that is the first + -- local declaration in the body. - else - Body_To_Analyze := - Copy_Generic_Node - (Generic_Parent (Specification (N)), Empty, - Instantiating => True); + elsif Ekind (Subp) = E_Function + and then not Is_Scalar_Type (Etype (Subp)) + and then not Is_Access_Type (Etype (Subp)) + and then not Is_Constrained (Etype (Subp)) + then + if not Has_Single_Return then + Cannot_Inline + ("cannot inline & (unconstrained return type)?", N, Subp); + return; end if; - else - Body_To_Analyze := - Copy_Generic_Node (Original_Body, Empty, - Instantiating => False); - end if; - Set_Parameter_Specifications (Specification (Original_Body), No_List); - Set_Defining_Unit_Name (Specification (Original_Body), - Make_Defining_Identifier (Sloc (N), New_Internal_Name ('S'))); - Set_Corresponding_Spec (Original_Body, Empty); + -- Ditto for functions that return controlled types, where controlled + -- actions interfere in complex ways with inlining. - if Ekind (Subp) = E_Function then - Set_Subtype_Mark (Specification (Original_Body), - New_Occurrence_Of (Etype (Subp), Sloc (N))); + elsif Ekind (Subp) = E_Function + and then Controlled_Type (Etype (Subp)) + then + Cannot_Inline + ("cannot inline & (controlled return type)?", N, Subp); + return; end if; - if Present (Declarations (Orig_Body)) - and then Has_Excluded_Declaration (Declarations (Orig_Body)) + if Present (Declarations (N)) + and then Has_Excluded_Declaration (Declarations (N)) then - return False; + return; end if; if Present (Handled_Statement_Sequence (N)) then - if - (Present (Exception_Handlers (Handled_Statement_Sequence (N)))) - then - Cannot_Inline ("handler prevents front-end inlining of&?", - First (Exception_Handlers (Handled_Statement_Sequence (N)))); - return False; + if Present (Exception_Handlers (Handled_Statement_Sequence (N))) then + Cannot_Inline + ("cannot inline& (exception handler)?", + First (Exception_Handlers (Handled_Statement_Sequence (N))), + Subp); + return; elsif Has_Excluded_Statement (Statements (Handled_Statement_Sequence (N))) then - return False; + return; end if; end if; @@ -1697,26 +2813,50 @@ package body Sem_Ch6 is -- checks on inlining (forbidden declarations, handlers, etc). if Stat_Count > Max_Size - and then not Is_Always_Inlined (Subp) + and then not Has_Pragma_Inline_Always (Subp) then - Cannot_Inline ("body is too large for front-end inlining of&?", N); - return False; + Cannot_Inline ("cannot inline& (body too large)?", N, Subp); + return; end if; if Has_Pending_Instantiation then Cannot_Inline - ("cannot inline& because of forward instance within enclosing body", - N); - return False; + ("cannot inline& (forward instance within enclosing body)?", + N, Subp); + return; + end if; + + -- Within an instance, the body to inline must be treated as a nested + -- generic, so that the proper global references are preserved. + + if In_Instance then + Save_Env (Scope (Current_Scope), Scope (Current_Scope)); + Original_Body := Copy_Generic_Node (N, Empty, True); + else + Original_Body := Copy_Separate_Tree (N); end if; + -- We need to capture references to the formals in order to substitute + -- the actuals at the point of inlining, i.e. instantiation. To treat + -- the formals as globals to the body to inline, we nest it within + -- a dummy parameterless subprogram, declared within the real one. + -- To avoid generating an internal name (which is never public, and + -- which affects serial numbers of other generated names), we use + -- an internal symbol that cannot conflict with user declarations. + + Set_Parameter_Specifications (Specification (Original_Body), No_List); + Set_Defining_Unit_Name + (Specification (Original_Body), + Make_Defining_Identifier (Sloc (N), Name_uParent)); + Set_Corresponding_Spec (Original_Body, Empty); + Body_To_Analyze := Copy_Generic_Node (Original_Body, Empty, False); -- Set return type of function, which is also global and does not need -- to be resolved. if Ekind (Subp) = E_Function then - Set_Subtype_Mark (Specification (Body_To_Analyze), + Set_Result_Definition (Specification (Body_To_Analyze), New_Occurrence_Of (Etype (Subp), Sloc (N))); end if; @@ -1727,46 +2867,81 @@ package body Sem_Ch6 is end if; Expander_Mode_Save_And_Set (False); + Remove_Pragmas; Analyze (Body_To_Analyze); - New_Scope (Defining_Entity (Body_To_Analyze)); + Push_Scope (Defining_Entity (Body_To_Analyze)); Save_Global_References (Original_Body); End_Scope; Remove (Body_To_Analyze); Expander_Mode_Restore; + + if In_Instance then + Restore_Env; + end if; + + -- If secondary stk used there is no point in inlining. We have + -- already issued the warning in this case, so nothing to do. + + if Uses_Secondary_Stack (Body_To_Analyze) then + return; + end if; + Set_Body_To_Inline (Decl, Original_Body); + Set_Ekind (Defining_Entity (Original_Body), Ekind (Subp)); Set_Is_Inlined (Subp); - return True; - end Build_Body_To_Inline; + ------------------- + -- Cannot_Inline -- + ------------------- + + procedure Cannot_Inline (Msg : String; N : Node_Id; Subp : Entity_Id) is + begin + -- Do not emit warning if this is a predefined unit which is not + -- the main unit. With validity checks enabled, some predefined + -- subprograms may contain nested subprograms and become ineligible + -- for inlining. + + if Is_Predefined_File_Name (Unit_File_Name (Get_Source_Unit (Subp))) + and then not In_Extended_Main_Source_Unit (Subp) + then + null; + + elsif Has_Pragma_Inline_Always (Subp) then + + -- Remove last character (question mark) to make this into an error, + -- because the Inline_Always pragma cannot be obeyed. + + Error_Msg_NE (Msg (Msg'First .. Msg'Last - 1), N, Subp); + + elsif Ineffective_Inline_Warnings then + Error_Msg_NE (Msg, N, Subp); + end if; + end Cannot_Inline; + ----------------------- -- Check_Conformance -- ----------------------- procedure Check_Conformance - (New_Id : Entity_Id; - Old_Id : Entity_Id; - Ctype : Conformance_Type; - Errmsg : Boolean; - Conforms : out Boolean; - Err_Loc : Node_Id := Empty; - Get_Inst : Boolean := False) + (New_Id : Entity_Id; + Old_Id : Entity_Id; + Ctype : Conformance_Type; + Errmsg : Boolean; + Conforms : out Boolean; + Err_Loc : Node_Id := Empty; + Get_Inst : Boolean := False; + Skip_Controlling_Formals : Boolean := False) is - Old_Type : constant Entity_Id := Etype (Old_Id); - New_Type : constant Entity_Id := Etype (New_Id); - Old_Formal : Entity_Id; - New_Formal : Entity_Id; - procedure Conformance_Error (Msg : String; N : Node_Id := New_Id); - -- Post error message for conformance error on given node. - -- Two messages are output. The first points to the previous - -- declaration with a general "no conformance" message. - -- The second is the detailed reason, supplied as Msg. The - -- parameter N provide information for a possible & insertion - -- in the message, and also provides the location for posting - -- the message in the absence of a specified Err_Loc location. + -- Post error message for conformance error on given node. Two messages + -- are output. The first points to the previous declaration with a + -- general "no conformance" message. The second is the detailed reason, + -- supplied as Msg. The parameter N provide information for a possible + -- & insertion in the message, and also provides the location for + -- posting the message in the absence of a specified Err_Loc location. ----------------------- -- Conformance_Error -- @@ -1793,29 +2968,57 @@ package body Sem_Ch6 is ("not type conformant with declaration#!", Enode); when Mode_Conformant => - Error_Msg_N - ("not mode conformant with declaration#!", Enode); + if Nkind (Parent (Old_Id)) = N_Full_Type_Declaration then + Error_Msg_N + ("not mode conformant with operation inherited#!", + Enode); + else + Error_Msg_N + ("not mode conformant with declaration#!", Enode); + end if; when Subtype_Conformant => - Error_Msg_N - ("not subtype conformant with declaration#!", Enode); + if Nkind (Parent (Old_Id)) = N_Full_Type_Declaration then + Error_Msg_N + ("not subtype conformant with operation inherited#!", + Enode); + else + Error_Msg_N + ("not subtype conformant with declaration#!", Enode); + end if; when Fully_Conformant => - Error_Msg_N - ("not fully conformant with declaration#!", Enode); + if Nkind (Parent (Old_Id)) = N_Full_Type_Declaration then + Error_Msg_N + ("not fully conformant with operation inherited#!", + Enode); + else + Error_Msg_N + ("not fully conformant with declaration#!", Enode); + end if; end case; Error_Msg_NE (Msg, Enode, N); end if; end Conformance_Error; + -- Local Variables + + Old_Type : constant Entity_Id := Etype (Old_Id); + New_Type : constant Entity_Id := Etype (New_Id); + Old_Formal : Entity_Id; + New_Formal : Entity_Id; + Access_Types_Match : Boolean; + Old_Formal_Base : Entity_Id; + New_Formal_Base : Entity_Id; + -- Start of processing for Check_Conformance begin Conforms := True; - -- We need a special case for operators, since they don't - -- appear explicitly. + -- We need a special case for operators, since they don't appear + -- explicitly. if Ctype = Type_Conformant then if Ekind (New_Id) = E_Operator @@ -1831,7 +3034,22 @@ package body Sem_Ch6 is and then New_Type /= Standard_Void_Type then if not Conforming_Types (Old_Type, New_Type, Ctype, Get_Inst) then - Conformance_Error ("return type does not match!", New_Id); + Conformance_Error ("\return type does not match!", New_Id); + return; + end if; + + -- Ada 2005 (AI-231): In case of anonymous access types check the + -- null-exclusion and access-to-constant attributes match. + + if Ada_Version >= Ada_05 + and then Ekind (Etype (Old_Type)) = E_Anonymous_Access_Type + and then + (Can_Never_Be_Null (Old_Type) + /= Can_Never_Be_Null (New_Type) + or else Is_Access_Constant (Etype (Old_Type)) + /= Is_Access_Constant (Etype (New_Type))) + then + Conformance_Error ("\return type does not match!", New_Id); return; end if; @@ -1840,18 +3058,17 @@ package body Sem_Ch6 is elsif Old_Type /= Standard_Void_Type or else New_Type /= Standard_Void_Type then - Conformance_Error ("functions can only match functions!", New_Id); + Conformance_Error ("\functions can only match functions!", New_Id); return; end if; - -- In subtype conformant case, conventions must match (RM 6.3.1(16)) + -- In subtype conformant case, conventions must match (RM 6.3.1(16)). -- If this is a renaming as body, refine error message to indicate that -- the conflict is with the original declaration. If the entity is not -- frozen, the conventions don't have to match, the one of the renamed -- entity is inherited. if Ctype >= Subtype_Conformant then - if Convention (Old_Id) /= Convention (New_Id) then if not Is_Frozen (New_Id) then @@ -1865,10 +3082,10 @@ package body Sem_Ch6 is Error_Msg_Name_2 := Name_Ada + Convention_Id'Pos (Convention (New_Id)); - Conformance_Error ("prior declaration for% has convention %!"); + Conformance_Error ("\prior declaration for% has convention %!"); else - Conformance_Error ("calling conventions do not match!"); + Conformance_Error ("\calling conventions do not match!"); end if; return; @@ -1876,7 +3093,7 @@ package body Sem_Ch6 is elsif Is_Formal_Subprogram (Old_Id) or else Is_Formal_Subprogram (New_Id) then - Conformance_Error ("formal subprograms not allowed!"); + Conformance_Error ("\formal subprograms not allowed!"); return; end if; end if; @@ -1892,6 +3109,95 @@ package body Sem_Ch6 is New_Formal := First_Formal (New_Id); while Present (Old_Formal) and then Present (New_Formal) loop + if Is_Controlling_Formal (Old_Formal) + and then Is_Controlling_Formal (New_Formal) + and then Skip_Controlling_Formals + then + goto Skip_Controlling_Formal; + end if; + + if Ctype = Fully_Conformant then + + -- Names must match. Error message is more accurate if we do + -- this before checking that the types of the formals match. + + if Chars (Old_Formal) /= Chars (New_Formal) then + Conformance_Error ("\name & does not match!", New_Formal); + + -- Set error posted flag on new formal as well to stop + -- junk cascaded messages in some cases. + + Set_Error_Posted (New_Formal); + return; + end if; + end if; + + -- Ada 2005 (AI-423): Possible access [sub]type and itype match. This + -- case occurs whenever a subprogram is being renamed and one of its + -- parameters imposes a null exclusion. For example: + + -- type T is null record; + -- type Acc_T is access T; + -- subtype Acc_T_Sub is Acc_T; + + -- procedure P (Obj : not null Acc_T_Sub); -- itype + -- procedure Ren_P (Obj : Acc_T_Sub) -- subtype + -- renames P; + + Old_Formal_Base := Etype (Old_Formal); + New_Formal_Base := Etype (New_Formal); + + if Get_Inst then + Old_Formal_Base := Get_Instance_Of (Old_Formal_Base); + New_Formal_Base := Get_Instance_Of (New_Formal_Base); + end if; + + Access_Types_Match := Ada_Version >= Ada_05 + + -- Ensure that this rule is only applied when New_Id is a + -- renaming of Old_Id. + + and then Nkind (Parent (Parent (New_Id))) = + N_Subprogram_Renaming_Declaration + and then Nkind (Name (Parent (Parent (New_Id)))) in N_Has_Entity + and then Present (Entity (Name (Parent (Parent (New_Id))))) + and then Entity (Name (Parent (Parent (New_Id)))) = Old_Id + + -- Now handle the allowed access-type case + + and then Is_Access_Type (Old_Formal_Base) + and then Is_Access_Type (New_Formal_Base) + + -- The type kinds must match. The only exception occurs with + -- multiple generics of the form: + + -- generic generic + -- type F is private; type A is private; + -- type F_Ptr is access F; type A_Ptr is access A; + -- with proc F_P (X : F_Ptr); with proc A_P (X : A_Ptr); + -- package F_Pack is ... package A_Pack is + -- package F_Inst is + -- new F_Pack (A, A_Ptr, A_P); + + -- When checking for conformance between the parameters of A_P + -- and F_P, the type kinds of F_Ptr and A_Ptr will not match + -- because the compiler has transformed A_Ptr into a subtype of + -- F_Ptr. We catch this case in the code below. + + and then (Ekind (Old_Formal_Base) = Ekind (New_Formal_Base) + or else + (Is_Generic_Type (Old_Formal_Base) + and then Is_Generic_Type (New_Formal_Base) + and then Is_Internal (New_Formal_Base) + and then Etype (Etype (New_Formal_Base)) = + Old_Formal_Base)) + and then Directly_Designated_Type (Old_Formal_Base) = + Directly_Designated_Type (New_Formal_Base) + and then ((Is_Itype (Old_Formal_Base) + and then Can_Never_Be_Null (Old_Formal_Base)) + or else + (Is_Itype (New_Formal_Base) + and then Can_Never_Be_Null (New_Formal_Base))); -- Types must always match. In the visible part of an instance, -- usual overloading rules for dispatching operations apply, and @@ -1901,42 +3207,93 @@ package body Sem_Ch6 is and then Is_Dispatching_Operation (New_Id) then if not Conforming_Types - (Base_Type (Etype (Old_Formal)), - Base_Type (Etype (New_Formal)), Ctype, Get_Inst) + (T1 => Base_Type (Etype (Old_Formal)), + T2 => Base_Type (Etype (New_Formal)), + Ctype => Ctype, + Get_Inst => Get_Inst) + and then not Access_Types_Match then - Conformance_Error ("type of & does not match!", New_Formal); + Conformance_Error ("\type of & does not match!", New_Formal); return; end if; elsif not Conforming_Types - (Etype (Old_Formal), Etype (New_Formal), Ctype, Get_Inst) + (T1 => Old_Formal_Base, + T2 => New_Formal_Base, + Ctype => Ctype, + Get_Inst => Get_Inst) + and then not Access_Types_Match then - Conformance_Error ("type of & does not match!", New_Formal); + Conformance_Error ("\type of & does not match!", New_Formal); return; end if; -- For mode conformance, mode must match - if Ctype >= Mode_Conformant - and then Parameter_Mode (Old_Formal) /= Parameter_Mode (New_Formal) - then - Conformance_Error ("mode of & does not match!", New_Formal); - return; + if Ctype >= Mode_Conformant then + if Parameter_Mode (Old_Formal) /= Parameter_Mode (New_Formal) then + Conformance_Error ("\mode of & does not match!", New_Formal); + return; + + -- Part of mode conformance for access types is having the same + -- constant modifier. + + elsif Access_Types_Match + and then Is_Access_Constant (Old_Formal_Base) /= + Is_Access_Constant (New_Formal_Base) + then + Conformance_Error + ("\constant modifier does not match!", New_Formal); + return; + end if; + end if; + + if Ctype >= Subtype_Conformant then + + -- Ada 2005 (AI-231): In case of anonymous access types check + -- the null-exclusion and access-to-constant attributes must + -- match. + + if Ada_Version >= Ada_05 + and then Ekind (Etype (Old_Formal)) = E_Anonymous_Access_Type + and then Ekind (Etype (New_Formal)) = E_Anonymous_Access_Type + and then + (Can_Never_Be_Null (Old_Formal) /= + Can_Never_Be_Null (New_Formal) + or else + Is_Access_Constant (Etype (Old_Formal)) /= + Is_Access_Constant (Etype (New_Formal))) + then + -- It is allowed to omit the null-exclusion in case of stream + -- attribute subprograms. We recognize stream subprograms + -- through their TSS-generated suffix. + + declare + TSS_Name : constant TSS_Name_Type := Get_TSS_Name (New_Id); + begin + if TSS_Name /= TSS_Stream_Read + and then TSS_Name /= TSS_Stream_Write + and then TSS_Name /= TSS_Stream_Input + and then TSS_Name /= TSS_Stream_Output + then + Conformance_Error + ("\type of & does not match!", New_Formal); + return; + end if; + end; + end if; end if; -- Full conformance checks if Ctype = Fully_Conformant then - -- Names must match + -- We have checked already that names match - if Chars (Old_Formal) /= Chars (New_Formal) then - Conformance_Error ("name & does not match!", New_Formal); - return; + if Parameter_Mode (Old_Formal) = E_In_Parameter then - -- And default expressions for in parameters + -- Check default expressions for in parameters - elsif Parameter_Mode (Old_Formal) = E_In_Parameter then declare NewD : constant Boolean := Present (Default_Value (New_Formal)); @@ -1945,15 +3302,15 @@ package body Sem_Ch6 is begin if NewD or OldD then - -- The old default value has been analyzed and expanded, - -- because the current full declaration will have frozen - -- everything before. The new default values have not - -- been expanded, so expand now to check conformance. + -- The old default value has been analyzed because the + -- current full declaration will have frozen everything + -- before. The new default value has not been analyzed, + -- so analyze it now before we check for conformance. if NewD then - New_Scope (New_Id); - Analyze_Default_Expression - (Default_Value (New_Formal), Etype (New_Formal)); + Push_Scope (New_Id); + Analyze_Per_Use_Expression + (Default_Value (New_Formal), Etype (New_Formal)); End_Scope; end if; @@ -1963,7 +3320,7 @@ package body Sem_Ch6 is Default_Value (New_Formal)) then Conformance_Error - ("default expression for & does not match!", + ("\default expression for & does not match!", New_Formal); return; end if; @@ -1973,10 +3330,10 @@ package body Sem_Ch6 is end if; -- A couple of special checks for Ada 83 mode. These checks are - -- skipped if either entity is an operator in package Standard. + -- skipped if either entity is an operator in package Standard, -- or if either old or new instance is not from the source program. - if Ada_83 + if Ada_Version = Ada_83 and then Sloc (Old_Id) > Standard_Location and then Sloc (New_Id) > Standard_Location and then Comes_From_Source (Old_Id) @@ -1994,7 +3351,7 @@ package body Sem_Ch6 is and then Ctype = Fully_Conformant then Conformance_Error - ("(Ada 83) IN must appear in both declarations", + ("\(Ada 83) IN must appear in both declarations", New_Formal); return; end if; @@ -2002,7 +3359,7 @@ package body Sem_Ch6 is -- Grouping (use of comma in param lists) must be the same -- This is where we catch a misconformance like: - -- A,B : Integer + -- A, B : Integer -- A : Integer; B : Integer -- which are represented identically in the tree except @@ -2012,27 +3369,169 @@ package body Sem_Ch6 is or else Prev_Ids (Old_Param) /= Prev_Ids (New_Param) then Conformance_Error - ("grouping of & does not match!", New_Formal); + ("\grouping of & does not match!", New_Formal); return; end if; end; end if; + -- This label is required when skipping controlling formals + + <> + Next_Formal (Old_Formal); Next_Formal (New_Formal); end loop; if Present (Old_Formal) then - Conformance_Error ("too few parameters!"); + Conformance_Error ("\too few parameters!"); return; elsif Present (New_Formal) then - Conformance_Error ("too many parameters!", New_Formal); + Conformance_Error ("\too many parameters!", New_Formal); return; end if; - end Check_Conformance; + ----------------------- + -- Check_Conventions -- + ----------------------- + + procedure Check_Conventions (Typ : Entity_Id) is + + function Skip_Check (Op : Entity_Id) return Boolean; + pragma Inline (Skip_Check); + -- A small optimization: skip the predefined dispatching operations, + -- since they always have the same convention. Also do not consider + -- abstract primitives since those are left by an erroneous overriding. + -- This function returns True for any operation that is thus exempted + -- exempted from checking. + + procedure Check_Convention + (Op : Entity_Id; + Search_From : Elmt_Id); + -- Verify that the convention of inherited dispatching operation Op is + -- consistent among all subprograms it overrides. In order to minimize + -- the search, Search_From is utilized to designate a specific point in + -- the list rather than iterating over the whole list once more. + + ---------------------- + -- Check_Convention -- + ---------------------- + + procedure Check_Convention + (Op : Entity_Id; + Search_From : Elmt_Id) + is + procedure Error_Msg_Operation (Op : Entity_Id); + -- Emit a continuation to an error message depicting the kind, name, + -- convention and source location of subprogram Op. + + ------------------------- + -- Error_Msg_Operation -- + ------------------------- + + procedure Error_Msg_Operation (Op : Entity_Id) is + begin + Error_Msg_Name_1 := Chars (Op); + + -- Error messages of primitive subprograms do not contain a + -- convention attribute since the convention may have been first + -- inherited from a parent subprogram, then changed by a pragma. + + if Comes_From_Source (Op) then + Error_Msg_Sloc := Sloc (Op); + Error_Msg_N + ("\ primitive % defined #", Typ); + + else + Error_Msg_Name_2 := Get_Convention_Name (Convention (Op)); + + if Present (Abstract_Interface_Alias (Op)) then + Error_Msg_Sloc := Sloc (Abstract_Interface_Alias (Op)); + Error_Msg_N ("\\overridden operation % with " & + "convention % defined #", Typ); + + else pragma Assert (Present (Alias (Op))); + Error_Msg_Sloc := Sloc (Alias (Op)); + Error_Msg_N ("\\inherited operation % with " & + "convention % defined #", Typ); + end if; + end if; + end Error_Msg_Operation; + + -- Local variables + + Second_Prim_Op : Entity_Id; + Second_Prim_Op_Elmt : Elmt_Id; + + -- Start of processing for Check_Convention + + begin + Second_Prim_Op_Elmt := Next_Elmt (Search_From); + while Present (Second_Prim_Op_Elmt) loop + Second_Prim_Op := Node (Second_Prim_Op_Elmt); + + if not Skip_Check (Second_Prim_Op) + and then Chars (Second_Prim_Op) = Chars (Op) + and then Type_Conformant (Second_Prim_Op, Op) + and then Convention (Second_Prim_Op) /= Convention (Op) + then + Error_Msg_N + ("inconsistent conventions in primitive operations", Typ); + + Error_Msg_Operation (Op); + Error_Msg_Operation (Second_Prim_Op); + + -- Avoid cascading errors + + return; + end if; + + Next_Elmt (Second_Prim_Op_Elmt); + end loop; + end Check_Convention; + + ---------------- + -- Skip_Check -- + ---------------- + + function Skip_Check (Op : Entity_Id) return Boolean is + begin + return Is_Predefined_Dispatching_Operation (Op) + or else Is_Abstract_Subprogram (Op); + end Skip_Check; + + -- Local variables + + Prim_Op : Entity_Id; + Prim_Op_Elmt : Elmt_Id; + + -- Start of processing for Check_Conventions + + begin + -- The algorithm checks every overriding dispatching operation against + -- all the corresponding overridden dispatching operations, detecting + -- differences in coventions. + + Prim_Op_Elmt := First_Elmt (Primitive_Operations (Typ)); + while Present (Prim_Op_Elmt) loop + Prim_Op := Node (Prim_Op_Elmt); + + -- A small optimization: skip the predefined dispatching operations + -- since they always have the same convention. Also avoid processing + -- of abstract primitives left from an erroneous overriding. + + if not Skip_Check (Prim_Op) then + Check_Convention + (Op => Prim_Op, + Search_From => Prim_Op_Elmt); + end if; + + Next_Elmt (Prim_Op_Elmt); + end loop; + end Check_Conventions; + ------------------------------ -- Check_Delayed_Subprogram -- ------------------------------ @@ -2045,6 +3544,10 @@ package body Sem_Ch6 is -- If T is not yet frozen and needs a delayed freeze, then the -- subprogram itself must be delayed. + --------------------- + -- Possible_Freeze -- + --------------------- + procedure Possible_Freeze (T : Entity_Id) is begin if Has_Delayed_Freeze (T) @@ -2065,7 +3568,9 @@ package body Sem_Ch6 is begin -- Never need to freeze abstract subprogram - if Is_Abstract (Designator) then + if Ekind (Designator) /= E_Subprogram_Type + and then Is_Abstract_Subprogram (Designator) + then null; else -- Need delayed freeze if return type itself needs a delayed @@ -2097,10 +3602,10 @@ package body Sem_Ch6 is Utyp : constant Entity_Id := Underlying_Type (Typ); begin - if Is_Return_By_Reference_Type (Typ) then + if Is_Inherently_Limited_Type (Typ) then Set_Returns_By_Ref (Designator); - elsif Present (Utyp) and then Controlled_Type (Utyp) then + elsif Present (Utyp) and then CW_Or_Controlled_Type (Utyp) then Set_Returns_By_Ref (Designator); end if; end; @@ -2122,12 +3627,11 @@ package body Sem_Ch6 is New_Discr_Type : Entity_Id; procedure Conformance_Error (Msg : String; N : Node_Id); - -- Post error message for conformance error on given node. - -- Two messages are output. The first points to the previous - -- declaration with a general "no conformance" message. - -- The second is the detailed reason, supplied as Msg. The - -- parameter N provide information for a possible & insertion - -- in the message. + -- Post error message for conformance error on given node. Two messages + -- are output. The first points to the previous declaration with a + -- general "no conformance" message. The second is the detailed reason, + -- supplied as Msg. The parameter N provide information for a possible + -- & insertion in the message. ----------------------- -- Conformance_Error -- @@ -2147,9 +3651,9 @@ package body Sem_Ch6 is New_Discr_Id := Defining_Identifier (New_Discr); - -- The subtype mark of the discriminant on the full type - -- has not been analyzed so we do it here. For an access - -- discriminant a new type is created. + -- The subtype mark of the discriminant on the full type has not + -- been analyzed so we do it here. For an access discriminant a new + -- type is created. if Nkind (Discriminant_Type (New_Discr)) = N_Access_Definition then New_Discr_Type := @@ -2165,6 +3669,14 @@ package body Sem_Ch6 is then Conformance_Error ("type of & does not match!", New_Discr_Id); return; + else + -- Treat the new discriminant as an occurrence of the old one, + -- for navigation purposes, and fill in some semantic + -- information, for completeness. + + Generate_Reference (Old_Discr, New_Discr_Id, 'r'); + Set_Etype (New_Discr_Id, Etype (Old_Discr)); + Set_Scope (New_Discr_Id, Scope (Old_Discr)); end if; -- Names must match @@ -2187,11 +3699,11 @@ package body Sem_Ch6 is -- The old default value has been analyzed and expanded, -- because the current full declaration will have frozen - -- everything before. The new default values have not - -- been expanded, so expand now to check conformance. + -- everything before. The new default values have not been + -- expanded, so expand now to check conformance. if NewD then - Analyze_Default_Expression + Analyze_Per_Use_Expression (Expression (New_Discr), New_Discr_Type); end if; @@ -2211,7 +3723,7 @@ package body Sem_Ch6 is -- In Ada 83 case, grouping must match: (A,B : X) /= (A : X; B : X) - if Ada_83 then + if Ada_Version = Ada_83 then declare Old_Disc : constant Node_Id := Declaration_Node (Old_Discr); @@ -2260,37 +3772,146 @@ package body Sem_Ch6 is Err_Loc : Node_Id := Empty) is Result : Boolean; + pragma Warnings (Off, Result); + begin + Check_Conformance + (New_Id, Old_Id, Fully_Conformant, True, Result, Err_Loc); + end Check_Fully_Conformant; + + --------------------------- + -- Check_Mode_Conformant -- + --------------------------- + + procedure Check_Mode_Conformant + (New_Id : Entity_Id; + Old_Id : Entity_Id; + Err_Loc : Node_Id := Empty; + Get_Inst : Boolean := False) + is + Result : Boolean; + pragma Warnings (Off, Result); + begin + Check_Conformance + (New_Id, Old_Id, Mode_Conformant, True, Result, Err_Loc, Get_Inst); + end Check_Mode_Conformant; + + -------------------------------- + -- Check_Overriding_Indicator -- + -------------------------------- + + procedure Check_Overriding_Indicator + (Subp : Entity_Id; + Overridden_Subp : Entity_Id; + Is_Primitive : Boolean) + is + Decl : Node_Id; + Spec : Node_Id; + + begin + -- No overriding indicator for literals + + if Ekind (Subp) = E_Enumeration_Literal then + return; + + elsif Ekind (Subp) = E_Entry then + Decl := Parent (Subp); + + else + Decl := Unit_Declaration_Node (Subp); + end if; + + if Nkind_In (Decl, N_Subprogram_Body, + N_Subprogram_Body_Stub, + N_Subprogram_Declaration, + N_Abstract_Subprogram_Declaration, + N_Subprogram_Renaming_Declaration) + then + Spec := Specification (Decl); + + elsif Nkind (Decl) = N_Entry_Declaration then + Spec := Decl; + + else + return; + end if; + + if Present (Overridden_Subp) then + if Must_Not_Override (Spec) then + Error_Msg_Sloc := Sloc (Overridden_Subp); + + if Ekind (Subp) = E_Entry then + Error_Msg_NE + ("entry & overrides inherited operation #", Spec, Subp); + else + Error_Msg_NE + ("subprogram & overrides inherited operation #", Spec, Subp); + end if; + end if; + + -- If Subp is an operator, it may override a predefined operation. + -- In that case overridden_subp is empty because of our implicit + -- representation for predefined operators. We have to check whether the + -- signature of Subp matches that of a predefined operator. Note that + -- first argument provides the name of the operator, and the second + -- argument the signature that may match that of a standard operation. + + elsif Nkind (Subp) = N_Defining_Operator_Symbol + and then Must_Not_Override (Spec) + then + if Operator_Matches_Spec (Subp, Subp) then + Error_Msg_NE + ("subprogram & overrides predefined operator ", + Spec, Subp); + end if; + + elsif Must_Override (Spec) then + if Ekind (Subp) = E_Entry then + Error_Msg_NE ("entry & is not overriding", Spec, Subp); - begin - Check_Conformance - (New_Id, Old_Id, Fully_Conformant, True, Result, Err_Loc); - end Check_Fully_Conformant; + elsif Nkind (Subp) = N_Defining_Operator_Symbol then + if not Operator_Matches_Spec (Subp, Subp) then + Error_Msg_NE + ("subprogram & is not overriding", Spec, Subp); + end if; - --------------------------- - -- Check_Mode_Conformant -- - --------------------------- + else + Error_Msg_NE ("subprogram & is not overriding", Spec, Subp); + end if; - procedure Check_Mode_Conformant - (New_Id : Entity_Id; - Old_Id : Entity_Id; - Err_Loc : Node_Id := Empty; - Get_Inst : Boolean := False) - is - Result : Boolean; + -- If the operation is marked "not overriding" and it's not primitive + -- then an error is issued, unless this is an operation of a task or + -- protected type (RM05-8.3.1(3/2-4/2)). Error cases where "overriding" + -- has been specified have already been checked above. - begin - Check_Conformance - (New_Id, Old_Id, Mode_Conformant, True, Result, Err_Loc, Get_Inst); - end Check_Mode_Conformant; + elsif Must_Not_Override (Spec) + and then not Is_Primitive + and then Ekind (Subp) /= E_Entry + and then Ekind (Scope (Subp)) /= E_Protected_Type + then + Error_Msg_N + ("overriding indicator only allowed if subprogram is primitive", + Subp); + + return; + end if; + end Check_Overriding_Indicator; ------------------- -- Check_Returns -- ------------------- + -- Note: this procedure needs to know far too much about how the expander + -- messes with exceptions. The use of the flag Exception_Junk and the + -- incorporation of knowledge of Exp_Ch11.Expand_Local_Exception_Handlers + -- works, but is not very clean. It would be better if the expansion + -- routines would leave Original_Node working nicely, and we could use + -- Original_Node here to ignore all the peculiar expander messing ??? + procedure Check_Returns (HSS : Node_Id; Mode : Character; - Err : out Boolean) + Err : out Boolean; + Proc : Entity_Id := Empty) is Handler : Node_Id; @@ -2305,6 +3926,7 @@ package body Sem_Ch6 is procedure Check_Statement_Sequence (L : List_Id) is Last_Stm : Node_Id; + Stm : Node_Id; Kind : Node_Kind; Raise_Exception_Call : Boolean; @@ -2318,6 +3940,65 @@ package body Sem_Ch6 is Last_Stm := Last (L); + -- Deal with digging out exception handler statement sequences that + -- have been transformed by the local raise to goto optimization. + -- See Exp_Ch11.Expand_Local_Exception_Handlers for details. If this + -- optimization has occurred, we are looking at something like: + + -- begin + -- original stmts in block + + -- exception \ + -- when excep1 => | + -- goto L1; | omitted if No_Exception_Propagation + -- when excep2 => | + -- goto L2; / + -- end; + + -- goto L3; -- skip handler when exception not raised + + -- <> -- target label for local exception + -- begin + -- estmts1 + -- end; + + -- goto L3; + + -- <> + -- begin + -- estmts2 + -- end; + + -- <> + + -- and what we have to do is to dig out the estmts1 and estmts2 + -- sequences (which were the original sequences of statements in + -- the exception handlers) and check them. + + if Nkind (Last_Stm) = N_Label + and then Exception_Junk (Last_Stm) + then + Stm := Last_Stm; + loop + Prev (Stm); + exit when No (Stm); + exit when Nkind (Stm) /= N_Block_Statement; + exit when not Exception_Junk (Stm); + Prev (Stm); + exit when No (Stm); + exit when Nkind (Stm) /= N_Label; + exit when not Exception_Junk (Stm); + Check_Statement_Sequence + (Statements (Handled_Statement_Sequence (Next (Stm)))); + + Prev (Stm); + Last_Stm := Stm; + exit when No (Stm); + exit when Nkind (Stm) /= N_Goto_Statement; + exit when not Exception_Junk (Stm); + end loop; + end if; + -- Don't count pragmas while Nkind (Last_Stm) = N_Pragma @@ -2334,10 +4015,12 @@ package body Sem_Ch6 is -- Don't count exception junk or else - ((Nkind (Last_Stm) = N_Goto_Statement - or else Nkind (Last_Stm) = N_Label - or else Nkind (Last_Stm) = N_Object_Declaration) - and then Exception_Junk (Last_Stm)) + (Nkind_In (Last_Stm, N_Goto_Statement, + N_Label, + N_Object_Declaration) + and then Exception_Junk (Last_Stm)) + or else Nkind (Last_Stm) in N_Push_xxx_Label + or else Nkind (Last_Stm) in N_Pop_xxx_Label loop Prev (Last_Stm); end loop; @@ -2367,6 +4050,9 @@ package body Sem_Ch6 is -- missing return curious, and raising Program_Error does not -- seem such a bad behavior if this does occur. + -- Note that in the Ada 2005 case for Raise_Exception, the actual + -- behavior will be to raise Constraint_Error (see AI-329). + if Is_RTE (Entity (Name (Last_Stm)), RE_Raise_Exception) or else Is_RTE (Entity (Name (Last_Stm)), RE_Reraise_Occurrence) @@ -2380,7 +4066,6 @@ package body Sem_Ch6 is declare Arg : constant Node_Id := Original_Node (First_Actual (Last_Stm)); - begin if Nkind (Arg) = N_Attribute_Reference and then Attribute_Name (Arg) = Name_Identity @@ -2418,7 +4103,6 @@ package body Sem_Ch6 is elsif Kind = N_Case_Statement then declare Case_Alt : Node_Id; - begin Case_Alt := First_Non_Pragma (Alternatives (Last_Stm)); while Present (Case_Alt) loop @@ -2535,13 +4219,12 @@ package body Sem_Ch6 is -- If we fall through, issue appropriate message if Mode = 'F' then - if not Raise_Exception_Call then Error_Msg_N ("?RETURN statement missing following this statement!", Last_Stm); Error_Msg_N - ("\?Program_Error may be raised at run time", + ("\?Program_Error may be raised at run time!", Last_Stm); end if; @@ -2552,10 +4235,27 @@ package body Sem_Ch6 is Err := True; + -- Otherwise we have the case of a procedure marked No_Return + else - Error_Msg_N - ("implied return after this statement not allowed (No_Return)", - Last_Stm); + if not Raise_Exception_Call then + Error_Msg_N + ("?implied return after this statement " & + "will raise Program_Error", + Last_Stm); + Error_Msg_NE + ("\?procedure & is marked as No_Return!", + Last_Stm, Proc); + end if; + + declare + RE : constant Node_Id := + Make_Raise_Program_Error (Sloc (Last_Stm), + Reason => PE_Implicit_Return); + begin + Insert_After (Last_Stm, RE); + Analyze (RE); + end; end if; end Check_Statement_Sequence; @@ -2584,6 +4284,10 @@ package body Sem_Ch6 is -- This is used to check if S1 > S2 in the sense required by this -- test, for example nameab < namec, but name2 < name10. + ----------------------------- + -- Subprogram_Name_Greater -- + ----------------------------- + function Subprogram_Name_Greater (S1, S2 : String) return Boolean is L1, L2 : Positive; N1, N2 : Natural; @@ -2634,7 +4338,8 @@ package body Sem_Ch6 is begin -- Check body in alpha order if this is option - if Style_Check_Subprogram_Order + if Style_Check + and then Style_Check_Order_Subprograms and then Nkind (N) = N_Subprogram_Body and then Comes_From_Source (N) and then In_Extended_Main_Source_Unit (N) @@ -2675,7 +4380,7 @@ package body Sem_Ch6 is Err_Loc : Node_Id := Empty) is Result : Boolean; - + pragma Warnings (Off, Result); begin Check_Conformance (New_Id, Old_Id, Subtype_Conformant, True, Result, Err_Loc); @@ -2691,7 +4396,7 @@ package body Sem_Ch6 is Err_Loc : Node_Id := Empty) is Result : Boolean; - + pragma Warnings (Off, Result); begin Check_Conformance (New_Id, Old_Id, Type_Conformant, True, Result, Err_Loc); @@ -2705,20 +4410,33 @@ package body Sem_Ch6 is (T1 : Entity_Id; T2 : Entity_Id; Ctype : Conformance_Type; - Get_Inst : Boolean := False) - return Boolean + Get_Inst : Boolean := False) return Boolean is Type_1 : Entity_Id := T1; Type_2 : Entity_Id := T2; + Are_Anonymous_Access_To_Subprogram_Types : Boolean := False; function Base_Types_Match (T1, T2 : Entity_Id) return Boolean; - -- If neither T1 nor T2 are generic actual types, or if they are - -- in different scopes (e.g. parent and child instances), then verify - -- that the base types are equal. Otherwise T1 and T2 must be - -- on the same subtype chain. The whole purpose of this procedure - -- is to prevent spurious ambiguities in an instantiation that may - -- arise if two distinct generic types are instantiated with the - -- same actual. + -- If neither T1 nor T2 are generic actual types, or if they are in + -- different scopes (e.g. parent and child instances), then verify that + -- the base types are equal. Otherwise T1 and T2 must be on the same + -- subtype chain. The whole purpose of this procedure is to prevent + -- spurious ambiguities in an instantiation that may arise if two + -- distinct generic types are instantiated with the same actual. + + function Find_Designated_Type (T : Entity_Id) return Entity_Id; + -- An access parameter can designate an incomplete type. If the + -- incomplete type is the limited view of a type from a limited_ + -- with_clause, check whether the non-limited view is available. If + -- it is a (non-limited) incomplete type, get the full view. + + function Matches_Limited_With_View (T1, T2 : Entity_Id) return Boolean; + -- Returns True if and only if either T1 denotes a limited view of T2 + -- or T2 denotes a limited view of T1. This can arise when the limited + -- with view of a type is used in a subprogram declaration and the + -- subprogram body is in the scope of a regular with clause for the + -- same unit. In such a case, the two type entities can be considered + -- identical for purposes of conformance checking. ---------------------- -- Base_Types_Match -- @@ -2731,7 +4449,7 @@ package body Sem_Ch6 is elsif Base_Type (T1) = Base_Type (T2) then - -- The following is too permissive. A more precise test must + -- The following is too permissive. A more precise test should -- check that the generic actual is an ancestor subtype of the -- other ???. @@ -2744,20 +4462,80 @@ package body Sem_Ch6 is end if; end Base_Types_Match; + -------------------------- + -- Find_Designated_Type -- + -------------------------- + + function Find_Designated_Type (T : Entity_Id) return Entity_Id is + Desig : Entity_Id; + + begin + Desig := Directly_Designated_Type (T); + + if Ekind (Desig) = E_Incomplete_Type then + + -- If regular incomplete type, get full view if available + + if Present (Full_View (Desig)) then + Desig := Full_View (Desig); + + -- If limited view of a type, get non-limited view if available, + -- and check again for a regular incomplete type. + + elsif Present (Non_Limited_View (Desig)) then + Desig := Get_Full_View (Non_Limited_View (Desig)); + end if; + end if; + + return Desig; + end Find_Designated_Type; + + ------------------------------- + -- Matches_Limited_With_View -- + ------------------------------- + + function Matches_Limited_With_View (T1, T2 : Entity_Id) return Boolean is + begin + -- In some cases a type imported through a limited_with clause, and + -- its nonlimited view are both visible, for example in an anonymous + -- access-to-class-wide type in a formal. Both entities designate the + -- same type. + + if From_With_Type (T1) + and then T2 = Available_View (T1) + then + return True; + + elsif From_With_Type (T2) + and then T1 = Available_View (T2) + then + return True; + + else + return False; + end if; + end Matches_Limited_With_View; + + -- Start of processing for Conforming_Types + begin -- The context is an instance association for a formal - -- access-to-subprogram type; the formal parameter types - -- require mapping because they may denote other formal - -- parameters of the generic unit. + -- access-to-subprogram type; the formal parameter types require + -- mapping because they may denote other formal parameters of the + -- generic unit. if Get_Inst then Type_1 := Get_Instance_Of (T1); Type_2 := Get_Instance_Of (T2); end if; - -- First see if base types match + -- If one of the types is a view of the other introduced by a limited + -- with clause, treat these as conforming for all purposes. + + if Matches_Limited_With_View (T1, T2) then + return True; - if Base_Types_Match (Type_1, Type_2) then + elsif Base_Types_Match (Type_1, Type_2) then return Ctype <= Mode_Conformant or else Subtypes_Statically_Match (Type_1, Type_2); @@ -2774,73 +4552,123 @@ package body Sem_Ch6 is then return Ctype <= Mode_Conformant or else Subtypes_Statically_Match (Type_1, Full_View (Type_2)); + + elsif Is_Private_Type (Type_2) + and then In_Instance + and then Present (Full_View (Type_2)) + and then Base_Types_Match (Type_1, Full_View (Type_2)) + then + return Ctype <= Mode_Conformant + or else Subtypes_Statically_Match (Type_1, Full_View (Type_2)); end if; - -- Test anonymous access type case. For this case, static subtype - -- matching is required for mode conformance (RM 6.3.1(15)) + -- Ada 2005 (AI-254): Anonymous access-to-subprogram types must be + -- treated recursively because they carry a signature. + + Are_Anonymous_Access_To_Subprogram_Types := + Ekind (Type_1) = Ekind (Type_2) + and then + (Ekind (Type_1) = E_Anonymous_Access_Subprogram_Type + or else + Ekind (Type_1) = E_Anonymous_Access_Protected_Subprogram_Type); - if Ekind (Type_1) = E_Anonymous_Access_Type - and then Ekind (Type_2) = E_Anonymous_Access_Type + -- Test anonymous access type case. For this case, static subtype + -- matching is required for mode conformance (RM 6.3.1(15)). We check + -- the base types because we may have built internal subtype entities + -- to handle null-excluding types (see Process_Formals). + + if (Ekind (Base_Type (Type_1)) = E_Anonymous_Access_Type + and then + Ekind (Base_Type (Type_2)) = E_Anonymous_Access_Type) + or else Are_Anonymous_Access_To_Subprogram_Types -- Ada 2005 (AI-254) then declare Desig_1 : Entity_Id; Desig_2 : Entity_Id; begin - Desig_1 := Directly_Designated_Type (Type_1); - - -- An access parameter can designate an incomplete type. + -- In Ada2005, access constant indicators must match for + -- subtype conformance. - if Ekind (Desig_1) = E_Incomplete_Type - and then Present (Full_View (Desig_1)) + if Ada_Version >= Ada_05 + and then Ctype >= Subtype_Conformant + and then + Is_Access_Constant (Type_1) /= Is_Access_Constant (Type_2) then - Desig_1 := Full_View (Desig_1); + return False; end if; - Desig_2 := Directly_Designated_Type (Type_2); + Desig_1 := Find_Designated_Type (Type_1); - if Ekind (Desig_2) = E_Incomplete_Type - and then Present (Full_View (Desig_2)) - then - Desig_2 := Full_View (Desig_2); - end if; + Desig_2 := Find_Designated_Type (Type_2); - -- The context is an instance association for a formal - -- access-to-subprogram type; formal access parameter - -- designated types require mapping because they may - -- denote other formal parameters of the generic unit. + -- If the context is an instance association for a formal + -- access-to-subprogram type; formal access parameter designated + -- types require mapping because they may denote other formal + -- parameters of the generic unit. if Get_Inst then Desig_1 := Get_Instance_Of (Desig_1); Desig_2 := Get_Instance_Of (Desig_2); end if; - -- It is possible for a Class_Wide_Type to be introduced for - -- an incomplete type, in which case there is a separate class_ - -- wide type for the full view. The types conform if their - -- Etypes conform, i.e. one may be the full view of the other. - -- This can only happen in the context of an access parameter, - -- other uses of an incomplete Class_Wide_Type are illegal. + -- It is possible for a Class_Wide_Type to be introduced for an + -- incomplete type, in which case there is a separate class_ wide + -- type for the full view. The types conform if their Etypes + -- conform, i.e. one may be the full view of the other. This can + -- only happen in the context of an access parameter, other uses + -- of an incomplete Class_Wide_Type are illegal. - if Ekind (Desig_1) = E_Class_Wide_Type - and then Ekind (Desig_2) = E_Class_Wide_Type + if Is_Class_Wide_Type (Desig_1) + and then Is_Class_Wide_Type (Desig_2) then return - Conforming_Types (Etype (Desig_1), Etype (Desig_2), Ctype); + Conforming_Types + (Etype (Base_Type (Desig_1)), + Etype (Base_Type (Desig_2)), Ctype); + + elsif Are_Anonymous_Access_To_Subprogram_Types then + if Ada_Version < Ada_05 then + return Ctype = Type_Conformant + or else + Subtypes_Statically_Match (Desig_1, Desig_2); + + -- We must check the conformance of the signatures themselves + + else + declare + Conformant : Boolean; + begin + Check_Conformance + (Desig_1, Desig_2, Ctype, False, Conformant); + return Conformant; + end; + end if; + else return Base_Type (Desig_1) = Base_Type (Desig_2) and then (Ctype = Type_Conformant - or else - Subtypes_Statically_Match (Desig_1, Desig_2)); + or else + Subtypes_Statically_Match (Desig_1, Desig_2)); end if; end; -- Otherwise definitely no match else + if ((Ekind (Type_1) = E_Anonymous_Access_Type + and then Is_Access_Type (Type_2)) + or else (Ekind (Type_2) = E_Anonymous_Access_Type + and then Is_Access_Type (Type_1))) + and then + Conforming_Types + (Designated_Type (Type_1), Designated_Type (Type_2), Ctype) + then + May_Hide_Profile := True; + end if; + return False; end if; - end Conforming_Types; -------------------------- @@ -2849,32 +4677,41 @@ package body Sem_Ch6 is procedure Create_Extra_Formals (E : Entity_Id) is Formal : Entity_Id; - Last_Formal : Entity_Id; + First_Extra : Entity_Id := Empty; Last_Extra : Entity_Id; Formal_Type : Entity_Id; P_Formal : Entity_Id := Empty; - function Add_Extra_Formal (Typ : Entity_Id) return Entity_Id; - -- Add an extra formal, associated with the current Formal. The - -- extra formal is added to the list of extra formals, and also - -- returned as the result. These formals are always of mode IN. + function Add_Extra_Formal + (Assoc_Entity : Entity_Id; + Typ : Entity_Id; + Scope : Entity_Id; + Suffix : String) return Entity_Id; + -- Add an extra formal to the current list of formals and extra formals. + -- The extra formal is added to the end of the list of extra formals, + -- and also returned as the result. These formals are always of mode IN. + -- The new formal has the type Typ, is declared in Scope, and its name + -- is given by a concatenation of the name of Assoc_Entity and Suffix. + + ---------------------- + -- Add_Extra_Formal -- + ---------------------- - function Add_Extra_Formal (Typ : Entity_Id) return Entity_Id is + function Add_Extra_Formal + (Assoc_Entity : Entity_Id; + Typ : Entity_Id; + Scope : Entity_Id; + Suffix : String) return Entity_Id + is EF : constant Entity_Id := - Make_Defining_Identifier (Sloc (Formal), - Chars => New_External_Name (Chars (Formal), 'F')); + Make_Defining_Identifier (Sloc (Assoc_Entity), + Chars => New_External_Name (Chars (Assoc_Entity), + Suffix => Suffix)); begin - -- We never generate extra formals if expansion is not active - -- because we don't need them unless we are generating code. - - if not Expander_Active then - return Empty; - end if; - - -- A little optimization. Never generate an extra formal for - -- the _init operand of an initialization procedure, since it - -- could never be used. + -- A little optimization. Never generate an extra formal for the + -- _init operand of an initialization procedure, since it could + -- never be used. if Chars (Formal) = Name_uInit then return Empty; @@ -2883,21 +4720,37 @@ package body Sem_Ch6 is Set_Ekind (EF, E_In_Parameter); Set_Actual_Subtype (EF, Typ); Set_Etype (EF, Typ); - Set_Scope (EF, Scope (Formal)); + Set_Scope (EF, Scope); Set_Mechanism (EF, Default_Mechanism); Set_Formal_Validity (EF); - Set_Extra_Formal (Last_Extra, EF); + if No (First_Extra) then + First_Extra := EF; + Set_Extra_Formals (Scope, First_Extra); + end if; + + if Present (Last_Extra) then + Set_Extra_Formal (Last_Extra, EF); + end if; + Last_Extra := EF; + return EF; end Add_Extra_Formal; -- Start of processing for Create_Extra_Formals begin - -- If this is a derived subprogram then the subtypes of the - -- parent subprogram's formal parameters will be used to - -- to determine the need for extra formals. + -- We never generate extra formals if expansion is not active + -- because we don't need them unless we are generating code. + + if not Expander_Active then + return; + end if; + + -- If this is a derived subprogram then the subtypes of the parent + -- subprogram's formal parameters will be used to to determine the need + -- for extra formals. if Is_Overloadable (E) and then Present (Alias (E)) then P_Formal := First_Formal (Alias (E)); @@ -2910,9 +4763,9 @@ package body Sem_Ch6 is Next_Formal (Formal); end loop; - -- If Extra_formals where already created, don't do it again - -- This situation may arise for subprogram types created as part - -- of dispatching calls (see Expand_Dispatch_Call) + -- If Extra_formals were already created, don't do it again. This + -- situation may arise for subprogram types created as part of + -- dispatching calls (see Expand_Dispatching_Call) if Present (Last_Extra) and then Present (Extra_Formal (Last_Extra)) @@ -2920,8 +4773,18 @@ package body Sem_Ch6 is return; end if; - Formal := First_Formal (E); + -- If the subprogram is a predefined dispatching subprogram then don't + -- generate any extra constrained or accessibility level formals. In + -- general we suppress these for internal subprograms (by not calling + -- Freeze_Subprogram and Create_Extra_Formals at all), but internally + -- generated stream attributes do get passed through because extra + -- build-in-place formals are needed in some cases (limited 'Input). + if Is_Predefined_Dispatching_Operation (E) then + goto Test_For_BIP_Extras; + end if; + + Formal := First_Formal (E); while Present (Formal) loop -- Create extra formal for supporting the attribute 'Constrained. @@ -2936,6 +4799,13 @@ package body Sem_Ch6 is Formal_Type := Etype (Formal); end if; + -- Do not produce extra formals for Unchecked_Union parameters. + -- Jump directly to the end of the loop. + + if Is_Unchecked_Union (Base_Type (Formal_Type)) then + goto Skip_Extra_Formal_Generation; + end if; + if not Has_Discriminants (Formal_Type) and then Ekind (Formal_Type) in Private_Kind and then Present (Underlying_Type (Formal_Type)) @@ -2944,54 +4814,170 @@ package body Sem_Ch6 is end if; if Has_Discriminants (Formal_Type) - and then - ((not Is_Constrained (Formal_Type) - and then not Is_Indefinite_Subtype (Formal_Type)) - or else Present (Extra_Formal (Formal))) + and then not Is_Constrained (Formal_Type) + and then not Is_Indefinite_Subtype (Formal_Type) then Set_Extra_Constrained - (Formal, Add_Extra_Formal (Standard_Boolean)); + (Formal, Add_Extra_Formal (Formal, Standard_Boolean, E, "F")); end if; end if; - -- Create extra formal for supporting accessibility checking + -- Create extra formal for supporting accessibility checking. This + -- is done for both anonymous access formals and formals of named + -- access types that are marked as controlling formals. The latter + -- case can occur when Expand_Dispatching_Call creates a subprogram + -- type and substitutes the types of access-to-class-wide actuals + -- for the anonymous access-to-specific-type of controlling formals. + -- Base_Type is applied because in cases where there is a null + -- exclusion the formal may have an access subtype. -- This is suppressed if we specifically suppress accessibility - -- checks for either the subprogram, or the package in which it - -- resides. However, we do not suppress it simply if the scope - -- has accessibility checks suppressed, since this could cause - -- trouble when clients are compiled with a different suppression - -- setting. The explicit checks are safe from this point of view. - - if Ekind (Etype (Formal)) = E_Anonymous_Access_Type + -- checks at the package level for either the subprogram, or the + -- package in which it resides. However, we do not suppress it + -- simply if the scope has accessibility checks suppressed, since + -- this could cause trouble when clients are compiled with a + -- different suppression setting. The explicit checks at the + -- package level are safe from this point of view. + + if (Ekind (Base_Type (Etype (Formal))) = E_Anonymous_Access_Type + or else (Is_Controlling_Formal (Formal) + and then Is_Access_Type (Base_Type (Etype (Formal))))) and then not - (Suppress_Accessibility_Checks (E) + (Explicit_Suppress (E, Accessibility_Check) or else - Suppress_Accessibility_Checks (Scope (E))) + Explicit_Suppress (Scope (E), Accessibility_Check)) and then - (not Present (P_Formal) + (No (P_Formal) or else Present (Extra_Accessibility (P_Formal))) then - -- Temporary kludge: for now we avoid creating the extra - -- formal for access parameters of protected operations - -- because of problem with the case of internal protected - -- calls. ??? + -- Temporary kludge: for now we avoid creating the extra formal + -- for access parameters of protected operations because of + -- problem with the case of internal protected calls. ??? if Nkind (Parent (Parent (Parent (E)))) /= N_Protected_Definition and then Nkind (Parent (Parent (Parent (E)))) /= N_Protected_Body then Set_Extra_Accessibility - (Formal, Add_Extra_Formal (Standard_Natural)); + (Formal, Add_Extra_Formal (Formal, Standard_Natural, E, "F")); end if; end if; + -- This label is required when skipping extra formal generation for + -- Unchecked_Union parameters. + + <> + if Present (P_Formal) then Next_Formal (P_Formal); end if; - Last_Formal := Formal; Next_Formal (Formal); end loop; + + <> + + -- Ada 2005 (AI-318-02): In the case of build-in-place functions, add + -- appropriate extra formals. See type Exp_Ch6.BIP_Formal_Kind. + + if Ada_Version >= Ada_05 and then Is_Build_In_Place_Function (E) then + declare + Result_Subt : constant Entity_Id := Etype (E); + + Discard : Entity_Id; + pragma Warnings (Off, Discard); + + begin + -- In the case of functions with unconstrained result subtypes, + -- add a 3-state formal indicating whether the return object is + -- allocated by the caller (0), or should be allocated by the + -- callee on the secondary stack (1) or in the global heap (2). + -- For the moment we just use Natural for the type of this formal. + -- Note that this formal isn't usually needed in the case where + -- the result subtype is constrained, but it is needed when the + -- function has a tagged result, because generally such functions + -- can be called in a dispatching context and such calls must be + -- handled like calls to a class-wide function. + + if not Is_Constrained (Result_Subt) + or else Is_Tagged_Type (Underlying_Type (Result_Subt)) + then + Discard := + Add_Extra_Formal + (E, Standard_Natural, + E, BIP_Formal_Suffix (BIP_Alloc_Form)); + end if; + + -- In the case of functions whose result type has controlled + -- parts, we have an extra formal of type + -- System.Finalization_Implementation.Finalizable_Ptr_Ptr. That + -- is, we are passing a pointer to a finalization list (which is + -- itself a pointer). This extra formal is then passed along to + -- Move_Final_List in case of successful completion of a return + -- statement. We cannot pass an 'in out' parameter, because we + -- need to update the finalization list during an abort-deferred + -- region, rather than using copy-back after the function + -- returns. This is true even if we are able to get away with + -- having 'in out' parameters, which are normally illegal for + -- functions. This formal is also needed when the function has + -- a tagged result, because generally such functions can be called + -- in a dispatching context and such calls must be handled like + -- calls to class-wide functions. + + if Controlled_Type (Result_Subt) + or else Is_Tagged_Type (Underlying_Type (Result_Subt)) + then + Discard := + Add_Extra_Formal + (E, RTE (RE_Finalizable_Ptr_Ptr), + E, BIP_Formal_Suffix (BIP_Final_List)); + end if; + + -- If the result type contains tasks, we have two extra formals: + -- the master of the tasks to be created, and the caller's + -- activation chain. + + if Has_Task (Result_Subt) then + Discard := + Add_Extra_Formal + (E, RTE (RE_Master_Id), + E, BIP_Formal_Suffix (BIP_Master)); + Discard := + Add_Extra_Formal + (E, RTE (RE_Activation_Chain_Access), + E, BIP_Formal_Suffix (BIP_Activation_Chain)); + end if; + + -- All build-in-place functions get an extra formal that will be + -- passed the address of the return object within the caller. + + declare + Formal_Type : constant Entity_Id := + Create_Itype + (E_Anonymous_Access_Type, E, + Scope_Id => Scope (E)); + begin + Set_Directly_Designated_Type (Formal_Type, Result_Subt); + Set_Etype (Formal_Type, Formal_Type); + Init_Size_Align (Formal_Type); + Set_Depends_On_Private + (Formal_Type, Has_Private_Component (Formal_Type)); + Set_Is_Public (Formal_Type, Is_Public (Scope (Formal_Type))); + Set_Is_Access_Constant (Formal_Type, False); + + -- Ada 2005 (AI-50217): Propagate the attribute that indicates + -- the designated type comes from the limited view (for + -- back-end purposes). + + Set_From_With_Type (Formal_Type, From_With_Type (Result_Subt)); + + Layout_Type (Formal_Type); + + Discard := + Add_Extra_Formal + (E, Formal_Type, E, BIP_Formal_Suffix (BIP_Object_Access)); + end; + end; + end if; end Create_Extra_Formals; ----------------------------- @@ -3036,8 +5022,8 @@ package body Sem_Ch6 is if Debug_Flag_E then Write_Str ("New overloaded entity chain: "); Write_Name (Chars (S)); - E := S; + E := S; while Present (E) loop Write_Str (" "); Write_Int (Int (E)); E := Homonym (E); @@ -3059,8 +5045,10 @@ package body Sem_Ch6 is -- Warn unless genuine overloading - if (not Is_Overloadable (E)) - or else Subtype_Conformant (E, S) + if (not Is_Overloadable (E) or else Subtype_Conformant (E, S)) + and then (Is_Immediately_Visible (E) + or else + Is_Potentially_Use_Visible (S)) then Error_Msg_Sloc := Sloc (E); Error_Msg_N ("declaration of & hides one#?", S); @@ -3081,7 +5069,6 @@ package body Sem_Ch6 is begin E := Current_Entity (Designator); - while Present (E) loop -- We are looking for a matching spec. It must have the same scope, @@ -3090,10 +5077,9 @@ package body Sem_Ch6 is -- another regardless of whether they are type conformant or not). if Scope (E) = Current_Scope then - if (Current_Scope = Standard_Standard - or else (Ekind (E) = Ekind (Designator) - and then - Type_Conformant (E, Designator))) + if Current_Scope = Standard_Standard + or else (Ekind (E) = Ekind (Designator) + and then Type_Conformant (E, Designator)) then -- Within an instantiation, we know that spec and body are -- subtype conformant, because they were subtype conformant @@ -3134,6 +5120,36 @@ package body Sem_Ch6 is return E; + -- If E is an internal function with a controlling result + -- that was created for an operation inherited by a null + -- extension, it may be overridden by a body without a previous + -- spec (one more reason why these should be shunned). In that + -- case remove the generated body, because the current one is + -- the explicit overriding. + + elsif Ekind (E) = E_Function + and then Ada_Version >= Ada_05 + and then not Comes_From_Source (E) + and then Has_Controlling_Result (E) + and then Is_Null_Extension (Etype (E)) + and then Comes_From_Source (Spec) + then + Set_Has_Completion (E, False); + + if Expander_Active then + Remove + (Unit_Declaration_Node + (Corresponding_Body (Unit_Declaration_Node (E)))); + return E; + + -- If expansion is disabled, the wrapper function has not + -- been generated, and this is the standard case of a late + -- body overriding an inherited operation. + + else + return Empty; + end if; + -- If body already exists, this is an error unless the -- previous declaration is the implicit declaration of -- a derived subprogram, or this is a spurious overloading @@ -3157,10 +5173,9 @@ package body Sem_Ch6 is and then Nkind (Unit_Declaration_Node (Designator)) = N_Subprogram_Body and then - Nkind (Parent (Unit_Declaration_Node (Designator))) - = N_Compilation_Unit + Nkind (Parent (Unit_Declaration_Node (Designator))) = + N_Compilation_Unit then - -- Child units cannot be overloaded, so a conformance mismatch -- between body and a previous spec is an error. @@ -3184,7 +5199,6 @@ package body Sem_Ch6 is function Fully_Conformant (New_Id, Old_Id : Entity_Id) return Boolean is Result : Boolean; - begin Check_Conformance (New_Id, Old_Id, Fully_Conformant, False, Result); return Result; @@ -3196,8 +5210,7 @@ package body Sem_Ch6 is function Fully_Conformant_Expressions (Given_E1 : Node_Id; - Given_E2 : Node_Id) - return Boolean + Given_E2 : Node_Id) return Boolean is E1 : constant Node_Id := Original_Node (Given_E1); E2 : constant Node_Id := Original_Node (Given_E2); @@ -3214,7 +5227,7 @@ package body Sem_Ch6 is -- match explicit actuals with the same value. function FCO (Op_Node, Call_Node : Node_Id) return Boolean; - -- Compare an operator node with a function call. + -- Compare an operator node with a function call --------- -- FCL -- @@ -3294,13 +5307,13 @@ package body Sem_Ch6 is begin -- Non-conformant if paren count does not match. Note: if some idiot -- complains that we don't do this right for more than 3 levels of - -- parentheses, they will be treated with the respect they deserve :-) + -- parentheses, they will be treated with the respect they deserve! if Paren_Count (E1) /= Paren_Count (E2) then return False; - -- If same entities are referenced, then they are conformant - -- even if they have different forms (RM 8.3.1(19-20)). + -- If same entities are referenced, then they are conformant even if + -- they have different forms (RM 8.3.1(19-20)). elsif Is_Entity_Name (E1) and then Is_Entity_Name (E2) then if Present (Entity (E1)) then @@ -3426,7 +5439,7 @@ package body Sem_Ch6 is and then FCE (Left_Opnd (E1), Left_Opnd (E2)) and then FCE (Right_Opnd (E1), Right_Opnd (E2)); - when N_And_Then | N_Or_Else | N_In | N_Not_In => + when N_And_Then | N_Or_Else | N_Membership_Test => return FCE (Left_Opnd (E1), Left_Opnd (E2)) and then @@ -3483,7 +5496,6 @@ package body Sem_Ch6 is when N_Parameter_Association => return - Chars (Selector_Name (E1)) = Chars (Selector_Name (E2)) and then FCE (Explicit_Actual_Parameter (E1), Explicit_Actual_Parameter (E2)); @@ -3565,13 +5577,83 @@ package body Sem_Ch6 is end if; end Fully_Conformant_Expressions; + ---------------------------------------- + -- Fully_Conformant_Discrete_Subtypes -- + ---------------------------------------- + + function Fully_Conformant_Discrete_Subtypes + (Given_S1 : Node_Id; + Given_S2 : Node_Id) return Boolean + is + S1 : constant Node_Id := Original_Node (Given_S1); + S2 : constant Node_Id := Original_Node (Given_S2); + + function Conforming_Bounds (B1, B2 : Node_Id) return Boolean; + -- Special-case for a bound given by a discriminant, which in the body + -- is replaced with the discriminal of the enclosing type. + + function Conforming_Ranges (R1, R2 : Node_Id) return Boolean; + -- Check both bounds + + ----------------------- + -- Conforming_Bounds -- + ----------------------- + + function Conforming_Bounds (B1, B2 : Node_Id) return Boolean is + begin + if Is_Entity_Name (B1) + and then Is_Entity_Name (B2) + and then Ekind (Entity (B1)) = E_Discriminant + then + return Chars (B1) = Chars (B2); + + else + return Fully_Conformant_Expressions (B1, B2); + end if; + end Conforming_Bounds; + + ----------------------- + -- Conforming_Ranges -- + ----------------------- + + function Conforming_Ranges (R1, R2 : Node_Id) return Boolean is + begin + return + Conforming_Bounds (Low_Bound (R1), Low_Bound (R2)) + and then + Conforming_Bounds (High_Bound (R1), High_Bound (R2)); + end Conforming_Ranges; + + -- Start of processing for Fully_Conformant_Discrete_Subtypes + + begin + if Nkind (S1) /= Nkind (S2) then + return False; + + elsif Is_Entity_Name (S1) then + return Entity (S1) = Entity (S2); + + elsif Nkind (S1) = N_Range then + return Conforming_Ranges (S1, S2); + + elsif Nkind (S1) = N_Subtype_Indication then + return + Entity (Subtype_Mark (S1)) = Entity (Subtype_Mark (S2)) + and then + Conforming_Ranges + (Range_Expression (Constraint (S1)), + Range_Expression (Constraint (S2))); + else + return True; + end if; + end Fully_Conformant_Discrete_Subtypes; + -------------------- -- Install_Entity -- -------------------- procedure Install_Entity (E : Entity_Id) is Prev : constant Entity_Id := Current_Entity (E); - begin Set_Is_Immediately_Visible (E); Set_Current_Entity (E); @@ -3584,10 +5666,8 @@ package body Sem_Ch6 is procedure Install_Formals (Id : Entity_Id) is F : Entity_Id; - begin F := First_Formal (Id); - while Present (F) loop Install_Entity (F); Next_Formal (F); @@ -3600,25 +5680,22 @@ package body Sem_Ch6 is function Is_Non_Overriding_Operation (Prev_E : Entity_Id; - New_E : Entity_Id) - return Boolean + New_E : Entity_Id) return Boolean is Formal : Entity_Id; F_Typ : Entity_Id; G_Typ : Entity_Id := Empty; function Get_Generic_Parent_Type (F_Typ : Entity_Id) return Entity_Id; - -- If F_Type is a derived type associated with a generic actual - -- subtype, then return its Generic_Parent_Type attribute, else - -- return Empty. + -- If F_Type is a derived type associated with a generic actual subtype, + -- then return its Generic_Parent_Type attribute, else return Empty. function Types_Correspond (P_Type : Entity_Id; - N_Type : Entity_Id) - return Boolean; - -- Returns true if and only if the types (or designated types - -- in the case of anonymous access types) are the same or N_Type - -- is derived directly or indirectly from P_Type. + N_Type : Entity_Id) return Boolean; + -- Returns true if and only if the types (or designated types in the + -- case of anonymous access types) are the same or N_Type is derived + -- directly or indirectly from P_Type. ----------------------------- -- Get_Generic_Parent_Type -- @@ -3632,11 +5709,11 @@ package body Sem_Ch6 is if Is_Derived_Type (F_Typ) and then Nkind (Parent (F_Typ)) = N_Full_Type_Declaration then - -- The tree must be traversed to determine the parent - -- subtype in the generic unit, which unfortunately isn't - -- always available via semantic attributes. ??? - -- (Note: The use of Original_Node is needed for cases - -- where a full derived type has been rewritten.) + -- The tree must be traversed to determine the parent subtype in + -- the generic unit, which unfortunately isn't always available + -- via semantic attributes. ??? (Note: The use of Original_Node + -- is needed for cases where a full derived type has been + -- rewritten.) Indic := Subtype_Indication (Type_Definition (Original_Node (Parent (F_Typ)))); @@ -3663,8 +5740,7 @@ package body Sem_Ch6 is function Types_Correspond (P_Type : Entity_Id; - N_Type : Entity_Id) - return Boolean + N_Type : Entity_Id) return Boolean is Prev_Type : Entity_Id := Base_Type (P_Type); New_Type : Entity_Id := Base_Type (N_Type); @@ -3695,10 +5771,10 @@ package body Sem_Ch6 is -- Start of processing for Is_Non_Overriding_Operation begin - -- In the case where both operations are implicit derived - -- subprograms then neither overrides the other. This can - -- only occur in certain obscure cases (e.g., derivation - -- from homographs created in a generic instantiation). + -- In the case where both operations are implicit derived subprograms + -- then neither overrides the other. This can only occur in certain + -- obscure cases (e.g., derivation from homographs created in a generic + -- instantiation). if Present (Alias (Prev_E)) and then Present (Alias (New_E)) then return True; @@ -3709,8 +5785,8 @@ package body Sem_Ch6 is and then Comes_From_Source (New_E) then -- We examine the formals and result subtype of the inherited - -- operation, to determine whether their type is derived from - -- (the instance of) a generic type. + -- operation, to determine whether their type is derived from (the + -- instance of) a generic type. Formal := First_Formal (Prev_E); @@ -3726,7 +5802,7 @@ package body Sem_Ch6 is Next_Formal (Formal); end loop; - if not Present (G_Typ) and then Ekind (Prev_E) = E_Function then + if No (G_Typ) and then Ekind (Prev_E) = E_Function then G_Typ := Get_Generic_Parent_Type (Base_Type (Etype (Prev_E))); end if; @@ -3760,6 +5836,7 @@ package body Sem_Ch6 is begin while Present (Prim_Elt) loop P_Prim := Node (Prim_Elt); + if Chars (P_Prim) = Chars (New_E) and then Ekind (P_Prim) = Ekind (New_E) then @@ -3777,12 +5854,12 @@ package body Sem_Ch6 is Next_Entity (N_Formal); end loop; - -- Found a matching primitive operation belonging to - -- the formal ancestor type, so the new subprogram - -- is overriding. + -- Found a matching primitive operation belonging to the + -- formal ancestor type, so the new subprogram is + -- overriding. - if not Present (P_Formal) - and then not Present (N_Formal) + if No (P_Formal) + and then No (N_Formal) and then (Ekind (New_E) /= E_Function or else Types_Correspond @@ -3795,8 +5872,8 @@ package body Sem_Ch6 is Next_Elmt (Prim_Elt); end loop; - -- If no match found, then the new subprogram does - -- not override in the generic (nor in the instance). + -- If no match found, then the new subprogram does not + -- override in the generic (nor in the instance). return True; end; @@ -3821,61 +5898,77 @@ package body Sem_Ch6 is Formals : List_Id; Op_Name : Entity_Id; - A : Entity_Id; - B : Entity_Id; + FF : constant Entity_Id := First_Formal (S); + NF : constant Entity_Id := Next_Formal (FF); begin - -- Check that equality was properly defined. + -- Check that equality was properly defined, ignore call if not - if No (Next_Formal (First_Formal (S))) then + if No (NF) then return; end if; - A := Make_Defining_Identifier (Loc, Chars (First_Formal (S))); - B := Make_Defining_Identifier (Loc, - Chars (Next_Formal (First_Formal (S)))); - - Op_Name := Make_Defining_Operator_Symbol (Loc, Name_Op_Ne); - - Formals := New_List ( - Make_Parameter_Specification (Loc, - Defining_Identifier => A, - Parameter_Type => - New_Reference_To (Etype (First_Formal (S)), Loc)), - - Make_Parameter_Specification (Loc, - Defining_Identifier => B, - Parameter_Type => - New_Reference_To (Etype (Next_Formal (First_Formal (S))), Loc))); - - Decl := - Make_Subprogram_Declaration (Loc, - Specification => - Make_Function_Specification (Loc, - Defining_Unit_Name => Op_Name, - Parameter_Specifications => Formals, - Subtype_Mark => New_Reference_To (Standard_Boolean, Loc))); - - -- Insert inequality right after equality if it is explicit or after - -- the derived type when implicit. These entities are created only - -- for visibility purposes, and eventually replaced in the course of - -- expansion, so they do not need to be attached to the tree and seen - -- by the back-end. Keeping them internal also avoids spurious freezing - -- problems. The parent field is set simply to make analysis safe. - - if No (Alias (S)) then - Set_Parent (Decl, Parent (Unit_Declaration_Node (S))); - else - Set_Parent (Decl, Parent (Parent (Etype (First_Formal (S))))); - end if; + declare + A : constant Entity_Id := + Make_Defining_Identifier (Sloc (FF), + Chars => Chars (FF)); - Mark_Rewrite_Insertion (Decl); - Set_Is_Intrinsic_Subprogram (Op_Name); - Analyze (Decl); - Set_Has_Completion (Op_Name); - Set_Corresponding_Equality (Op_Name, S); - Set_Is_Abstract (Op_Name, Is_Abstract (S)); + B : constant Entity_Id := + Make_Defining_Identifier (Sloc (NF), + Chars => Chars (NF)); + + begin + Op_Name := Make_Defining_Operator_Symbol (Loc, Name_Op_Ne); + + Formals := New_List ( + Make_Parameter_Specification (Loc, + Defining_Identifier => A, + Parameter_Type => + New_Reference_To (Etype (First_Formal (S)), + Sloc (Etype (First_Formal (S))))), + + Make_Parameter_Specification (Loc, + Defining_Identifier => B, + Parameter_Type => + New_Reference_To (Etype (Next_Formal (First_Formal (S))), + Sloc (Etype (Next_Formal (First_Formal (S))))))); + + Decl := + Make_Subprogram_Declaration (Loc, + Specification => + Make_Function_Specification (Loc, + Defining_Unit_Name => Op_Name, + Parameter_Specifications => Formals, + Result_Definition => + New_Reference_To (Standard_Boolean, Loc))); + + -- Insert inequality right after equality if it is explicit or after + -- the derived type when implicit. These entities are created only + -- for visibility purposes, and eventually replaced in the course of + -- expansion, so they do not need to be attached to the tree and seen + -- by the back-end. Keeping them internal also avoids spurious + -- freezing problems. The declaration is inserted in the tree for + -- analysis, and removed afterwards. If the equality operator comes + -- from an explicit declaration, attach the inequality immediately + -- after. Else the equality is inherited from a derived type + -- declaration, so insert inequality after that declaration. + + if No (Alias (S)) then + Insert_After (Unit_Declaration_Node (S), Decl); + elsif Is_List_Member (Parent (S)) then + Insert_After (Parent (S), Decl); + else + Insert_After (Parent (Etype (First_Formal (S))), Decl); + end if; + Mark_Rewrite_Insertion (Decl); + Set_Is_Intrinsic_Subprogram (Op_Name); + Analyze (Decl); + Remove (Decl); + Set_Has_Completion (Op_Name); + Set_Corresponding_Equality (Op_Name, S); + Set_Is_Abstract_Subprogram (Op_Name, Is_Abstract_Subprogram (S)); + end; end Make_Inequality_Operator; ---------------------- @@ -3889,7 +5982,6 @@ package body Sem_Ch6 is begin F := First_Formal (Fun); B := True; - while Present (F) loop if No (Default_Value (F)) then B := False; @@ -3908,7 +6000,6 @@ package body Sem_Ch6 is function Mode_Conformant (New_Id, Old_Id : Entity_Id) return Boolean is Result : Boolean; - begin Check_Conformance (New_Id, Old_Id, Mode_Conformant, False, Result); return Result; @@ -3922,53 +6013,52 @@ package body Sem_Ch6 is (S : Entity_Id; Derived_Type : Entity_Id := Empty) is - E : Entity_Id := Current_Entity_In_Scope (S); - Prev_Vis : Entity_Id := Empty; - - function Is_Private_Declaration (E : Entity_Id) return Boolean; - -- Check that E is declared in the private part of the current package, - -- or in the package body, where it may hide a previous declaration. - -- We can' use In_Private_Part by itself because this flag is also - -- set when freezing entities, so we must examine the place of the - -- declaration in the tree, and recognize wrapper packages as well. - - procedure Maybe_Primitive_Operation (Overriding : Boolean := False); - -- If the subprogram being analyzed is a primitive operation of - -- the type of one of its formals, set the corresponding flag. - - ---------------------------- - -- Is_Private_Declaration -- - ---------------------------- + Overridden_Subp : Entity_Id := Empty; + -- Set if the current scope has an operation that is type-conformant + -- with S, and becomes hidden by S. - function Is_Private_Declaration (E : Entity_Id) return Boolean is - Priv_Decls : List_Id; - Decl : constant Node_Id := Unit_Declaration_Node (E); + Is_Primitive_Subp : Boolean; + -- Set to True if the new subprogram is primitive - begin - if Is_Package (Current_Scope) - and then In_Private_Part (Current_Scope) - then - Priv_Decls := - Private_Declarations ( - Specification (Unit_Declaration_Node (Current_Scope))); + E : Entity_Id; + -- Entity that S overrides - return In_Package_Body (Current_Scope) - or else List_Containing (Decl) = Priv_Decls - or else (Nkind (Parent (Decl)) = N_Package_Specification - and then not Is_Compilation_Unit ( - Defining_Entity (Parent (Decl))) - and then List_Containing (Parent (Parent (Decl))) - = Priv_Decls); - else - return False; - end if; - end Is_Private_Declaration; + Prev_Vis : Entity_Id := Empty; + -- Predecessor of E in Homonym chain + + procedure Check_For_Primitive_Subprogram + (Is_Primitive : out Boolean; + Is_Overriding : Boolean := False); + -- If the subprogram being analyzed is a primitive operation of the type + -- of a formal or result, set the Has_Primitive_Operations flag on the + -- type, and set Is_Primitive to True (otherwise set to False). Set the + -- corresponding flag on the entity itself for later use. + + procedure Check_Synchronized_Overriding + (Def_Id : Entity_Id; + First_Hom : Entity_Id; + Overridden_Subp : out Entity_Id); + -- First determine if Def_Id is an entry or a subprogram either defined + -- in the scope of a task or protected type, or is a primitive of such + -- a type. Check whether Def_Id overrides a subprogram of an interface + -- implemented by the synchronized type, return the overridden entity + -- or Empty. - ------------------------------- - -- Maybe_Primitive_Operation -- - ------------------------------- + function Is_Private_Declaration (E : Entity_Id) return Boolean; + -- Check that E is declared in the private part of the current package, + -- or in the package body, where it may hide a previous declaration. + -- We can't use In_Private_Part by itself because this flag is also + -- set when freezing entities, so we must examine the place of the + -- declaration in the tree, and recognize wrapper packages as well. + + ------------------------------------ + -- Check_For_Primitive_Subprogram -- + ------------------------------------ - procedure Maybe_Primitive_Operation (Overriding : Boolean := False) is + procedure Check_For_Primitive_Subprogram + (Is_Primitive : out Boolean; + Is_Overriding : Boolean := False) + is Formal : Entity_Id; F_Typ : Entity_Id; B_Typ : Entity_Id; @@ -3997,24 +6087,25 @@ package body Sem_Ch6 is and then Visible_Part_Type (T) and then not In_Instance then - if Is_Abstract (T) - and then Is_Abstract (S) - and then (not Overriding or else not Is_Abstract (E)) + if Is_Abstract_Type (T) + and then Is_Abstract_Subprogram (S) + and then (not Is_Overriding + or else not Is_Abstract_Subprogram (E)) then Error_Msg_N ("abstract subprograms must be visible " - & "('R'M 3.9.3(10))!", S); + & "(RM 3.9.3(10))!", S); elsif Ekind (S) = E_Function and then Is_Tagged_Type (T) and then T = Base_Type (Etype (S)) - and then not Overriding + and then not Is_Overriding then Error_Msg_N ("private function with tagged result must" & " override visible-part function", S); Error_Msg_N ("\move subprogram to the visible part" - & " ('R'M 3.9.3(10))", S); + & " (RM 3.9.3(10))", S); end if; end if; end Check_Private_Overriding; @@ -4049,9 +6140,8 @@ package body Sem_Ch6 is then return True; - elsif (Nkind (N) = N_Private_Type_Declaration - or else - Nkind (N) = N_Private_Extension_Declaration) + elsif Nkind_In (N, N_Private_Type_Declaration, + N_Private_Extension_Declaration) and then Present (Defining_Identifier (N)) and then T = Full_View (Defining_Identifier (N)) then @@ -4064,23 +6154,42 @@ package body Sem_Ch6 is return False; end Visible_Part_Type; - -- Start of processing for Maybe_Primitive_Operation + -- Start of processing for Check_For_Primitive_Subprogram begin + Is_Primitive := False; + if not Comes_From_Source (S) then null; - elsif (Ekind (Current_Scope) = E_Package + -- If subprogram is at library level, it is not primitive operation + + elsif Current_Scope = Standard_Standard then + null; + + elsif ((Ekind (Current_Scope) = E_Package + or else Ekind (Current_Scope) = E_Generic_Package) and then not In_Package_Body (Current_Scope)) - or else Overriding + or else Is_Overriding then -- For function, check return type if Ekind (S) = E_Function then - B_Typ := Base_Type (Etype (S)); + if Ekind (Etype (S)) = E_Anonymous_Access_Type then + F_Typ := Designated_Type (Etype (S)); + else + F_Typ := Etype (S); + end if; + + B_Typ := Base_Type (F_Typ); - if Scope (B_Typ) = Current_Scope then + if Scope (B_Typ) = Current_Scope + and then not Is_Class_Wide_Type (B_Typ) + and then not Is_Generic_Type (B_Typ) + then + Is_Primitive := True; Set_Has_Primitive_Operations (B_Typ); + Set_Is_Primitive (S); Check_Private_Overriding (B_Typ); end if; end if; @@ -4097,7 +6206,16 @@ package body Sem_Ch6 is B_Typ := Base_Type (F_Typ); - if Scope (B_Typ) = Current_Scope then + if Ekind (B_Typ) = E_Access_Subtype then + B_Typ := Base_Type (B_Typ); + end if; + + if Scope (B_Typ) = Current_Scope + and then not Is_Class_Wide_Type (B_Typ) + and then not Is_Generic_Type (B_Typ) + then + Is_Primitive := True; + Set_Is_Primitive (S); Set_Has_Primitive_Operations (B_Typ); Check_Private_Overriding (B_Typ); end if; @@ -4105,15 +6223,151 @@ package body Sem_Ch6 is Next_Formal (Formal); end loop; end if; - end Maybe_Primitive_Operation; + end Check_For_Primitive_Subprogram; + + ----------------------------------- + -- Check_Synchronized_Overriding -- + ----------------------------------- + + procedure Check_Synchronized_Overriding + (Def_Id : Entity_Id; + First_Hom : Entity_Id; + Overridden_Subp : out Entity_Id) + is + Formal_Typ : Entity_Id; + Ifaces_List : Elist_Id; + In_Scope : Boolean; + Typ : Entity_Id; + + begin + Overridden_Subp := Empty; + + -- Def_Id must be an entry or a subprogram + + if Ekind (Def_Id) /= E_Entry + and then Ekind (Def_Id) /= E_Function + and then Ekind (Def_Id) /= E_Procedure + then + return; + end if; + + -- Search for the concurrent declaration since it contains the list + -- of all implemented interfaces. In this case, the subprogram is + -- declared within the scope of a protected or a task type. + + if Present (Scope (Def_Id)) + and then Is_Concurrent_Type (Scope (Def_Id)) + and then not Is_Generic_Actual_Type (Scope (Def_Id)) + then + Typ := Scope (Def_Id); + In_Scope := True; + + -- The subprogram may be a primitive of a concurrent type + + elsif Present (First_Formal (Def_Id)) then + Formal_Typ := Etype (First_Formal (Def_Id)); + + if Is_Concurrent_Type (Formal_Typ) + and then not Is_Generic_Actual_Type (Formal_Typ) + then + Typ := Formal_Typ; + In_Scope := False; + + -- This case occurs when the concurrent type is declared within + -- a generic unit. As a result the corresponding record has been + -- built and used as the type of the first formal, we just have + -- to retrieve the corresponding concurrent type. + + elsif Is_Concurrent_Record_Type (Formal_Typ) + and then Present (Corresponding_Concurrent_Type (Formal_Typ)) + then + Typ := Corresponding_Concurrent_Type (Formal_Typ); + In_Scope := False; + + else + return; + end if; + else + return; + end if; + + -- Gather all limited, protected and task interfaces that Typ + -- implements. There is no overriding to check if is an inherited + -- operation in a type derivation on for a generic actual. + + if Nkind (Parent (Typ)) /= N_Full_Type_Declaration + and then + not Nkind_In (Parent (Def_Id), N_Subtype_Declaration, + N_Task_Type_Declaration, + N_Protected_Type_Declaration) + then + Collect_Abstract_Interfaces (Typ, Ifaces_List); + + if not Is_Empty_Elmt_List (Ifaces_List) then + Overridden_Subp := + Find_Overridden_Synchronized_Primitive + (Def_Id, First_Hom, Ifaces_List, In_Scope); + end if; + end if; + end Check_Synchronized_Overriding; + + ---------------------------- + -- Is_Private_Declaration -- + ---------------------------- + + function Is_Private_Declaration (E : Entity_Id) return Boolean is + Priv_Decls : List_Id; + Decl : constant Node_Id := Unit_Declaration_Node (E); + + begin + if Is_Package_Or_Generic_Package (Current_Scope) + and then In_Private_Part (Current_Scope) + then + Priv_Decls := + Private_Declarations ( + Specification (Unit_Declaration_Node (Current_Scope))); + + return In_Package_Body (Current_Scope) + or else + (Is_List_Member (Decl) + and then List_Containing (Decl) = Priv_Decls) + or else (Nkind (Parent (Decl)) = N_Package_Specification + and then not Is_Compilation_Unit ( + Defining_Entity (Parent (Decl))) + and then List_Containing (Parent (Parent (Decl))) + = Priv_Decls); + else + return False; + end if; + end Is_Private_Declaration; -- Start of processing for New_Overloaded_Entity begin + -- We need to look for an entity that S may override. This must be a + -- homonym in the current scope, so we look for the first homonym of + -- S in the current scope as the starting point for the search. + + E := Current_Entity_In_Scope (S); + + -- If there is no homonym then this is definitely not overriding + if No (E) then Enter_Overloaded_Entity (S); Check_Dispatching_Operation (S, Empty); - Maybe_Primitive_Operation; + Check_For_Primitive_Subprogram (Is_Primitive_Subp); + + -- If subprogram has an explicit declaration, check whether it + -- has an overriding indicator. + + if Comes_From_Source (S) then + Check_Synchronized_Overriding (S, Homonym (S), Overridden_Subp); + Check_Overriding_Indicator + (S, Overridden_Subp, Is_Primitive => Is_Primitive_Subp); + end if; + + -- If there is a homonym that is not overloadable, then we have an + -- error, except for the special cases checked explicitly below. elsif not Is_Overloadable (E) then @@ -4135,11 +6389,12 @@ package body Sem_Ch6 is Enter_Overloaded_Entity (S); Set_Homonym (S, Homonym (E)); Check_Dispatching_Operation (S, Empty); + Check_Overriding_Indicator (S, Empty, Is_Primitive => False); -- If the subprogram is implicit it is hidden by the previous - -- declaration. However if it is dispatching, it must appear in - -- the dispatch table anyway, because it can be dispatched to - -- even if it cannot be called directly. + -- declaration. However if it is dispatching, it must appear in the + -- dispatch table anyway, because it can be dispatched to even if it + -- cannot be called directly. elsif Present (Alias (S)) and then not Comes_From_Source (S) @@ -4154,47 +6409,71 @@ package body Sem_Ch6 is else Error_Msg_Sloc := Sloc (E); - Error_Msg_N ("& conflicts with declaration#", S); - -- Useful additional warning. + -- Generate message,with useful additionalwarning if in generic if Is_Generic_Unit (E) then - Error_Msg_N ("\previous generic unit cannot be overloaded", S); + Error_Msg_N ("previous generic unit cannot be overloaded", S); + Error_Msg_N ("\& conflicts with declaration#", S); + else + Error_Msg_N ("& conflicts with declaration#", S); end if; return; end if; + -- E exists and is overloadable + else - -- E exists and is overloadable. Determine whether S is the body - -- of E, a new overloaded entity with a different signature, or - -- an error altogether. + -- Ada 2005 (AI-251): Derivation of abstract interface primitives + -- need no check against the homonym chain. They are directly added + -- to the list of primitive operations of Derived_Type. + + if Ada_Version >= Ada_05 + and then Present (Derived_Type) + and then Is_Dispatching_Operation (Alias (S)) + and then Present (Find_Dispatching_Type (Alias (S))) + and then Is_Interface (Find_Dispatching_Type (Alias (S))) + and then not Is_Predefined_Dispatching_Operation (Alias (S)) + then + goto Add_New_Entity; + end if; + + Check_Synchronized_Overriding (S, E, Overridden_Subp); + + -- Loop through E and its homonyms to determine if any of them is + -- the candidate for overriding by S. while Present (E) loop + + -- Definitely not interesting if not in the current scope + if Scope (E) /= Current_Scope then null; + -- Check if we have type conformance + elsif Type_Conformant (E, S) then - -- If the old and new entities have the same profile and - -- one is not the body of the other, then this is an error, - -- unless one of them is implicitly declared. + -- If the old and new entities have the same profile and one + -- is not the body of the other, then this is an error, unless + -- one of them is implicitly declared. -- There are some cases when both can be implicit, for example -- when both a literal and a function that overrides it are -- inherited in a derivation, or when an inhertited operation - -- of a tagged full type overrides the ineherited operation of - -- a private extension. Ada 83 had a special rule for the - -- the literal case. In Ada95, the later implicit operation - -- hides the former, and the literal is always the former. - -- In the odd case where both are derived operations declared - -- at the same point, both operations should be declared, - -- and in that case we bypass the following test and proceed - -- to the next part (this can only occur for certain obscure - -- cases involving homographs in instances and can't occur for + -- of a tagged full type overrides the inherited operation of + -- a private extension. Ada 83 had a special rule for the the + -- literal case. In Ada95, the later implicit operation hides + -- the former, and the literal is always the former. In the + -- odd case where both are derived operations declared at the + -- same point, both operations should be declared, and in that + -- case we bypass the following test and proceed to the next + -- part (this can only occur for certain obscure cases + -- involving homographs in instances and can't occur for -- dispatching operations ???). Note that the following - -- condition is less than clear. For example, it's not at - -- all clear why there's a test for E_Entry here. ??? + -- condition is less than clear. For example, it's not at all + -- clear why there's a test for E_Entry here. ??? if Present (Alias (S)) and then (No (Alias (E)) @@ -4204,18 +6483,33 @@ package body Sem_Ch6 is (Ekind (E) = E_Entry or else Ekind (E) /= E_Enumeration_Literal) then - -- When an derived operation is overloaded it may be due - -- to the fact that the full view of a private extension + -- When an derived operation is overloaded it may be due to + -- the fact that the full view of a private extension -- re-inherits. It has to be dealt with. - if Is_Package (Current_Scope) + if Is_Package_Or_Generic_Package (Current_Scope) and then In_Private_Part (Current_Scope) then Check_Operation_From_Private_View (S, E); end if; -- In any case the implicit operation remains hidden by - -- the existing declaration. + -- the existing declaration, which is overriding. + + Set_Is_Overriding_Operation (E); + + if Comes_From_Source (E) then + Check_Overriding_Indicator (E, S, Is_Primitive => False); + + -- Indicate that E overrides the operation from which + -- S is inherited. + + if Present (Alias (S)) then + Set_Overridden_Operation (E, Alias (S)); + else + Set_Overridden_Operation (E, S); + end if; + end if; return; @@ -4245,7 +6539,7 @@ package body Sem_Ch6 is if Is_Non_Overriding_Operation (E, S) then Enter_Overloaded_Entity (S); - if not Present (Derived_Type) + if No (Derived_Type) or else Is_Tagged_Type (Derived_Type) then Check_Dispatching_Operation (S, Empty); @@ -4260,6 +6554,8 @@ package body Sem_Ch6 is -- replaced in the list of primitive operations of its type -- (see Override_Dispatching_Operation). + Overridden_Subp := E; + declare Prev : Entity_Id; @@ -4301,21 +6597,21 @@ package body Sem_Ch6 is then -- For nondispatching derived operations that are -- overridden by a subprogram declared in the private - -- part of a package, we retain the derived subprogram - -- but mark it as not immediately visible. If the - -- derived operation was declared in the visible part - -- then this ensures that it will still be visible - -- outside the package with the proper signature - -- (calls from outside must also be directed to this - -- version rather than the overriding one, unlike the - -- dispatching case). Calls from inside the package - -- will still resolve to the overriding subprogram - -- since the derived one is marked as not visible - -- within the package. + -- part of a package, we retain the derived + -- subprogram but mark it as not immediately visible. + -- If the derived operation was declared in the + -- visible part then this ensures that it will still + -- be visible outside the package with the proper + -- signature (calls from outside must also be + -- directed to this version rather than the + -- overriding one, unlike the dispatching case). + -- Calls from inside the package will still resolve + -- to the overriding subprogram since the derived one + -- is marked as not visible within the package. -- If the private operation is dispatching, we achieve -- the overriding by keeping the implicit operation - -- but setting its alias to be the overring one. In + -- but setting its alias to be the overriding one. In -- this fashion the proper body is executed in all -- cases, but the original signature is used outside -- of the package. @@ -4328,14 +6624,14 @@ package body Sem_Ch6 is if not Is_Dispatching_Operation (E) then Set_Is_Immediately_Visible (E, False); else - - -- work done in Override_Dispatching_Operation. + -- Work done in Override_Dispatching_Operation, + -- so nothing else need to be done here. null; end if; - else - -- Find predecessor of E in Homonym chain. + else + -- Find predecessor of E in Homonym chain if E = Current_Entity (E) then Prev_Vis := Empty; @@ -4366,20 +6662,35 @@ package body Sem_Ch6 is end if; Enter_Overloaded_Entity (S); + Set_Is_Overriding_Operation (S); + Check_Overriding_Indicator (S, E, Is_Primitive => True); + + -- Indicate that S overrides the operation from which + -- E is inherited. + + if Comes_From_Source (S) then + if Present (Alias (E)) then + Set_Overridden_Operation (S, Alias (E)); + else + Set_Overridden_Operation (S, E); + end if; + end if; if Is_Dispatching_Operation (E) then - -- An overriding dispatching subprogram inherits - -- the convention of the overridden subprogram - -- (by AI-117). - Set_Convention (S, Convention (E)); + -- An overriding dispatching subprogram inherits the + -- convention of the overridden subprogram (by + -- AI-117). + Set_Convention (S, Convention (E)); Check_Dispatching_Operation (S, E); + else Check_Dispatching_Operation (S, Empty); end if; - Maybe_Primitive_Operation (Overriding => True); + Check_For_Primitive_Subprogram + (Is_Primitive_Subp, Is_Overriding => True); goto Check_Inequality; end; @@ -4407,48 +6718,95 @@ package body Sem_Ch6 is Set_Scope (S, Current_Scope); - Error_Msg_N ("& conflicts with declaration#", S); + -- Generate error, with extra useful warning for the case + -- of a generic instance with no completion. if Is_Generic_Instance (S) and then not Has_Completion (E) then Error_Msg_N - ("\instantiation cannot provide body for it", S); + ("instantiation cannot provide body for&", S); + Error_Msg_N ("\& conflicts with declaration#", S); + else + Error_Msg_N ("& conflicts with declaration#", S); end if; return; end if; else - null; + -- If one subprogram has an access parameter and the other + -- a parameter of an access type, calls to either might be + -- ambiguous. Verify that parameters match except for the + -- access parameter. + + if May_Hide_Profile then + declare + F1 : Entity_Id; + F2 : Entity_Id; + begin + F1 := First_Formal (S); + F2 := First_Formal (E); + while Present (F1) and then Present (F2) loop + if Is_Access_Type (Etype (F1)) then + if not Is_Access_Type (Etype (F2)) + or else not Conforming_Types + (Designated_Type (Etype (F1)), + Designated_Type (Etype (F2)), + Type_Conformant) + then + May_Hide_Profile := False; + end if; + + elsif + not Conforming_Types + (Etype (F1), Etype (F2), Type_Conformant) + then + May_Hide_Profile := False; + end if; + + Next_Formal (F1); + Next_Formal (F2); + end loop; + + if May_Hide_Profile + and then No (F1) + and then No (F2) + then + Error_Msg_NE ("calls to& may be ambiguous?", S, S); + end if; + end; + end if; end if; - Prev_Vis := E; E := Homonym (E); end loop; + <> + -- On exit, we know that S is a new entity Enter_Overloaded_Entity (S); - Maybe_Primitive_Operation; + Check_For_Primitive_Subprogram (Is_Primitive_Subp); + Check_Overriding_Indicator + (S, Overridden_Subp, Is_Primitive => Is_Primitive_Subp); - -- If S is a derived operation for an untagged type then - -- by definition it's not a dispatching operation (even - -- if the parent operation was dispatching), so we don't - -- call Check_Dispatching_Operation in that case. + -- If S is a derived operation for an untagged type then by + -- definition it's not a dispatching operation (even if the parent + -- operation was dispatching), so we don't call + -- Check_Dispatching_Operation in that case. - if not Present (Derived_Type) + if No (Derived_Type) or else Is_Tagged_Type (Derived_Type) then Check_Dispatching_Operation (S, Empty); end if; end if; - -- If this is a user-defined equality operator that is not - -- a derived subprogram, create the corresponding inequality. - -- If the operation is dispatching, the expansion is done - -- elsewhere, and we do not create an explicit inequality - -- operation. + -- If this is a user-defined equality operator that is not a derived + -- subprogram, create the corresponding inequality. If the operation is + -- dispatching, the expansion is done elsewhere, and we do not create + -- an explicit inequality operation. <> if Chars (S) = Name_Op_Eq @@ -4458,7 +6816,6 @@ package body Sem_Ch6 is then Make_Inequality_Operator (S); end if; - end New_Overloaded_Entity; --------------------- @@ -4475,10 +6832,14 @@ package body Sem_Ch6 is Default : Node_Id; Ptype : Entity_Id; + -- The following are used for setting Is_Only_Out_ + Num_Out_Params : Nat := 0; + First_Out_Param : Entity_Id := Empty; + function Is_Class_Wide_Default (D : Node_Id) return Boolean; - -- Check whether the default has a class-wide type. After analysis - -- the default has the type of the formal, so we must also check - -- explicitly for an access attribute. + -- Check whether the default has a class-wide type. After analysis the + -- default has the type of the formal, so we must also check explicitly + -- for an access attribute. --------------------------- -- Is_Class_Wide_Default -- @@ -4500,10 +6861,9 @@ package body Sem_Ch6 is -- analyzed. The Ekind is established in a separate loop at the end. Param_Spec := First (T); - while Present (Param_Spec) loop - Formal := Defining_Identifier (Param_Spec); + Set_Never_Set_In_Source (Formal, True); Enter_Name (Formal); -- Case of ordinary parameters @@ -4518,15 +6878,33 @@ package body Sem_Ch6 is Formal_Type := Entity (Ptype); - if Ekind (Formal_Type) = E_Incomplete_Type - or else (Is_Class_Wide_Type (Formal_Type) - and then Ekind (Root_Type (Formal_Type)) = - E_Incomplete_Type) + if Is_Incomplete_Type (Formal_Type) + or else + (Is_Class_Wide_Type (Formal_Type) + and then Is_Incomplete_Type (Root_Type (Formal_Type))) then - if Nkind (Parent (T)) /= N_Access_Function_Definition - and then Nkind (Parent (T)) /= N_Access_Procedure_Definition + -- Ada 2005 (AI-326): Tagged incomplete types allowed + + if Is_Tagged_Type (Formal_Type) then + null; + + -- Special handling of Value_Type for CIL case + + elsif Is_Value_Type (Formal_Type) then + null; + + elsif not Nkind_In (Parent (T), N_Access_Function_Definition, + N_Access_Procedure_Definition) then Error_Msg_N ("invalid use of incomplete type", Param_Spec); + + -- An incomplete type that is not tagged is allowed in an + -- access-to-subprogram type only if it is a local declaration + -- with a forthcoming completion (3.10.1 (9.2/2)). + + elsif Scope (Formal_Type) /= Scope (Current_Scope) then + Error_Msg_N + ("invalid use of limited view of type", Param_Spec); end if; elsif Ekind (Formal_Type) = E_Void then @@ -4534,16 +6912,77 @@ package body Sem_Ch6 is Parameter_Type (Param_Spec), Formal_Type); end if; + -- Ada 2005 (AI-231): Create and decorate an internal subtype + -- declaration corresponding to the null-excluding type of the + -- formal in the enclosing scope. Finally, replace the parameter + -- type of the formal with the internal subtype. + + if Ada_Version >= Ada_05 + and then Null_Exclusion_Present (Param_Spec) + then + if not Is_Access_Type (Formal_Type) then + Error_Msg_N + ("`NOT NULL` allowed only for an access type", Param_Spec); + + else + if Can_Never_Be_Null (Formal_Type) + and then Comes_From_Source (Related_Nod) + then + Error_Msg_NE + ("`NOT NULL` not allowed (& already excludes null)", + Param_Spec, + Formal_Type); + end if; + + Formal_Type := + Create_Null_Excluding_Itype + (T => Formal_Type, + Related_Nod => Related_Nod, + Scope_Id => Scope (Current_Scope)); + + -- If the designated type of the itype is an itype we + -- decorate it with the Has_Delayed_Freeze attribute to + -- avoid problems with the backend. + + -- Example: + -- type T is access procedure; + -- procedure Op (O : not null T); + + if Is_Itype (Directly_Designated_Type (Formal_Type)) then + Set_Has_Delayed_Freeze (Formal_Type); + end if; + end if; + end if; + -- An access formal type else Formal_Type := Access_Definition (Related_Nod, Parameter_Type (Param_Spec)); + + -- No need to continue if we already notified errors + + if not Present (Formal_Type) then + return; + end if; + + -- Ada 2005 (AI-254) + + declare + AD : constant Node_Id := + Access_To_Subprogram_Definition + (Parameter_Type (Param_Spec)); + begin + if Present (AD) and then Protected_Present (AD) then + Formal_Type := + Replace_Anonymous_Access_To_Protected_Subprogram + (Param_Spec); + end if; + end; end if; Set_Etype (Formal, Formal_Type); - - Default := Expression (Param_Spec); + Default := Expression (Param_Spec); if Present (Default) then if Out_Present (Param_Spec) then @@ -4555,13 +6994,27 @@ package body Sem_Ch6 is -- Do the special preanalysis of the expression (see section on -- "Handling of Default Expressions" in the spec of package Sem). - Analyze_Default_Expression (Default, Formal_Type); + Analyze_Per_Use_Expression (Default, Formal_Type); + + -- An access to constant cannot be the default for + -- an access parameter that is an access to variable. + + if Ekind (Formal_Type) = E_Anonymous_Access_Type + and then not Is_Access_Constant (Formal_Type) + and then Is_Access_Type (Etype (Default)) + and then Is_Access_Constant (Etype (Default)) + then + Error_Msg_N + ("formal that is access to variable cannot be initialized " & + "with an access-to-constant expression", Default); + end if; - -- Check that the designated type of an access parameter's - -- default is not a class-wide type unless the parameter's - -- designated type is also class-wide. + -- Check that the designated type of an access parameter's default + -- is not a class-wide type unless the parameter's designated type + -- is also class-wide. if Ekind (Formal_Type) = E_Anonymous_Access_Type + and then not From_With_Type (Formal_Type) and then Is_Class_Wide_Default (Default) and then not Is_Class_Wide_Type (Designated_Type (Formal_Type)) then @@ -4570,10 +7023,27 @@ package body Sem_Ch6 is end if; end if; + -- Ada 2005 (AI-231): Static checks + + if Ada_Version >= Ada_05 + and then Is_Access_Type (Etype (Formal)) + and then Can_Never_Be_Null (Etype (Formal)) + then + Null_Exclusion_Static_Checks (Param_Spec); + end if; + <> Next (Param_Spec); end loop; + -- If this is the formal part of a function specification, analyze the + -- subtype mark in the context where the formals are visible but not + -- yet usable, and may hide outer homographs. + + if Nkind (Related_Nod) = N_Function_Specification then + Analyze_Return_Type (Related_Nod); + end if; + -- Now set the kind (mode) of each formal Param_Spec := First (T); @@ -4601,67 +7071,122 @@ package body Sem_Ch6 is Apply_Scalar_Range_Check (Default, Formal_Type); end if; + end if; + + elsif Ekind (Formal) = E_Out_Parameter then + Num_Out_Params := Num_Out_Params + 1; + if Num_Out_Params = 1 then + First_Out_Param := Formal; end if; + + elsif Ekind (Formal) = E_In_Out_Parameter then + Num_Out_Params := Num_Out_Params + 1; end if; Next (Param_Spec); end loop; + if Present (First_Out_Param) and then Num_Out_Params = 1 then + Set_Is_Only_Out_Parameter (First_Out_Param); + end if; end Process_Formals; + ---------------------------- + -- Reference_Body_Formals -- + ---------------------------- + + procedure Reference_Body_Formals (Spec : Entity_Id; Bod : Entity_Id) is + Fs : Entity_Id; + Fb : Entity_Id; + + begin + if Error_Posted (Spec) then + return; + end if; + + -- Iterate over both lists. They may be of different lengths if the two + -- specs are not conformant. + + Fs := First_Formal (Spec); + Fb := First_Formal (Bod); + while Present (Fs) and then Present (Fb) loop + Generate_Reference (Fs, Fb, 'b'); + + if Style_Check then + Style.Check_Identifier (Fb, Fs); + end if; + + Set_Spec_Entity (Fb, Fs); + Set_Referenced (Fs, False); + Next_Formal (Fs); + Next_Formal (Fb); + end loop; + end Reference_Body_Formals; + ------------------------- -- Set_Actual_Subtypes -- ------------------------- procedure Set_Actual_Subtypes (N : Node_Id; Subp : Entity_Id) is - Loc : constant Source_Ptr := Sloc (N); - Decl : Node_Id; - Formal : Entity_Id; - T : Entity_Id; - First_Stmt : Node_Id := Empty; - AS_Needed : Boolean; + Loc : constant Source_Ptr := Sloc (N); + Decl : Node_Id; + Formal : Entity_Id; + T : Entity_Id; + First_Stmt : Node_Id := Empty; + AS_Needed : Boolean; begin + -- If this is an emtpy initialization procedure, no need to create + -- actual subtypes (small optimization). + + if Ekind (Subp) = E_Procedure + and then Is_Null_Init_Proc (Subp) + then + return; + end if; + Formal := First_Formal (Subp); while Present (Formal) loop T := Etype (Formal); - -- We never need an actual subtype for a constrained formal. + -- We never need an actual subtype for a constrained formal if Is_Constrained (T) then AS_Needed := False; - -- If we have unknown discriminants, then we do not need an - -- actual subtype, or more accurately we cannot figure it out! - -- Note that all class-wide types have unknown discriminants. + -- If we have unknown discriminants, then we do not need an actual + -- subtype, or more accurately we cannot figure it out! Note that + -- all class-wide types have unknown discriminants. elsif Has_Unknown_Discriminants (T) then AS_Needed := False; - -- At this stage we have an unconstrained type that may need - -- an actual subtype. For sure the actual subtype is needed - -- if we have an unconstrained array type. + -- At this stage we have an unconstrained type that may need an + -- actual subtype. For sure the actual subtype is needed if we have + -- an unconstrained array type. elsif Is_Array_Type (T) then AS_Needed := True; - -- The only other case which needs an actual subtype is an - -- unconstrained record type which is an IN parameter (we - -- cannot generate actual subtypes for the OUT or IN OUT case, - -- since an assignment can change the discriminant values. - -- However we exclude the case of initialization procedures, - -- since discriminants are handled very specially in this context, - -- see the section entitled "Handling of Discriminants" in Einfo. - -- We also exclude the case of Discrim_SO_Functions (functions - -- used in front end layout mode for size/offset values), since - -- in such functions only discriminants are referenced, and not - -- only are such subtypes not needed, but they cannot always - -- be generated, because of order of elaboration issues. + -- The only other case needing an actual subtype is an unconstrained + -- record type which is an IN parameter (we cannot generate actual + -- subtypes for the OUT or IN OUT case, since an assignment can + -- change the discriminant values. However we exclude the case of + -- initialization procedures, since discriminants are handled very + -- specially in this context, see the section entitled "Handling of + -- Discriminants" in Einfo. + + -- We also exclude the case of Discrim_SO_Functions (functions used + -- in front end layout mode for size/offset values), since in such + -- functions only discriminants are referenced, and not only are such + -- subtypes not needed, but they cannot always be generated, because + -- of order of elaboration issues. elsif Is_Record_Type (T) and then Ekind (Formal) = E_In_Parameter and then Chars (Formal) /= Name_uInit + and then not Is_Unchecked_Union (T) and then not Is_Discrim_SO_Function (Subp) then AS_Needed := True; @@ -4676,28 +7201,42 @@ package body Sem_Ch6 is -- unconstrained discriminated records. if AS_Needed then - Decl := Build_Actual_Subtype (T, Formal); - if Nkind (N) = N_Accept_Statement then + + -- If expansion is active, The formal is replaced by a local + -- variable that renames the corresponding entry of the + -- parameter block, and it is this local variable that may + -- require an actual subtype. + + if Expander_Active then + Decl := Build_Actual_Subtype (T, Renamed_Object (Formal)); + else + Decl := Build_Actual_Subtype (T, Formal); + end if; + if Present (Handled_Statement_Sequence (N)) then First_Stmt := First (Statements (Handled_Statement_Sequence (N))); Prepend (Decl, Statements (Handled_Statement_Sequence (N))); Mark_Rewrite_Insertion (Decl); else - -- If the accept statement has no body, there will be - -- no reference to the actuals, so no need to compute - -- actual subtypes. + -- If the accept statement has no body, there will be no + -- reference to the actuals, so no need to compute actual + -- subtypes. return; end if; else + Decl := Build_Actual_Subtype (T, Formal); Prepend (Decl, Declarations (N)); Mark_Rewrite_Insertion (Decl); end if; - Analyze (Decl); + -- The declaration uses the bounds of an existing object, and + -- therefore needs no constraint checks. + + Analyze (Decl, Suppress => All_Checks); -- We need to freeze manually the generated type when it is -- inserted anywhere else than in a declarative part. @@ -4707,7 +7246,14 @@ package body Sem_Ch6 is Freeze_Entity (Defining_Identifier (Decl), Loc)); end if; - Set_Actual_Subtype (Formal, Defining_Identifier (Decl)); + if Nkind (N) = N_Accept_Statement + and then Expander_Active + then + Set_Actual_Subtype (Renamed_Object (Formal), + Defining_Identifier (Decl)); + else + Set_Actual_Subtype (Formal, Defining_Identifier (Decl)); + end if; end if; Next_Formal (Formal); @@ -4727,7 +7273,6 @@ package body Sem_Ch6 is -- point of the call. if Out_Present (Spec) then - if Ekind (Scope (Formal_Id)) = E_Function or else Ekind (Scope (Formal_Id)) = E_Generic_Function then @@ -4738,14 +7283,40 @@ package body Sem_Ch6 is Set_Ekind (Formal_Id, E_In_Out_Parameter); else - Set_Ekind (Formal_Id, E_Out_Parameter); - Set_Not_Source_Assigned (Formal_Id); + Set_Ekind (Formal_Id, E_Out_Parameter); + Set_Never_Set_In_Source (Formal_Id, True); + Set_Is_True_Constant (Formal_Id, False); + Set_Current_Value (Formal_Id, Empty); end if; else Set_Ekind (Formal_Id, E_In_Parameter); end if; + -- Set Is_Known_Non_Null for access parameters since the language + -- guarantees that access parameters are always non-null. We also set + -- Can_Never_Be_Null, since there is no way to change the value. + + if Nkind (Parameter_Type (Spec)) = N_Access_Definition then + + -- Ada 2005 (AI-231): In Ada95, access parameters are always non- + -- null; In Ada 2005, only if then null_exclusion is explicit. + + if Ada_Version < Ada_05 + or else Can_Never_Be_Null (Etype (Formal_Id)) + then + Set_Is_Known_Non_Null (Formal_Id); + Set_Can_Never_Be_Null (Formal_Id); + end if; + + -- Ada 2005 (AI-231): Null-exclusion access subtype + + elsif Is_Access_Type (Etype (Formal_Id)) + and then Can_Never_Be_Null (Etype (Formal_Id)) + then + Set_Is_Known_Non_Null (Formal_Id); + end if; + Set_Mechanism (Formal_Id, Default_Mechanism); Set_Formal_Validity (Formal_Id); end Set_Formal_Mode; @@ -4756,17 +7327,29 @@ package body Sem_Ch6 is procedure Set_Formal_Validity (Formal_Id : Entity_Id) is begin - -- If in full validity checking mode, then we can assume that - -- an IN or IN OUT parameter is valid (see Exp_Ch5.Expand_Call) + -- If no validity checking, then we cannot assume anything about the + -- validity of parameters, since we do not know there is any checking + -- of the validity on the call side. if not Validity_Checks_On then return; + -- If validity checking for parameters is enabled, this means we are + -- not supposed to make any assumptions about argument values. + + elsif Validity_Check_Parameters then + return; + + -- If we are checking in parameters, we will assume that the caller is + -- also checking parameters, so we can assume the parameter is valid. + elsif Ekind (Formal_Id) = E_In_Parameter and then Validity_Check_In_Params then Set_Is_Known_Valid (Formal_Id, True); + -- Similar treatment for IN OUT parameters + elsif Ekind (Formal_Id) = E_In_Out_Parameter and then Validity_Check_In_Out_Params then @@ -4780,7 +7363,6 @@ package body Sem_Ch6 is function Subtype_Conformant (New_Id, Old_Id : Entity_Id) return Boolean is Result : Boolean; - begin Check_Conformance (New_Id, Old_Id, Subtype_Conformant, False, Result); return Result; @@ -4790,11 +7372,18 @@ package body Sem_Ch6 is -- Type_Conformant -- --------------------- - function Type_Conformant (New_Id, Old_Id : Entity_Id) return Boolean is + function Type_Conformant + (New_Id : Entity_Id; + Old_Id : Entity_Id; + Skip_Controlling_Formals : Boolean := False) return Boolean + is Result : Boolean; - begin - Check_Conformance (New_Id, Old_Id, Type_Conformant, False, Result); + May_Hide_Profile := False; + + Check_Conformance + (New_Id, Old_Id, Type_Conformant, False, Result, + Skip_Controlling_Formals => Skip_Controlling_Formals); return Result; end Type_Conformant; @@ -4810,7 +7399,6 @@ package body Sem_Ch6 is begin F := First_Formal (Designator); - while Present (F) loop N := N + 1;